- 05 Dec, 2020 40 commits
-
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/30f45a6f043f..e05f7b914762 2020-12-05 kmoon@chromium.org Manually roll build and tools/memory 2020-12-05 tsepez@chromium.org Fix SEGV in chrome under XFA for xfa_node_caption.pdf 2020-12-05 kmoon@chromium.org Roll third_party/zlib/ e84c9a3fd..c29ee8c9c (3 commits) 2020-12-05 kmoon@chromium.org Roll v8/ e05d24f98..61f3e6140 (403 commits) 2020-12-05 kmoon@chromium.org Roll third_party/skia/ 1ce8964db..ae95077db (317 commits) 2020-12-05 kmoon@chromium.org Roll third_party/icu/ 7db579a73..6a33b647c (4 commits) 2020-12-05 kmoon@chromium.org Roll tools/clang/ c72342ce9..9ec0bb322 (13 commits) 2020-12-05 kmoon@chromium.org Roll third_party/freetype/src/ 32b14552d..8cc4d0dc3 (5 commits) 2020-12-05 kmoon@chromium.org Roll third_party/depot_tools/ da73999f7..18f45d287 (51 commits; 16 trivial rolls) 2020-12-04 tsepez@chromium.org Fix some grammar in cjx_node.cpp 2020-12-04 kmoon@chromium.org Roll third_party/android_ndk/ 85c22b30b..27c0a8d09 (0 commit) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I77deada861e6597f006fd6417e5e9f49a0c350c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576468Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834043}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d9042e3e6082..36207e820037 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ia4a2b7093fb84d3ca8a26d6a8608241879a2d64f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576464Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834042}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c532048062be..d63d562d1b26 2020-12-05 stha09@googlemail.com IWYU: include string.h for memcpy If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I8dcc179611e208d79c481f20945b917301075f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576465Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834041}
-
Liquan (Max) Gu authored
This CL clean-up the files according to Android Studio's cleanup advise. This CL does not cause any behavioural changes. Bug: 1155582 Change-Id: Ia5d63a43e867744ee6f25f90e0cff0007e1a0fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575756 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#834040}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ifb5a65ab5639e989364a7efab35238e56fa51b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576419Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834039}
-
Stephan Hartmann authored
Bug: None Change-Id: Iba75af392d248846b1d86b21b5ff4b45dce2e054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575120Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#834038}
-
Chris Mumford authored
mojo_blob_storage_context() and native_file_system_context() are only used by IndexedDBDispatcherHost. Making them private to simplify the interface. Bug: none Change-Id: I7647d6c8301e7ccce9e60d0ea363202ed8e80d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575897Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#834037}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607166734-69b9a909cc2088c22879c6c9e7f8fd519f4237d8.profdata to chrome-mac-master-1607188490-ce7b02b4e02b77e7f75110583023cf555cf2eef0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2cc0a04e30b45e4424430f905c1212df20cbd4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575347Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834036}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607166734-e9365668558fc300c935cf3532da06f65c9b06bd.profdata to chrome-linux-master-1607188490-01893ccb74f7e9cad0b1c9d01df378ae016644d8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3cf440eccabb08966c5400cd7b14862429700710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576375Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834035}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607158109-cb59c5163bb73c4e3a2267188e86d32f6337beac.profdata to chrome-win64-master-1607179152-5b4699a702547a5be32091b1b306083e2a5d86b6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I19ecbc86272322c648fe3106301d46a965bf2ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576364Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834034}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e0dee01043d1..f326e4faef66 2020-12-05 michaelludwig@google.com Remove SkCanvas::LayerIter used in SkCanvasStateUtils If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: Icc93dce6cd752b73a8e970dc69bc286b378a4a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576367Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834033}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I7e6298d7283364ae2d1a132b008b0da5624390af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576356Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834032}
-
Wez authored
This reverts commit f3dce521. Reason for revert: We have no urgent need for this feature so removing it in favour of introducing a caller (vs system) controlled API. Original change's description: > [fuchsia] Allow system config to request Android-ish user agent OS. > > Allow WebEngine to be configured to report an Android-like UserAgent > via the system-provided config-data, to allow it to be fetch the right > form of content for the device form-factor. > > This will likely be replaced with options to configure the Client Hints > reported, on a per-instance basis, once those are standardized. > > Bug: b/171582703, 1010256 > Change-Id: I9db408be09ec9b9a78facc7b078d635b96c3637b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522071 > Commit-Queue: Wez <wez@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Auto-Submit: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825042} Bug: b/171582703 Bug: 1010256 Change-Id: If513affc89195fb78eafb1e9160e583b41708f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574976 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#834031}
-
David Dorwin authored
Previously, the string positions were calculated then used to replace parts of the string left to right, which produced the wrong string when code was added earlier in the file causing the messages to be logged from a four-digit line number in frame_impl.cc. (It would have also failed had the function been moved to the beginning of the file and had a two-digit line number.) Bug: 1136681 Change-Id: Ia5e9a7f11a676d8fc538a19322274ae66e47d9a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573198 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#834030}
-
Liquan (Max) Gu authored
PaymentRequestUi is the details of PaymentUiService and so CPRService should not have access to it. This CL hides PaymentRequestUi from CPRService. After the CL, CPRService uses it by the proxy of PaymentUiService. For the methods that have been moved into PaymentUiService, this CL adds the null-check in them. Bug: 1155582 Change-Id: Iaf5a8624232226c5c9c6fe29c411e377f10e8735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574777 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#834029}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607147157-7253fb93519f47883631135ae2487e5bf63d1c0b.profdata to chrome-win64-master-1607158109-cb59c5163bb73c4e3a2267188e86d32f6337beac.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib96f3c3ed24293030f77035a02ab961c91752976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576093Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834028}
-
Abigail Klein authored
observer. This CL does two things: 1. Do not notify SODAInstallerObservers when the component has not been updated. The crash was initiated when the component updater sent a status update saying that the SODA component was up-to-date, which occurred while SODA was running and not when it was installing. These up-to-date messages should not be relayed to the SODAInstallerObservers. 2. Remove the CaptionsHandler from the SODAInstaller observer list when the CaptionsHandler is destructed. The crash occurred because the CaptionsHandler had not properly removed itself as an observer. Before this CL, the CaptionsHandler removed itself when javascript was disallowed, which was assumed to occur when the CaptionsHandler was destructed. On testing, it turns out that this is not the case, so this CL ensures that the CaptionsHandler is removed as an observer on destruction. Bug: 1055150, 1155625 Change-Id: Icb2073a1380f1d1cefc25690d84aa840804ff29c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575005Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#834027}
-
Scott Violet authored
onOffsetsChanged() does nothing if fullscreen. This changes the code to call to setControlsOffset() so that the offsets are correctly updated. BUG=1149335 TEST=testTopViewRemainsHiddenOnFullscreenRotation Change-Id: I419f629292caf5f4454a04920c6a9778c8f16731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575898Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#834026}
-
Aaron Leventhal authored
Also unify HasARIAOwns() logic, while ensuring that different types of aria-owns are handled. Bug: 1155617 Change-Id: If2f76e35ca8b444a620ca052281953258937a9f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575445 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#834025}
-
Eric Lawrence authored
The specification says that Referrer policies should only permit a comma delimited list when delivered via the HTTP header, but not via the meta tag. Match other browsers and ignore a meta-specified policy if it contains commas. Bug: 1093914, 1111447 Change-Id: Ie2528c968e1e45a2209d611aee37fa406987074c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567572Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#834024}
-
Liquan (Max) Gu authored
MinimalUi is the implementation details of PaymentUiService and so should not be exposed to the payment request service. This CL encapsulate the MinimalUI logic in PaymentUiService so that PaymentUiService no longer provides the MinimalUICoordinator instance. Bug: 1155582 Change-Id: Ica49ae9190248d400f29ef8102c9a4394356ad85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575342 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#834023}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a488b77c17f5..952584d5b9bb 2020-12-05 tvanderlippe@chromium.org Upgrade third_party/codemirror to 5.58.3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2bd83a4ae7d1838ce05772b0f8ef632b572da6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576337Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834022}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607147157-f5b7556f12cc4a67a4d86e796b1f10a124355671.profdata to chrome-linux-master-1607166734-e9365668558fc300c935cf3532da06f65c9b06bd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2dcb3562abb37d16c52cfd3cdb217f84b655eb2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576095Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834021}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607147157-05c119e40ba733e24d2e3874fc8b53f1f41ca77b.profdata to chrome-mac-master-1607166734-69b9a909cc2088c22879c6c9e7f8fd519f4237d8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6a9fe6c5f2e5bc0af5b613e456cd03d0b237de82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576091Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834020}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ab784e384be6..a488b77c17f5 2020-12-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2674f71d5424ba7dd4bdd86532825244b9e92aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576318Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834019}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607061555-42057a46d6898e28766e44cc3eff7a0d211d34f4.profdata to chrome-win32-master-1607147157-aa03f5071526bec501a925219d4b546c82550b2e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie723dd7b8f069ff3804172a808e70458aea1b419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576084Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834018}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607126042-eec6b76e1d472288c9c26f1dc48d90cf1137b5cd.profdata to chrome-win64-master-1607147157-7253fb93519f47883631135ae2487e5bf63d1c0b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iacc8355f38a43809fa185378d2c95a90812a32f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575807Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834017}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d3455123dc42..d9042e3e6082 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Iaa5d13f3d08624a45bbbe8431c2d2df2c2007d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576086Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834016}
-
wutao authored
Bug: b/173476225 Test: manual Change-Id: Id108f71d73062d1158fa7175bcbb0b80f9a327b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574259 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#834015}
-
Hans Wennborg authored
This reverts commit 3d519f44. Reason for revert: This caused a 15% build time increase (see second bug). Original change's description: > Move CanExecuteScripts() to V8ScriptRunner::CompileAndRunScript() > > To unify how CanExecuteScripts() is checked across > classic script evaluation code paths. > > This CL doesn't change the behavior. > > Bug: 1111134 > Change-Id: If95a32043c52767eda05f16f9630edee26c5e75f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544938 > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832649} TBR=yukishiino@chromium.org,hiroshige@chromium.org,dom@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1111134, 1155843 Change-Id: I7531522623086a7e9903364288a557341208d84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576236Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#834014}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Id252c3be8bfaa30e170738b05fc080707d19a97d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575008Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834013}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/aafe855f7f51..251ba5cb119f 2020-12-05 syoussefi@chromium.org Vulkan: Fix transform feedback with in-render-pass clears 2020-12-05 zentaro@chromium.org Mark classes with final dtors as final 2020-12-05 syoussefi@chromium.org Vulkan: Support for geometry shader with max_vertices=0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:999886 Tbr: ianelliott@google.com Test: Test: no errors building Change-Id: I28a264ccafd777333994d11d5670716a0defceeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576026Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834012}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ibd5440d101a9db5bb4017135da5bb0a111e81446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576021Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834011}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607126042-accdd94f2839e19c977142b92f1ccbe3b6368bd6.profdata to chrome-linux-master-1607147157-f5b7556f12cc4a67a4d86e796b1f10a124355671.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifa7a91759a06f0380b8d6ef9ebe4450557c324c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576032Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834010}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607126042-3a5b481c1c794ae044b96bf2fc778aeb692519cf.profdata to chrome-mac-master-1607147157-05c119e40ba733e24d2e3874fc8b53f1f41ca77b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I055d26dfdf25556300c2bbc4d83fce99ca6a1396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576031Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834009}
-
Aaron Leventhal authored
Remove RemapAriaRolesDueToParent: - It's harmless to have cells, rows etc. exist without a parent table. Having code in Blink to remap these roles causes complexity and issues with aria-owns. Adding any complexity to do this is more trouble than it's worth - Remapping kListBoxOption to a kMenuItem when it's in a kMenu is related to old code inherited from WebKit. WebKit made efforts to try to change role=option or <option> elements inside a role=menu to menuitems, but this is just not worth it. Also, 2 old tests that failed now pass, so the -expected.txt files are removed -- the expectations were only there to allow the failures. Bug: 1150481 Change-Id: I7342e3c15bf2dd3d877f90e682db7d68bf8c9142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568365Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#834008}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b364bad6550e..d3455123dc42 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I3506dd759cdf78c55ba05a50f3dbeb3914e6073f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576023Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834007}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/46ab28975e89..ab784e384be6 2020-12-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9324e7c0d69783d9e7fbe4355c230a71d0cf2e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576024Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834006}
-
Fergal Daly authored
The call in SetRenderFrameHost was useless because the speculative RFH has already been move out of place so the validation exits early. This change moves the validation into a static method that takes 2 frames as arguments, so that it can be used even in this case. https://crrev.com/c/2564933/1 shows that this passes all tests even with SkipEarlyCommitPendingForCrashedFrame. Bug: 1146573 Change-Id: I59574bd78a93534ec7e0ae603589e82c2e87a119 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564933Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#834005}
-
Jimmy Gong authored
Provide more context on where the setting buttons is routed to. Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/ad7a89eaab68906ed5e04fc18cf4f6cacd1ef94c Fixed: 1152781 Change-Id: I0fef47d663c41f20ba3842820d661967bbc08066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570328 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#834004}
-