- 13 Nov, 2019 40 commits
-
-
Mike West authored
The test has flaked thrice this morning on Win10, and looks flaky generally: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http%2Ftests%2Fdevtools%2Ftracing%2Ftimeline-style%2Ftimeline-style-recalc-all-invalidator-types.js TBR=bmeurer@chromium.org Bug: 1024151 Change-Id: I4b5e37604bd0aaf5d6fce253ceee9d22dd44c7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912703Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#714867}
-
Saurabh Nijhara authored
Updated API in update_required_screen to fetch the Eol status of the device. GetEolStatus has been deprecated and hence, now using GetEolInfo. Also, added a browser test for the same. Bug: 1020616 Change-Id: I3e5ba906fb9c2fa88e75536b4a1017ae2f7bee79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910085 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#714866}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e94ac7ab5553..89ab0576bf88 git log e94ac7ab5553..89ab0576bf88 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 e33c1582b4bc..4f023f565a61 (4 commits) Created with: gclient setdep -r src/third_party/skia@89ab0576bf88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: chromium:None Change-Id: I4c1c91f99339f5865a9f9c6fd67662ca1388031e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914037Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714865}
-
Rahul Arakeri authored
Mac uses Option + click instead of Shift + click (on Windows/Linux). Bug: 1016955 Change-Id: I49c54fb8773c68d37d4bc0b7fc677f259767967b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885975 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714864}
-
Mike West authored
See https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/6852 is a recent build in which it fails with: ``` ({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,19],"numberOfLiveResourceFetchers":[1,2],"numberOfLiveResources":[0,2]}) ``` TBR=snianu@microsoft.com Bug: 1024161 Change-Id: Ifa8923ce4e71d3fb097e788f9f1ce613d2ce98da No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912705 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/362f46250e2d..33ddd5f9c3ce git log 362f46250e2d..33ddd5f9c3ce --date=short --no-merges --format='%ad %ae %s' 2019-11-13 skyostil@google.com Merge "TrackEvent: Add support for instant events" Created with: gclient setdep -r src/third_party/perfetto@33ddd5f9c3ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I6cf8b9ef2bef07df434b9a529a46e497293854ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914159Reviewed-by:
-
Kent Tamura authored
* Rename FindActualFocusTarget() to GetFocusableArea() to match to the specification. * FlushAutofocusCandidates() applies GetFocusableArea() instead of focusing delegatesFocus hosts unconditionally. Bug: 1024056 Change-Id: I954e306d9fec20bbe26b46060aefa0d9925ad14b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913222 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#714861}
-
Kuo Jen Wei authored
Bug: b/117810572 Test: Pass presubmit check. Pass tast run <DUT> 'camera.CCAUI*' Change-Id: I7ad44a0d3d78ddd2c4f0d052d0bb6402e2406d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886270Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#714860}
-
Stefan Zager authored
The methods MapToVisualRectInTopFrameSpace and ApplyTransformForTopFrameSpace in LocalFrameView give the impression that they are mapping into the coordinate system of the main frame, but that is not the case. In fact, an OOPIF has never before known its position WRT its parent or the main frame. Fortunately, up to now nothing has relied on having coordinates mapped to the space of a remote main frame. This patch plumbs to each render process the offset of the local frame root from the main frame's viewport, so that it's possible to map to the coordinate space of the main frame. This capability is required for upcoming features. It also renames those two methods in LocalFrameView, to be more explicit about what they do: s/MapToVisualRectInTopFrameSpace/MapToVisualRectInRemoteRootFrame/ s/ApplyTransformForTopFrameSpace/MapLocalToRemoteRootFrame/ Change-Id: I3e6e3fc0f7c8edd78e2a30dd9051b8d03b3d8a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899386 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#714859}
-
Mike West authored
This reverts commit 06b27c6f. Reason for revert: This consistently fails under MSan with: ``` [ RUN ] StackTraceTest.OutputToStream ../../base/debug/stack_trace_unittest.cc:82: Failure Value of: backtrace_message.find("testing::Test::Run") != std::string::npos Actual: false Expected: true Expected a demangled symbol in backtrace: #0 0x5608768c4adb in backtrace /b/swarming/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:4101:13 #1 0x56087a80709b in base::debug::CollectStackTrace(void**, unsigned long) ./../../base/debug/stack_trace_posix.cc:840:39 #2 0x56087a45d4da in StackTrace ./../../base/debug/stack_trace.cc:206:12 #3 0x56087a45d4da in base::debug::StackTrace::StackTrace() ./../../base/debug/stack_trace.cc:203:28 #4 0x5608770e0c0f in base::debug::StackTraceTest_OutputToStream_Test::TestBody() ./../../base/debug/stack_trace_unittest.cc:39:14 #5 0x56087a2470c5 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #6 0x56087a2470c5 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2508:5 #7 0x56087a24abde in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2684:11 #8 0x56087a24c81a in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2816:28 #9 0x56087a28aa4a in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5338:44 #10 0x56087a288cae in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #11 0x56087a288cae in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:4925:10 #12 0x56087a9047a5 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2473:46 #13 0x56087a9047a5 in base::TestSuite::Run() ./../../base/test/test_suite.cc:394:16 #14 0x56087a98ce2a in Run ./../../base/callback.h:98:12 #15 0x56087a98ce2a in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:158:38 #16 0x56087a98c8bf in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:228:10 #17 0x56087a8b39a0 in main ./../../base/test/run_all_base_unittests.cc:12:10 #18 0x7f4d99e7d830 in __libc_start_main ??:0:0 #19 0x56087688a67a in _start ??:0:0 Stack trace: #0 0x56087a45d4da in StackTrace ./../../base/debug/stack_trace.cc:206:12 #1 0x56087a45d4da in base::debug::StackTrace::StackTrace() ./../../base/debug/stack_trace.cc:203:28 #2 0x56087a1f22de in StackTraceGetter::CurrentStackTrace(int, int) ./../../third_party/googletest/custom/gtest/internal/custom/stack_trace_getter.cc:22:27 #3 0x56087a226149 in testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) ./../../third_party/googletest/src/googletest/src/gtest.cc:820:35 ``` (see https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8896945774609420288/+/steps/base_unittests/0/logs/Deterministic_failure:_StackTraceTest.OutputToStream__status_FAILURE_/0) Original change's description: > Reland "[base] Cleanup StackTraceTest.OutputToStream #ifdef soup." > > This was most recently reverted in > https://chromium-review.googlesource.com/c/chromium/src/+/1906545 > due to failures on some ChromeOS platforms, which lack the necessary > tables to allow stack-trace unwinding. > > Bug: 999737, 706728 > Change-Id: I7889416cd2ae9b6a09caf9eebb68a5ccf8bf4ca3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911680 > Auto-Submit: Wez <wez@chromium.org> > Commit-Queue: Albert J. Wong <ajwong@chromium.org> > Reviewed-by: Albert J. Wong <ajwong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714735} TBR=ajwong@chromium.org,wez@chromium.org Change-Id: I94bb1c35c8a8b205b72f4a7705996276453f9c2a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 999737, 706728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912704Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6bfc3bbb7a58..15f6f95cdc3e git log 6bfc3bbb7a58..15f6f95cdc3e --date=short --no-merges --format='%ad %ae %s' 2019-11-13 vapier@chromium.org paygen: add some debug logic around storelog Created with: gclient setdep -r src/third_party/chromite@15f6f95cdc3e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ib69fb25b3037a5f9e66873776d3881b5604738d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913590Reviewed-by:
-
Julie Jeongeun Kim authored
This CL cleans up old mojo types for mojom::EmbeddedSearchClient using AssociatedReceiver, AssociatedRemote, and PendingAssociatedRemote. Bug: 955171 Change-Id: I1fe1d2cf2fda69ebc8f88f49771171741754b457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897399Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#714856}
-
Rune Lillesveen authored
With FlatTreeStyleRecalc we expect to traverse up the current flat tree ancestor chain even when the distribution is marked dirty. Otherwise, we will not be able to reach the style dirty nodes marked when we have a dirty distribution. Bug: 1023178 Change-Id: I2b80ad252bc17bb223a3caa9336526c9e2fb6387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911208Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#714855}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a1a26deab50b..362f46250e2d git log a1a26deab50b..362f46250e2d --date=short --no-merges --format='%ad %ae %s' 2019-11-13 treehugger-gerrit@google.com Merge "TrackEvent: Add support for scoped events" 2019-11-13 treehugger-gerrit@google.com Merge "ui: Fix persisting of target selection on record page" Created with: gclient setdep -r src/third_party/perfetto@362f46250e2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ia2d824576b2339de697b8572aba81c4d15f0148a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912935Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9501212cd058..e94ac7ab5553 git log 9501212cd058..e94ac7ab5553 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9da287fd0264..88632cac30e1 (6 commits) Created with: gclient setdep -r src/third_party/skia@e94ac7ab5553 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: chromium:None Change-Id: I27310e36afcff8203c20c11c4c7c3b9b23aa1fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912933Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2a11883d0071..9dab499b2b5b git log 2a11883d0071..9dab499b2b5b --date=short --no-merges --format='%ad %ae %s' 2019-11-13 dberris@chromium.org Pinpoint: Support 'story' in lieu of 'trace' Created with: gclient setdep -r src/third_party/catapult@9dab499b2b5b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=nuskos@google.com Bug: chromium:1023408 Change-Id: Ica5c46c80efe9d131add0f2e41acabfeabaace52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912934Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 79aabb06. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 88d98fda "Add more scroll to text WPTs" faa1edfe "update WPT tests to eliminate CSSPseudoElement from animations" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ic6db50c83c546242273ed94f8198066f6ebb6304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913112Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714851}
-
Shelley Vohr authored
Electron has exposed methods to allow setting the aspect ratio for a given window, and as a part of that needed to allow users to reset the aspect ratio. On macOS, we could do that using https://github.com/electron/electron/blob/3ae3233e65aa71b4815e156cd426834c30eb993b/shell/browser/native_window_mac.mm#L807-L816 , but on Linux this was not possible with currently exposed APIs without this patch. Change-Id: Ief3abea2322a734efe3e61b72df4d77daa88fb97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895789Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#714850}
-
Ramin Halavati authored
kCCTIncognito feature and flag are added to enable/disable incognito Chrome Custom Tabs. The default is set to disabled. Bug: 1023759 Change-Id: If32d256e3e9eaa94bcc09f7538c85e2dab53c589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911201Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#714849}
-
Ramin Halavati authored
Serving URL Request from persistent filesystems in incognito mode is enabled. Bug: 990592 Change-Id: Ieaaf59e60cc9d8de8ecbb3395ee209b0854555b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911202Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#714848}
-
rbpotter authored
Autogenerate a JS module version of cr/ui/store.js and add typechecking. This is a prerequesite for migrating pages that depend on cr.ui.Store to Polymer 3, e.g. Bookmarks. Bug: 1022213 Change-Id: I81634347188232468e851b63859b553c7e33c6a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912693 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#714847}
-
David Lei authored
This cl does the following: - change html encoding to utf-8 to support translation files. - add build-time grd file selection. - build real resources (if src-internal is available) or mock resources (for tests/if src-internal is unavailable). - iterate over chromeos_media_app_bundle_resources to add them as resources to serve at runtime. Submit after landing cl/277647372 & pushing to src-internal. Design doc: go/cr-g3-remote-resources#bookmark=id.b1xx7d4iasyv Bug: 996088, 1023739, b/141645032, b/142915800 Change-Id: Ib26a65b84f61b1f938e22c4242114448111c3469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895263Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#714846}
-
Shik Chen authored
Bug: b:111902891 Test: Pass capture_unittests. Change-Id: Ia9c207055613f0d2db98b22e435746a9818676dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911880 Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#714845}
-
Jan Wilken Dörrie authored
This change adds UKMs for Touch To Fill User Actions. Launch Bug: https://crbug.com/1008937 Collection Review: go/touch-to-fill-ukm-collection-review Bug: 1020996 Change-Id: Ie2c4c731e2f53d879b9d5df73ab4e4465b21b228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897932 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#714844}
-
Kuo Jen Wei authored
Use photo-item/video-item for item showing selected photo/video resolution. Use title-item for title of external camera. Test: tast run <DUT> 'camera.CCAUI*' Bug: b/141518780 Change-Id: Ie4bb9eb89e5b6c1fc17b3b0bc2d9055227f52b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905295 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
Maggie Cai authored
This CL adds the functionality to delete all preferred apps settings for an particular app id. BUG=853604 Change-Id: I9d5306d6b1cac860306a2fb568d828b1bebff4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913280 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#714842}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I466bd7d099511b4bbcbfcc2cbf58961f96f3b5d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912932Reviewed-by:
-
W. James MacLean authored
Disable /0 variant of ViewSourceWithSplitCacheEnabledTest.NetworkIsolationKeyReusedForBackNavigation. Dissable the test when the parameter is 'false'. TBR=yaoxia@chromium.org Bug: 1024033 Change-Id: Ia6f2b8e727437b2269f28c8c1353f41e83322510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913606Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#714840}
-
W. James MacLean authored
Disabling a flaky test. TBR=xingliu@chromium.org Bug: 910870 Change-Id: I3ad5666f526f9a9a6268f9a5c6e4e97e13649c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913561 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/29e7d3ba..09220549 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6d7cb4ced5b6705e60e84a63a67ffb376c427c7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913111Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714838}
-
Sinan Sahin authored
Bug: 1022185 Change-Id: Ib3344bd152874b92917b54b40a1f73003cfddd61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913463Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#714837}
-
W. James MacLean authored
Update testExpectations to deal with this flaky test. TBR=dalecurtis@chromium.org Bug: 816914 Change-Id: I0838b12a303a3b36bb4a915b69f2b9a307bc87ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913612Reviewed-by:
-
Zhiheng Li authored
Bug: internal b/143071435 Test: tested on AndroidThings device Change-Id: I4b93f9ed7c39dbfa1e669c285515234f2acc241d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902075Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Auto-Submit: Zhiheng(Vincent) Li <vincentli@google.com> Cr-Commit-Position: refs/heads/master@{#714835}
-
Liquan (Max) Gu authored
Added comments: * Comment why the ref over the weak-ref is chosen for WebContents. * Comment why using an abbreviation. Bug: 999196 Change-Id: I94eddbed050e131865869ac09521fa7275d48619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912912Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#714834}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/e46010f01da9..0865050e54e9 git log e46010f01da9..0865050e54e9 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 rharrison@google.com Split spvc shader generation into initialize and compile phases (#882) 2019-11-12 9856269+sarahM0@users.noreply.github.com opName - opStruct (#880) Created with: gclient setdep -r src/third_party/shaderc/src@0865050e54e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I62159dec827ab3d973b07f92d2f2230a5315c02d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912928Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cea09e02b1a6..a4e6d1590f29 Created with: gclient setdep -r src-internal@a4e6d1590f29 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I21bd3e5b70f712d0083a9712ad46599d5a74392e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912930Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714832}
-
Noel Gordon authored
Replace computer and shared SVG icons with viewBox="0 0 20 20" version from UX, and optimize them using SVGOMG. Bug: 992819, 1002393 Change-Id: I3f2d7625cb1d72e42a540e6da93a21bf186a819d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913779Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#714831}
-
Wei Lee authored
The corresponding CL on ARC side is: http://ag/9684171 Bug: b/144062362 Test: Tested with an enterprise account and policy which blocks CCA and CCA will not show up as an option when forwarding camera intent. Change-Id: Ie27c899f044d7e72cd58439510adbb4af6b7775e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903238 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#714830}
-
Manu Cornet authored
When going to tablet mode ShelfWidget/ShelfConfig gets updated before the AppListController gets to notify observers that AppList will be visible. This means ShelfWidget will update thinking that the AppList is not visible, when it actually is. To fix this race, check whether the AppList *should* be visible at ShelfConfig::is_in_app(). Change-Id: I7d82b6ca5bd8933146dad75c0c1edb3257e41a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903595 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#714829}
-
Paul Dyson authored
Bug: 991433 Change-Id: Ifdb323f64cb9dddc59e95ba673a5cadbf7869cb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910822 Commit-Queue: Paul Dyson <pdyson@chromium.org> Reviewed-by:
-
