GitLab

There was a race condition where GetTokenService could be called on an
already destroyed TokenServiceProvider (see linked bug for details).
Update Core to ensure TokenServiceProvider is not destroyed out from
under the token service task runner thread.

BUG=401119

Review URL: https://codereview.chromium.org/458753006

Cr-Commit-Position: refs/heads/master@{#289222}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289222 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349436

Review URL: https://codereview.chromium.org/453033004

Cr-Commit-Position: refs/heads/master@{#289221}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289221 0039d316-1c4b-4281-b951-d872f2087c98

This reduces telemetry_unittests cycle time by ~12s on all platforms.


BUG=402956
TEST=NO_TVCM=1 tools/telemetry/run_tests action_runner play seek

Review URL: https://codereview.chromium.org/463013003

Cr-Commit-Position: refs/heads/master@{#289220}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289220 0039d316-1c4b-4281-b951-d872f2087c98

Currently when unpublishing or unsubscribing, we still keep playing or recording
audio till it times out. We need to keep a track of which operations have
requested playing or recording and once those operations are unpublished or
unsubscribed, we need to appropriately stop the record/playback.

To do this, the first change is to stop keeping a list of tokens, instead we
just keep a list of operations. If we send our currently playing token to the
server, it is guaraunteed to _not issue another token, unless our current token
is going to expire in less time than is on the publish. In that case, we simply
replace our currently playing token with the new one, making sure that we
always just need to keep one token around.

With this, the logic for playing/recording is completely changed. Now we just
check if we have active transmit/receive, and if we do, we ensure that we are
playing our current token (or keep recording); if we do not have an active
transmit and we are playing, we stop playing. For all other cases our
ProcessNextTransmit and ProcessNextReceive is a nop.

The one ugliness in the code is that we have to keep the code for processing
the audible and inaudible tokens in the same class, since the WhispernetClient
can only give 'one' method tokens back. If two different classes call the
WhispernetClient to encode tokens, the get samples callback from the second
will overrite the callback for the first, hence the first class will never
get its samples back. Once we find a way around this, we can just have two
AudioDirectiveHandlers, one for audible and one for inaudible, but till then
we need to keep this processing together in one AudioDirectiveHandler.


R=xiyuan@chromium.org
BUG=392028

Review URL: https://codereview.chromium.org/461803003

Cr-Commit-Position: refs/heads/master@{#289219}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289219 0039d316-1c4b-4281-b951-d872f2087c98

The crash occurs because of a timer dereferencing a null engine pointer.
The crash appears to have occurred due to this patch https://codereview.chromium.org/427583003/

Fix is to cancel all timers when the pdf instance is being torn down before
destroying the engine.

BUG=403036

Review URL: https://codereview.chromium.org/462283002

Cr-Commit-Position: refs/heads/master@{#289218}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289218 0039d316-1c4b-4281-b951-d872f2087c98

Force a commit if the top controls animate the scroll offset. This prevents main
and impl scroll offsets from remaining out-of-sync, which can cause problems
with subsequent touch interaction.

BUG=402907,364340

Review URL: https://codereview.chromium.org/461083002

Cr-Commit-Position: refs/heads/master@{#289217}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289217 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401761

Review URL: https://codereview.chromium.org/401453002

Cr-Commit-Position: refs/heads/master@{#289216}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289216 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402943

Review URL: https://codereview.chromium.org/464243002

Cr-Commit-Position: refs/heads/master@{#289215}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289215 0039d316-1c4b-4281-b951-d872f2087c98

Clicking on the install button for a paid app will now open the webstore
page for the app, where the user can sign in (if not signed in already)
and see the price of the app / buy it.

BUG=319024
TEST=Check installing paid and unpaid apps from the app launcher search
results.

Review URL: https://codereview.chromium.org/448543002

Cr-Commit-Position: refs/heads/master@{#289214}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289214 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401588

Review URL: https://codereview.chromium.org/450053003

Cr-Commit-Position: refs/heads/master@{#289213}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289213 0039d316-1c4b-4281-b951-d872f2087c98

Keep trackers demoted when it is being synced from local to remote, so that the tracker is not chosen for another LocalToRemoteSyncer instance.

BUG=344769
TEST=unit_tests --gtest_filter=LocalToRemoteSyncerTest.*

Review URL: https://codereview.chromium.org/446793002

Cr-Commit-Position: refs/heads/master@{#289212}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289212 0039d316-1c4b-4281-b951-d872f2087c98

Screenshot:
http://i.imgur.com/RILqQqe.png

BUG=234425

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288418

Review URL: https://codereview.chromium.org/359493005

Cr-Commit-Position: refs/heads/master@{#289211}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289211 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289210}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289210 0039d316-1c4b-4281-b951-d872f2087c98

Revert of GN: Specify grit generated output paths to be the same as gyp's. (patchset #1 of https://codereview.chromium.org/454253004/)

Reason for revert:
Broke GN compile and try jobs

http://build.chromium.org/p/chromium.webkit/builders/Linux%20GN

Original issue's description:
> GN: Specify grit generated output paths to be the same as gyp's.
> 
> BUG=401588
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289149

TBR=brettw@chromium.org,jamescook@chromium.org,yoz@chromium.org,thestig@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=401588

Review URL: https://codereview.chromium.org/461213003

Cr-Commit-Position: refs/heads/master@{#289209}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289209 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Split Screen mode implementation. (patchset #3 of https://codereview.chromium.org/461503002/)

Reason for revert:
Breaking "Linux Chromium OS ASan LSan Tests (3)" http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/2721

Original issue's description:
> Split Screen mode implementation.
> 
> Implements Split Screen mode and window cycling behavior.
> Resubmit of https://codereview.chromium.org/420603011/
> 
> TBR=oshima@chromium.org,mukai@chromium.org
> 
> BUG=383421
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289064

TBR=mukai@chromium.org,oshima@chromium.org,sadrul@chromium.org,mfomitchev@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=383421

Review URL: https://codereview.chromium.org/468053002

Cr-Commit-Position: refs/heads/master@{#289208}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289208 0039d316-1c4b-4281-b951-d872f2087c98

Segfault occurs in internet_options_handler.cc when accessing a
non-existent policy. This was introduced in https://crrev.com/427903004.

Please note: http://imgur.com/sD3vz0W.jpg

BUG=403111
R=pneubeck@chromium.org
TBR=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/470433002

Cr-Commit-Position: refs/heads/master@{#289201}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289201 0039d316-1c4b-4281-b951-d872f2087c98

This file was just a placeholder, including blink_test_environment.h
waiting for Blink to be updated.

Now that Blink was updated and rolled into Chromium, we can remove it.

Chromium side (part 1) ->
https://src.chromium.org/viewvc/chrome?revision=288636&view=revision
Blink side (part 2) ->
https://src.chromium.org/viewvc/blink?revision=179977&view=revision
Chromium side (part 3) -> this patch

BUG=None
TEST=webkit_unit_tests
R=avi@chromium.org

Review URL: https://codereview.chromium.org/463603003

Cr-Commit-Position: refs/heads/master@{#289200}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289200 0039d316-1c4b-4281-b951-d872f2087c98

- keyboard overlay and partial_screenshot overlay should do nothing
  if there are already overlays.
- overlay_event_filter should cancel the existing delegate if
  another delegate is trying to activate.

BUG=341958
R=jamescook@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/461093003

Cr-Commit-Position: refs/heads/master@{#289199}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289199 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=sadrul@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/465143002

Cr-Commit-Position: refs/heads/master@{#289198}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289198 0039d316-1c4b-4281-b951-d872f2087c98

Decoders can register to get notified when a Decryptor is set.
setContentDecryptionModule() provides a new Decryptor to
WebMediaPlayer. Since the decoders run on the media thread, it may
take some time for the old Decryptor to get detached and a new one
connected. Adding a callback to be used so that
setContentDecryptionModule() knows when the Decoders are done with
the notification. The additional callback is optional. This will be
used to resolve the setMediaKeys() promise on the blink side.

BUG=358271
TEST=media unittests and EME layout tests pass

Review URL: https://codereview.chromium.org/416333011

Cr-Commit-Position: refs/heads/master@{#289197}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289197 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289195}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289195 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jamesr

Review URL: https://codereview.chromium.org/467943002

Cr-Commit-Position: refs/heads/master@{#289194}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289194 0039d316-1c4b-4281-b951-d872f2087c98

Notify the ContentViewClient of selection and insertion-related events,
allowing customized behavior depending on the state of selection. This is
particularly relevant for informing how the selection text string is being
updated.

BUG=400824

Review URL: https://codereview.chromium.org/469483002

Cr-Commit-Position: refs/heads/master@{#289193}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289193 0039d316-1c4b-4281-b951-d872f2087c98

Has a JavaScript file that contains a function to tell whether or not a
page is an article and related functions to get a string of that JavaScript
so that it can be injected into the page.

BUG=383630

Review URL: https://codereview.chromium.org/464973002

Cr-Commit-Position: refs/heads/master@{#289192}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289192 0039d316-1c4b-4281-b951-d872f2087c98

This changes the currently unused V8ObjectVar to store a pointer to the
instance rather than a PP_Instance ID. This is just more convenient for
the code which uses the V8ObjectVar. When the instance is deleted, the
pointer will be cleared so it should always be valid or NULL.

BUG=351636

Review URL: https://codereview.chromium.org/464653003

Cr-Commit-Position: refs/heads/master@{#289191}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289191 0039d316-1c4b-4281-b951-d872f2087c98

Made changes based on new API level to make Lint happy in all
builds.

BUG=327768

Review URL: https://codereview.chromium.org/460453002

Cr-Commit-Position: refs/heads/master@{#289190}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289190 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350219
TBR=thestig

Review URL: https://codereview.chromium.org/460183002

Cr-Commit-Position: refs/heads/master@{#289189}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289189 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402728

Review URL: https://codereview.chromium.org/464693002

Cr-Commit-Position: refs/heads/master@{#289188}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289188 0039d316-1c4b-4281-b951-d872f2087c98

booleans in Mojo messages":
(http://src.chromium.org/viewvc/chrome?view=revision&revision=282182)

Use ArrayOf(PackedBool) instead of ArrayOfBoolArrayPointers. This makes
it easier for the TBD JS message validator to retrieve the type of an array's
elements. It's also a little more consistent with the rest of codec.js.

BUG=402601

Review URL: https://codereview.chromium.org/460063002

Cr-Commit-Position: refs/heads/master@{#289187}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289187 0039d316-1c4b-4281-b951-d872f2087c98

ServiceWorkerCacheStorage currently expects to have its public
functions run by a SequencedTaskRunner.

This CL changes the functions to run on the calling thread and only
uses the TaskRunner for blocking operations.  This way, when calling
the cache and blob storage, we're on the calling thread (IO).

Also added some comments along the way.

BUG=392621

Review URL: https://codereview.chromium.org/460683002

Cr-Commit-Position: refs/heads/master@{#289186}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289186 0039d316-1c4b-4281-b951-d872f2087c98

Moves ForceEnableZoom, UserSetForceEnableZoom, and 
FontScaleFactor preferences upstream and adds support for
observing all those preferences in Java.

UserSetForceEnableZoom is currently stored using Android
SharedPreferences, which are application global, so this
class is currently not keyed off the profile. Preferably
this should be migrated to be per profile, at which point
the FontSizePrefs could be keyed off the profile instead of
being an application global singleton.

BUG=383630

Review URL: https://codereview.chromium.org/415343002

Cr-Commit-Position: refs/heads/master@{#289185}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289185 0039d316-1c4b-4281-b951-d872f2087c98

We migrated to the new kToolbarSize pref over four years ago.  I think this is
safe to remove. :)

Review URL: https://codereview.chromium.org/451193003

Cr-Commit-Position: refs/heads/master@{#289184}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289184 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403143

Review URL: https://codereview.chromium.org/469583003

Cr-Commit-Position: refs/heads/master@{#289183}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289183 0039d316-1c4b-4281-b951-d872f2087c98

This helps check that the pexe fetch is able to happen before
the component files are accessed. Otherwise, if the component
files are accessed before the pexe fetch, then it will error
out early, and the PNaCl on-demand installation will not happen.

Followup to Justin's fix: https://codereview.chromium.org/453073002
I tested that without Justin's fix, this patch will make the test catch the error.

BUG=401755

Review URL: https://codereview.chromium.org/467863002

Cr-Commit-Position: refs/heads/master@{#289182}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289182 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Fix for race condition where print preview hangs when attempting to print a PDF that hasn't loaded. (https://codereview.chromium.org/427723004/)

Reason for revert:
The changes fix an issue, but cause a more serious one. 

crbug.com/402402

Original issue's description:
> Fix for race condition where print preview hangs when attempting to print a PDF that hasn't loaded.
> 
> If |type| in RequestPrintPreview() equals PRINT_PREVIEW_USER_INITIATED_ENTIRE_FRAME and |is_loading_| is true, RequestPrintPreview() returns,
> then is called again, right after |is_loading_| is set to false in DidStopLoading(). 
> 
> 
> BUG=376969
> TEST=See bug for steps to reproduce.
> 
> Additional way to reproduce:
> Build blink_tests and browser_tests in out/Release. Then in src/webkit/tools/layout_tests run this command:
> ./run_webkit_tests.py --platform browser_test.linux source_pdf/
> 
> you can replace linux with win or mac depending on your platform.
> 
> The program will attempt to save a PDF as a PDF through print preview. It will eventually fail because Print Preview will hang due to this bug.
> If you want visual confirmation that this will happen open:
> src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_driver.py.
> 
> Then add this line of code to the function cmd_line.
> cmd.append('--enable-pixel-output-in-tests')
> 
> Then run the script again. Enabling pixel output will also make it significantly more likely for the bug to occur.
> Its also more likely to happen on windows for some reason.
> 
> This is how I came across the bug.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287982

Review URL: https://codereview.chromium.org/463123004

Cr-Commit-Position: refs/heads/master@{#289181}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289181 0039d316-1c4b-4281-b951-d872f2087c98

In Cast Streaming we used to fail if coded size of the video frame
doesn't match the configured resolution.

This should be changed to natural size because one some hardware the
capturer can pad the video frames to encode efficiently.

BUG=402501

Review URL: https://codereview.chromium.org/467913002

Cr-Commit-Position: refs/heads/master@{#289179}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289179 0039d316-1c4b-4281-b951-d872f2087c98

BUG=388517
NOTRY=true

Review URL: https://codereview.chromium.org/466203002

Cr-Commit-Position: refs/heads/master@{#289178}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289178 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396738

Review URL: https://codereview.chromium.org/462313002

Cr-Commit-Position: refs/heads/master@{#289177}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289177 0039d316-1c4b-4281-b951-d872f2087c98

to initialize requests in WebURLLoaderImpl.

BUG=394645

Review URL: https://codereview.chromium.org/453133002

Cr-Commit-Position: refs/heads/master@{#289176}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289176 0039d316-1c4b-4281-b951-d872f2087c98

With the workaround in r286800, mailbox synchronizer skips tile
textures, so is compatible with async transfer egl.

This is a partial revert of r286501.

BUG=399311

Review URL: https://codereview.chromium.org/463563002

Cr-Commit-Position: refs/heads/master@{#289172}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289172 0039d316-1c4b-4281-b951-d872f2087c98