- 10 Mar, 2020 40 commits
-
-
Abigail Klein authored
Move the entrypoint to the live caption feature to accessibility settings, which is the location specified by the PRD. Include the description text, specified by the PRD. The entrypoint allows live caption to be enabled on Linux and Windows only. Screenshots are included and uploaded to Google cloud for translation purposes. Bug: 1055150 Change-Id: I0c645e9273db95a2e5ec929960bc842b6b3e8cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090100Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#748807}
-
Ana Salazar authored
This animation happens during transition between hotseat states. Bug: 1058609 Change-Id: Iff1f81625e6de2bf6dc6dcfee09225c4d16cc53e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088641Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#748806}
-
Gayane Petrosyan authored
Bug: 1056176 Change-Id: I3e3b4cdca19c628c1e575fae2e90fe0f016e488b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078982 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Auto-Submit: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#748805}
-
Greg Thompson authored
The test was leaking an empty key on TearDown. With this change, it deletes the key if it was created in SetUp and also deletes an empty key left behind by previous test runs. Additinally, tests from this harness must run serially since they all interact with the ServiceControlManager and centralized machine state. As such, build and run them into setup_unittests rather than installer_util_unittests. This change also introduces a use of ScopedInstallDetails to configure state for system-level operations (the only case in which the code under test will run). BUG=1059314 Change-Id: I6f3a35cda45704e9195dfae25a90401fb8915c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095540 Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#748804}
-
Vasiliy Telezhnikov authored
This CL fixes the size of SurfaceQuad that used to embed root renderer content. Previously it was assumed to be viewport size, this CL changes it to CompositorFrame size. Bug: 805739 Change-Id: I035f5928bd2cb57c6cc6ffd301d8f6e363d28ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096114Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#748803}
-
Rayan Kanso authored
Use version 122 which includes all the required changes for enabling web shortcuts for WebAPKs. Coincides with M82. Change-Id: I3e636ab1a7bf56a9f14b7556cb04902a0d74bbb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095546Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#748802}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b2678cfefedd..84a1b3e9ba0d git log b2678cfefedd..84a1b3e9ba0d --date=short --first-parent --format='%ad %ae %s' 2020-03-10 nisse@webrtc.org Remove nisse from call/OWNERS Created with: gclient setdep -r src/third_party/webrtc@84a1b3e9ba0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I91ccb2148fdecb6b85ba91c7b09ae002238d0e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096552Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748801}
-
Xianzhu Wang authored
Only reference filters can create visual effect on empty contents. As we now support empty paint chunks, we can avoid the dummy display item for a filter on empty contents. Instead, we emit filter paint operation for the filter with correct bounds and visual rect in PaintChunksToCcLayer. Change-Id: I709858a236aefa0403d35f591928f25875560f9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093915 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#748800}
-
Manu Cornet authored
Now that the overflow bubble code is gone, it's safer to remove ways for users to disable this flag. Call sites for "is scrollable shelf enabled" (which now always returns true) will be updated in a separate change. Bug: 1009638 Change-Id: I69f6bcbc771a0afcf2cebfbfe01a58c0f7f16079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095122 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#748799}
-
Dana Fried authored
This was causing e.g. the save password icon to not appear or appear incorrectly in some cases, see attached bug. New solution is to have the PWA actions container directly implement the container interface and override the insets logic, which has been simplified to return the insets and not a whole border object. Followup: - Use the same logic to fix a wonky insets (and inkdrop) size in touch mode with the Butter chip Bug: 1059659 Change-Id: Ia92753e55be5f43b34718cc9901f5273badf3eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096117 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#748798}
-
Matthew Mourgos authored
This change moves the gesture OOBE animations into "chrome/browser/resources/chromeos/login/images/" where other OOBE related resources already reside. Change-Id: I1e8b319eff5e675ea7f195b9392428143320618e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095782Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#748797}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0c4a3c2503a6..f8ceb227ac3a git log 0c4a3c2503a6..f8ceb227ac3a --date=short --first-parent --format='%ad %ae %s' 2020-03-10 jbudorick@chromium.org Roll luci-auth. Created with: gclient setdep -r src/third_party/depot_tools@f8ceb227ac3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1059948 Tbr: agable@chromium.org Change-Id: I166bf06fce90001934777c65b657ecf57a6e0558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096919Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748796}
-
Chris Mumford authored
Fused sensors were being rounded (r746199) for privacy. The fused sensors were interpretig the SensorReading as the wrong type, using the input type instead of the fused output type. This resulted in interpreting a relative Euler sensor as quaternion. Bug: 1058722 Change-Id: I41bb81daa65314f1e069487c4614177efee273ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095868 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#748795}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eaadca132fce..4599cc694fd8 git log eaadca132fce..4599cc694fd8 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 jacktfranklin@chromium.org Add missing license header to BUILD.gn file Created with: gclient setdep -r src/third_party/devtools-frontend/src@4599cc694fd8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I875e2f0d61de41dd3ec67a3b0423ee6a1b5394a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096916Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748794}
-
George Burgess IV authored
The variable here is an `int64_t`. On arm, this should be `%lld`. PRId64 solves these things. Bug: 1058218 Change-Id: Id06c379bd3af9498ea8b5e0fb94c2c594d4be1d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095942Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#748793}
-
sczs authored
This was removed in https://crrev.com/c/2058083, but for History's case this is still needed in order to get rid of the separators when the tableview is empty. Other collections hide the separator lines when the screen is shown, since History has a search function is a bit different and this was the easiest safest way of doing it. Bug: 1057998 Change-Id: Ia58ee0bc70ad08daf19c1d0721d894986de4e333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090915Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#748792}
-
Ken Rockot authored
This also serves as a simple example of converting a typemap with inlined sources on a mojom_component target. Bug: 1059389 Change-Id: If80faa47cdfcebf7c36c80d1ef6a611cb31bd69e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094336 Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#748791}
-
Olivier Li authored
Document some intent of atomic operations with memory order directives and make some comments more correct. Bug: 1034046 Change-Id: Ice1968a2b655e2dd5e0dbdcf0a7fd12d2f8be166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079198Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Oliver Li <olivierli@google.com> Cr-Commit-Position: refs/heads/master@{#748790}
-
sauski authored
The Recent Permissions polymer element introduced in a previous CL did not support re-focusing upon a back navigation. This CL extents the element to support this. Bug: 1032584 Change-Id: I20d038d27ea55f7f6146e661277f9640d1350a4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086262 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#748789}
-
Aran Gilman authored
Note that the tests currently cover only one metric, ReaderModeReceivedDistillability. The other still needs to have a test added in a follow-up CL. See go/chrome-desktop-reader-mode-dd#heading=h.5rfn5g2dude for the UKM collection review. Bug: 992074 Change-Id: I30b31bca6d7d3e3310c984022118a56d3b0a68b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881497Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#748788}
-
Mohamed Amir Yosef authored
Bug: 1002000 Change-Id: I5c870f4c8d63a08c59c0b035ffb9e34c0c03f994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095545Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#748787}
-
Shakti Sahu authored
CCT incognito was enabled accidentally. Disabling it. Bug: 651995 Change-Id: I2fcd8ab4aafe7e9908efd3463f850bf6682618ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096876Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#748786}
-
Mikel Astiz authored
Change-Id: I1c6d16a6f95beca15c5b00cd84a3057aa9f23441 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093610Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#748785}
-
Yue Zhang authored
Bug: 1050443 Change-Id: I093021c8763df8d4d1978fb0bf249391d9e74aa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092116Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#748784}
-
Joshua Pawlicki authored
This reverts commit f440b571. Reason for revert: Breaks compile: [8419/52202] CXX obj/chrome/browser/browser/ui_controller_android_utils.o FAILED: obj/chrome/browser/browser/ui_controller_android_utils.o /b/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF...(too long) ../../chrome/browser/android/autofill_assistant/ui_controller_android_utils.cc:135:53: error: calling a private constructor of class 'JniIntWrapper' Java_AssistantDateTime_Constructor(env, value.year(), value.month(), ^ ../../base/android/jni_int_wrapper.h:46:3: note: declared private here JniIntWrapper(long); ^ 1 error generated. Original change's description: > [Autofill Assistant] Added ShowCalendarPopup to UI framework. > > This adds a new interaction to the framework, which shows a calendar > popup and lets the user set or clear a date from the specified range. > > Bug: b/145043394 > Change-Id: I739e6b5ccb5821352b1ce63e63d8573bdde74f8f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093224 > Commit-Queue: Clemens Arbesser <arbesser@google.com> > Reviewed-by: Sandro Maggi <sandromaggi@google.com> > Cr-Commit-Position: refs/heads/master@{#748718} TBR=arbesser@google.com,marianfe@google.com,sandromaggi@google.com Change-Id: I3f9bfc40d3c3f7cec4118eb189fdf48709a6e62e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/145043394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094710Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#748783}
-
Joshua Pawlicki authored
NOTRY=true TBR=szuend@chromium.org Bug: 1060270 Change-Id: Ic7d66dbd821aa57a4058a84635ed0ddba919d127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096996Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#748782}
-
Tom Anderson authored
This type is specific to NavButtonProvider, which only exists for Linux, so the type is moved inside NavButtonProvider R=sky BUG=None Change-Id: I910bd42a4ead9a8b6add268f021d01dbc6eb41b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092877 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#748781}
-
Rushan Suleymanov authored
Bug: 1048771 Change-Id: I9b6a201cb0ab4f7f9477a13c5cad10d27c72b4f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089676Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#748780}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c598caf81aa3..8cf4a76817cb git log c598caf81aa3..8cf4a76817cb --date=short --first-parent --format='%ad %ae %s' 2020-03-09 dburger@chromium.org Better failure message out of RevWorkOnEBuild. 2020-03-09 saklein@chromium.org cros flash-ap: Fix servo default port example. 2020-03-09 kinaba@google.com chrome_chromeos_lkgm: Skip betty. Created with: gclient setdep -r src/third_party/chromite@8cf4a76817cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Ie1c2b0ce3dd984261604181c9fdd99baf9cb329f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096541Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748779}
-
Becca Hughes authored
Add a basic webui at chrome://media-feeds for debugging Media Feeds internals. BUG=1058187 Change-Id: Ia769f103bdd5abfd6ff00754c26117e684d2fb03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086331 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#748778}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1f6408da19a..6c0bae98fece Created with: gclient setdep -r src-internal@6c0bae98fece If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I1e1a15c11baa13d6bb0f20870d4f227823d9e4bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096548Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748777}
-
Ken Rockot authored
Bug: 1059389 Change-Id: Ifbef91dec1142962f1dcdd34dd2c6e0b2000cd13 Tbr: jbroman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092065 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#748776}
-
Brian White authored
Change-Id: I330fcde6b5413bee9f035866518f1bd4734220d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095343 Auto-Submit: Brian White <bcwhite@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#748775}
-
Xianzhu Wang authored
Pixel moving filters [1] can expand bounds of visual effect from the bounds of all descendants. We need reference box for all of them. [1] https://cs.chromium.org/chromium/src/cc/paint/filter_operations.cc?rcl=0b6c41a840ed2a011a989c5d2130b93cc038fc4d&l=82 Change-Id: I1a1fcce6b1db2d876820d263c1456fe6c482ba33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095958Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#748774}
-
Omar Morsi authored
ECDSA support in chrome.enterprise.platformKeys support was introduced in this CL:1967468 and this CL mentions its usage in the API documentation. Bug: chromium:1058036 Change-Id: Ie9c57f1fe7024a47d350fd6fda5e5e8a51671118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087618Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#748773}
-
Michael Sun authored
A variable is initialized inside function MediaSessionPositionChanged to temporally store duration/length information or remain 0 if duration is not updated. This blocking the media position from updating as well. Fixing the issue by add a zero check for the duration before compare to the position. BUG=b:147365793 Change-Id: I51d853bf8d618e28ccf75b68cea3c1d02f03b031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095413 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Auto-Submit: Michael Sun <michaelfsun@google.com> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#748772}
-
Jamie Walch authored
macOS's extended chmod syntax can be used for either users or groups, and supports "user:<user>" and "group:<group>" to resolve ambiguities. This causes problems if the username is "user", as chmod can't parse the ACL in this case. This CL prepends "user:" to all ACLs to avoid this problem. Change-Id: I15c143b94a2c3113f518ed2b558f007ad769d0c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088397 Auto-Submit: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#748771}
-
Jeff Yoon authored
* ci.star - ios13-beta-sim to run Chromium recipe * mb_config.pyl - GN arguments for ios13-beta-sim * testing/*.pyl, *.json - tests to bind to ios13-beta-sim * Replaced contents of ios-sim-cr-recipe with this as it is no longer needed. All introduced content (mixins, waterfall, test_suites) need a mapping, so I've replaced it as part of clean up as well. * gn_isolate_map.pyl - updating all iOS test targets to generated scripts. Remains backwards compatible to iOS as required files are still there for iOS recipe consumption. * BUILD.gn files - adding shard values for test targets that utilize parallelization via test runner. Bug: 1055164 Change-Id: Id36ffdecd2935cacdf4825c99f26d2f6b561200d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085118Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#748770}
-
Rouslan Solomakhin authored
Before this patch, the only call site for RespondWithCallbacks::CreateForInvoke() always specified PAYMENT_REQUEST as the event type, which is redundant, because only PAYMENT_REQUEST event can invoke a payment app. This patch removes the event_type parameter from the CreateForInvoke() static method. After this patch, calling into RespondWithCallbacks::CreateForInvoke() does not require to specify an event type. Bug: 1005076 Change-Id: I9eb33b9c08585534c5ec451574ee5563efa3b52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090802 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#748769}
-
Gayane Petrosyan authored
Boilerplate code that adds properties for download button and qrcode bitmap. This CL also hooks up the download button to saveBitmap utility function. Bug: 993920 Change-Id: I1ebc7a6641a7294a1b3d9c63fd8cfdeb83fb7c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071510Reviewed-by:
Travis Skare <skare@google.com> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Auto-Submit: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#748768}
-