- 17 Aug, 2020 40 commits
-
-
Andy Paicu authored
Since camera and microphone are particularly sensitive permissions we should be viligent and stop streams immediately when the user revokes the permission. This CL uses the permission controller subscription functionality to listen to permission changes on the relevant origins. Each DeviceRequest will have up to 2 permission subscriptions (1 audio, 1 video). When a permission is changed to non-Granted the specific DeviceRequest is canceled. Subscriptions are removed when the DeviceRequest is deleted. Because MediaStreamManager is an IO thread class but PermissionController is a UI thread class, this CL has to do a bit of thread hoping: FinalizeStream(IO) > SubscribeToPermissionControllerOnUIThread(UI) > SetPermissionSubscriptionIDs(IO) >(maybe)> UnsubscribeFromPermissionControllerOnUIThread(UI) DeleteRequest(IO) > UnsubscribeFromPermissionControllerOnUIThread(UI) Bug: 1116435 Change-Id: I6649125e028d607eeb7ba5701b710a715addf6f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352790 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#798564}
-
Glen Robertson authored
This is used to synchronously query for available icons matching the desired parameters. Needed for app_icon_factory. Will allow other ReadSmallest[Compressed]Icon calls to take a set purpose and size instead of a vector<IconPurpose> and min_size. Bug: 1102701 Change-Id: I592db59435badbbd6e63bf6c485b505ad4c86088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355159 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#798563}
-
George Burgess IV authored
Was this intended to be a use-after-move? Or not? Only one way to find out! (This was flagged by clang-tidy as potentially buggy code, since uses of things after std::move is often a programmer error) Bug: None Change-Id: I274839476d5787820a03aa5e358fd35617a14786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202693Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#798562}
-
Wez authored
Add browser-test to verify that the document.visibilityState is set to "hidden" when a web.Frame is created. Also clean up FrameImpl::set_semantics_manager_for_test() not to require a fidl::InterfacePtr<>, to simplify the calling tests. Bug: 1109270 Change-Id: Ief6acc4aacb2e97d64896d30b75d2a3cf2cb9b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355924 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798561}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d2fe803ccc6a..00fc92a77376 2020-08-17 jobay@google.com Reland^2 "eliminate initial timeout in waitForFunction" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112692 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3a00976cae4a3105188b3ecf786c77e4e8c8fa2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359889Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798560}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5abddab6695e..3f714d9026a2 2020-08-17 jleconte@google.com Quest WebRtcTest is missing from the quest module. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1024246 Tbr: wenbinzhang@google.com Change-Id: Ie5189749a1e2a8ad6ed7b6ebda8bbf4b47a09d70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359829Reviewed-by:
-
Jonathan Mengedoht authored
The State processes the logic if .well-known/change-password is supported. Bug: 927473 Change-Id: Ib0276bb716d600aa458c38f8319b0978a3993159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346347 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#798558}
-
Takashi Toyoshima authored
Today, the method valid of the HTTP request is validated in Blink for user exposed APIs such as Fetch and XHR to conform the RFC 7230. But it's still possible that compromised renderers insert arbitrary ASCII strings to the method value. This patch adds the same RFC 7230 token check in the network service as the secondary check. Bug: 1110195 Change-Id: Ia99a986f82034875f7e8c0b2224f2260a99eeffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355534Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#798557}
-
Clemens Arbesser authored
This makes more sense to me, since (1) the controller shouldn't have to know, and (2) the parameters are owned by the trigger context anyway. This is a refactoring only and should have no user-facing changes. Change-Id: I06da79a4215a12df66bf5f69f7a2634ba34f43ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356504 Auto-Submit: Clemens Arbesser <arbesser@google.com> Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#798556}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d882e93e416b..c4245f475be7 2020-08-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from eb85c0213d43 to a9b199b05c1f (12 revisions) 2020-08-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 00c099ff to 39dd8685 (521 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1085700,chromium:1112112 Tbr: stani@google.com Test: Test: Test: Capture and play back first 1200 frames of COD. Change-Id: I5c1fb9b7c5bdc4ed5c51d5c0c18b397ac636f053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359750Reviewed-by:
-
Alexandre Courbot authored
This reverts commit 6f7b3d69. Reason for revert: segfaults on tast.arc.VideoDecodeAccelVDVDA.* Bug: b:163920993 Test: video_decode_accelerator_tests --use_vd_vda passes on Nocturne. Original change's description: > RELAND: media/gpu/vaapi_video_decoder: keep allocated VASurfaces alive > > The original CL was reverted due to crashes in betty initialization: > betty is a VM which doesn't support VA, so the VideoDecoderPipeline > constructed-destructed a VaapiVideoDecoder, hitting an unprotected > nullptr |vaapi_wrapper_| in dtor. Fix in crrev.com/c/2339494/2..3. > > TBR=andrescj@chromium.org > > Original CL description ----------------------------------------------- > > Certain platforms and codecs suffer from horrible artifacts (Intel BYT, > H264) or crashes (Intel BSW/BDW, VP9). This was traced to some kind of > error in the tracking of the VASurfaces lifetime in the driver: every > time we get a new resource from the pool to decode onto, this is > imported into libva as a VASurface: this works fine almost everywhere > but doesn't play well in these old platforms (see CreateSurface() body). > > This CL adds a map that keeps the ref-counted VASurfaces alive and > indexed by the unique GpuMemoryBufferId until the VA Context is > destroyed. In so doing, we're basically observing the "contract" of > va.h vaDestroySurfaces() [1] "Surfaces can only be destroyed after all > contexts using these surfaces have been destroyed". > > [1] https://github.com/intel/libva/blob/libva-2.0.0/va/va.h#L1134 > > Bug: b:142019786 b:143323596 > Change-Id: I593763ec02dad7bba240c8fed9e71de21637a231 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339494 > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795026} TBR=mcasas@chromium.org,jchinlee@chromium.org,andrescj@chromium.org Bug: b:142019786 b:143323596 Change-Id: Ibb0ccf74c2c540a005a1f26794fca9b2f85a6ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359598 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#798554}
-
Hitoshi Yoshida authored
This CL adds checking if |config->profile| is available before accessing it. Bug: 839389 Change-Id: I92214e32575f86c899c4a6fc3aeea189877118d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358941 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#798553}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5f4456e3c52f..807e4fa951b9 2020-08-17 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Jinja2 from 3f90fa05c857 to 61cfe2ac6c91 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I0f684505c690cb758d929aeb91de1beb253570bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359683Reviewed-by:
-
Jit Yao Yap authored
This CL adds a Mojo service for Remote Apps. The service is a thin layer which mainly forwards calls to the RemoteAppsManager. Only extensions under the imprivata_in_session_extension behavior feature have access to the API. Bug: 1101208 Change-Id: Ieaf9f6839ba22d86cb3fba8fa64afe49ade8e6ce DD: go/remote_apps_mojo Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332615 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#798551}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4ae1505c..f8df7e0a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ief440491b7882dd7dfae0a8338c4fb912a0a307c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358580Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798550}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9ae6d7f2ee9e..a9b199b05c1f 2020-08-17 cnorthrop@google.com Capture/Replay: Add ability to override entry points If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Test: Test: Capture and play back first 1200 frames of COD. Change-Id: I18ca50a17cd334aff13c36e7a4ec171252768453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359677Reviewed-by:
-
Thanh Nguyen authored
This CL: 1. Use vector icons for zero state file results. 2. Remove unnecessary pngs 3. Refactor file icon utils. Bug: 1067326 Change-Id: Ia64a505f4d40c7f8fcf981d7e6b976f7555de83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355351 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#798548}
-
Zhuoyu Qian authored
This patch rename UpdateShortcutInfosFromManifest() to UpdateShortcutsMenuItemInfosFromManifest(). And rename CreateShortcutInfos() to CreateShortcutsMenuItemInfos(). Bug: 1100751 Change-Id: Ibffe82bcac99676d6ca89f63df0588d776efae5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354126Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#798547}
-
Maggie Cai authored
Currently if we try to launch default arc app (e.g. play store) from intent picker when play store disabled, nothing will happen. This CL adapts the functionatliy to enable play store in this scenario. BUG = 1096903, 853604 Change-Id: Ib1efaba445d0dc957b2c425c61ffee164f838dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351350Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7491e8b30f77..d882e93e416b 2020-08-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from d315022be5b7 to 5e9b29fab92d (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: I1e1b9d434b22416bf5def211319890efcf35faab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359682Reviewed-by:
-
Maksim Sisov authored
Trusty and Jessie have symbols unversioned. Thus, unversion the symbols in Linux sysroot the same way as was done for libdbus. Bug: 1116384 Change-Id: I2c16584de51141b53536c2a24f992913170a8f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352948Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#798544}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e4e6433497c5..d2fe803ccc6a 2020-08-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0c6cd6fe41d3025375e6c9a028d5500d04672b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359678Reviewed-by:
-
Peter Kasting authored
* Inline temps * Style guide bans "0.f" * Don't restate types * Better Time/TimeDelta unit usage * Simplify * Improve comments * Split separate DCHECK conditions * Use const/constexpr more * Eliminate unnecessary heap alloc Bug: none Change-Id: I4f7938318d436855f754ea262af268a0a95f414f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359007 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798542}
-
Yuki Yamada authored
It is not necessary to call Abandon() if the ExecutionContext is already destroyed. This is tested in PrerenderingTest.AbandonPrerender. Bug: 1115764, 1100257 Change-Id: I3f21953c03b2688d0b3760b05a9aabf1ee8ca781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355357 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#798541}
-
Peter Kasting authored
* Inline temps * Range-based for * Split DCHECKs * Better units * Shorten code Bug: none Change-Id: I4f501c85c38f91efb3a6c94f2d3248f03cc808c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358998 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798540}
-
Nicholas Hollingum authored
Since crrev.com/c/1955818 all exo widgets (i.e. windows with a title bar, close buttons, etc) are defaulted to Arc++. This caused many crostini windows, which previously had no association, to be considered as Arc++ apps. This causes the Arc++ IME to steal events when there happens to be (or ever have been) an active input field in an arc++ app anywhere. We move the code that sets Arc++ windows to ClientControlledShellSurface, which Arc++ apps use. Bug: 1069388 Change-Id: If559a68315c2dcf175023f6601bdaf8bb6de46ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306499 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
-
Yoshisato Yanagisawa authored
Bug: 1105814 Change-Id: I78028c4e5f5bda13174090984675600270a011b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359026 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#798538}
-
Keith Lee authored
Applying comments in https://chromium-review.googlesource.com/c/chromium/src/+/2327773. Bug: 1108170 Change-Id: I3a528db4f4a7df288af0a5b02d758f5d9616f011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355657Reviewed-by:
-
Jing Wang authored
This is requested by UX in https://docs.google.com/document/d/1bZASllOcjDJdufpJdedUuM0cTQlIaoVO7K8AhXtWBrs/edit# Besides the announcement text change, now we will always announce the instruction about how to browse, accept and dismiss no matter if the annotation icon is displayed. So removed one inapplicable test. Test: Tested on DUT Bug: 1116298 Change-Id: I9fe24ea6ff50de5af4c24d4512dcf337f616b391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355530 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#798536}
-
Naoki Fukino authored
This is a follow-up of CL:2354115. As only one client listen to the click event of filter buttons, setting onclick property is sufficient and concise over addEventListener. Bug: none Change-Id: I13b5ad9c658c8489ec50a99754db422a79dc5551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359594Reviewed-by:
-
chrome://media-appTrent Apted authored
Currently user settings for default websites that may block these web features leak into system apps unless explicitly auto-granted. Bug: b/163088459 Change-Id: I22fb8bfcdd3a83c1a054c663bda0e54f89a6c238 Test: Open an image from ChromeOS Files app after setting chrome://settings/content/javascript to "Blocked" Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358940 Commit-Queue: dstockwell <dstockwell@google.com> Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
dstockwell <dstockwell@google.com> Cr-Commit-Position: refs/heads/master@{#798534}
-
My Nguyen authored
Bug: 1113612 Change-Id: I831b447955cc147c80cb9dac9da4414933d787ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358716Reviewed-by:
-
My Nguyen authored
Spell check logic is from languages_page. It's currently disabled. Further logic for spellcheck languages will be added later. Spec: http://go/cros-lang-settings-ux slide 23. Current view: http://screen/36a08c58-4057-46d7-a6ef-7f43d370cbdc Note: All strings are not finalised so they are translateable false and no screenshots required. Bug: 1113439 Change-Id: Ic79458b605eda3fafc35f606f961e42b4ab23ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354118 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#798532}
-
Prashant Nevase authored
There is no need to treat raster images differently. The element role added for images were used for deciding initial classification which is now moved to DarkModeFilter::AnalyzeShouldApplyToImage(), which should be called before calling ApplyToImageFlagsIfNeeded(). The functions added in Image class which were used for deciding element role for svg image container and gradient generated image are removed. Along with skipping filter to images drawn into larger rects, this patch adds logic for considering images for applying dark mode filter which have very smaller source rect. The analysis based on |src| and |dst| rects is extended for all kinds of images. With this rastered content from SVG images and gradient generated images undergo classification. Bug: 1094005 Change-Id: I6d24c770e2c703ddccfb70c00c0a5c9c51507498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352251Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#798531}
-
Naoki Fukino authored
Adding unit tests to evaluate the behavior of FileTypeFiltersController class, which was added with CL:2354115. Bug: 1114721 Test: Ran browser_tests --gtest_filter=*FileTypeFiltersController Change-Id: I9cc1cc8379fb35de909202d3043bda6d5304a024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359314Reviewed-by:
-
Xianzhu Wang authored
These were created in crrev.com/c/2146093 probably after we removed the mac10.10 bot for web tests and before we removed mac10.10 from blinkpy/web_tests scripts. TBR=szager@chromium.org Bug: 1107003 Change-Id: If64631c91dd341f580dad15e6deb72395c63c6a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359366Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798529}
-
Ana SollanoKim authored
Previously, we had made the legends fragment in the following change https://chromium-review.googlesource.com/c/chromium/src/+/2090762. In this other change https://chromium-review.googlesource.com/c/chromium/src/+/2263353 we decided to not break borders for now. Because the legend is part of the fieldset border, we now want to treat the legend as monolithic. We still have logic for breaking the fieldset border, this will be addressed in a follow up change. Bug: 1097012 Change-Id: Iace252447063eb694c47fb9eea2a406ba2fe79d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353354 Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#798528}
-
My Nguyen authored
Spec: http://go/cros-lang-settings-ux slide 23. Current view: http://screen/f9bbb539-b983-4ac7-aa9f-cb0886bd2f9f Note: All strings are not finalised so they are translateable false and no screenshots required. Bug: 1113439 Change-Id: Ic1ab01755fe86c28b89468aba54cc5dff010ced5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354113Reviewed-by:
-
tby authored
This is the first in a series of changes to how search providers are created and configured, with the aim of reducing the number of ranking and filtering steps between the providers and the UI. Eventually I'd like to repurpose the concept of a 'mixer group'. This change makes a small start by removing a feature of groups that we don't use anymore: multipliers on result scores. This CL also deletes some obsolete tests that don't take into account modern ranking. This coverage is mostly duplicated by search result ranker tests. Bug: 1028447 Change-Id: Ib6d27975ede3b9ee0a9d4b508d262ebff154670b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342533 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798526}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ic2ce391f18c132cb7347d71461b190ed928b0711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359406Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798525}
-
