GitLab

Remove some redundant number_(0) initializers.

Also, for IndexedDBKey, use number_ for both number and date type
to save memory.

R=cmumford@chromium.org

Review URL: https://codereview.chromium.org/1071683002

Cr-Commit-Position: refs/heads/master@{#324347}

Adding tests for diagonal scrolling to telemetry.

BUG=466867

Review URL: https://codereview.chromium.org/999243003

Cr-Commit-Position: refs/heads/master@{#324346}

BUG=451527
R=mfoltz@chromium.org,kalman@chromium.org

Review URL: https://codereview.chromium.org/1040773002

Cr-Commit-Position: refs/heads/master@{#324345}

This patch adds two entreis to rappor.xml for Web Components usage.
Blink CL is at:
https://codereview.chromium.org/986583002/
Chromium CL is at:
https://codereview.chromium.org/1014543003/

BUG=461671

Review URL: https://codereview.chromium.org/1071463003

Cr-Commit-Position: refs/heads/master@{#324344}

The recipes need the ability to parse the test results. Adding
support for the json-results-file option so we can tell what junit
tests failed in the infra recipes.

BUG=

Review URL: https://codereview.chromium.org/1062403004

Cr-Commit-Position: refs/heads/master@{#324343}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5b9a14f..b06aa90

TBR=cbiesinger@chromium.org,keishi@chromium.org

Review URL: https://codereview.chromium.org/1076513004

Cr-Commit-Position: refs/heads/master@{#324342}

This CL moves cross-process postMessage plumbing from RenderView
to RenderFrame:

- The renderer-to-browser RouteMessageEvent message is now sent
  through RenderFrameProxy rather than a swapped-out RenderView.

- The bulk of WebContentsImpl::RouteMessageEvent is moved into
  RenderFrameProxyHost::RouteMessageEvent.  Unfortunately, we still
  need to call up to WebContents for dealing with <webview> and
  on-demand creation of swapped-out RVs for the opener chain.  This
  will be cleaned up as part of https://crbug.com/225940.

- the browser-to-renderer PostMessageEvent message is now handled in
  RenderFrameImpl::OnPostMessageEvent, instead of RenderViewImpl.

These changes make it possible to send messages between cross-process
subframes when in --site-per-process mode.  This is exercised in a new
test, SitePerProcessBrowserTest.SubframePostMessage.  More work will
be needed to support postMessages involving subframes in cross-process
openers (see https://crbug.com/225940 and https://crbug.com/423587).

With this change, the RFHM::SupportCrossProcessPostMessage test now
works in --site-per-process mode, so it is enabled on the Site
Isolation FYI bots.

BUG=389721
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1046933005

Cr-Commit-Position: refs/heads/master@{#324341}

Adds a colored title area. When the title is set, it will be exposed
with a simple animation.

Including the title in the original html is still supported.

Fixes some issues with margins and line spacing.

Review URL: https://codereview.chromium.org/1060623002

Cr-Commit-Position: refs/heads/master@{#324340}

For details see the STL Breaking Changes (VS14 CTP1) section of:
http://blogs.msdn.com/b/vcblog/archive/2014/06/06/
c-14-stl-features-fixes-and-breaking-changes-in-
visual-studio-14-ctp1.aspx

In particular:
"The Standard has always forbidden containers of const elements...
...elements must be Assignable, which const T isn't."

Error message is:
error C2338: The C++ Standard forbids containers of const
elements because allocator<const T> is ill-formed.

R=cpu@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/1066213002

Cr-Commit-Position: refs/heads/master@{#324339}

I noticed while doing some refactoring elsewhere that observer_ was not
being initialized and so early calls to OnDevicesChanged could branch on
an uninitialized value and crash.

Review URL: https://codereview.chromium.org/1075593003

Cr-Commit-Position: refs/heads/master@{#324338}

This not working was preventing certain corruption-testing tests from
being written.

Also modified Does{Table,Index,Column}Exist() to reflect that these
names are _not_ case sensitive.  It is not possible to have distinct
tables [Foo] and [foo].

BUG=none

Review URL: https://codereview.chromium.org/1069313004

Cr-Commit-Position: refs/heads/master@{#324337}

This has the advantage of making cancellation of requests an O(1) operation rather than O(NumRequestsPerJob).

BUG=455366

Review URL: https://codereview.chromium.org/1075563002

Cr-Commit-Position: refs/heads/master@{#324336}

This allows handles created on the exe (or any other module) to be properly tracked.

BUG=472362

Review URL: https://codereview.chromium.org/1045513004

Cr-Commit-Position: refs/heads/master@{#324335}

Clients should now include webrtc/video_frame.h which is the right
header for I420VideoFrame type, i420_video_frame.h is just a pass
through header include.

This should help fix pbos' TODO in the WebRTC repo and allow us to land
https://webrtc-codereview.appspot.com/46819004/.

BUG=None
R=tommi@chromium.org

Review URL: https://codereview.chromium.org/1067823002

Cr-Commit-Position: refs/heads/master@{#324334}

BUG=None
R=ellyjones@chromium.org

Review URL: https://codereview.chromium.org/1051933002

Cr-Commit-Position: refs/heads/master@{#324333}

This CL suppresses the test failures on the Win7 Release ATI GPU bot:

WebglConformance.conformance_extensions_angle_instanced_arrays
WebglConformance.conformance_rendering_more_than_65536_indices

BUG=475095

Review URL: https://codereview.chromium.org/1075443006

Cr-Commit-Position: refs/heads/master@{#324332}

In order to commit property trees to the compositor thread, they need to
be stored on the LayerTreeHost/LayerTreeImpl.  This change adds plumbing
so that the PropertyTree computation is not entirely internal to CDP.

BUG=386793

Review URL: https://codereview.chromium.org/1062403002

Cr-Commit-Position: refs/heads/master@{#324331}

678baca8bd4a EXC_CRASH should never be wrapped in another EXC_CRASH
ab2390619387 crashpad_database_util: add --new-report
1baff4ff92fe Accept non-fatal resource exceptions without generating
             crash reports

BUG=475236,crashpad:35
TBR=rsesek@chromium.org

Review URL: https://codereview.chromium.org/1071763002

Cr-Commit-Position: refs/heads/master@{#324330}

This prevents a double-close problem that arises when libva uses the same drm
fd as gbm.

TODO(hshi): refactor VAAPI wrapper's management of drm file (crbug.com/475250).

BUG=462459
BUG=464628
TEST=verify that video acceleration works and the netflix hang is fixed
R=jorgelo@chromium.org, piman@chromium.org

Review URL: https://codereview.chromium.org/1073653003

Cr-Commit-Position: refs/heads/master@{#324329}

Define a fill-paragraph-function which only fills in comments instead of
everywhere. Previously, we would fill in other contexts, like lists.

BUG=none

Review URL: https://codereview.chromium.org/1071733002

Cr-Commit-Position: refs/heads/master@{#324328}

https://codereview.chromium.org/1033373003/ introduced lazily issuing updated GuestView attributes
between create and attach. The AllowTransparency and AllowScaling attributes were defaulting to false
if not available in the attach params and so they were getting reset on attach. This CL fixes the issue
by only updating the attributes if they are passed along on attach.

BUG=471997

Review URL: https://codereview.chromium.org/1065413002

Cr-Commit-Position: refs/heads/master@{#324327}

Revert of cc: Re-use transforms from transform nodes when computing visible rects (patchset #2 id:20001 of https://codereview.chromium.org/1060413002/)

Reason for revert:
Causes css3/filters/effect-reference-hidpi-hw.html to have an incorrect visible rect.

Original issue's description:
> cc: Re-use transforms from transform nodes when computing visible rects
>
> This makes CalculateVisibleRects try to re-use the to_target and
> from_target transforms stored in transform nodes whenever it needs to
> compute a transform. Since these baked transforms incorporate the
> target's sublayer scale, the fallback path now also includes sublayer
> scale for consistency.
>
> Testing locally on a z620, this improves property tree computation time
> by 7% on Gmail, and by 20% on rAF-driven poster circle.
>
> BUG=474725
>
> Committed: https://crrev.com/992c398b2fb0e7ab9c7ba58a8eb36787e03962e4
> Cr-Commit-Position: refs/heads/master@{#324122}

TBR=vollick@chromium.org

BUG=474725

Review URL: https://codereview.chromium.org/1077433003

Cr-Commit-Position: refs/heads/master@{#324326}

As usual, the RunUntilIdle() call causes problems. Calling stop() on the
webrtc stream apparently doesn't propagate back to the capture, so make sure
that we call stop() on the capture stream explicitly.

Also, raise frame rate to 60 fps.

Not entirely sure if this will fix the attached bug or not, but either way it's a problem that should be fixed.

BUG=474808

Review URL: https://codereview.chromium.org/1076533002

Cr-Commit-Position: refs/heads/master@{#324325}

BUG=

Review URL: https://codereview.chromium.org/1076613002

Cr-Commit-Position: refs/heads/master@{#324324}

Move smooth_gesture_util from tools/perf/ to tools/telemetry/telemetry/web_perf/

BUG=468061

Review URL: https://codereview.chromium.org/1067883002

Cr-Commit-Position: refs/heads/master@{#324323}

BUG=

Review URL: https://codereview.chromium.org/1070903002

Cr-Commit-Position: refs/heads/master@{#324322}

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4091

Review URL: https://codereview.chromium.org/1059423002

Cr-Commit-Position: refs/heads/master@{#324321}

Review URL: https://codereview.chromium.org/1070933002

Cr-Commit-Position: refs/heads/master@{#324320}

Previously, TCP keep alives were enabled on all
desktop platforms, but the delay was not being set on
OSX, resulting in not sending keep alives every 45
seconds, like on other platforms.  This CL adds the
code to do that.

It does the same on iOS, though keep alives aren't
enabled on mobile platforms, anyways.

BUG=468764

Review URL: https://codereview.chromium.org/1065563006

Cr-Commit-Position: refs/heads/master@{#324319}

Disable logging of failed SPDY PINGs in a timemax bucket, and update histogram bucketing strategy for Net.SpdyPing.RTT to match the strategy of Net.TCP_Connection_Latency.
* timemax is int64max, whereas histograms use int values, so this doesn't end up working well and can break certain analysis operations such as computing the average SPDY PING time. Additionally, counts for failed SPDY PINGs are recorded in the Net.SpdySession.ClosedOnError enum histogram, so there's no need for us to log them in a special bucket in the RTT histo as well.
* Also change the histogram bucketing strategy for Net.SpdyPing.RTT to match the strategy of Net.TCP_Connection_Latency since these are measuring similar things and it's useful to be able to compare TCP RTTs with application-layer RTTs.

BUG=475129

Review URL: https://codereview.chromium.org/1074523002

Cr-Commit-Position: refs/heads/master@{#324318}

This doesn't force use of the SSL repo, but prevents overwriting the
repo config if a user manually changes it to use HTTPS.

R=thestig@chromium.org, thestig@google.com
BUG=433450,474100

Review URL: https://codereview.chromium.org/1068323002

Cr-Commit-Position: refs/heads/master@{#324317}

TEST=For a manual test to exercise this code, see comment #2 in the bug.
BUG=469890

Review URL: https://codereview.chromium.org/1025403002

Cr-Commit-Position: refs/heads/master@{#324316}

BUG=475090

Review URL: https://codereview.chromium.org/1072443004

Cr-Commit-Position: refs/heads/master@{#324315}

BUG=353324
TEST=existing EME tests pass

Review URL: https://codereview.chromium.org/1068823003

Cr-Commit-Position: refs/heads/master@{#324314}

Wait for 'polymer-ready' event instead of hard-coded 2 seconds. Pay selector
cost once to ensure iterations are only capturing the cost of hit-testing.

Note that this CL is expected to reduce thread times on the dashboard.

BUG=472632

Review URL: https://codereview.chromium.org/1066983002

Cr-Commit-Position: refs/heads/master@{#324313}

This fixes a number of small issues I found while actually testing
things to get it ready to run on the bots. In particular, 'mb analyze'
didn't work right for GN. Tests were added.

TBR=brettw@chromium.org
BUG=466436

Review URL: https://codereview.chromium.org/1074583002

Cr-Commit-Position: refs/heads/master@{#324312}

This CLs fixes a few places in layout test code that were assuming
that the top-level frame is local, which was causing renderer crashes
when running a layout test containing a cross-site frame with
--site-per-process.  For example, most tests under
http/tests/security/postMessage/ ran into this.

BUG=474792
TEST=http/tests/security/postMessage/* tests don't crash with --site-per-process

Review URL: https://codereview.chromium.org/1073533002

Cr-Commit-Position: refs/heads/master@{#324311}

BUG=

Review URL: https://codereview.chromium.org/1068133002

Cr-Commit-Position: refs/heads/master@{#324310}

Instead of creating it under VideoContextProvider, which makes
refactoring this code harder, create it outside and pass it through
parameter.

This should help ease the transition of
https://codereview.chromium.org/920443003.

Tested on Android (with Nexus 5 device) with the following command
lines:

$ ./build/gyp_chromium -DOS=android -Goutput_dir=out_android
$ ninja -C out_android/Debug content_unittests content_unittests_apk
$ export CHROMIUM_OUT_DIR=out_android
$ build/android/test_runner.py gtest -s content_unittests --debug

AndroidWebView tests:
$ ninja -C out_android/Debug android_webview_apk android_webview_test_apk
$ build/android/adb_install_apk.py --apk=AndroidWebView.apk --debug
$ build/android/test_runner.py instrumentation --test-apk=AndroidWebViewTest
--test_data webview:android_webview/test/data/device_files --debug

BUG=338338
TEST=see above
R=boliu@chromium.org

Review URL: https://codereview.chromium.org/1064263002

Cr-Commit-Position: refs/heads/master@{#324309}

ChannelMojo has ScopedIPCSupport, but it is instantiated only in
in-process mode. This CL lets it always instantiate to make it
clear that ChannelInfo is protected by the ScopedIPCSupport.
It simplifies the relationship between the support object and
the channel, and makes the lifecycle invariant reasonable.

With this change, we no longer need to protect ChannelMojo with
ScopedIPCSupport on its client side. Now it's built-in.

Note that this is a speculative fix of fuzzer generated crash,
where Mojo channel related globals are gone before when channel
mojo is being destroyed.

BUG=473438
R=viettrungluu@chromium.org, rockot@chromium.org

Review URL: https://codereview.chromium.org/1054253005

Cr-Commit-Position: refs/heads/master@{#324308}