GitLab

BUG=360901
NOTRY=true

Review URL: https://codereview.chromium.org/255233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266931 0039d316-1c4b-4281-b951-d872f2087c98

I accidentally blew away my changes just before the last commit and
made a mistake while recreating it.

BUG=365904,368107
TBR=bajones@chromium.org

Review URL: https://codereview.chromium.org/259363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266930 0039d316-1c4b-4281-b951-d872f2087c98

Restrict tgkill(2) and kill(2) to the current process, forbid tkill.

BUG=367986
R=jorgelo@chromium.org

Review URL: https://codereview.chromium.org/258073008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266926 0039d316-1c4b-4281-b951-d872f2087c98

Update skia handle leak suppression to handle the most recent, and be immune to further, function name changes in SkCanvas::onDrawPosText.

TBR=thakis@chromium.org
BUG=346842

Review URL: https://codereview.chromium.org/263433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266924 0039d316-1c4b-4281-b951-d872f2087c98

browser_tests containts some tests for remoting, so it depends on
remoting_webapp, but didn't have the dependency defined in gyp.
Also added exclusion for remoting browser tests when remoting=0.

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/256193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266921 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364894
For trivial header file renaming in c/b and c/test:

R=mmenke@chromium.org, ygorshenin@chromium.org
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/242483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266920 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266918 0039d316-1c4b-4281-b951-d872f2087c98

BUG=108012
R=cmumford@chromium.org, jsbell@chromium.org

Review URL: https://codereview.chromium.org/240003011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266916 0039d316-1c4b-4281-b951-d872f2087c98

BUG=353857

Review URL: https://codereview.chromium.org/254523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266915 0039d316-1c4b-4281-b951-d872f2087c98

BUG=154632

Review URL: https://codereview.chromium.org/231063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266914 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266913 0039d316-1c4b-4281-b951-d872f2087c98

r1322: Add Arm64 support to dumpsyms.

R=thestig@chromium.org

Review URL: https://codereview.chromium.org/253133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266912 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266911 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367235

Review URL: https://codereview.chromium.org/259763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266910 0039d316-1c4b-4281-b951-d872f2087c98

These should be stable under TSAN now that this patch is landed:
https://codereview.chromium.org/240403003.

BUG=358390
R=jyasskin@chromium.org

Review URL: https://codereview.chromium.org/246203006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266909 0039d316-1c4b-4281-b951-d872f2087c98

Refactor RST_STREAM status code handling. Also handle SPDY4/HTTP2 status codes. 
Fix an off-by-one DCHECK for frame lengths equal to the frame limit.

This lands server change 63285101 by raullenchai and 63409085 by hkhalil. 
https://codereview.chromium.org/243643002/


Refactor GOAWAY status code handling, also handle SPDY4/HTTP2 status codes.

This lands server change 63424889 by hkhalil.
https://codereview.chromium.org/243613003/


SPDY tests: Additional headers validation in framer tests. 

Server change also included logic to lower-case headers and error on responses with incorrect casing. This wasn't merged, as Chromium instead has handling and tests on this in SpdyStream. 

This lands server change 63898388 by mlavan.
https://codereview.chromium.org/244833003/


SPDY: Replace SerializeDataFrameHeader.

Replaced with SerializeDataFrameHeaderWithPaddingLengthField, which serializes
DATA frame header and, when necessary, padding length fields. Tests are added.

This lands server change 64328823 by raullenchai.
https://codereview.chromium.org/244853004/


Modify SerializeHeaders, SerializePushPromise and SpdyFrameBuilder so that 
HEADERS and PUSH_PROMISE frame payloads can be serialized into CONTINUATION 
frames as needed. 

This lands server change 64331353 by mlavan.
https://codereview.chromium.org/246013002/


SPDY: RST_STREAM and GO_AWAY status checking.

Call OnError() from ProcessRstStreamFramePayload() and
ProcessGoAwayFramePayload() when handling an invalid status code.

This lands server change 64372977 by mlavan.
https://codereview.chromium.org/247503002/


SPDY: Fix flaky padding edge case.

The root cause of the flakiness is: during the processing of data frame, the
visitor should be informed if the FIN flag is set and there is no more data in
this frame. One corner case that has not been covered is when
remaining_data_length_ = remaining_padding_payload_length_ = 0, which does
happen when the data payload is empty (e.g., GET request) and the padding len
is exactly 1.

This lands server change 64513441 by raullenchai.
https://codereview.chromium.org/246933003/


SPDY: Use SpdyMajorVersion rather than ints for SPDY version number. 

Version comparisons are canonicalized on using the lowest applicable version 
number. Also add new SPDY5 enum (just the literal; no implementation). 
Fix a bug in cl/64786464 that could cause SPDY version to be 
mis-parsed in the framer. 

This lands server change 64786464 by mlavan and 64899106 by mlavan.
https://codereview.chromium.org/247243003/


Remove net:: when referencing types from code locations already within the net:: namespace. 
Remove obsolete TODO. 

This lands server change 64909661 by hkhalil and 64909678 by hkhalil.
https://codereview.chromium.org/246123005/


SPDY: Catch another edge case in version validation.

Specifically, where the version number is invalid, but happens to match the
enum number of a valid version. Also consolidate version checks in the framer
so that related logic is easier to reason about.

This lands server change 64912010 by mlavan.
https://codereview.chromium.org/247583002/


HPACK: Refactor and expand HpackHeaderTable indexing.

HpackHeaderTable now maintains indices for querying static and dynamic
entries by name and name & value. Indicies are ordered on entry name,
value, then table index. A full-table index is maintained, as well as a
reference-set index.

HpackEntry no longer tracks reference-set status (that's HpackHeaderTable's
job), and the "touch" mechanism has been replaced with a similar "state".
HpackHeaderTable & HpackEntry also now cooperate to provide HpackEntry with
sufficient bookmarking to compute it's own index.

HpackEncodingContext has been eliminated. HpackHeaderTable manages its
former responsibilities (primarly managing the static table).

Together, these changes allow an encoder to:
* Build the encoding delta via a linear walk through (just) the reference set
(assuming headers are already sorted, ala std::map).
* Map representations to entries in O(log(N)) time, preferring the
lowest-index entry.
* Determine a mapped entry's index in O(1) time.
* Add and evict representations to the dynamic table in O(log(N)) time.
* Efficiently enumerate all headers having a specific name. Not required now,
but may be in the future.

This lands server change 65185410 by jgraettinger.
https://codereview.chromium.org/246383003/


HPACK: Refactor and simplify HpackOutputStream

HpackOutputStream is no longer responsible for emitting entire opcodes. That
will be the encoder's job. Instead, it simply provides primitives for emitting
prefixes, varints, and byte arrays. The longer-term intent is that
HpackOutputStream will be merged into SpdyFrameBuilder and eliminated
altogether.

HpackOutputStream also no longer asserts a maximum literal length. Rationale
is that we already have a theoretical too-long header at this point: we might
as well emit it and allow the remote decoder to possibly accept it. At worst
we break the connection, which was going to happen anyway.

This lands server change 65186763 by jgraettinger.
https://codereview.chromium.org/247793002/


HPACK: Add HpackHuffmanTable::EncodedSize() 

EncodedSize() will be used by the HPACK encoder to select identity vs Huffman 
coding, without having to run the full Huffman coder. Also update tests to 
compare against EncodedSize() by default. 
HPACK unittest: Fixing memory error in Huffman test fixture. 

This lands server change 65187740 by jgraettinger and 65328503 by jgraettinger.
https://codereview.chromium.org/247893002/


HPACK: Implement delta encoding.

HpackEncoder determines each header set's delta with the reference set, and
makes use of the full HPACK encoding grammar to emit a minimal compression
for the set.

A "encode without compression" method has also been added which bypasses the
dynamic table & Huffman coding. Selection of encoding method is controlled by
SpdyFramer::enable_compression_.

Encoding context updates are not yet used. That's a future optimization.

HpackRoundTripTest has been added to verify that HpackEncoder & HpackDecoder
successfully round-trip sequences of canned and dynamically generated header
sets.

This lands server change 65188922 by jgraettinger.
https://codereview.chromium.org/247283003/


BUG=345769,339578

Review URL: https://codereview.chromium.org/246073007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266904 0039d316-1c4b-4281-b951-d872f2087c98

> [webcrypto] Make operations run on a background thread so they don't block the blink thread.
> 
> More details on threading strategy provided in webcrypto_impl.cc.
> 
> BUG=245025
> 
> Review URL: https://codereview.chromium.org/233733004

TBR=eroman@chromium.org

Review URL: https://codereview.chromium.org/252213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266903 0039d316-1c4b-4281-b951-d872f2087c98

R= nfullagar@chromium.org
BUG= https://code.google.com/p/nativeclient/issues/detail?id=2205
TEST= none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/255813009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266902 0039d316-1c4b-4281-b951-d872f2087c98

Unlike the other toolchains, bionic supports both static and dynamic.  This CL adds an environment variable which will allow SDK targets to be built with dynamic linking.  It also enables additional bionic targets such as nacl_io demo and test.

Since the current dynamic loader only supports searching DT_NEEDED namespaces for symbols, bionic forces us to declare dependencies explicitly which causes build order issues.

BUG=none
R=binji@chromium.org

Review URL: https://codereview.chromium.org/240493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266900 0039d316-1c4b-4281-b951-d872f2087c98

PrintPreviewTest.TaskManagerNewPrintPreview was something else's fault.

> Revert 266653 "[Mac] Allow fullscreen transitions while constrai..."
> 
> Mac Tests (dbg) failing for PrintPreviewTest.TaskManagerNewPrintPreview
> http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%281%29/builds/23012
> 
> 
> > [Mac] Allow fullscreen transitions while constrained windows are open.
> > 
> > r166410 disabled the browser from entering fullscreen mode when any one
> > tab has a constrained window open (e.g., Print dialog).  However, this
> > is inconsistent with the behavior on all other desktop platforms.  This
> > change removes the restriction.
> > 
> > Landing on behalf of miu@chromium.org manually, as to make a branch cut.
> > 
> > BUG=366567,146451
> > TEST=Repro steps in bug 366567 (easier to understand from the multiple demo videos).  Also, manual testing of browser transition into and out of fullscreen before/after a print dialog is open.
> > R=avi@chromium.org, sky@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/253493005
> 
> TBR=avi@chromium.org
> 
> Review URL: https://codereview.chromium.org/252693007

TBR=ajwong@chromium.org

Review URL: https://codereview.chromium.org/252233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266899 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=maniscalco@chromium.org, pavely@chromium.org

Review URL: https://codereview.chromium.org/254713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266898 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368280
TBR=awong@chromium.org,robliao@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/254013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266897 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/260233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266896 0039d316-1c4b-4281-b951-d872f2087c98

> cc: Split animating and drawing into separate actions
> 
> Split impl-side animating and drawing into separate actions. This is
> needed to allow for the possibility of a commit between animating and
> drawing so that the main thread gets a chance to consume the new
> animation state. In particular this allows the main thread to
> synchronize with a fling animation using an onscroll handler.
> 
> BUG=347366
> 
> Review URL: https://codereview.chromium.org/206793003

Reason for revert: Broke some downstream unit tests.

TBR=skyostil@chromium.org
BUG=368064

Review URL: https://codereview.chromium.org/254883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266895 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364468
R=bshe@chromium.org

Review URL: https://codereview.chromium.org/252743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266894 0039d316-1c4b-4281-b951-d872f2087c98

Also doing some light refactoring to make the code cleaner.

BUG=360512
NOTRY=True

Review URL: https://codereview.chromium.org/260333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266893 0039d316-1c4b-4281-b951-d872f2087c98

First two test cases:
  password change detected when SU is signed in, only su is signed in after
  password change is detected when manager is signed in.

R=nkostylev@chromium.org

BUG=354607

Review URL: https://codereview.chromium.org/243103007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266892 0039d316-1c4b-4281-b951-d872f2087c98

Store default search provider data in dictionary pref, and add DefaultSearchManager class to handle the reading and writing of this pref (DefaultSearchManager will eventually all default search related concerns).

This pref will be used to persist data about user-selected
default search providers. In future CLs, support will be added for default search providers set by policy and sync.

BUG=365762

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266479

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266615

R=gab@chromium.org, pkasting@chromium.org

Review URL: https://codereview.chromium.org/229763005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266891 0039d316-1c4b-4281-b951-d872f2087c98

Typedef not currently needed.

R=ben@chromium.org
TBR=ben@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/253673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266890 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

BUG=239179

Review URL: https://codereview.chromium.org/259623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266889 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266887 0039d316-1c4b-4281-b951-d872f2087c98

Easier this way for clients to track and not worry about overflow.

BUG=none
TEST=none
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266793

Review URL: https://codereview.chromium.org/253883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266886 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff rossberg@chromium.org in case of problems.

TBR=rossberg@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/255183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266885 0039d316-1c4b-4281-b951-d872f2087c98

Uses gtest parameterization for two of the WebRTC
browser tests so they can be re-run with different
constraints (and reference files).

To run 360p only:
out/Release/browser_tests --gtest_filter=WebRtcVideoQualityBrowserTest*0 --run-manual --ui-test-action-max-timeout=300000
and 720p only:
out/Release/browser_tests --gtest_filter=WebRtcVideoQualityBrowserTest*1 --run-manual --ui-test-action-max-timeout=600000

This CL should get a follow-up after 
https://codereview.chromium.org/254803002/ is landed 
(then webrtc_video_quality_test_hd.html can be removed).

We also really should look into making the test more hermetic
so ffmpeg and zxing is bundled and auto-downloaded on all the
target platforms (using Google storage).

BUG=286290
TEST=locally running the test on Linux, Mac and Windows.

Review URL: https://codereview.chromium.org/247723006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266884 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266883 0039d316-1c4b-4281-b951-d872f2087c98

> Roll gyp r1895:1907
> 
> r1907 Test handling of empty RULE_INPUT_DIRNAME and fix this on android.
> r1906 gyp performance: Another fixed O(n^2) in dependency calcs.
> r1905 gyp: isinstance -> type for another 1-5% save.
> r1904 gyp: avoid copying items that will be deleted.
> r1903 Show ASM output file instead of input file, just like CC and CXX.
> r1902 win: disable two flaky tests on gyp-win32
> r1901 Remove the default setting for clcompile_cmd in msvs-ninja
> r1900 gyp: cache conditional ASTs for 3 CPU seconds (5%) gain.
> r1899 gyp: use a set() in DeepDependencies for less O(n^2).
> r1898 gyp: fix O(n^2) in dependency calculations.
> r1897 gyp: 1% faster by optimizing IsPathSections
> r1896 gyp: use all processors instead of hard-coded 8.
> 
> TBR=thakis@chromium.org
> BUG=
> 
> Review URL: https://codereview.chromium.org/253493009

TBR=torne@chromium.org

Review URL: https://codereview.chromium.org/259223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266882 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266881 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff rossberg@chromium.org in case of problems.

TBR=rossberg@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/253873011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266879 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366103
R=sky@chromium.org, yoz@chromium.org

Review URL: https://codereview.chromium.org/246653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266878 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266877 0039d316-1c4b-4281-b951-d872f2087c98