- 12 Nov, 2020 40 commits
-
-
John Palmer authored
Call setAssistiveWindowProperties only when needed. This stops breaking ChromeVox This reverts commit a7f6e1a1. Reason for revert: Adding a fix so that ChromeVox editing notifications still work Original change's description: > Revert "Make assistive window show with autocorrect manager" > > Fixed: 1146877 > TBR=jopalmer@chromium.org > > Reason for revert: > Breaks ChromeVox; found via bisect; see bug. > > This reverts commit 6cbffa8a. > > Dependent changes (also reverted): > 73bcb673 > 84c821b5 > b197149c > > Change-Id: I65bc46c273cd64555676073cf6cd172128cfe068 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529695 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825948} Change-Id: I3d4b08c6197f287dbf55fca2d377ce577c81a617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530953Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#826690}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/36fdadd1a606..e48f06fb0cca 2020-11-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia237f648e215de00a287198053ce677f8ef1b16d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533997Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826689}
-
Yuki Shiino authored
This reverts commit 30a60064. Reason for revert: Suspicious about causing test failures. https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/4433 Original change's description: > [ozone/x11] Enabled user input monitor unit tests. > > This CL adds Ozone platform initialisation to the user input monitor tests > so they can now work with Ozone enabled. > > Bug: 1109112 > Change-Id: I31f9dabf2da9eed85cd05fe27017899b0247f4bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521144 > Commit-Queue: Alexander Dunaev <adunaev@igalia.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826638} TBR=sky@chromium.org,adunaev@igalia.com Change-Id: Ic8cd3da17dd5d2de01981aa9a8f33b6a55621c43 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1109112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531810Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#826688}
-
Yuki Shiino authored
This reverts commit ca288e0c. Reason for revert: Suspicious about build breakage. https://ci.chromium.org/p/chromium/builders/ci/mac-arm64-rel/3020 Original change's description: > Offer to install Rosetta for Widevine if it's not already installed > > If a page wants a CDM and it's unavailable, show an infobar. If > the user agrees, install Rosetta for them. > > Bug: 1145792, 1142017 > Change-Id: I92f030c2dbb5d9b092b84252fddee6f7ad55a436 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527771 > Commit-Queue: Avi Drissman <avi@chromium.org> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826636} TBR=avi@chromium.org,pkasting@chromium.org,thakis@chromium.org,xhwang@chromium.org,ericde@google.com,rsesek@chromium.org,mark@chromium.org Change-Id: I7c7f88b0690f801cdfb990562f7938d73676bf23 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1145792 Bug: 1142017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534272Reviewed-by:
-
Yuki Shiino authored
This reverts commit 49dbb543. Reason for revert: Suspicious about making RepeatableQueriesServiceTest.SignedOut_Deletion flaky. https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29?limit=200 Original change's description: > [NTP][RQ] Makes deletion of queries from in-memory URL DB asynchronous > > Deletion from the in-memory URL DB can be slow: http://shortn/_eSkRG8RvpV > This CL makes the deletion of queries from the in-memory URL DB async > by posting the deletion task to a sequenced task runner on the UI thread. > > Fixed: 1110077 > Change-Id: Ia8099093eea6efde952bfbb58cd182b06174f8e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531654 > Reviewed-by: Ramya Nagarajan <ramyan@chromium.org> > Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826399} TBR=mahmadi@chromium.org,ramyan@chromium.org Change-Id: I6377c865ef669849aa9f4fa484e80f3544531280 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532543Reviewed-by:
-
Xing Liu authored
Android R starts to restrict other apps to access app's private directory on R. Based on suggestion from Android engineer, we can use a few new APIs added in Q and R to move the storage path a non private directory. Old path: /storage/$volume_id/$app_private_directory/Download New path: /storage/&volume_id/Download Bug: 1116905 Change-Id: Iecb34a08648678dbd1ff986c7ee60f3a4647c725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515262Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#826685}
-
Morten Stenshorne authored
AppendSingleFragmentIgnoringPagination() is called when fragmentation gets disabled because of transforms. This needs to be fixed; see crbug.com/1058792 - in the meantime, let's at least traverse the fragment tree, to avoid DCHECK failures. Note that things aren't going to look or behave right if such nodes break into multiple fragments - neither with nor without this fix. Bug: 1146975 Change-Id: I7ded8d094185e69e39ce115b256661dee48f7e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529099Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#826684}
-
Rakina Zata Amni authored
Currently we only track visibilitychange on document, but the event might bubble up to window. It's possible for web developers to add the event listener on window instead, and we should still disable sudden terminations if that's the case. Bug: 1135582 Change-Id: Iae7f783b9e1713b3409b6f385148388932f0087d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526883Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#826683}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/28f538d7ea5a..74f0f62cef42 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukishiino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yukishiino@google.com Change-Id: I13b7009cf0a7396233caed00a471400da63e509f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533895Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826682}
-
Glen Robertson authored
Trying to match the restrictions in the Payment Request API spec [1] (DG isn't spec'd yet). We require that the "payment" feature policy is enabled. Secure context is already ensured by the IDL. Also add some logging of errors so developers can figure out what is going wrong. [1]: https://w3c.github.io/payment-request/#dfn-payment-relevant-browsing-context Bug: 1061503 Change-Id: I2c13663148ad8736a4d9ab3ea124d96038d8e878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526872Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#826681}
-
Yao Xiao authored
Why: we don't want floc to change more often than the intended scheduled update cadence. What: - For each history-delete notification, if it's all-history or the time-range overlaps with the time range of the history used to compute the floc, we invalidate the floc. Otherwise, we keep using the current floc. - Remove the mechanism caching the swaa_nac_account_enabled status. It's no longer needed as we don't need to query more often than the scheduled update rate (% rare race condition). How: Store history_begin_time_/history_end_time_ fields to FlocId. Compare these fields with the history delete info. Bug: 1143597 Change-Id: I685fd1a10cbc8044e799d7a644dfa2b7bb82ddd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507454 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826680}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d3f0d0cc3810..53d3c085a784 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I83d83edb52833daf49e9c25be8df478e191a5a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533728Reviewed-by:
-
Benjamin Gordon authored
The ippusb backend is the same as the airscan backend, but used over USB instead of the network. Add enum values corresponding to the same manufacturer list that we track for the airscan backend. crrev.com/c/2533675 adds the same values on the Chrome OS side. Bug: b:153544296 Bug: b:160472550 Change-Id: I0bc253f58a16231c5b995b3f8aac0c89273941bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533795Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Benjamin Gordon <bmgordon@chromium.org> Cr-Commit-Position: refs/heads/master@{#826678}
-
dpapad authored
Moving most IDR_WEBUI_CSS_* resources from webui_resources.grd to the auto-generated webui_generated_resources.grd. Resources that rely on flattenhtml=true are not affected, since |flattenhtml| is purposefully not supported by generate_grd(). Bug: 1132403 Change-Id: Iee43d27b9d34a0f9062dab5e6a56c1c428b5cca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521930 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#826677}
-
Shannon Chen authored
Add a rightMouseKey in SyntheticMouseEvent in accessibility API to allow the option of sending the event on the selected mouse key (left, right, middle, forward, back). Signed-off-by:
Shannon Chen <shannc@chromium.org> Bug: None Change-Id: Ib5cd2b1ac30dc7a5efe41b09e0bc17650916ad7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531094 Commit-Queue: Shannon Chen <shannc@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Sunny Sachanandani authored
Add separate feature flags for video and main dcomp swap chains. Bug: 1117318 Change-Id: Ic02400c56dc831dadf1cf43c4b948cea806dd5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533836 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#826675}
-
Bartek Nowierski authored
Until now the 1st page was uncommitted only on 32-bit architectures, which looks like a mistake. It isn't used on 64-bit either and it should be uncommitted there too, in order not to waste space. Change-Id: I107dd8c064f92546bfaad01ea00747b721751172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533214Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#826674}
-
Mason Freed authored
This CL updates the eyedropper button from the color picker to have the correct aria name and role. Bug: 1141168 Change-Id: I6f10794027d26c38785ee47b51fb8b6f3ebe69d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528303 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#826673}
-
François Degros authored
Bug: 1056077 Change-Id: If20f3e795f64a402f4209fff53e7c65e2dc1aa38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532486Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#826672}
-
Xing Liu authored
Only the browser process needs to initialize Chime SDK through ChimeDelegate. Renderer process will crash and hang since we try to access the shared preference in a sandbox process. TBR=dtrainor@chromium.org Bug: 1146954 Change-Id: I21f84b4b507423d1672d6778f782666c2a384950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527530Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#826671}
-
rajendrant authored
This CL adds the robots rules that will be retrieved from Litepages, and some support classes to parse and apply the rules. Bug: 1144836 Change-Id: I4ae00f0b08ccbb0ddfe98007c18f041f64d8022b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518970 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#826670}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605095997-f02476ae2299d621bcc109d9e9e9e82082bcc8d2.profdata to chrome-win64-master-1605128385-e428bee778404d65a307409bc6db7ad616d50a2d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I104f5f2ff83014b0a66628d8060f9a0ed84a0d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533685Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ea635f12e83e..36fdadd1a606 2020-11-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6e2f4394f3d4a2d69b17b11da66eadb27f6bf95c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533962Reviewed-by:
-
Clark DuVall authored
This reverts commit 10e2cc6c. Reason for revert: Possibly causing crash in crbug.com/1148015. Original change's description: > Cache return values from BundleUtils.createIsolatedSplitContext() > > This avoids getting a newly created ContextImpl from every call to > Context.createContextForSplit(). > > Bug: 1126301 > Change-Id: I080841b697e2f28000d2a4d11ff197a015a1dca8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527852 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825990} TBR=agrieve@chromium.org,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1126301, 1148015 Change-Id: I15b2f1283c8de5d6e8eee9fe17917f3399bc9e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533844Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#826667}
-
rbpotter authored
Bug: 1132403 Change-Id: Ic0f6da7e726d727a323baa194221107646bd9a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530898 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#826666}
-
Toni Barzic authored
The waiter was not checking whether the home launcher visibility matches the expected state before starting the wait, and was relying on HomeLauncherAnimationComplete getting called (which only works for transitions initiated by user actions - e.g. drag gesture or pressing the home button). This changes the API implementation to work for wider set of cases - for example to wait for launcher transition to end after transition to tablet mode. The implementation now: 1. Verifies that app list state is as expected before checking home launcher visibility(e.g. during tablet mode transition the app list may animate from closed to fullscreen state) 2. Home launcher state waiter now returns early if the launcher already has the target visibility. 3. Waits for the visibility state to change - the waiter remains the same in the test API, but the state change callback now runs whenever the home launcher visibility changes to a final value. BUG=1147906, 1143980 Change-Id: I3728f12d81241ad84e0db95ea50779bd2598e1f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530594 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by: -
kouhei authored
This CL introduces a lifecycle statemachine to AgentSchedulingGroupHost. The `AgentSchedulingGroupHost::state_` makes it explicit which lifestage the AgentSchedulingGroupHost is currently at, and checks if each method is called on one of the assumed states. This is a preparatory work to introducing AgentSchedulingGroupHost shutdown, which will add more states to the state machine. Bug: 1141459 Change-Id: Ic8c4f4f85322b52612510b3354d5ae6828311263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492281 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#826664}
-
Austin Tankiang authored
There is an Available Offline toggle already on the toolbar, so this menu item is superfluous. Bug: 1145058 Change-Id: Ifa48b9e6c40d49be181f48b30c308cc0fbf1d329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526873 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#826663}
-
Yutaka Hirano authored
No one implements the method in a meaningful way. Bug: None Change-Id: I5eb3ca12ef4dd904e680a108bd1c1156414a6dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528783Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#826662}
-
Julie Jeongeun Kim authored
This CL converts ExtensionMsg_SetActivityLoggingEnabled to a mojom::Renderer message. Bug: 1146101 Change-Id: Idf6520590b576c3c8ffe95477193dc1f6d9ee8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525887Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#826661}
-
Xing Liu authored
Implements more ReadingListModelObserver methods. When sync happens, we need to sync the in-memory bookmark tree. OCL:https://chromium-review.googlesource.com/c/chromium/src/+/2518774 Revert:https://chromium-review.googlesource.com/c/chromium/src/+/2532461 Difference: 1. Add comment for Add() about invalidated pointer when adding existing URL. 2. Fix test, don't use invalidated pointer. TBR=dtrainor@chromium.org Bug: 1133504,1147311 Change-Id: I9e2b85ceb0c6ba49e625dc2e9fd3789b56d55dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532911Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#826660}
-
Joey Arhar authored
I2P: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/9396JedBBOM This feature adds a new AbortSignal option, named "signal", to the options parameter of addEventListener. This new option can be used to remove the event listener with an AbortController by calling abort(). More context: https://github.com/whatwg/dom/issues/911 Bug: 1146467 Change-Id: I8ab1b93ec8be859c6876296fda4a9b808253c7d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527343 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
-
Yuki Shiino authored
This reverts commit 17bbb4dd. Reason for revert: Suspicious about compilation breakage: https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-dbg/14892 Original change's description: > [fuchsia] Implement NavigationPolicyThrottle for navigation blocking > > * Add an implementation of NavigationPolicyThrottle to WebEngine > * Add NavigationPolicyHandler, which keeps track of throttles and checks > if navigations need to be passed on to the client > * Add a FakeNavigationPolicyProvider for tests > > Test: NavigationPolicyThrottleTest > Bug: 1117601 > Change-Id: I0bdf94345b10d829bea4aeb85f74204970a97239 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519039 > Commit-Queue: Sharon Yang <yangsharon@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826625} TBR=sergeyu@chromium.org,yangsharon@chromium.org Change-Id: I5ad8cdcd55e3718a25e3fe0cb332d6d7b90b4532 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1117601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532022Reviewed-by:
-
Yuki Shiino authored
This reverts commit f5684467. Reason for revert: Suspicious about test failures on bots: ExistingUserControllerActiveDirectoryTest https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21268 https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/21256 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38839 Original change's description: > UserSessionManager trigger tpm initialization whenever TPM is enabled. > > we are obsoleting `TpmIsBeingOwned()`, which is not really necessary > anyway; even if `TpmIsBeingOwned()` returns `true`, triggering the TPM > initilaization again is just no-ops at ChromeOS side. > > BUG=b:172775884 > TEST=TBD if untitests needed. > > Change-Id: If4240a0c8a9a7485d77856e1e5c346c89407c09a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532155 > Commit-Queue: Leo Lai <cylai@google.com> > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826306} TBR=achuith@chromium.org,alemate@chromium.org,cylai@google.com Change-Id: I1727f2b194a60cb5f684cd9205902ec4ebb33ee4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:172775884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531804Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/09ecef60e829..79f7371f4fc8 2020-11-11 tsepez@chromium.org Consolidate logic in CFXJSE_FormCalcContext, part 2 2020-11-11 tsepez@chromium.org Consolidate logic in CFXJSE_FormCalcContext, part 1. 2020-11-11 tsepez@chromium.org Handle OOM in CPDF_ContentParser::PrepareContent(). 2020-11-11 nigi@chromium.org Enable 4 embeddertests in FPDFEditEmbedderTest suite for Skia/SkiaPaths. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I9109997b8041e0ef9d5b7751588c3dc1290bdf08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533955Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/3120d5ea0de8..b70a5b02e971 2020-11-11 enga@chromium.org Reject all callbacks with DeviceLost on wire client disconnect If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: I147433c60945e321f35355813e13367118fcc77e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533956Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b3e24ac9..034eac1e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8c92df080858640c5570a355f87ca4efa5a690cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533842Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826654}
-
Zhaoyang Li authored
Use the post method from requests.Session so connection can be reused, saving reporting time and potentially fix a connection error. Added a finalize method to StdJson class, to close the connection after reporting all results. Bug: 1136998 Change-Id: I7e5c5e40b700655f4ac32ca8f84813c9b35cce5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521514Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#826653}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c877d81ec34e..28f538d7ea5a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukishiino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1129937,chromium:1145760,chromium:1145865,chromium:1147179 Tbr: yukishiino@google.com Change-Id: Ie63a6a4076fb7875e2418fd45e90b41a7e90c3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533689Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d3f0d0cc3810..53d3c085a784 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If8de7165930c8d4c75937417e779ae66c34a16a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533993Reviewed-by:
-
