GitLab

This is a reland of 310bb105

Original change's description:
> Progress on the Revamped context menu
> 
> This CL consists of:
> - Improvements for URL formatting (i18n and emphasizing)
> - Addition of grey background while loading
> - Addition of favicons, monograms, and thumbnails
> - Addition of checkered pattern behind the transparent PNGs
> - Some visual polish and fixes
> 
> Bug: 655359
> Change-Id: I6ebf13b6097780db22c05804f2b9cdf6d1ee8461
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595114
> Reviewed-by: Theresa <twellington@chromium.org>
> Commit-Queue: Sinan Sahin <sinansahin@google.com>
> Cr-Commit-Position: refs/heads/master@{#659233}

Bug: 655359
Change-Id: Ie3d559eb0c353aef2eecf56cf36bcc29d41ec4ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610854Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#659763}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/01010b5cd43c..013ffd95d645


Created with:
  gclient setdep -r src-internal@013ffd95d645

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

BUG=chromium:962653
TBR=fergal@google.com,avi@google.com,btolsch@google.com,andypaicu@google.com

Change-Id: I302e8d0b79f4525cced970a8145c1179965c19fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612360Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659762}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/ea6122f18e6a..5ea0721b4537


git log ea6122f18e6a..5ea0721b4537 --date=short --no-merges --format='%ad %ae %s'
2019-05-14 chrome-bot@chromium.org Update config settings by config-updater.
2019-05-14 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@5ea0721b4537

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Change-Id: I2bdb17efda585dc6ecd4d31a44c1292374c9d859
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612383Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659761}

With Grid Tab Switcher, the only users of thumbnail cache are
StaticLayout and ToolbarSwipeLayout. To avoid visible degradation,
StaticLayout needs the cache size to be at least 1, and
ToolbarSwipeLayout needs 2.

Bug: 959054
Change-Id: I8f9bfd376e7b52bb61165b33b201cec09397a44e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594427
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659760}

isTabGroupsAndroidEnabled() implies isGridTabSwitcherEnabled(), and all
callers of isGridTabSwitcherEnabled() should also check
isTabGroupsAndroidEnabled().

There's no visual difference because all the affected code paths are
in the bottom toolbar, which is force disabled when
isTabGroupsAndroidEnabled() is on.

Bug: None
Change-Id: I35542d90c7c5e8c1d3c9c9effd7567e16e3f088e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594734Reviewed-by: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659759}

As the first step to deprecate WTF::CString, the bug has suggested replacing
EXPECT_STREQ with EXPECT_EQ. This CL replaces EXPECTED_STREQ with EXPECT_EQ
in the cases of both converting WTF::String to const char* to use EXPECTE_STREQ
and the expected string is ASCII.

Bug: 950077
Change-Id: I093991a0f863c45913e5456c45a019afec3aca0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609721Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#659758}

Instead of having separate stores and getters for page and browser
actions on ExtensionActionManager, have a single store for all actions.
Similarly, remove the type-specific GetPageAction() and
GetBrowserAction() methods from ExtensionActionManager, and only use
GetExtensionAction().

Call sites that rely on a certain type of action (which is relatively
rare) now check the action type through ExtensionAction::action_type().

Also clean up extension_action_manager_unittest.cc to use parameterized
tests and more targeted cases.

This CL does not yet hook up generic actions (specified through the
"action" key in the manifest) to ExtensionActionManager; that will
happen next.

Bug: 893373

Change-Id: Ib82f2f71b27f1118f2c02b9376cc5849aafab50a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585959
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659757}

When switching to a Tab, before the live layer is available, a
grayscale thumbnail would be shown instead. However, after the
live layer is available, we still add the ThumbnailLayer with
alpha = 0, which is transparent and invisible.

That ThumbnailLayer is skipped in this CL.

Bug: 959054
Change-Id: I15c9b6d9cb97f3183a30fe83991eb9c5fe3d1d78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595295Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659756}

https://chromium-review.googlesource.com/c/chromium/src/+/1589012
added the new android compilers which also upload resource_sizes
data to bot_platforms. However, in generate_perf_sharding and elsewhere
we assume that every bot_platform has a shard map. Also, the other platforms
in this list are similar in that they run Telemetry benchmarks, whereas
resource_sizes is running some math on the compiler builder to find the
size of the APK and other related data.

Bug: 961830
Change-Id: Ib3c1460923863f21c28e5bfb08ae170ef59565c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612359
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659755}

Using wpt-import in Chromium 400f6e82.
With Chromium commits locally applied on WPT:
c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed"
fec827fb "Added wpt tests for overscroll customization."
c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet"
d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions"
223d6ec0 "Reland "[EventTiming] Fix programmatic click test""


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: I66f5a68c5b0cdcf4fc1738e29aa02ce8b211e6dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612399Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659754}

https://pdfium.googlesource.com/pdfium.git/+log/726ece1b5340..0db20e0a220b


git log 726ece1b5340..0db20e0a220b --date=short --no-merges --format='%ad %ae %s'
2019-05-14 thomasanderson@chromium.org Fix ODR violations in public fuzzers
2019-05-14 thomasanderson@chromium.org Split public fuzzer static initializer into its own file
2019-05-14 thomasanderson@chromium.org Add missing dependencies to fuzzers
2019-05-14 thomasanderson@chromium.org Move pdfium sources into fpdfsdk


Created with:
  gclient setdep -r src/third_party/pdfium@0db20e0a220b

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:960288,chromium:960288,chromium:960288,chromium:960288
TBR=pdfium-deps-rolls@chromium.org

Change-Id: I3d67a73b565d90cb0e2266d5a0c052b3d8c30591
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612211Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659753}

This detects framework version change and invalidate icons for installed
packages.
This also fixes flakiness in unit test when installing app icons and
deleting invalidated icons could happen from different concurrent threads.

TEST=Locally, unit test
BUG=959028

Change-Id: Ifb2b9a857a07275df401fc9df988cf931219ba4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610845Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659752}

BUG=503643

Change-Id: I41becf134e3aecd20ce51e50571fff880703b348
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611912
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659751}

NetowrkState usage has been mostly removed from non test consumers of
network_icon.cc.

This removes the single remaining usage in GetSignalStrengthForNetwork,
updates the tests and removes the NetworkState dependency entirely.

This also includes a bit of cleanup to cros_network_config.cc to
separate NetworkStateHandler dependencies from NetworkState/DeviceState
dependencies in the file local helper functions. (These were
temporarily used in the tests but that was reverted, but the cleanup
still seems useful).

Bug: 862420
Change-Id: I566505e5a4f22538d8a862eeb5fcfc9f3c3ffd79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600306
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659750}

The rtree build_tree code is calculating two parameters num_strips
and num_tiles that it used to iterate through the list but both are
unnecessary.  The iterated parameters were not used, and the ceil
used on the sqrt insured that we go through every single branch.

This patch removes the extra variables and converts the two loops
going through strips and tiles, into one loop that goes through
branches from the input.

Bug: None
Change-Id: I156a1607d81010f00523f0a6c60e45dfe3a88a88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612047Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: James Bankoski <jimbankoski@google.com>
Cr-Commit-Position: refs/heads/master@{#659749}

Bug: 881215
Test: unit_tests --gtest_filter=AboutFlagsTest*, AboutFlagsHistogramTest*
Change-Id: Ia1749065e2b41bba2f402d7790e9e00d7592b144
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610666
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659748}

Chrome's network stack runs out of process in most places, so logging
actions to the in-process NetLog accomplishes nothing. Cast should be
grabbing a UDP socket using the NetworkContext interface, instead of
creating an in-process socket (Which will also get its network events to
appear in the out-of-process NetLog).

Bug: 767450
Change-Id: I3c742689f0b4a29138fd63669928b3a55d5ee2d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612056
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659747}

These have been spiking a bit, and so to cut down on the noise, reduce
the rate at which we emit these to 1% of the previous total.

The UMA stats will still show the true numbers, and this should still
allow us to get urls to try to reproduce these cases that are failing in
the wild.

Bug: 879110
Change-Id: Ice743cfa10f460deaf806cd1b28d534f446ce975
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612225Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Auto-Submit: enne <enne@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659746}

This introduces the simplified layout algorithm. This is triggered when
 - An OOF descendant has its constraints changed.
 - The block-size of a fragment changes in size.

There are several nuanced details with this algorithm. E.g. determining
the correct static position for an OOF descendant.

Bug: 635619
Change-Id: Iba4c4b82edf873fa4cad9ba28e9fa3849a4a8e8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590237
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659745}

On some test runs the SetupListeners() call was being made too late,
resulting in it missing the initial change event for controllers being
connected.  This removes that race condition by registering in the
continuation on the requestSession promise so that it can guarantee the
listeners get set up before any events would fire.

Bug: 963149
Change-Id: If7a1b9d82fa31166d87be2d39141a9cb8fbaf7e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612026
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659744}

https://boringssl.googlesource.com/boringssl/+log/777a239175c26fcaa4c6c2049fedc90e859bd9b6..f014d609c07cf83d5a9be730469f67bd199c017e

The following commits have Chromium bugs associated:
  b29e1e15a Save and restore errors when ignoring ssl_send_alert result.

Add a regression test for the error-mapping issue. Though we fixed it in
BoringSSL, Chromium's error mapping has enough moving parts that we should test
in Chromium too.

Additionally, this retires crypto_test_data.cc in favor of a Chromium-specific
stub to integrate with Chromium's test data mechanism. The recent PRESUBMIT
check is unhappy about the generated file. In doing so, limit the tests to
Chromium to avoid worrying about issues when WebRTC pulls in
//third_party/boringssl. They do not appear to be running those tests anyway.
(Apparently providing data to tests in a uniform way across projects is
impossible...)

Bug: 959305
Change-Id: I85bb350b19c96cfa80fb816a39d617f7a4e7707d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610474
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659743}

Make the upload an image option in the richer picker work. Selecting
an image and pressing open will immediately close the dialog. This
is consistent with the orgiinal version of the menu but will change
in the future.

Screencast: http://go/scrcast/NTc1MDQ4OTAzMzQ3NDA0OHw1MTNlMmNmMi02Yw

Bug: 937570
Change-Id: I7fa86164d530cc50c60c29385da14b4ae1921878
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611728
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659742}

NetworkState and NetworkStateHandler were generating
shill::kStateDisconnect for non-visible services and not connected
tether services.
However, shill::kStateDisconnect is a legacy status value from flimlam
and some chrome code doesn't expect this status to appear.
Use shill::kStateIdle instead.
Also avoid using kStateCarrier as it's not reported by shill anymore
either.

Bug: 552190, b:131667462, 954552
Test: Unit tests
Change-Id: I1ba28fba457682f45ae8816a7869f5c29f6fd200
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591595
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659741}

Fix bug in NGLineTruncator::TruncateChild where it incorrectly assumes a
fragment always has content. This isn't always the case, especially when
obscure -webkit features are used. This change adds an extra null check.

Not using a WPT test as the test case replies on impl specific behavior.

Bug: 962297, 962471
Change-Id: I87ac7841a93303802aa2028e0ee04aaa9ab0961d
Test: web_tests/fast/text/empty-ellipsis-vertical-rl-crash.html
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612224
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659740}

Bug: 890054
Change-Id: I91cb2f1365ba5eb0ead2440fbc08e785eb5a58c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601688
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659739}

BUG=941120

Change-Id: I9aa263f404dcb4d673298823ddaa3b202521dbae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612218Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659738}

WebXR browser tests now verify that no WebXR gamepads are attached to
the navigator array and that the expected number or XRInputSources are
attached to the XRSession.

This fixes an issue that caused webxr gamepad browser tests to
consistently fail on some Windows machines because the gamepad API
would detect random USB devices and think they are gamepads and attach
them to the navigator array.

Also consolidated the gamepad-related tests in WebXrVrInputTest.java
because the WebXRGamepadSupport flag no longer exists.

Bug: 961371, 947581
Change-Id: I348a455c44b37a813409af9bf4a7e5fefb68a51c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602097
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659737}

This functionality was added purely for mus and is no longer necessary.

BUG=958241
TEST=purely dead code removal
TBR=estade@chromium.org

Change-Id: Ifc6905dc078d51584fc49cb5dd21654efc438e16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610988Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659736}

It appears that the default "rotate" animation for dialogs fails to
handle layer visibility correctly and thus triggers DCHECKs and other
issues. Using "fade" works around this until "rotate" can be fixed.

That fix is happening on
https://chromium-review.googlesource.com/c/chromium/src/+/1610462

Change-Id: I062035c52142f054cd9032a0b785db314d442d8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612217
Auto-Submit: Adam Langley <agl@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#659735}

Expiration is left at the default (M76).

Bug: 959086
Change-Id: I7c87dc520bbb5a310e5a36120c3e3add7ead23b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610495
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659734}

Bug: 958997
Change-Id: I5508e191ac7767a8f1266e66157d59e08047c5e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612277Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659733}

This is because the reference_view is a BrowserAppMenuButton which
is no longer a MenuButton.

Bug: 962442,960952

Change-Id: I00c40561290c21c13dbad250017a0d09756b8cb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610542
Commit-Queue: Charlene Yan <cyan@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659732}

The code is no longer in use, since variations now uses the network
service's URLLoader interface, instead of URLFetchers.

Bug: None
Change-Id: If506394f8abbdc4bc5ea166652dbdabcda8f172d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612046
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659731}

The FormControlsRefresh feature will make macOS use the Aura theme (and
the refresh theme, where it is implemented).

Add a runtime feature, FormControlsRefresh, to control this in blink.

Bug: 846357, 956778
Change-Id: I4eefee7ef06748b95d4f2df361a38001a4989b0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611108Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659730}

This change adds a test for the Serial API similar to the ones added
to exercise issue 723503 for WebUSB and Web Bluetooth and duplicates
the fix used to resolve this issue for Web Bluetooth.

Change-Id: If6efaf9a0105b48fc158dd7f52762fb23c8634ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606591
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659729}

Add logic to set FeaturePodsContainer Layout according to page numbers
Add PageIndicatorView in UnifiedSystemTrayView

The SystemTray will be limited to show 3x3 FeaturePodButtons at a time.
Additional Buttons will be added to additional pages.
The available pages will be signified by small buttons under the
feature pods container.

Bug: 914077
Change-Id: I8e2e1a51b0503bda251e409f7ce77d81f57f136e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590610
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659728}

The WebXR Spec requires that select events be fired in the order:
1) SelectStart
2) Select
3) SelectEnd

The current implementation in chrome flips the order of events 2 and 3.
This change flips that order to match the spec.

Bug: 960997
Change-Id: I3a8aca683898515102999d86b7bcee6c6e74ef24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607180
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659727}

This reverts commit c29b91d2.

Reason for revert: making CQ tests very slow crbug.com/962601

Original change's description:
> Relandx2 "Do not create PrefetchGCMAppHander in reduced mode"
> 
> This reverts commit 63893bf5.
> 
> Reason for reland: fix performance regression outlined in crbug.com/950549.
> This was done by scheduling the gcm token refresh to after the browser has
> started fully (i.e. after the critical path, which ends after first page load).
> 
> Original change's description:
> > Do not create PrefetchGCMAppHander in reduced mode
> >
> > If in reduced mode, we cannot create PrefetchGCMAppHandler. Instead we pass the
> > prefetch service a closure to create the gcm app handler on demand.
> >
> > This cl also changes the signature of the getter for PrefetchGCMHandler in
> > PrefetchService to require a profile to be passed in. This ensures that:
> > 1) the getter can only be called in full browser mode (there is no profile in
> > reduced mode).
> > 2) if PrefetchGCMHandler hadn't been created yet, then it can be
> > created on demand using the aforementioned profile.
> >
> > Bug: 934337
> > Change-Id: I7e813f425e0ba8687f9b519b4300fa7eec014929
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495737
> > Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
> > Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
> > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> > Reviewed-by: Xi Han <hanxi@chromium.org>
> > Reviewed-by: Jian Li <jianli@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#640470}
> 
> Bug: 950549, 934337
> Change-Id: Id8824fa087e31ac7b875a828318af5a4ca9afd47
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588164
> Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
> Auto-Submit: Mohamed Heikal <mheikal@chromium.org>
> Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#656215}

TBR=carlosk@chromium.org,mheikal@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 934337, 962601
Change-Id: I2f4013a801ef6c7359df79a73b0dec3e90471f02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612378Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659726}

As of r626853 SerialChooserController no longer owners its own
connection to the SerialPortManager. Since this connection can now
outlive the controller instance it is not safe to bind an raw pointer
to |this|. This patch adds a WeakPtrFactory so that callbacks arriving
after the controller has been destroyed are safely discarded.

Bug: 952709
Change-Id: I1994b0aa3e7514bb200c304e70accce4b17e0b9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606588Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659725}

Bug: 958938
Change-Id: Ia6dd28f199732906327a2ca6b7d2d45053690ea9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600626Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659724}