GitLab

This change converts MediaControlsMenuHost mojom interface client in blink
to use BrowserInterfaceBroker.

Bug: 936482
Change-Id: Iefe4ce64adfd4b67d6a12b18a400cf503d97369f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824917
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700452}

When the user selects a JPG file from disk to use as their profile image
we send the image to the renderer as a base64 encoded PNG. The PNG
encoding can be slow, so post a task to move encoding off the UI thread.

Test: Open OS settings > Personalization > Change device account image,
  and select a large JPEG. Select file window closing animation plays
  smoothly.

Bug: 812180
Change-Id: Ied7cebe1e85be580b5cd49e5ffb077815e73ebba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826002
Commit-Queue: James Cook <jamescook@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700451}

This CL adds the left gradient zone during gesture drag and scrolling
animation.

Bug: 1004134
Change-Id: I134b0ea33ae06cbfe0974113ed08203d2b8c63cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818118
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700450}

The attached bug contains details on where the previous logic in GetTabGroupForTargetIndex was causing different behavior based on group size.

This CL updates the logic to focus more on current position than previous group membership. As noted in the inline comments:

  (If the tab is between two tabs with the same group membership, match that group.)

  // If the tabs on the left and right have different group memberships,
  // including if one is ungrouped or nonexistent, change the group of the
  // dragged tab based on whether it is "leaning" toward the left or the
  // right of the gap. If the tab is centered in the gap, make the tab
  // ungrouped.

  ("Leaning" is defined by being 1/4 the tab width toward either side of the gap.)

  // Extra polish: Prefer staying in an existing group, if any. This prevents
  // tabs at the edge of the group from flickering between grouped and
  // ungrouped. It also gives groups a slightly "sticky" feel while dragging.

  (There is also some special handling for the far left and far right of the tab strip.)

A screencast of this interaction is attached to the bug.

Bug: 1004946
Change-Id: Id3cf631354a47ffa5c3f1aeacdc82bd2af13ea24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823729
Commit-Queue: Connie Wan <connily@chromium.org>
Reviewed-by: Charlene Yan <cyan@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700449}

A device policy which controls the cursor highlight accessibility feature on the
login screen.The policy can be applied as a recommended or mandatory policy.

Test:
1. Set the login_screen_cursor_highlight_enabled policy to True, open System
Tray => "Accessibility", check that "Highlight mouse cursor" is displayed with a green
check in the login screen.
2. Set the policy to False, open System Tray, check that "Highlight mouse cursor" is
not displayed in the login screen.

Bug: 552439
Change-Id: I49b3547c78c657b01aa80c025ded6d461e9bc200
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816543
Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700448}

These are the same checks with chrome/test/data/webui/.
Also fixing existing violations.

Bug: 720034,1005029
Change-Id: Ic3db4eab01ce109da7f24c9b6f2480d522b3dfb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826010
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700447}

LogonUI uses fixed buffer size to pass the json object to rundll32. To fix the issue, first write/read the buffer size to/from the pipe.

Bug: 902911 https://bugs.chromium.org/p/chromium/issues/detail?id=902911
Change-Id: Ibfc23a098c53c4b6c58a979ee38fb46dc38d55bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825909
Commit-Queue: Emre Kanlikilicer <emreknlk@google.com>
Reviewed-by: Tien Mai <tienmai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700446}

Exactly what it says on the tin. Compressed JPEG data is now available.
Expected to be used for Mohnstrudel tabstrip.

Change-Id: I523ad8a65a38b7a6c66bc462c8f78ca7d5012318
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817583Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700445}

This change tracks when a burst of input clicks is received
on a page at the same position. In particular it captures the
max count of sequence of input clicks that are within a 500ms
delta between two clicks in the sequence that are close to the
same position.

Bug: 1001590
Change-Id: I202eae441130fba19b4d1478736803f2a6eac3cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790242Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700444}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/a7f82b08de68..3004764570f3

git log a7f82b08de68..3004764570f3 --date=short --no-merges --format='%ad %ae %s'
2019-09-26 vapier@chromium.org cros lint: force python2 with pylint

Created with:
  gclient setdep -r src/third_party/chromite@3004764570f3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Ic8998d8544a93a2c33193013208b5a66969ef3c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826868Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700443}

This reverts commit 068ce39e.

Reason for revert: This change is not desired on mainline.

Original change's description:
> [Feed] Comment out NTP asserts.
> 
> Bug: 992585
> Change-Id: I76d8de861d6844bfa00bd402ab8bf4110c7974f8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819997
> Reviewed-by: Theresa  <twellington@chromium.org>
> Commit-Queue: Sky Malice <skym@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#699099}

TBR=twellington@chromium.org,skym@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 992585
Change-Id: I43e4da44c760b324df31f48e347a1ce58b09bd7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828098Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700442}

Makes GPU gold pixel tests output links to the triage page for the
entire CL instead of each individual image when running on the trybots.
This makes it so that users only need to open one link regardless of
how many failures there are in order to triage everything.

Bug: 1008524

Change-Id: I94891663fe09bb59ba386e7bd24bc72a4ffe1468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825907
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700441}

Change-Id: Iedcc3720627552c022d8dcb167a724bd09bcfa02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823438Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Marc-André Decoste <mad@chromium.org>
Commit-Queue: Kathryn Spiers <ksspiers@google.com>
Cr-Commit-Position: refs/heads/master@{#700440}

This CL sets coverage input properties on linux-chromeos-rel so that
it will start instrumenting and processing code coverage data.

Bug: 1000367
Change-Id: I9335cd0512e95d2d0f1ec2b6caa69c62380b42d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825734Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700439}

Use constants from base/numerics/math_constants.h instead. Do IWYU and
remove some unnecessary casting along the way.

Change-Id: Iee15ae1d99c643c3950d085f02cda72c64c71ea5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827243Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700438}

This CL adjusts conditions to include search engine from Play API in the
list of prepopulated engines on settings screen. It also adjusts
DefaultSearchManager to propagate created_from_play_api flag through
preferences.

BUG=1002271
R=pkasting@chromium.org,wylieb@chromium.org

Change-Id: I05a1ea866a3b32a0bdf73b3333d1a9258b453941
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824134Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Kevin Bailey <krb@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700437}

It can't be disabled/enabled remotely on the welcome screen - so kinda
useless to guard the feature.

Bug: 999090
Change-Id: I7489355c7a9925edef69d47de05d4fe22ae6c45a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824878Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700436}

Bug: 1004757
Change-Id: Ib3e3df302e6b8e995a767463a485ed29f6b511b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825718Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Harley Li <hhli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700435}

-webkit-gradient(radial, ...) and -webkit-radial-gradient(...)
now reject negative radius values.

This improves consistency with radial-gradient.
https://drafts.csswg.org/css-images-3/#radial-gradients


Bug: 1008112
Change-Id: Ibfad0b73146d40418f78584c037ab9cc0febd7e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824507Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700434}

Change-Id: I152b8c53921e134f5463d1a5211f7c722ad9e56b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828062
Auto-Submit: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700433}

Bug: 960245
Change-Id: Ia1309ec99b1518aa7371fa24130c71662eb332cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823725
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700432}

https://android.googlesource.com/platform/external/perfetto.git/+log/8f223cdf4c24..5d1b15f34c87

git log 8f223cdf4c24..5d1b15f34c87 --date=short --no-merges --format='%ad %ae %s'
2019-09-26 ilkos@google.com Merge "Join frames and symbols to improve performance"
2019-09-26 pmuetschard@google.com Merge changes I60f7fc3b,I99786210,I45008d53,I1c07ced9
2019-09-26 treehugger-gerrit@google.com Merge "perfetto-ui: Tidy up scrolling code"
2019-09-26 lalitm@google.com Merge "trace_processor: add thread track table and interning code"
2019-09-26 treehugger-gerrit@google.com Merge "Actually support java_hprof in BuiltinProducer."

Created with:
  gclient setdep -r src/third_party/perfetto@5d1b15f34c87

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I478effe7867d179919807e64f7fd8ff1d06e6887
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828044Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700431}

Bug: 1007607
Change-Id: If71e3b363fdcf191dac41da7f79c55aa917e9d52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827771
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700430}

https://webrtc.googlesource.com/src.git/+log/ee8ee2f10366..c6d7d58c13e8

git log ee8ee2f10366..c6d7d58c13e8 --date=short --no-merges --format='%ad %ae %s'
2019-09-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2d2f043b..ecfd30c3 (700199:700332)

Created with:
  gclient setdep -r src/third_party/webrtc@c6d7d58c13e8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: I2cd31a9cc6f034324217d0657f7cd086366d7eb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828047Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700429}

The single escape does not work correctly for the case of replacements
within an HTML template string in JS, and the double escape works
correctly both for the template string in JS case and the normal HTML
replacement case.

Discovered while migrating the extensions page to use Polymer 3,
specifically the i18nPolymer replacements in shortcut_input.html,
which contain commas for Chrome OS.

Bug: 1004967
Change-Id: Ifb7a743cc2048942294a1cb93f73871191ffa254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826279Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700428}

Phonetic hints would get interrupted by other speech output in some
cases (usually when interrupted by a hint).
This change queues and delays phonetic and hint speech, so that
phonetic speech doesn't get dropped.

Change-Id: I1e1a79129a490b34de381405f7a978d1d6cca74d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801749Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700427}

These changes are a part of a separate project to import the
webdriver tests into google3. Changes include fixing typos and
updating assert statements.

Bug: 1008539
Change-Id: I1ae5c99c86043719b96b2543c9f5fc35974a130e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828104Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Cr-Commit-Position: refs/heads/master@{#700426}

Previously, we've had to wait for readystatechange before defining
the guest view custom elements because
1) there were circular dependencies that would cause errors if we
tried to perform the definition immediately, and
2) the Custom Elements V0 registration context was scoped to the
document rather than the window, so if we defined the elements
while the document was still on about:blank, the definition would
be available on about:blank, but not for the extension.

Now that the circular dependencies are fixed and guest view is
migrated to Custom Elements V1 (whose registration context is
scoped to the window), it is no longer necessary to wait for
readystatechange.

We now perform the definition immediately.

Bug: 810012
Change-Id: Ib5e8ba6f4e302eaae56c5566765521d64b1a0e15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1278287
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700425}

Importing an AHB to the client sandboxed process seems to be causing
issues, so disable GMBs for canvas resources completely. Using a GMB
here is also not useful unless SurfaceControl is enabled. Since the GMB
can not be used as an overlay otherwise.

R=mcasas@chromium.org

Bug: 1003920
Change-Id: If9fd6c965d004775ad79e162a660dfef02ad1a42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827857Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700424}

https://chromium.googlesource.com/angle/angle.git/+log/2bdefbf8162d..70d79b76994e

git log 2bdefbf8162d..70d79b76994e --date=short --no-merges --format='%ad %ae %s'
2019-09-26 jonahr@google.com GL: Add state validation functions to GL backend
2019-09-26 jmadill@chromium.org Vulkan: Clean up garbage APIs.

Created with:
  gclient setdep -r src/third_party/angle@70d79b76994e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@google.com

Bug: None
Change-Id: I608e73c42bebe4ceafce70d4943da1eeaadb75fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827760Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700423}

Add enum values to SafetyTipInteraction to record how a user
dismisses the Safety Tip.

Bug: 1001162
Change-Id: Ib4c86d88d21362593767c0d5c31fa3f0c1ac1edd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822498
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700422}

This CL implements a GstaticJsonFetcher that actually connects to
gstatic to fetch the JSON files.

Bug: 1001291
Change-Id: I5dcb34e1ea10b8ab6a80343d73757de5bd08da37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825484
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700421}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/983111f039f6..e4174f483ee5

git log 983111f039f6..e4174f483ee5 --date=short --no-merges --format='%ad %ae %s'
2019-09-26 mbonadei@chromium.org Add VS 2019 support to package_from_installed.py.
2019-09-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-26 ehmaldonado@chromium.org depot_tools: Enable more tests for windows.

Created with:
  gclient setdep -r src/third_party/depot_tools@e4174f483ee5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: chromium:1006238,chromium:1007580
Change-Id: Ia1456294b6f69fc2ca860a18992cc5a372491693
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828041Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700420}

Merge the method up into SynchronizeVisualPropertiesFromRenderView()
and change callers to it elsewhere. One unit test is changed
to call SynchronizeVisualPropertiesFromRenderView() instead. The web
test synchronous resize mode path is changed to set the sizes without
constructing a VisualProperties.

R=avi@chromium.org

Bug: 1006052
Change-Id: I74bfeec606fba52e793cf4f624a759b3858eb88c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825623
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700419}

Bug: 1003391
Change-Id: I27a60bffbf951c92ed1bcf8ffbafd7e473335f25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827379Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700418}

Adds a "LayoutOptions" object that is passed from the PDF plugin (via
the "documentDimensions" message), through the extension, and back to
the plugin (via the "viewport" message).

We plan to make layout asynchronous for crbug.com/885110. To accomplish
this, we need to carry certain layout state through the JavaScript
layer, until the layout change finally is applied.

In the future, we may want to modify the layout options in JavaScript
(such as for 2-up view), but for now, we just need to pass the exact
same object back and forth.

Bug: 885110
Change-Id: Iaac57422dbba185399358ceffdbde4e6ad2c7899
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815769
Commit-Queue: K Moon <kmoon@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700417}

When OnTabClosing() is called the WebContents has been removed from the
model. This is problematic as it's entirely likely for some of the code
in OnTabClosing() to trigger a call back to Browser by way of a delegate
which then expects the WebContents to be in the model. The fix is to reset
the delegate early on in the future, so that none of the code calls back to
Browser.

TabDetachedAtImpl() also resets the delegate, but TabDetachedAtImpl() may
be called in scenarios where OnTabClosing() is not called.

BUG=1007379
TEST=none

Change-Id: I6d0141a540b39ce52725d7bc198175e1b89a40af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825924Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700416}

This CL also serves as a self-contained "vertical" example for how to
move a WebUI page to the DevUI DFM.

Bug: 927131
Change-Id: I88c5f624d2094ecfd1cf1919d9cb4abe8d1daea4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823605Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700415}

This change allows Mojo client processes to connect to a new process
network if disconnected from a previous one. Prior to this change, a
process could only belong to one network for its entire lifetime.

This new behavior is useful in cases where a client process may outlive
its original broker process (for example, if the broker crashes) and
should be able to continue operating normally when a new broker process
is established in the system.

Bug: 813112
Change-Id: Ifb5f16f1b39127cf7b469ee798f2d3da159fa432
Tbr: jam@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821743Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#700414}

This bug was introduced by my previous CL (https://crrev.com/c/1811183).
In that CL, calculating the edge padding was put before the update of
layout strategy. In this CL, replacing the check on layout strategy with
calling CanFitAllAppsWithoutScrolling.

Bug: 1006379
Change-Id: I74b6e0f85662d1c5c31cdbe0d1139357000a3321
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828060Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700413}