- 15 Oct, 2020 40 commits
-
-
Jan Wilken Dörrie authored
This change adds a link to the origin to the dialog shown when removing a compromised credential. Since injecting links to insecure domains is not allowed due to the risk of XSS, this is limited to HTTPS origins. Fixed: 1066790 Change-Id: I297c3e49b4388bed5c229959345741565b1d2092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133966Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#817525}
-
Clemens Arbesser authored
This was erroneously reported on every start of autofill_assistant, not just lite-script starts. Bug: b/170952445 Change-Id: I952c7f7aafce879ad7fd8ef7c268b42c5b4fd101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475916Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#817524}
-
Ben Pastene authored
We skip expectations for any builder with 'error' in its GN args. And many android builders set the 'use_errorprone_java_compiler' arg, so they all have their expectations skipped. The correct condition would be to test that all the GN args is wholly equal to 'error'. This fixes that. Now only 'chromium_presubmit' and 'ios-simulator' are skipped. Bug: 1117577 Change-Id: Ibcbfd966fe5918e234a99b010928345192daf057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472207Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#817523}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 87-4277.0-1602498224-benchmark-87.0.4280.19-r1 to 87-4277.0-1602498224-benchmark-87.0.4280.20-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I71ad830c3ab81006798bef2a87f13f6c41e989f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476513Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817522}
-
Thomas Lukaszewicz authored
This CL adds a reusable bubble and corresponding WebUIController class to be used when implementing Secondary UI using WebUI. See the below doc for more details. https://docs.google.com/document/d/1UtAVhVpo8Si_XlZEdt-BH_AN4egBo1XppZEhF3_bthM/edit?usp=sharing Bug: 1099917 Change-Id: I6b16997b05dc2bf2f208ca71dd5b3cfa11db00f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462223 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#817521}
-
bttk authored
These methods are only called on LocationBarCoordinator and have no effect on CustomTabToolbar. Change-Id: I4af4c32d8aadfdade5d5c4c04faa31c90abe63dd Bug: 1133482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464085Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#817520}
-
Sebastien Lalancette authored
Reasons for becoming an owner: - I created this directory in: crrev.com/c/2297601 - The creation of the SharingCoordinator stems from a non-trivial design requirement to support showing an ActivityView at an arbitrary position in the layout tree. Since I designed this solution, it makes sense that I keep an eye on contributions made to it. Change-Id: I229db494287a138ababa3437acdde5119028d283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472198Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#817519}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 79fe037f. With Chromium commits locally applied on WPT: 5fb2b257 "[AspectRatio] Fix divide by zero with a small float ratio" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I066667c1bf7d2007cc58fc86c2564876a3b0fbd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475302Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817518}
-
Philip Rogers authored
This patch removes StyleDifference::BackdropFilterChanged and instead makes backdrop filter changes fully invalidate compositing. Backdrop filter is a compositing reason for SVG (see CompositingReasonFinder::DirectReasonsForSVGChildPaintProperties). When backdrop filter changes, SVG children need to notify the root of potential compositing changes (see SVG StyleDidChange functions such as LayoutSVGInline::StyleDidChange which check StyleDifference::CompositingReasonsChanged). Instead of adding a check of StyleDifference::BackdropFilterChanged in several SVG classes, this patch removes the backdrop filter property specific difference and just full invalidates compositing. Bug: 1138443 Change-Id: I328a4e8a2253b083c8dadc9bf1caf467f15a0eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474916Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#817517}
-
Ella Ge authored
This CL moves WebappDisclosureSnackbarController to browserservices folder, makes it use TrustedWebActivityModel and the DisclosureInfobar as TrustedWebActivityDisclosureController. This will change the text in unbound webapk's disclosure snackbar text to be the same as TWA one. Bug: 1128675 Change-Id: I900c41c04a6f36489bed1e08cf81c74f89e2801e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453896Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Owen Min authored
Rename c/b/enterprise/reporting/notification to c/b/enterprise/reporting/extension_request so that the extension_request_observer can be used by real-time reporting which is not part of notification. Also move extension_request_policy_handler into the extension_request/. Bug: 1137964 Change-Id: I7c8af718333494114d20416fcfa9415bc8f7a6be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468467Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817515}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/139f1af3ffa6..b842a763db41 2020-10-15 tvanderlippe@chromium.org Typecheck resources/ServiceWorkerCacheViews.js with TypeScript 2020-10-15 leese@chromium.org Fall back to wasm function names when DWARF function names not provided If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1137789 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I91c0431fcecea18e335d05fc62348789abe75445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475005Reviewed-by:
-
Prashant Nevase authored
Pass DarkModeRasterFilter from blink::LayerTreeView to cc::GpuImageDecodeCache. This is part of raster side dark mode. Bug: 1094005 Change-Id: I5794103b61da9a6ce9790bcba5bc923f17a26d38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467741 Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#817513}
-
Mikel Astiz authored
No behavioral differences: all demographics-related logic is removed from SyncPrefs and intocomponents/sync/base/user_demographics.*. This is a prior step to moving all this logic away from components/sync. Change-Id: Ia2e0525d0d7a9a1cfb2b3906824cb64154cd2e34 Bug: 1137346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474856 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#817512}
-
Tanmoy Mollik authored
If AccountManagerTestRule is initialized with a FakeProfileDataSource then it should add profileData objects when adding accounts. Bug: 1136470 Change-Id: I015389190e93725875601c926658ed4a207301df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455986Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#817511}
-
Mehran Mahmoudi authored
Bug: 1138902 Change-Id: If0a8944718004ab56f7e60c532b051ded909ea0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476033 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Auto-Submit: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#817510}
-
Dave Tapuska authored
Try to pare down the public RenderView interface by removing uncalled APIs. BUG=1097816 Change-Id: Ic7554cdf87e3bea438745eab73f14cc5520322ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475973Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#817509}
-
Scott Violet authored
This is necessary in the case of a configuration change. In particular when this happens the Activity is destroyed, but not the Browser/fragment/tabs. BUG=1124960 TEST=see bug Change-Id: Idfa4faa0850d231d34ae84914b06467942f42c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473045Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#817508}
-
Elly Fong-Jones authored
Bug: None Change-Id: Ie895d32cd402b8596ca833d8bd43f172947052de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463556 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#817507}
-
Wei Li authored
For cetain properties such as model, callback, or generic pointer types, they can not be easily serialized to/from a string. To support such properties, this CL adds support to no longer require every property to have type converters. Bug: 938501 Change-Id: If198607b8af81a36b9fecb290a4f2a423488c902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467337 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#817506}
-
Greg Thompson authored
base/win/registry.h includes more than it uses. These files were inadvertently relying on that fact. This CL adds missing includes so that registry.h can be cleaned up. BUG=None This CL was uploaded by git cl split. R=estade@chromium.org Change-Id: I8640470b816fa9c012bd43594d90dce34e6a711e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475055 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Roberto Moura authored
When revealing the Thumb Strip (from Hidden to Peeked state), the thumbnails slide in upwards from below. When revealing the Tab Grid (from Peeked or Hidden to Revealed state) the Tab Grid's top toolbar slides in downwards from above. Correct the top inset value for the thumb strip layout. Bug: 1127604 Change-Id: Ib5601992816c9aad7135a7a3b44c2ae516187544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466756 Auto-Submit: Roberto Moura <mouraroberto@google.com> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Alice Wang authored
This CL records metrics when the web sign-in bottom sheet is dismissed for different reasons. Bug: 1138435 Change-Id: I237e20cad5f1a7d14b163150baf72b7d42b8ce1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475233Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Marc Treib authored
Bug: 1138305 Change-Id: I041541d01b0e46ec034c5579a5a26be7d4bff4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474693 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
Mansi Awasthi authored
Currently Embed element with children in different tree are treated as an empty object. It's because IsEmptyObjectReplacedByCharacter() calls AnchorUnignoredChildCount() to see if an element has any children. This call doesn't check if the element has a child tree. This results in incorrect range calculation for PDF documents. This CL adds a check in IsEmptyObjectReplacedByCharacter() that an Embed element with non empty children including child tree should not be treated as an empty object. Bug: 1131507 Change-Id: I0fb2572a80c304c7cee35f68062321e09b78ed62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449670 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#817501}
-
Alice Wang authored
This CL tests two sign-in metrics in the web sign-in bottom sheet. Bug: 1134874 Change-Id: Ie2a4b213856226f7e8004b17a55f7a097a405ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475700Reviewed-by:
-
Eugene But authored
Use correct key names (osName, osVersion) as described here: https://sites.google.com/a/google.com/crash/users/getting-started/getting-started-guide#TOC-Step-6:-Upload-crash-reports-from-your-application Bug: 1103752 Change-Id: Ie3a7141aa31cd154cad29421a04364039f58eb10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473377 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817499}
-
Roberto Moura authored
The plus sign cell is a cell added to the end of the collection view of the Tab Grid / Thumb Strip that opens a new tab when tapped. It has the same shape of the thumbnail cells but has a plus sign in its center. A new class was created for that: PlusSignCell. The plus sign cell is always the last element of the collection view. Screenshot: http://screen/49Y5RU8dPwDVXkW.png Bug: 1127604, 1137983, 1137986 Change-Id: Ib1d9df1c22e6d3c2ca1340317dc7a39104275663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431668 Commit-Queue: Roberto Moura <mouraroberto@google.com> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
-
kylechar authored
This reverts commit 0be396a2. Reason for revert: Speculative revert for https://crbug.com/1138919 Original change's description: > Fix Windows overlay texture lifetime > > With SkiaRenderer on Windows overlay textures weren't kept alive after > the client destroys them if still in use. Implement something in > SkiaOutputDeviceGL that is similar SkiaOutputDeviceBufferQueue where we > keep a map of mailboxes to textures to keep alive. Instead of using > SharedImageRepresentationOverlay we have to use GLImage still as not all > Windows video paths are using shared image. > > Bug: 1136194 > Change-Id: Ibeb5726b914058c0868a90dcc9bca74a8499c660 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462038 > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817164} TBR=sunnyps@chromium.org,kylechar@chromium.org,vasilyt@chromium.org Change-Id: I811b7f36afce932a359b72f5fe4e9df9cde43712 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1136194, 1138919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475756Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#817497}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e07f2b21917d..dd09d6e2ef11 2020-10-15 adlai@google.com Migrate skottiekit to GrDirectContext If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: I3e2f34d76c4cc2260139f6c3844f5a0e8496b65c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475636Reviewed-by:
-
Greg Thompson authored
base/win/registry.h includes more than it uses. These files were inadvertently relying on that fact. This CL adds missing includes so that registry.h can be cleaned up. BUG=None This CL was uploaded by git cl split. R=pkotwicz@chromium.org Change-Id: I4d705b912fa264ffaf2c65bac06c47789bb79f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475073 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#817495}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602741093-4d55155af2d57fc162c54eb0d019ea99dc26a80f.profdata to chrome-linux-master-1602762990-5610fc4d08ce928742199548ea998fa82cc20428.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia8a2ad4f538d9c85cd3e6e49b913825efbee3eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474637Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/481fb88fee33..b0248ea45f6e 2020-10-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from f121d1252b2a to 465acf564a41 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I92952da0e345e9f7a4aab83a2170760fb6b13788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474583Reviewed-by:
-
Greg Thompson authored
base/win/registry.h includes more than it uses. These files were inadvertently relying on that fact. This CL adds missing includes so that registry.h can be cleaned up. BUG=None This CL was uploaded by git cl split. R=ganesh@chromium.org Change-Id: I9870f7a77b294b14475c63a4b2752de0d86ef87b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475113 Commit-Queue: S. Ganesh <ganesh@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#817492}
-
Greg Thompson authored
base/win/registry.h includes more than it uses. These files were inadvertently relying on that fact. This CL adds missing includes so that registry.h can be cleaned up. BUG=None This CL was uploaded by git cl split. R=rogerta@chromium.org Change-Id: I212f88b802f2fc159938f2cc3ac5bff86d4b84ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475035 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#817491}
-
Wei Lee authored
Originally, we use background page and chrome.runtime API for communication between CCA and Tast tests. However, since SWA does not have background page and cannot use chrome.runtime API, we introduce a new implementation using SharedWorker for communication. Bug: 980846 Test: Tested with the related Tast CL and run "$ tast run [DUT] camera.CCAUI*" Change-Id: I575aeb11db4af90de1eebf63ad7f1d8f1608ded2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362235Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#817490}
-
Evan Stade authored
This change adds a workaround for the fact that GMS's CastContext typecasts from Context to Application (in WebLayer, ContextUtils.getApplicationContext() will return a ClassLoaderContextWrapper, not an Application). MediaRouteDialogFragment is made public as it appears DialogFragment subclasses must be public. This also adds a CastOptionsProvider reference in WebLayer shell. It's still clear not whether WebLayer should provide this in its client- side manifest, so this errs on the side of not breaking clients. For now, clients that want to use MediaRouter code will have to provide their own CastOptionsProvider. Bug: 1057100 Change-Id: I12c651e005e495fa1f83c311c569ae0e2973ff80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468563 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#817489}
-
Owen Min authored
Remove following uma metrics as they are not actively monitoring by anyone. Signin.ForceSigninVerificationTime.Success Signin.ForceSigninVerificationTime.Failure Signin.ForceSigninVerificationRequest Bug: 1089514 Change-Id: I74693b957544e4f285aad2b6685ebaaefebe3cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468461Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817488}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602741093-813b9f30d38756007f17b964e7014a850d40bedc.profdata to chrome-mac-master-1602762990-5c0ecdd782b8586c3ade2c97da0a453329c89923.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6074203051a3455dcc791c6fbd1d88ee394cb028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475638Reviewed-by:
-
Mark Mentovai authored
This version of Xcode updates the macOS SDK from 11.0 20A5384b (close to 11.0db9) to 11.0 20A5395d (close to 11.0db10). lipo is added to build/xcode_binaries.yaml because it may help with https://chromium-review.googlesource.com/c/chromium/src/+/2462242/17#message-eee09fed41f8e46c1241f0d5a33d336b0221a4fc. The xcode_12_beta hermetic toolchain in build/mac_toolchain.py was built with this new build/xcode_binaries.yaml and contains lipo. CQ-Include-Trybots: luci.chromium.try:mac-arm64-rel Change-Id: Ie4398f7d7d51c67a9f81dfaf5c45b6f2dfca8ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475753 Commit-Queue: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#817486}
-
