- 27 Jan, 2020 40 commits
-
-
Miguel Casas authored
crrev.com/c/1863153 introduced a regression when it started looking at the kWebRtcHWH264Encoding flag, which was enabled by default. This was caused by the convoluted logic around h264 sw/hw encoding support. This CL removes that check entirely since the flag was fully enabled anyway [1] so the original check: if (webrtc_h264_sw_enabled || base::FeatureList::IsEnabled(blink::features::kWebRtcHWH264Encoding)) was always true (bc of the second member). This CL thus removes all the code related to that flag, allowing for h264 to be accepted even if there's no sw fallback, hence restoring the original behaviour pre-deprecation. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1863153/4/third_party/blink/common/features.cc Bug: webrtc:11244 Change-Id: Id9132181fdca08ede12e22a1cc66590f1062269d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022929 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#735541}
-
David Trainor authored
This patch removes download home dependencies from the DownloadGlue class and the DownloadManagerUiConfig class. - For DownloadGlue, a LegacyDownloadProvider interface is exposed and passed through. This allows the implementation to still live publicly until we can remove the whole chain. - For DownloadManagerUiConfig, pull out the component that reads from ChromeFeatureList and move it to a helper class to build the config from feature flags. Bug: 1025395 Change-Id: I8c36f2dcab192ff3f93aeb0ee2a99c01b568af5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919909 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735540}
-
Francois Doray authored
TBR=pbos@chromium.org Bug: 1046046 Change-Id: Ica565cd15a95ae03053bd6665b82c801da22eda5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023294Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#735539}
-
Connie Wan authored
Bug: 1043290 Change-Id: I74c497c43f6a34cb2b7c570aeaed42573ada35ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016402 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#735538}
-
Justin Gallagher authored
Adds support for moving multiple tabs to a new window from the tab context menu. Also correctly handles pinned tabs, preserving their pinned state in the new window. Since multiple tabs now can be moved, the string was changed to pluralize "tab" to "tabs" when necessary. Bug: 1036002 Change-Id: I3da4b5cd527a35134d5b0dbc7d64e01817078251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020525 Commit-Queue: Justin Gallagher <jugallag@microsoft.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#735537}
-
dalyk authored
We will continue to run our secure DNS auto-upgrade experiment past M81, so the ability to opt-out via chrome://flags is still needed. Bug: 985589 Change-Id: I82f38a153815817a2dccfec2c697be56678ff88f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023286Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#735536}
-
Brett Kilty authored
https://chromium-review.googlesource.com/c/chromium/src/+/1949007 introduced a 100% crash on Android with GPU disabled. No fallback_modes_ are pushed and new code was added to SIGKILL the process in this case. Bug: b/147243153 (internal) Test: Local before/after device test Change-Id: I0788d9562378b5b729a40f4e71db9c3993c6885c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018245Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: Brett Kilty <brettk@google.com> Auto-Submit: Brett Kilty <brettk@google.com> Cr-Commit-Position: refs/heads/master@{#735535}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I4b06e05517f12b1155884da3bfa50165162adc34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023227Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#735534}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d93fde1cd5a5..3906f655f40c git log d93fde1cd5a5..3906f655f40c --date=short --first-parent --format='%ad %ae %s' 2020-01-27 bsheedy@chromium.org Capture screenshot in CollectDebugData Created with: gclient setdep -r src/third_party/catapult@3906f655f40c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:369490 Tbr: oysteine@google.com Change-Id: I663727d248aa2659fe2d0f1a66c083bcc3164a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023430Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735533}
-
Karan Bhatia authored
Instead of using RE2::Extract, use RE2::Replace. This is preferred because: - This is the more common variant of substitutions. E.g. Javascript replace also does this. - With this change, it would be easier to add global replace later if need be by adding a single key to the Redirect dictionary. BUG=974391 Change-Id: Id1b3bf2fe9d21b3aa75e5215b1abaa6450d70979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021164 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#735532}
-
Taylor Bergquist authored
Bug: 1043376 Change-Id: I66f0b8e85dcfa0b1d7bd8bf5b2728993edc156f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017665Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#735531}
-
kylechar authored
Windows SkiaRenderer was crashing on resize while tab casting. Display::DisableSwapUntilResize() was setting size of 0x0. This stopped the display from calling SwapBuffers() and usually stopped it from drawing. However, if there were CopyOutputRequests then the display would still draw and SkiaOutputSurfaceImpl::Reshape() would be called with 0x0 size. This CL changes Display::DrawAndSwap() to always skip drawing after when DisableSwapUntilResize() is called. This will probably make casting a bit jankier while resizing, since we'll drop CopyOutputRequests, but would make resize smoother since we're doing less work. Bug: 1042007 Change-Id: I2d543a1d0fe58e974e706dd24efd5c5fd0b5c64f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011130 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#735530}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/28a9b122f5a5..f68213fc4db3 git log 28a9b122f5a5..f68213fc4db3 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 mtklein@google.com draw whole grid 2020-01-27 fmalita@chromium.org [skottie] Cleanup: convert transform adapters to new pattern 2020-01-27 mtklein@google.com rm mtklein@chromium 2020-01-27 bsalomon@google.com Revert "Switch runtime SkSL to always sample at explicit coords" Created with: gclient setdep -r src/third_party/skia@f68213fc4db3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I8d9eac778e230ed8595651b91226526566dd42d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023429Reviewed-by:
-
Takashi Toyoshima authored
Since CrComponentsCertificateManagerV3Test.All test depends on OOR-CORS as some other WebUI tests do, we need to flip the OOR-CORS to be enabled explicitly to run the test. Bug: 1045853 Change-Id: I280af083f8660e19242dd404cba3e14855ff6c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022125 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#735528}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8fdda11ff772..f5d825ac1bb6 git log 8fdda11ff772..f5d825ac1bb6 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 pfaffe@chromium.org Add a new scope chain view for showing wasm variables. Created with: gclient setdep -r src/third_party/devtools-frontend/src@f5d825ac1bb6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042636 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia54726f1ad4562cb464f44ef054340097cf91db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022968Reviewed-by:
-
Kristi Park authored
Show the initial "Send" animation once per profile instead of once per window. Bug: 1013258 Change-Id: I2a041e597d51a1acdd3a0fdd156627c34935390f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020535Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#735526}
-
Henrique Nakashima authored
This will be used in at least two places: OmniboxSuggestion and CtrSuppression. Bug: 1022108 Change-Id: I627aae9bd0bc3c9f260371b2a4ac0ecf5f3dc992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019940Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#735525}
-
Mohammad Refaat authored
SessionRestorationBrowserAgent now observers WebStateList to monitor the changes of the active webState, once the active webState is changed, unless the new webstate is loading the session is saved. This was handled previously by two observers: - TabModelClosingWebStateObserver for changes that happen when the active webstate is closed. - TabModelSelectedWebStateObserver for changes that happen when the active webstate is changed from one to another. But it seems that we don't need two observers, we only need to observe didChangeActiveWebState as it's also called when the active webState detached. and the webStateList is locked after that happens so saving the session at that point is the same as saving it on WillCloseWebState. With that in place, TabModelSelectedWebStateObserver is not needed anymore so it's deleted. Also Changed TabModelClosingWebStateObserver to be ClosingWebStateObserver as it has nothing to do with tabmodel. Updated its initializer and usages. And in a later iteration i'll try to find a place to move the functionalities that it does to other places. (right now it handles tabRestoration and snapshot removal). Bug: 1045142, 1010164 Change-Id: I27ef8bf027ebb641230b56aecdc599acf807c1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018147 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#735524}
-
Tomasz Wiszkowski authored
Synced with jpor@ to learn why these colors are different and what these should be. Apparently these colors are intended to be the "disabled" color values, which was not immediately obvious. Bug: 1028397 Change-Id: I20a0f8b9fe3f23dcaf9335961ec89ed411f2caad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021330 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#735523}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/7763c888e0c0..4254ecaa075e $ git log 7763c888e..4254ecaa0 --date=short --no-merges --format='%ad %ae %s' 2020-01-26 marpan vp9-rtc: Fix condition in regulate_q for cyclic_refresh 2020-01-26 marpan vp9-svc: Fix to resetting rc flags on change_config 2020-01-17 chengchen Store frame partition info 2020-01-22 marpan vp9-rtc: Lower threshold for color sensitivity for screen 2020-01-17 jzern vpx_timestamp,gcd: assert params are positive Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I8c0282572308a1db8d049f2506434446181f1ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023185Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#735522}
-
Sasha McIntosh authored
Allow overdraw tracing even when no stencil buffer is present. This allows overdraw tracing to be enabled anytime ARB_occlusion_query is available. This change impacts the value viz.overdraw metrics when there is 5x overdraw or more. Previously, 4x or more overdraw was always measured as 4 times the overdraw area. eg. the maximum value is 4x the surface area. We now measure the total pixels drawn which can exceed this value. Change-Id: Ide261ddf8f08c3a66fb143bbe8cf1ef33f450d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015588 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#735521}
-
Joe Downing authored
TBR: mseaborn@chromium.org Bug: 1046044 Change-Id: I65fef5989be8ee468d67bee7c48887ed56af6e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023228Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#735520}
-
Maksim Ivanov authored
Trigger the a11y alert that reads the "Couldn’t recognize your smart card" message when the challenge-response login (a.k.a. smart card login) fails. Bug: 1004449 Test: add a smart card user onto Chromebook, remove the smart card, enable screen reader, click "Start" ("->"), check that "Couldn’t recognize your smart card" is read Change-Id: Iea19f5d8a3dd00adb1729d4c32879e1d3678890a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022952Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#735519}
-
Daniel Rubery authored
This CL adds the histogram SBClientPhishing.ClassifierNotReadyReason which records the model status whenever the classification fails because the model is not ready. This can be used to distinguish between the model not being ready due to a cold start (the model isn't fetched until a short delay after startup) and the model not being ready due to fetch failures. Change-Id: Ie131f8ef20e7b407631f1ab57033f902e176d186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016355Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#735518}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0aa48cc1dec7..1248b8ef4a7b git log 0aa48cc1dec7..1248b8ef4a7b --date=short --first-parent --format='%ad %ae %s' 2020-01-27 pkasting@chromium.org Fix a python invocation that wasn't replaced with vpython. Created with: gclient setdep -r src/third_party/depot_tools@1248b8ef4a7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ice80ffc245f2646e4e6b3971b6515bb2072f9608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023207Reviewed-by:
-
Albert J. Wong authored
Bug: none Change-Id: Iea9f7ed62af0dc08b18f0d8f6cce61547c64ee44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023351 Auto-Submit: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#735516}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c9cbb2b2c66b..3a053d8d7edc Created with: gclient setdep -r src-internal@3a053d8d7edc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1010717,chromium:1044158 Tbr: jbudorick@google.com Change-Id: Ifefa056b76dab72a57c7c6936bf99d964cb89c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023206Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735515}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8ec76b32. With Chromium commits locally applied on WPT: d020e0b0 "Use assert_precondition on LayoutInstability and EventTiming" 584db3f5 "Implement onremove event for web animations." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I54f18f735da7b4175e3d751b5547f4de236bfbf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021347Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735514}
-
sczs authored
Bug: 916160 Change-Id: I5e09837a97b4f8f00df18bfdf89c994f842fc69c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008150 Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#735513}
-
Austin Orion authored
These tests open a new tab and immediately navigate to a different URL. The problem is that chrome::AddTabAt by default opens the new tab to the NTP, which takes a considerable amount of time to load. By specifying that the new tab should open to the about:blank page instead of the NTP I observed a decrease in execution time of up to 4 seconds for some of these tests. Change-Id: Ife413d2d102610012ff509a712fbfb39314d0f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019805Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Austin Orion <auorion@microsoft.com> Cr-Commit-Position: refs/heads/master@{#735512}
-
Sigurdur Asgeirsson authored
Also CHECK on the result of setting the quota on the message pipe, as well as on the set quota on query. Bug: 1011441 Change-Id: If256de260ede9613b84296cc8edc0277bfba57ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022926 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#735511}
-
David Van Cleve authored
This is a partial revert of r715320, which changed URLPattern::MatchesURL to decline to match all invalid (!GURL::is_valid) URLs. This was an inadvertent behavior change; it wasn't clear what the intended behavior was in this case. Reverting this seems to resolve crbug.com/1041880, a bug involving some PDF loads from blob: URLs getting stuck as gray boxes. While r715320 was originally made to resolve a crash---namely, MatchesURL would crash on URLs with empty paths---the follow-up commit r718423 adds logic that will still suffice to prevent this crash (this is tested by ExtensionURLPatternTest.WildcardMatchesPathlessUrl and ExtensionURLPatternTest.NonwildcardDoesntMatchPathlessUrl). Changes: - URLPattern: revert the behavior change and update documentation to reflect that intended behavior is actually to allow the wildcard '<all_urls>' pattern to match invalid URLs - URLPattern tests: update to reflect the intended new behavior Bug: 1041880 R=devlin Change-Id: I4f4571c70d0f0dbd7b52cdadbf96a7ea6854cfe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022251Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#735510}
-
Joe Downing authored
This reverts commit 9da458ed. Reason for revert: Appears to have caused a buildbreak on win-archive-rel bot: https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/10166 Original change's description: > Manually roll src/third_party/perfetto 0dace75a3e64..08a30f8552a1 (8 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/0dace75a3e64..08a30f8552a1 > > git log 0dace75a3e64..08a30f8552a1 --date=short --first-parent --format='%ad %ae %s' > 2020-01-27 eseckler@google.com Merge "build: add src/tracing/ipc/service to Chrome's libperfetto" > 2020-01-27 treehugger-gerrit@google.com Merge "traced_perf: re-enable linux build + add x86 regs handling" > 2020-01-27 fmayer@google.com Merge "Fix StackProfileTracker for empty callstack." > 2020-01-27 primiano@google.com Speculatively fix chromium roll > 2020-01-27 primiano@google.com Roll clang, libcxx and fuzzer > 2020-01-27 primiano@google.com Update GN and mass reformat gn files > 2020-01-27 primiano@google.com Merge "GN: clean up build files, split ipc client/service" > 2020-01-27 taylori@google.com Merge "perfetto-ui: Fix canvas limit px" > > Created with: > gclient setdep -r src/third_party/perfetto@08a30f8552a1 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: None > Change-Id: Ib610f52351d8b97a7a9f80f7c492e5a67b060c55 > Tbr: perfetto-bugs@google.com > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022646 > Reviewed-by: Primiano Tucci <primiano@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Commit-Queue: Primiano Tucci <primiano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735490} TBR=primiano@chromium.org,eseckler@chromium.org Change-Id: I8de9e0549e3b7d6b22854e0e9da865a6145ea31c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023230Reviewed-by:
-
Kevin Marshall authored
Removes chromium.far from CIPD distribution, now the downstream consumers have fully migrated to using "web_engine.far" instead. TBR=sergeyu@chromium.org Bug: 1029180 Change-Id: I2f80b641e20b7c06ec17ea7de27501d3a4eb1012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008273Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#735508}
-
sczs authored
It now uses the same approach as the Settings back button per http://crrev.com/c/2006260 Bug: 1034183 Change-Id: I74661463921132db2756b916bed74d6384ca0215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020621 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#735507}
-
David Tseng authored
Originally applied in https://chromium-review.googlesource.com/c/chromium/src/+/1996132 Change-Id: I236a50a6a4592f280cc898bc5702b6b3d44b4f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022361Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#735506}
-
Devlin Cronin authored
Browser Action API tests exercise a fair amount of the "general" behavior of the extensions menu, so it's good to have extra coverage. Parameterize them (further) to run with and without the extensions menu turned on. Bug: None Change-Id: I827a4ca4a66b4df185698a0fe68a71d80b28efac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020610Reviewed-by:
-
Andrew Grieve authored
Bug: 726475 Change-Id: Ia9068d24655c3cff62faeaf6eec7815fec4fdba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967792Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#735504}
-
Natalie Chouinard authored
Extend SettingsActivity action bar shadow to ListFragments as well. Currently, this is only used by the Search Engine Settings screen. Manual test of new UI: https://screenshot.googleplex.com/original/HLC5cp01rKb.png Fixed: 988877 Change-Id: Iabc971dbbe19e11db83818d6c937a798ce8d494f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021333Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#735503}
-
Francois Doray authored
R=mseaborn@chromium.org TBR=mseaborn@chromium.org Bug: 1046033 Change-Id: Idc13f4bf1fc4417c5deba549129ff5b8c903ecfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023268Reviewed-by:
-
