GitLab

OverlayStrategyFullscreen used to promote a quad to an overlay
finding a suitable quad, removing it from the quad_list and
pushing the overlay candidate to the list of overlay candidates.

This behavior was relying on ozone optimization that would
replace the primary plane if there were a fullscreen overlay
on top of it.

This CLs changes OverlayStrategyFullscreen behavior making it more
aggressive.
Once a quad that can be promoted is found, quad_list is erased since
all the quads are either not visible, or covered by the fullscreen
overlay, or the fullscreen overlay itself.

It also clear the overlay_list, that contains the primary buffer,
since the promoted overlay will be replacing it, in this way
we stop relying on the ozone optimization.

BUG=b/29430506
TEST=cc_unittests --gtest_filter="*FullscreenOverlayTest*", also tried it on minnie.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2281033003
Cr-Commit-Position: refs/heads/master@{#414830}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/470a9e84e35b..1af2c16ca8ae

$ git log 470a9e84e..1af2c16ca --date=short --no-merges --format='%ad %ae %s'
2016-08-26 chiniforooshan Update stale links in the Telemetry doc
2016-08-26 eakuefner [Catapult] Add catapult_base/catapult_base/node_modules to .gitignore
2016-08-26 benjhayden Modernize DiagnosticMap to subclass ES6 Map.

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2282063003
Cr-Commit-Position: refs/heads/master@{#414829}

This is a prepartory CL to bring compositor_frame.typemap to Blink. There is no
change in behavior except the include paths for compositor_frame.h is trimmed.

Currently, compositor_frame.h indirectly include base/trace_event/trace_event.h
via latency_info.h and resource_format.h (Note that resource_format.h indirectly
include trace_event.h via gpu_memory_buffer.h). Once the compositor_frame.h is
brought to Blink mojom file (which I'm going to do in future CLs), the
trace_event.h will have conflicting macro definition with
third_party/WebKit/Source/platform/TraceEvent.h.

By analyzing latency_info.h and resource_format.h, I find that the trace_event.h
was previously over-included. Therefore, I shifted the problematic included
file from these two header files to their respective cc files. All the rest of
changes in this CL are just results due to this shift to make Chrome compiled.

BUG=629566
TBR=dtrainor@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2273193002
Cr-Commit-Position: refs/heads/master@{#414828}

These methods have been marked with DISABLE_CFI_PERF
attribute in https://codereview.chromium.org/2258003002/
and don't need to be double-listed.

Also, fix a couple of patterns with double star.

BUG=641343,641536

Review-Url: https://codereview.chromium.org/2282753003
Cr-Commit-Position: refs/heads/master@{#414827}

EphemeralRange is supposed to operate on the same version of the tree
it was created. Unfortunately, the updateStyleAndLayout call in
plainText was causing a DOM mutation in some cases, thus
invalidating the range. Let's not do that.

BUG=639728
R=esprehn

Review-Url: https://codereview.chromium.org/2272793002
Cr-Commit-Position: refs/heads/master@{#414826}

The Mac IxD doesn't use them. Instead, buttons have a separate pressed state which is defined in the Harmony spec.

BUG=640032

Review-Url: https://codereview.chromium.org/2270933002
Cr-Commit-Position: refs/heads/master@{#414825}

Sheriffs and general bug fixers often find this logspam confusing,
thinking it relevant to the problem at hand. However it's rare that the
actual perpetrator sees it when adding the problem. So keep the blocking
behaviour, but remove the log.

R=thakis@chromium.org
BUG=258201

Review-Url: https://codereview.chromium.org/2286943002
Cr-Commit-Position: refs/heads/master@{#414824}

There is one blocking bug that prevents this from being added, but this addresses the other issues.

Aura and Ash hit a "gn check" worst-case which requires lots of //nogncheck annotations.

This also separates out browser.h includes into !OS_ANDROID blocks (previously these includes were unconditional but "Browser" doesn't exist on Android).

R=sky
TBR=dbeam for webui/*

Review-Url: https://codereview.chromium.org/2272173002
Cr-Commit-Position: refs/heads/master@{#414823}

This makes sure we have a placeholder bitmap when we resume
and don't have a frame from the renderer yet.

BUG=636630

Review-Url: https://codereview.chromium.org/2186453004
Cr-Commit-Position: refs/heads/master@{#414822}

InputConnection#getSelectedText() should return null when the selection
is empty. ThreadedInputConnection was not doing this correctly, and confused
some OEM keyboards.

BUG=638201

Review-Url: https://codereview.chromium.org/2279293002
Cr-Commit-Position: refs/heads/master@{#414821}

Reland of move content::NotificationPermissionDispatcher. (patchset #1 id:1 of https://codereview.chromium.org/2258673002/ )

Reason for revert:
Fixed the leak by adding a connection error handler that resets m_permissionService, breaking the circular reference between NotificationManager and pending Mojo callbacks.

Original issue's description:
> Revert of Remove content::NotificationPermissionDispatcher. (patchset #5 id:80001 of https://codereview.chromium.org/2244913002/ )
>
> Reason for revert:
> Causing failure on Builder WebKit Linux Leak
>
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/22036
>
> request-permission-detached-context.html
>
> 15:25:46.371 7635 worker/0 http/tests/notifications/request-permission-detached-context.html leaked
> 15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
> 15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
> 15:25:46.374 17565 [4/95] http/tests/notifications/request-permission-detached-context.html failed unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]}))
> 15:25:46.372 7635 worker/0 http/tests/notifications/request-permission-detached-context.html failed:
> 15:25:46.372 7635 worker/0  leak detected: ({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]})
>
> Original issue's description:
> > Remove content::NotificationPermissionDispatcher.
> >
> > blink::Notification can make calls to the Mojo PermissionService itself.
> >
> > BUG=561879
> >
> > Committed: https://crrev.com/be876eec511985fc0f476628b7b43dc951bd04c5
> > Cr-Commit-Position: refs/heads/master@{#412636}
>
> TBR=esprehn@chromium.org,haraken@chromium.org,johnme@chromium.org,mvanouwerkerk@chromium.org,peter@chromium.org,reillyg@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=561879
>
> Committed: https://crrev.com/5241216894d534ab30c763375a78ad68e0d155db
> Cr-Commit-Position: refs/heads/master@{#412678}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=561879

Review-Url: https://codereview.chromium.org/2258353002
Cr-Commit-Position: refs/heads/master@{#414820}

Revert "Revert of Updates the IME list when the IME has refreshed. (patchset #7 id:120001 of https://codereview.chromium.org/2271483003/ )"

This reverts commit 70178552.

Reland the cl https://codereview.chromium.org/2271483003/ and fix the crash in test. It's caused by double deleting the tray bubble view when shutting down test/os without closing the IME menu bubble, which should not happen in real production.

Fix the underlying crash problem and add new test:
ImeMenuTrayTest.QuitChromeWithMenuOpen
to cover it.

BUG=640432
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2277753006
Cr-Commit-Position: refs/heads/master@{#414819}

Revert of Let PowerSaveBlocker manager anchor view in Java side (patchset #3 id:40001 of https://codereview.chromium.org/2259493005/ )

Reason for revert:
not needed. doesn't fix the regression.

Original issue's description:
> Let PowerSaveBlocker manager anchor view in Java side
>
> This reduces the number of native-to-Java calls by one
> with a view to mitigating the benchmark test regression
> introduced with https://crrev.com/2103243002.
> PowerSaveBlocker was the only class that created an anchor
> view during the test. Though the root cause not being
> entirely clear yet, having the view created on Java side
> can possibly help decrease the browser thread cpu consumption.
>
> BUG=635515
> TBR=tedchoc@chromium.org
>
> Committed: https://crrev.com/bc403d8872340a62c310c9665e3b3972344c8c5b
> Cr-Commit-Position: refs/heads/master@{#413900}

TBR=twellington@chromium.org,boliu@chromium.org,tedchoc@chromium.org,jinsukkim@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=635515
NOTRY=True

Review-Url: https://codereview.chromium.org/2279313005
Cr-Commit-Position: refs/heads/master@{#414818}

This file is no longer used, and even when it was (at least recently) wasn't placed in a git-controlled directory.

Review-Url: https://codereview.chromium.org/2287693002
Cr-Commit-Position: refs/heads/master@{#414817}

The Object used to store the listeners before does not support iteration
over Symbol keys.

BUG=641468

Review-Url: https://codereview.chromium.org/2284663003
Cr-Commit-Position: refs/heads/master@{#414816}

The observer is notified every time there is a change in the
cached network quality. In the later CLs, one such observer
would be created per-profile. On receiving the notification,
it would write the network id and the cached network quality
(both are included in the notification) to the prefs.

BUG=490870

Review-Url: https://codereview.chromium.org/2261813002
Cr-Commit-Position: refs/heads/master@{#414815}

In blink, we convert the string position to root frame and then convert to
AppKit coordinates by inverting y-axis. To do so, we must always use
FrameView::height() of the root frame rather than that of the
LocalFrame.

BUG=640353

Review-Url: https://codereview.chromium.org/2275323003
Cr-Commit-Position: refs/heads/master@{#414814}

BUG=640116

Review-Url: https://codereview.chromium.org/2268193002
Cr-Commit-Position: refs/heads/master@{#414813}

BUG=638630
TEST=mus_ws_unittests events_unittests blink_converters_unittests
     ash_unittests views_mus_unittests

Review-Url: https://codereview.chromium.org/2256343003
Cr-Commit-Position: refs/heads/master@{#414812}

Remove password_reveal_duration_ member in Textfield and always
gets it from ViewsDelegate.

BUG=634472
TEST=TextfieldTest.SetPasswordRevealDuration

Review-Url: https://codereview.chromium.org/2286433002
Cr-Commit-Position: refs/heads/master@{#414811}

//services/ui/surfaces code runs in the window-server, and so should not
directly use code in //services/ui/gpu, which should run in the gpu
process.

BUG=613366

Review-Url: https://codereview.chromium.org/2280723004
Cr-Commit-Position: refs/heads/master@{#414810}

Allows BindingSet<T>::AddBinding to associate an arbitrary
|context| value with a new binding when added. The set's
dispatch_context() accessor will return this value during
the extent of any message or error dispatch targeting
that specific binding.

Refactors BindingSet to simplify lifetime management
and allow it to be reused for associated bindings as well.

Also implements AddFilter for master interface bindings on
interface types which support associated interfaces, as this
was accidentally omitted when AddFilter was introduced.

BUG=612500
R=yzshen@chromium.org

Review-Url: https://codereview.chromium.org/2283543002
Cr-Commit-Position: refs/heads/master@{#414809}

Folds the following helper functions:

  applyCSSPropertyToTargetAndInstances
  removeCSSPropertyFromTargetAndInstances
  notifyTargetAndInstancesAboutAnimValChange

into their users, hoisting common predicates and simplifies
accordingly.

BUG=640676

Review-Url: https://codereview.chromium.org/2285473002
Cr-Commit-Position: refs/heads/master@{#414808}

* Remove timestamp tracking from X11DesktopHandler
* Track focus state in DWTHX11. Inspired by gtk/docs/focus_tracking.txt
  Hopefully this will fix most Linux-aura focus related bugs

BUG=635169,635177

Review-Url: https://codereview.chromium.org/2165083002
Cr-Commit-Position: refs/heads/master@{#414807}

When deciding if HTMLCanvasElement should be accelerated we changed
the code to get the shared main thread context before making the
decision because it's part of the decision. However, for most of the
things we decide on (such as are-we-using-display-list-canvas) we
don't care about the context. We only care once we decide we do want
to use it, then verify it's not using swiftshader.

So, defer getting/creating the shared main thread context until we
know we want to accelerate, then just fail to accelerate if swiftshader.

To make this logic more clear, I split the createImageBufferSurface()
method into createAcceleratedImageBufferSurface() and
createSoftwareImageBufferSurface() which is used if the former
fails/returns null. There is less nesting now so hopefully that's nice.

With this the memory.blink_memory_mobile's TheVerge case goes from
6422Kb of gpu memory back down to 4324Kb.

R=junov@chromium.org, kbr@chromium.org
BUG=640811,606056

Review-Url: https://codereview.chromium.org/2280723003
Cr-Commit-Position: refs/heads/master@{#414806}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/90d4177d32d5c0ee899f50fc431ad9cc2f1b25d9 Delete all references to GIT_MODE=True from build (agable@chromium.org)
  https://crrev.com/76d5c79ed794fe690650978678171b28027c8af8 Add dtu to recipe_modules/auto_biect OWNERS. (dtu@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=640251

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2286913002
Cr-Commit-Position: refs/heads/master@{#414805}

Settings are sometimes difficult to get access to, depend on the context.
Also we don't find any use cases to applying different rootLayerScrolls value
to individual frames. Migrating to RuntimeEnabledFeatures to simplify code.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2258523006
Cr-Commit-Position: refs/heads/master@{#414804}

Revert of IME for Mus: Make InputMethodMus use the IME Mojo API. (patchset #16 id:300001 of https://codereview.chromium.org/2230393002/ )

Reason for revert:
All text input appears to be broken in chrome on mash, and I bisected to this patch. Reverting locally appears to fix this.

Original issue's description:
> IME for Mus: Make InputMethodMus use the IME Mojo API.
>
> This CL:
> * Uses Mus' IMEServer to do the IME logic in InputMethodMus.
> * Adds unittests to test InputMethodMus.
> * Starts test_ime_driver on mus+ash session startup.
> * Modifies test_ime_driver to not-handle non character events.
>
> BUG=548407
>
> Committed: https://crrev.com/aa4f90ab72b60fd90e048b1e18193c30f0462d77
> Cr-Commit-Position: refs/heads/master@{#414748}

TBR=sadrul@chromium.org,sky@chromium.org,tsepez@chromium.org,moshayedi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=548407

Review-Url: https://codereview.chromium.org/2284003002
Cr-Commit-Position: refs/heads/master@{#414803}

- Remove unused includes.
- Use auto and nullptr.
- Simplify code.

Review-Url: https://codereview.chromium.org/2272933002
Cr-Commit-Position: refs/heads/master@{#414802}

TBR=schenney@chromium.org
NOTRY=true
BUG=641398

Review-Url: https://codereview.chromium.org/2279263003
Cr-Commit-Position: refs/heads/master@{#414801}

The existing MediaSession::Type does not work well for
Pepper&WebRTC. Spliting MediaContentType for MediaPlayer and
AudioFocusType for MediaSession to gain more control of audio focus.

Explainer for this CL:
https://docs.google.com/a/google.com/document/d/1W4uRH8Wvgau0_GtMda4EOSXRtxFuFLhb9W77sJagJpI/edit?usp=sharing

BUG=626351

Review-Url: https://codereview.chromium.org/1996043002
Cr-Commit-Position: refs/heads/master@{#414800}

The implementation is not async yet. I will add the state machine in a second
CL.

R=ikilpatrick@chromium.org,eae@chromium.org
BUG=635619

Review-Url: https://codereview.chromium.org/2281153002
Cr-Commit-Position: refs/heads/master@{#414799}

The tray separator has an opacity of 0.24 and it looks too dim when the
shelf is completely opaque. Update the tray separator's opacity to 0.3.

BUG=641453

Review-Url: https://codereview.chromium.org/2281173002
Cr-Commit-Position: refs/heads/master@{#414798}

This change provides the client-side classes needed to receive and send
geolocation messages. GeolocationFeature sends messages from the client
that either contain a geolocation coordinate or error message. The
GeolocationFeature class handles incoming GeoloationSetInterestLevelMessages
and RequestRefreshMessages.

Other items included:
* Changes device/geolocation/mock_location_provider to use fake_location_provider name
* Moves blimp/client/feature/mock_location_provider into device/geolocation.

BUG=614486

Review-Url: https://codereview.chromium.org/2161223003
Cr-Commit-Position: refs/heads/master@{#414797}

Work on making RootScrollerController work across iframes revealed that there's
two responsibilities that need management. All frames need a
RootScrollerController to manage the Element currently set as root scroller and
determine which Element should eventually become the effective root scroller.
In addition, we need the RootScrollerController to manage the
ViewportApplyScroll and set it on the appropriate element. Since only one
Element on the whole page needs this callback set, it makes sense that only the
top document should have this responsibility. Experience with classes like
FrameView and EventHandler shows that this may be better served by subclassing
the top level object rather than having isMainFrame() checks intermingled with
the other code.

BUG=505516

Review-Url: https://codereview.chromium.org/2280453002
Cr-Commit-Position: refs/heads/master@{#414796}

This change detects when we can paint the background onto the scrolling contents layer. This will unblock promoting scrollers with supported backgrounds on low DPI devices as we can now maintain subpixel antialiased text.

BUG=381840,568847
TEST=compositing/overflow/overflow-scroll-with-local-image-background.html, LayoutBoxTest.BackgroundRect, CompositedLayerMappingTest.ShouldPaintBackgroundOntoScrollingContentsLayer
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2068723002
Cr-Commit-Position: refs/heads/master@{#414795}

BUG=568415

Review-Url: https://codereview.chromium.org/2272053002
Cr-Commit-Position: refs/heads/master@{#414794}

BUG=

Review-Url: https://codereview.chromium.org/2275113003
Cr-Commit-Position: refs/heads/master@{#414793}

Use base::Bind and content::BrowserThread::PostTaskAndReplyWithResults()
instead of custom function pointer based callbacks.

Review-Url: https://codereview.chromium.org/2283823003
Cr-Commit-Position: refs/heads/master@{#414792}

Menu should use the new browser tools error icon.

BUG=630354

Review-Url: https://codereview.chromium.org/2280033003
Cr-Commit-Position: refs/heads/master@{#414791}