- 25 Sep, 2018 40 commits
-
-
Matthew Jones authored
Touch-dismissal is too quick for the feature, this patch adds a 6 second timeout instead. Bug: 888697 Change-Id: I5c3ca03435c634bd93f6255bc9af7b12abe89451 Reviewed-on: https://chromium-review.googlesource.com/1241136 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#593972}
-
Tarun Bansal authored
Check for root document URL in blink before sending anchor element metrics to the browser process. This check makes it consistent with the check in the browser process which verifies the properties of the root document URL. Additionally, navigation predictor is currently used only for metrics recording, it's safe to temporarily return on receiving a bad message instead of crashing the renderer. Bug: 879999 Change-Id: I881ed1079693c4a4952203a59c74980685069606 Reviewed-on: https://chromium-review.googlesource.com/1236469Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#593971}
-
Alex Clarke authored
Relanding https://chromium-review.googlesource.com/c/chromium/src/+/1238468 The fix can be seen in the delta between patch set 1 and 2. Original patch description: Make Chrome_DevToolsADBThread shutdown gracefully in tests To land the BrowserUIThreadScheduler we need in tests for all threads to stop using base::PostTaskWithTraits before the scheduler is deleted. Currently this is true for the UI and IO threads but it's not true for Chrome_DevToolsADBThread. This patch makes sure references retaining AndroidDeviceManager::HandlerThread are released in tests which triggers thread shutdown, fixing the problem. TBR=dgozman@chromium.org,finnur@chromium.org,mlamouri@chromium.org Bug: 863341, 872372, 888994 Change-Id: Ie9298d652cad2df6ad93d19cfb3dd5b76fdcf339 Reviewed-on: https://chromium-review.googlesource.com/1243115Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#593970}
-
Chris Hamilton authored
This will be used to determine if a tab is unsafe to discard due to a beforeunload handler that returns a non-empty string. BUG=877550 Change-Id: Ib0f9c11fbf74ca6a49c23c6b5866dde5faa2885f Reviewed-on: https://chromium-review.googlesource.com/1231739 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#593969}
-
Mikel Astiz authored
A datatype should be allowed to resolve conflicts in a way that deletions are preferred. None of the USS datatypes has done this until now, but we're experimenting with EXTENSIONS being integrated, and we do have such a policy for EXTENSIONS. Bug: 870624 Change-Id: Ib8869e4f31050def316d94161b7ea02a2dbd09a1 Reviewed-on: https://chromium-review.googlesource.com/1243185Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#593968}
-
Chris Lu authored
Late addition to the docs: https://github.com/material-components/material-components-ios/tree/develop/components/AppBar#migration-guide-mdcappbar-to-mdcappbarviewcontroller Bug: 874471 Change-Id: Ia60758a2594130d46918cee61d87fed38ead55d6 Reviewed-on: https://chromium-review.googlesource.com/1239534Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#593967}
-
Dmitry Gozman authored
When navigation to "about:blank" gets a new render process, we get site instance url equal to "about:". In this case our standard check for url permission fails. Usually about:blank does not go to a separate process, but there are some rare cases: - navigating away from isolated error page forces a new site instance; - navigating after crash creates a new renderer, since there is no existing one to reuse. Bug: 882589 Change-Id: I076ab544ca2360e7e4c13b58475c08e0be627593 Reviewed-on: https://chromium-review.googlesource.com/1240865Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#593966}
-
Danyao Wang authored
These tests currently assume that the repost confirmation dialog is shown on back/forward navigation. This is not true for WKBasedNavigationManager because it matches WKWebView behavior, which uses back/forward cache for back/forward navigation. This CL adds |reload| to explicitly trigger the repost confirmation dialog. Bug: 874635 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I24dafdd02014184f3fbc5b86f1026ebe8f5f00c7 Reviewed-on: https://chromium-review.googlesource.com/1243323 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#593965}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9def3b45ef06..f3119ef66d5c git log 9def3b45ef06..f3119ef66d5c --date=short --no-merges --format='%ad %ae %s' 2018-09-25 danilchap@webrtc.org Add generic frame descriptor to list of supported video extensions 2018-09-25 philipel@webrtc.org Use the generic descriptor information in the RtpFrameReferenceFinder. 2018-09-25 kron@webrtc.org Revert "Second reland of "Optimize execution time of RTPSender::UpdateDelayStatistics"" 2018-09-25 sakal@webrtc.org Disable AudioDeviceTest on thread sanitizer. 2018-09-25 danilchap@webrtc.org Support first packet reduction in H264 packetizer 2018-09-25 oprypin@webrtc.org Reland "Use new internal trybot in commit queue" Created with: gclient setdep -r src/third_party/webrtc@f3119ef66d5c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib77c53c8e722fddfab62637fd3e6b5cdddef43b0 Reviewed-on: https://chromium-review.googlesource.com/1242604Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593964}
-
Jongheon Kim authored
This patch changes the data type of video and audio decode counts in the IDL Bug: 887593 Change-Id: Ib988825d6db4eb7b1d18a3d2b5d2b4c2b791e882 Reviewed-on: https://chromium-review.googlesource.com/1240573Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#593963}
-
Eric Aleshire authored
I've been testing the iOS Autofill code against uwyiming@'s saved recipes and replays (in //src/chrome/test/data/autofill/captured_sites/), and found a few bits of profile information that I didn't set, so I went and added them in this minor change. This includes a credit card profile. Additionally, I change the profile data to match the data expected in uwyiming@'s recipes, since currently the profile data is hardcoded (instead of being included with the recipes). Bug: 881096 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ia24bb7e2b2cde8d5cab7c6623aa34d12b3ad9c1c Reviewed-on: https://chromium-review.googlesource.com/1240317Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#593962}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8aa858e5..c5a1fcbf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iedc6a2b929fb712a3bc975df3f03547d6f8a74e3 Reviewed-on: https://chromium-review.googlesource.com/1243363Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593961}
-
Kyle Milka authored
Previously the local image copy was stored in the user data directory meaning that all profiles shared a single image. Instead each profile should have a separate copy. Bug: 888076 Change-Id: I91c052fa7d440b1adeb5d98cd8bfc35a37d976aa Reviewed-on: https://chromium-review.googlesource.com/1239456 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#593960}
-
Mikel Astiz authored
The patch introduces a dedicated KeyedService that owns all relevant objects for syncing SESSIONS, FAVICON_IMAGES and FAVICON_TRACKING. This prevents some cyclic dependencies and makes sessions more similar to regular datatypes, owned by some service outside ProfileSyncService. The change allows simplifications in ProfileSyncService at the expense of the usual boilerplate with KeyedService factories. Bug: 883199 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I662dc5a55dc3e7aaae2f0acace3b7895fa7affc8 Reviewed-on: https://chromium-review.googlesource.com/1221126Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#593959}
-
manuk authored
Change-Id: Ie677436c9456cd096f3961e2e278f16e155490d9 Reviewed-on: https://chromium-review.googlesource.com/1241570Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#593958}
-
Mohamed Amir Yosef authored
Bug: 518688 Change-Id: I85ef75959e6a5310e15a4d098a0f02d79dcc3c54 Reviewed-on: https://chromium-review.googlesource.com/1243306 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#593957}
-
Etienne Pierre-Doray authored
This CL defines "blocking call" in scoped_blocking_call.h and mentions that ScopedBlockingCall serves as annotation for the TaskScheduler. Bug: 874080 Change-Id: Id85a42eb4750620b26c587adf5a43f471ea1168c Reviewed-on: https://chromium-review.googlesource.com/1236459Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#593956}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d96388423295..2e5a2964784b git log d96388423295..2e5a2964784b --date=short --no-merges --format='%ad %ae %s' 2018-09-25 treehugger-gerrit@google.com Merge "Make watchdog_noop inline to fix Mac build" Created with: gclient setdep -r src/third_party/perfetto@2e5a2964784b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ie240d0040e2f04c745fc4dd042f7e359f9715ff4 Reviewed-on: https://chromium-review.googlesource.com/1243267Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593955}
-
Theresa authored
BUG=885331 Change-Id: I3ca310aefd43a6a2293042535d992e60ac829fcf Reviewed-on: https://chromium-review.googlesource.com/1241553Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#593954}
-
Aaron Leventhal authored
Disabling flaky tests for now. TBR=dmazzoni,sadrul Bug: 877487 Change-Id: Idd03f723315b725fc8dab7222577f33af06b156e Reviewed-on: https://chromium-review.googlesource.com/1243223Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#593953}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/646f637f4ce4..40599feeed92 git log 646f637f4ce4..40599feeed92 --date=short --no-merges --format='%ad %ae %s' 2018-09-25 csmartdalton@google.com Enable CCPR on Vulkan without geometry shaders 2018-09-25 csmartdalton@google.com ccpr: Fix heap use-after-free caused by member destruction order Created with: gclient setdep -r src/third_party/skia@40599feeed92 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: I9be63279d2dcb13383e317fa084498a3f5989664 Reviewed-on: https://chromium-review.googlesource.com/1243265Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593952}
-
Mark Cogan authored
This CL removes the BVC presentation flag (it is now on by default) and factors out all conditional logic around it, deleting unused classes. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ia593e84d6a72796732d7183c7c29ba1a4873240b Reviewed-on: https://chromium-review.googlesource.com/1243064 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#593951}
-
François Beaufort authored
Now that SetAspectRatio is implemented everywhere, this CL re-enables a PictureInPictureWindowControllerBrowserTest test which was found flaky previously. Bug: 862505 Change-Id: I884a1b1ff3fe131c671c5e1a5e8142bb5e7d9a8a Reviewed-on: https://chromium-review.googlesource.com/1243083Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#593950}
-
Reza.Zakerinasab authored
This relands chromium-review.googlesource.com/c/chromium/src/+/1237140 after addressing jumbo compile failure due to repeated enum values. TBR=fserb@chromium.org Bug: 774520 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6922416b25272e29d115090fa61bc979f0317f0e Reviewed-on: https://chromium-review.googlesource.com/1243423 Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#593949}
-
Michael Lippautz authored
Bug: 843903 Change-Id: Ia6ec2f6f9b6e8e2db1fcf66122a3ede646c1f52c Reviewed-on: https://chromium-review.googlesource.com/1243129Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#593948}
-
Xi Cheng authored
Change-Id: Ifc214b2094ee91ec6d7964a5016151681804ba69 Reviewed-on: https://chromium-review.googlesource.com/1241770Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#593947}
-
Bo Liu authored
Filter operations uses extra render passes which is slower and uses more memory. Use a black SolidColorLayer with opacity to simulate brightness filter. This is mostly taken directly from PS1 of the original CL: https://codereview.chromium.org/1716653002/#ps1 Change-Id: I914e1bcd2073e7082e4d12e723549f7b73cbf1d3 Reviewed-on: https://chromium-review.googlesource.com/1242393Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#593946}
-
Javier Ernesto Flores Robles authored
This is a reland of 555dcba9 Original change's description: > [iOS][MF] Secure filling > > Observe the last focused field to validate it is secure before filling a password > > Bug: 878388 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs > Change-Id: Ide4407ea51b315c68c50fa010f256cde93f5eb26 > Reviewed-on: https://chromium-review.googlesource.com/1221217 > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593194} Bug: 878388 Change-Id: Ifc58398e280989981c9f15efd62e10224e1f999a Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1240282Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#593945}
-
Gemene Narcis authored
HttpPasswordStoreMigrator copies/moves HTTP saved credentials to HTTPS. However, signon_realm was computed wrong first time and it contained the whole URL path. https://crrev.com/c/1098967 solved this problem, but because the code already ran, PasswordStore contains some credentials that were created and have wrong signon_realm. This CL removes forms with wrong signon_realm, relying on HTTP->HTTPS migration to recreate them correctly. See https://docs.google.com/document/d/139w-K9cuCzFaqANNiEixpGLojZ2Fc6wo_q2PXgk238A/edit?usp=sharing for more details. Bug: 881731 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id20f5ecee02d6fe6d30b8692df64fb51d42d3275 Reviewed-on: https://chromium-review.googlesource.com/1186323Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Narcis Gemene <gemene@google.com> Cr-Commit-Position: refs/heads/master@{#593944}
-
Fredrik Söderquist authored
We don't want/need to call SetNeedsPaintPropertyUpdate in the TemporaryStyleScope helper. Hoist the calls to SetNeedsPaintPropertyUpdate out of AddResourcesFromLayoutObject/RemoveResourcesFromLayoutObject. Also add a new UpdateResourcesFromLayoutObject function that wraps the common Remove+Add sequence. Bug: 866487 Change-Id: I8f8a82802be0e16807e04eead0e409562ecbdb77 Reviewed-on: https://chromium-review.googlesource.com/1243244Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#593943}
-
Francois Doray authored
Instead of making every class in the graph friend of every other class in the graph, it makes more sense to expose public interfaces. Bug: 885293 Change-Id: I6fba10e6bd804b4be5c1532a201af90abb744d8b Reviewed-on: https://chromium-review.googlesource.com/1234227 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#593942}
-
Michael Lippautz authored
The code is not (yet) excluded from clusterfuzz which may call it with arbitrary arguments. Bug: 888865 Change-Id: Ie51e4ddbed51e55b2e8c15604c257ba0d37715a0 Reviewed-on: https://chromium-review.googlesource.com/1243245Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#593941}
-
Fredrik Söderquist authored
This just adds an (additional) dependency on the LayoutObject, while likely not giving much in terms of gain nowadays. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0b44312f82002d5fc5b510f9eb51b9cd0caf95a2 Reviewed-on: https://chromium-review.googlesource.com/1243303Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#593940}
-
Boris Sazonov authored
This CL changes the color of the title text in sync error card shown in 'Sync and Google services'. It is done by changing the type used by sync error card from SyncErrorCardPreference to regular Preference. The title color text is the only difference between SyncErrorCardPreference and Preference. Bug: 888938 Change-Id: I99c3646c8770acf7a297f1c0bfef0a5f00eeec04 Reviewed-on: https://chromium-review.googlesource.com/1242461Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#593939}
-
Antonio Gomes authored
URLFetcher will stop working with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. This CL migrates iOS' OpenInController. Additionally, the CL also fixes the unittest TestDisplayOpenInMenu that was flagged as DISABLED. BUG=773295 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I130b80cc7854d95266fba45b94df0caa40f89eda Reviewed-on: https://chromium-review.googlesource.com/1239373Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#593938}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4ebd8f3d9999..74c179bb9bb9 git log 4ebd8f3d9999..74c179bb9bb9 --date=short --no-merges --format='%ad %ae %s' 2018-09-25 jmadill@chromium.org Vulkan: Refresh descriptor sets on driver uniform change. Created with: gclient setdep -r src/third_party/angle@74c179bb9bb9 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I65d7be871fa789670cce85888c4865aaac2dd3f6 Reviewed-on: https://chromium-review.googlesource.com/1243264Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593937}
-
Danyao Wang authored
These tests are broken for WKBasedNavigationManager. They need to be migrated to EG test later. Also parameterize TabModelTest so both navigation manager implementations are tested on trybot. Bug: 863026 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I871eb635ef820ab97cf2c4cfbe19e30b74d28227 Reviewed-on: https://chromium-review.googlesource.com/1240868 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#593936}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bacfd87b3be2..9def3b45ef06 git log bacfd87b3be2..9def3b45ef06 --date=short --no-merges --format='%ad %ae %s' 2018-09-25 kron@webrtc.org Second reland of "Optimize execution time of RTPSender::UpdateDelayStatistics" Created with: gclient setdep -r src/third_party/webrtc@9def3b45ef06 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8ab404dff4c76fff8fd4f99562bff5b82e447703 Reviewed-on: https://chromium-review.googlesource.com/1242331Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593935}
-
Nico Weber authored
Bug: 832676 Change-Id: I4eebf5172371c2e69feef32d9fed265716992020 Reviewed-on: https://chromium-review.googlesource.com/1242136Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593934}
-
Aldo Culquicondor authored
This is the last piece necessary in the VR UI to support the command buffer. Re-enable pixeltest for Windows. Bug: 884256, 771794 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8c0a67021c859a88b0af519ace97266a142ec7d7 Reviewed-on: https://chromium-review.googlesource.com/1238816 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#593933}
-