- 17 May, 2019 40 commits
-
-
Rohit Rao authored
This defaults to NSObject, but can be set to a class that implements the XCTestObservation protocol to perform one-time setup in XCTest bundles. BUG=None Change-Id: I3ff7abbf928a16ce6626fc99ed8fd747902cc791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617623Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#660845}
-
Tim Volodine authored
Add UMA to record invocation counts for some network related callbacks: - onReceivedLoginRequest - onReceivedClientCertRequest - onReceivedHttpAuthRequest - onDownloadStart These are non-error callbacks, so there is no need to have separate histograms with error code distributions. BUG=841556,951885,945922 Change-Id: I88be3ca2dfd831b83099bdbf44ece885b9acad18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609708 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#660844}
-
Moe Ahmadi authored
Add language page allows the user to select a supported language to add to the list of user preferred languages. Existing accepts languages are excluded from the available options. screenshot: https://drive.google.com/file/d/1gV24hPwP1Gpiw_whOW45GQGmfJn_byEi/view?usp=sharing Bug: 957688 Change-Id: I63b261061cc867a1c7d5cd2373cb948eec1581f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611911Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#660843}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/18ebb45055a5..0559bc475569 git log 18ebb45055a5..0559bc475569 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 chrisforbes@google.com Check for rest of interactions between usage bits and format features Created with: gclient setdep -r src/third_party/swiftshader@0559bc475569 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/117974925 TBR=swiftshader-team+autoroll@google.com Change-Id: I6caf11421be26ab4311fc7ebe1a9cecbc92a4d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617376Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660842}
-
Mounir Lamouri authored
This is a reland of 15c84b57 Original change's description: > Media Engagement: only use/record for HTTPS origins. > > Bug: 958364 > Change-Id: Ifc87e6222df9de526f2900f13899af616604750e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591878 > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659971} Bug: 958364 Change-Id: I2e1c9741946797875fca63524260ad5d066f74cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614442 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#660841}
-
Tommy Martino authored
TBR=ellyjones@chromium.org Change-Id: Ide1f29008cd3840ec13c2252a279a76a4f5efdec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617628 Commit-Queue: Tommy Martino <tmartino@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#660840}
-
Jan Wilken Dörrie authored
This change moves Lambda capture expressions in the Allowed C++14 Features section and details their usage guidelines. Bug: NONE Change-Id: I2e1b117512ee3262f50d63c379b6d31506cfcd33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617506 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#660839}
-
Justin Cohen authored
Bug: 964323 TBR: mattm@ Change-Id: Ibd0f85b0317804869b4dbc8eee3527fd7ae89359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617626Reviewed-by:
-
kylechar authored
There is still flake in webgl2_conformance_gl_passthrough_tests on Windows Intel GPU FYI bots. Use a bigger hammer and mark all of deqp/functional/gles3/textureshadow/cube_* flaky. Bug: 963450 Change-Id: I0c1e305e591b6acbcc3768418dcad799c3f4eb99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617065Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#660837}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0c6daf034b11..e5b3e400b6e9 git log 0c6daf034b11..e5b3e400b6e9 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 8c742b26..5ca9f956 (448 commits) 2019-05-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6ddb7768fa25..06de90c66c18 (9 commits) Created with: gclient setdep -r src/third_party/skia@e5b3e400b6e9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: I7d49392fc0c917b1765667500351271338a7059e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617375Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c9178292..92b8322b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iac0d4b87103b6c56b70aad5f27f8a66405e62130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617067Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660835}
-
W. James MacLean authored
This refactor moves the logic in RenderWidget::PageScaleFactorChanged() to RenderWidget::SetPageScaleStateAndLimits(). This removes the need for RenderViewImpl::PageScaleFactorChanged() to call GetWidget(). This is a re-land of https://chromium-review.googlesource.com/c/chromium/src/+/1614080. TBR=dcheng@chromium.org TBR=collinbaker@chromium.org Bug: 924336 Change-Id: Id076ddc805c62069984181914f3722d4d081a3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617064Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#660834}
-
Justin Cohen authored
Change-Id: I399626094a700d9b8a581591c6080da8277d584f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611107Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
John Budorick authored
Follow-up to crrev.com/c/1496656 Bug: 961811 Change-Id: Id7a5e4d09e4ca966e75bcecc6f007e26553d534d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611118Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4274cc4631b0..cafd7736490e git log 4274cc4631b0..cafd7736490e --date=short --no-merges --format='%ad %ae %s' 2019-05-17 jmadill@chromium.org Fix KHR-GLES dEQP test paths. Created with: gclient setdep -r src/third_party/angle@cafd7736490e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: Ic13ed7c964a29e4227ad1241d45a709f0740314e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617268Reviewed-by:
-
Henrique Grandinetti authored
Bug: 964296 Change-Id: Ib458bbccb2fe10939a0ec43ad315f0fd6b22c134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617323Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#660830}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6ffd8ec5ef77..c05031d35df8 Created with: gclient setdep -r src-internal@c05031d35df8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: I73fc2f1438d25e425125ffe03150141ae621c63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617262Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660829}
-
A Olsen authored
Going through the SAML in-session password change flow will: a) Dismiss any existing notification that your password is expiring b) Delete the expiration time stored for your SAML password, so you will not receive any further notifications - until and unless you go through the SAML login flow again at some point and we receive an updated expiry time for your new password. Bug: 930109 Change-Id: I8561cf3425cc74ef3aa3d50a9ac604521f9fbfbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617357Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#660828}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I17c3e6872255d4282816036e1b877250b27dfecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617386Reviewed-by:
-
Alex Oldemeier authored
This adds the last part of the PluginVm setup flow. After the VM image has been downloaded we need to import it using vm_concierge. Since vm_concierge does the unzipping itself, this also refactors the setup flow and replaces unzipping by listening to the corresponding concierge signal. Follow-up CLs will add the functionality to cancel the import as well as additional tests to cover different error cases. Bug: 947014 Test: browser_tests --gtest_filter="PluginVm*" && unit_tests --gtest_filter="PluginVm*" Change-Id: If1d038ff9b0e5c9f7ca73ac7c68397620099a30d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611550Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org> Cr-Commit-Position: refs/heads/master@{#660826}
-
Min Qin authored
When Comparing UMAs for download that are resumed without the browser process, the reduced mode reports more downloads than the full mode. And that makes it hard to compare the UMAs neck to neck. If we only consider the first download that happens in the reduced mode, than this is the only download that will report UMA in full browser mode. This CL will capture the UMA for the first download in reduced mode. It allows us to compare the UMAs from full browser mode in a fair condition. BUG=963601 Change-Id: Ieb5c2dc06c985e5e2b545474a3f03a9dcbc3e165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615822Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#660825}
-
Qingsi Wang authored
Bug: None Change-Id: Idb203866343cefa751a52f25cd1084c0da2f218c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615714 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Jing Zhao authored
According to Android P API changes: https://developer.android.com/about/versions/pie/android-9.0-changes-all#information_removed_from_wi-fi_service_methods , NETWORK_STATE_CHANGED_ACTION system broadcast no longer contains connection information. With ACCESS_WIFI_STATE permission, use getConnectionInfo() instead. Change-Id: Idd0a26337e5c9861490f3ead5e559446f9b64a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600726Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Auto-Submit: jing zhao <zhaojing7@xiaomi.com> Cr-Commit-Position: refs/heads/master@{#660823}
-
Tsuyoshi Horo authored
This class is created if the page was loaded from a signed exchage which has "allowed-alt-sxg" link headers in the inner response and PrefetchedSignedExchanges were passed from the previous page. It holds the subresource signed exchange related headers ("alternate" link header in the outer response and "allowed-alt-sxg" link header in the inner response of the page's signed exchange), and the passed PrefetchedSignedExchanges. While dispatching link header preloads, LoaderFactoryForFrame::CreateURLLoader() will call PrefetchedSignedExchangeManager::MaybeCreateURLLoader() which creates a PrefetchedSignedExchangeLoader if there is a matching "allowed-alt-sxg" link header in the inner response of the page's signed exchange. After all link header preloads were dispatched, PrefetchedSignedExchangeManager ::StartLoad() is called from HTMLDocumentParser::EnqueueTokenizedChunk(). This method checks whether the all PrefetchedSignedExchangeLoaders has a matching "alternate" outer link header and a matching subresource signed exchange was already prefetched. If the check passes, starts loading the prefetched subresource signed exchange. Otherwise, starts normal loading. This check is intended to prevent the signed exchange distributor from sending arbitrary information to the publisher of the signed exchange. Bug: 935267 Change-Id: I3c27d2ad510f1622e5bb8f6e07e30623b5a92d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610273 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#660822}
-
Olya Kalitova authored
Bug: 931702 Change-Id: I3211bad5998a5ec9dd1f8ac8b69e719516e947c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617492Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#660821}
-
Ria Jiang authored
After we turn on devtools, there are highlighting overlays when we inspect elements - those overlays shouldn't be hit-testable. Change-Id: I78d297921dbdf92a3902651f05103b24c88d54cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614541Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#660820}
-
Alex Ilin authored
This reverts commit 61e00b8b. Reason for revert: this may cause crashes on Mac https://crbug.com/962462 Original change's description: > Convert NaCl crash reporting to the new shared memory API > > This CL replaces the deprecated base::SharedMemoryHandle used to hold the crash information > in nacl:: classes with new shared memory api. The plugin side writes to the shared memory > region using base::WritableSharedMemoryRegion and sends a read only version of the region > to the renderer process through the browser. The renderer side reads the crash info using > base::ReadOnlySharedMemoryRegion. > > Change-Id: I335040a9884d6dc79f107070c954a3ff250458a2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565974 > Reviewed-by: Derek Schuff <dschuff@chromium.org> > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Tanmoy Mollik <triploblastic@google.com> > Cr-Commit-Position: refs/heads/master@{#658493} TBR=dschuff@chromium.org,dcheng@chromium.org,rsesek@chromium.org,alexilin@chromium.org,triploblastic@google.com Bug: 962462 # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I29ea828b87fb11c8f3be6b6d5805b4e7cc3f0e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617490Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#660819}
-
Maya Lekova authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8e003ab0..c9178292 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel R=hablich@chromium.org Change-Id: I97d8e56a0b574f72410d94970462b3fa55506304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617350Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#660818}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fd2e487583fa..6ffd8ec5ef77 Created with: gclient setdep -r src-internal@6ffd8ec5ef77 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: Ia3fd36abd9d2e4c18c05ac44dbc410c8aac67c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617609Reviewed-by:
-
Rayan Kanso authored
Update the view's button instead of the action, since the action is shared across multiple views. Bug: 942174 Change-Id: I02c04486779591791b24567002bc14e08324babd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609707Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#660816}
-
Maksim Ivanov authored
Avoid causing an error log message from the ARC ToS screen: [ERROR:CONSOLE(219)] "Unexpected condition on chrome://oobe/gaia-signin: Could not find value for languageList", source: chrome://resources/js/load_time_data.js (219) Bug: 964121 Test: manual - go to Login screen and verify there's no error in the console Change-Id: Ia9c66844817ae45e199c3a35c9ff45a720b79b43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615942Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#660815}
-
David Roger authored
This fails on some bots with network error net::ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN. TBR=droger Bug: 964264 Change-Id: I651967916cafd1231f64f40e2f8372011315f49c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617348Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#660814}
-
Mohammad Refaat authored
This CL: 1- Replaces usage of didMoveTab with didMoveWebState in TabStripController and in BrowserViewController 2- Create FakeWebStateListObservingDelegate to be used in tests that requires the Obj-C version of WebStateListObserver. 3- Update tab_model_unittest to use the FakeWebStateListObservingDelegate for testing. Change-Id: I8868442244ad3e2933823d3b6f5e1c5fe047db9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614030Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#660813}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fd64d5d2d4a7..b1d937f4218e git log fd64d5d2d4a7..b1d937f4218e --date=short --no-merges --format='%ad %ae %s' 2019-05-17 khokhlov@google.com Write telemetry benchmark metadata in protobuf format Created with: gclient setdep -r src/third_party/catapult@b1d937f4218e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:944418 TBR=simonhatch@google.com Change-Id: Iba3ae6a7662ff73cd3c07cc8603ef4fb78732af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617603Reviewed-by:
-
Daniel Libby authored
This reverts commit 5fcb73a6. Reason for revert: regressed a few scenarios Will reland after fixing Original change's description: > Scroll scrollbar presses with gestures > > We don't currently track scrollbar scrolling latency - scrollbar > scrolling is currently performed on the main thread in response to > mouse events, so commits caused by this are categorized as LatencyInfo > with MOUSE type. > > With the work being done to move scrollbar scrolling to the compositor > thread (feature CompositorThreadedScrollbarScrolling), we want to be > able to track how latency changes (presumably improves) when we roll > out the feature in experiments. In order to do so we need to classify > scrolls that originate from scrollbars separately - this change adds > the foundation of how to accomplish this on the main thread. > > Instead of blink::Scrollbar directly scrolling its ScrollableArea in > response to a mouse input event, it will instead queue up a series of > scroll gestures, targetted at the ScrollableArea. A new method on > WebWidgetClient is exposed which adds the ability to inject these > synthesized gesture events. This is implemented in content in one of > two fashions: > - If the injection request happens during the handling of an input > event, the gesture(s) will be dispatched directly once the current > dispatch of the input event is complete. > - Otherwise, it gets queued up on the main thread event queue. > The latter condition comes into play when the autoscroll timer fires > due to holding down the mouse on the button or track. > > The reason for this distinction is due to the way the main thread event > queue dispatches events - it only dispatches the events that were > queued prior to running. If we always queued events, for rAF aligned > input (i.e. mouse-move) we'd be introducing a frame of latency as > the scroll would not be executed before the commit that occurs after > dispatching the rAF aligned input. > > This also has the nice side effect creating a mechanism to further > unify main thread scrolling (i.e. keyboard scrolling can be converted > to this code path as well). > > Once this mechanism is in place, we will dispatch the injected events > with a LatencyInfo with a modified type. This will be done in a follow > up change, as well as another one to convert the remaining scrolls > from blink::Scrollbar to use this gesture-based system. > > Bug: 954007 > Change-Id: I5da338103e833f2e909bc3163b618f57bd7142c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580588 > Commit-Queue: Daniel Libby <dlibby@microsoft.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#657031} TBR=dcheng@chromium.org,bokan@chromium.org,dtapuska@chromium.org,dlibby@microsoft.com Bug: 954007 Change-Id: I36be205eda2e3b8a22d7ff21a6da3f77eb326a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616341 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#660811}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c6568afa0b63..0c6daf034b11 git log c6568afa0b63..0c6daf034b11 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 robertphillips@google.com Direct backend object allocation API Created with: gclient setdep -r src/third_party/skia@0c6daf034b11 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: I04ab246d17a69fdaf99d7fde60c96177b738d9fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617607Reviewed-by:
-
Boris Sazonov authored
This reverts commit 3618cb02. Reason for revert: Broke downstream build https://ci.chromium.org/p/chrome/builders/ci/chromium-internal-arm-builder-rel/4234. Original change's description: > Autofill Assistant dependencies are now deps instead of classpath_deps. > > Bug: 951489 > Change-Id: I6959c83313aef83976910a56e7c198bcb98d50ea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613077 > Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660769} TBR=tedchoc@chromium.org,tiborg@chromium.org,jdemeulenaere@chromium.org Change-Id: I4d27e3663bd99809dd60233f4916356bef1cee64 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 951489, 964300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617353Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#660809}
-
Rayan Kanso authored
This reverts commit 972aadda. Reason for revert: Broke the build, depends on another CL Original change's description: > [DevTools] Enable PushMessaging & Notifications in handler. > > Allows the Background Services handler to receive push & notification > calls from the frontend. > > Bug: 927726 > Change-Id: Iaaca0205890f940d187f3b6e145e57fb1d3fdcb2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609705 > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660806} TBR=alph@chromium.org,rayankans@chromium.org Change-Id: Iabd10c617b4cacacf4e6134dd5109be801ab1c20 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 927726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617351Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#660808}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ad4aa017a42c..b0f423a33189 git log ad4aa017a42c..b0f423a33189 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 ilkos@google.com Merge "Support multiple process starts per activity start" Created with: gclient setdep -r src/third_party/perfetto@b0f423a33189 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7256d71689f8ea83e4232d3ae9b1b9366d3ad1b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617605Reviewed-by:
-
Rayan Kanso authored
Allows the Background Services handler to receive push & notification calls from the frontend. Bug: 927726 Change-Id: Iaaca0205890f940d187f3b6e145e57fb1d3fdcb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609705 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#660806}
-
