- 15 Aug, 2018 40 commits
-
-
Ben Pastene authored
I think this is why the fallback isn't working at all: https://chromium-swarm.appspot.com/tasklist?c=name&c=state&c=created_ts&c=duration&c=pending_time&c=pool&c=bot&et=1534289040000&f=buildername-tag%3Amac_chromium_rel_ng&f=name-tag%3Awebkit_layout_tests&f=os%3AMac-10.12&l=50&n=true&s=created_ts%3Adesc&st=1534202640000 It's inheriting the "gpu:none" that the recipe default to: https://codesearch.chromium.org/chromium/build/scripts/slave/recipe_modules/swarming/api.py?rcl=48ebe7c7e93d140e1746c034fbf39d2480bd34f0&l=188 And we don't have any 10.12 VMs: https://chromium-swarm.appspot.com/botlist?c=id&c=os&c=task&c=status&f=os%3AMac-10.12&f=pool%3AChrome&f=gpu%3Anone&l=100&q=gpu%3Anone&s=id%3Aasc Hopefully this helps things. If it doesn't, I'm going to move the entire suite back over to 10.12. We simple don't have the capacity for this... and won't for a while. Bug: 854874 Change-Id: I87f218a932266a0eef311741f20209f4ece0f8f8 Reviewed-on: https://chromium-review.googlesource.com/1174919Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#583355}
-
bsheedy authored
Adds a test to ensure that making a payment request from JavaScript in the VR Browser gets auto-rejected and the native UI does not appear. Bug: 862162 Change-Id: I1e29c2e4ed0feef5b0a46d329787159e366be84c Reviewed-on: https://chromium-review.googlesource.com/1176118Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#583354}
-
Justin Donnelly authored
Do this only in the pre-Refresh UI, where on Windows (and possibly some other circumstances?), the text styling is dependent on the selection state. Bug: 869768 Change-Id: If4ec69bb2316b0596116210f6e3aa70d1866b182 Reviewed-on: https://chromium-review.googlesource.com/1176196Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#583353}
-
erikchen authored
Previously, compare_build_artifacts.py used some basic heuristics to figure out which files to compare. This new option instead scans the .isolate files in the output directories, and uses their contents to determine which files to compare. Change-Id: I78bba7d3c06be682da694eeeb0dbe195fe312ace Bug: 870731 Reviewed-on: https://chromium-review.googlesource.com/1175043 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#583352}
-
Prashant Malani authored
Record the result of all major Low Entropy Credential authentication operations. The CL that introduced the code that generates this data is http://crrev.com/c/1093957 Bug: chromium:809749 Test: None Change-Id: I6de70122930d81ba753af750caaaa4bcd1a05d66 Reviewed-on: https://chromium-review.googlesource.com/1091296Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Prashant Malani <pmalani@chromium.org> Cr-Commit-Position: refs/heads/master@{#583351}
-
Christopher Cameron authored
Because BridgedNativeWidget will be living in its own process, it will be necessary for BridgedNativeWidget to create its own NSWindow, instead of having one be provided during initialization. This requires substantial refactoring, and two of the NSWindow classes that BridgedNativeWidget are provided live in chrome/browser/ui, and will need moving to a new location. For the moment, allow either creating a new NSWindow or specifying an NSWindow via the methods BridgedNativeWidget::CreateWindow and BridgedNativeWidget::SetWindow. This unblocks cross-process development. Also, be explicit that BridgedNativeWidget's NSWindow is always a NativeWidgetMacNSWindow or a sub-class thereof. The only exceptions to this are in tests, so merge testing functionality into NativeWidgetMacNSWindow. Bug: 859152 Change-Id: I61edb34d773fc11dff921da5edb34da1e306105b Reviewed-on: https://chromium-review.googlesource.com/1175051 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
-
Aldo Culquicondor authored
The compositor delegate will own and manage the surfaces, viewports and buffers. The newly added public interface restricts the manipulation of contexts to the client (RenderLoop). A native GL implementation is provided. Bug: 767282 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I23138f85ba859a64cbcc60c2d8f32757ec941f22 Reviewed-on: https://chromium-review.googlesource.com/1173394Reviewed-by:
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/624fec3ddbea..2ae6f8e569a3 git log 624fec3ddbea..2ae6f8e569a3 --date=short --no-merges --format='%ad %ae %s' 2018-08-15 primiano@google.com Merge "TraceProcessor: fix cost estimation of process and thread vtables" Created with: gclient setdep -r src/third_party/perfetto@2ae6f8e569a3 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ie9187cade7c824c5dae44c896b28ba0cb583e6eb Reviewed-on: https://chromium-review.googlesource.com/1174808Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583348}
-
Weilun Shi authored
Fixing the focusing issue when mixing up both keyboard navigation mode and mouse navigation mode. Focus on the first available option when we are on the mouse navigation mode but use tab or arrow key at the first time. Bug: 873071 Change-Id: I0a18ac3a92bff9eafef5788b4ced5755d4fa196e Reviewed-on: https://chromium-review.googlesource.com/1173754Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#583347}
-
John Budorick authored
Change-Id: If8206c443eee80987c4528d6aaeb58fb348dc57b Reviewed-on: https://chromium-review.googlesource.com/1176113Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#583346}
-
Xida Chen authored
Mark virtual/user-activation-v2/fast/events/touch/touch-latched-scroll-node-removed.html flaky on Mac TBR=wjmaclean@chromium.org NOTRY=true Bug: 869726 Change-Id: Iefe61d4ed93988b886a5c00f8f3574d9c3f59477 Reviewed-on: https://chromium-review.googlesource.com/1176215Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583345}
-
John Abd-El-Malek authored
This was accidentally introduced in r580764. Bug: 873785 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ie1e1aa9321f9863c5036a38d88cc7ca560127c00 Reviewed-on: https://chromium-review.googlesource.com/1175549 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#583344}
-
Xida Chen authored
It has been flaky for a while TBR=wjmaclean@chromium.org NOTRY=true Bug: 874538 Change-Id: Ia598f4367f0d90ff407395ffe69fb96ed707b59c Reviewed-on: https://chromium-review.googlesource.com/1176208Reviewed-by:
-
Vlad Tsyrklevich authored
cfi-icall is now enabled on all of the CFI bots so a separate bot is no longer required. Bug: 874112 Change-Id: I4d3b066c8622e03f1085d06a3ea1c638e22c960e Reviewed-on: https://chromium-review.googlesource.com/1174912 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
-
Stephen McGruer authored
The crash that these were meant to help debug has been long fixed. They are no longer needed. Bug: 770886 Change-Id: I7abf99be6cd00b9ae9a99934edaca95fe48e638d Reviewed-on: https://chromium-review.googlesource.com/1174992Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#583341}
-
Yuwei Huang authored
This CL removes old audio playback code that is no longer in used. Bug: 868088 Change-Id: I0dc350fc6d7fcabe89c6c7deba1da34fe53c3667 Reviewed-on: https://chromium-review.googlesource.com/1171855Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#583340}
-
Eugene But authored
These are existing User Actions, which were not logged on iOS. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id1700628a2c54dbd2ba2bbc43bf631a9e474b1ff Reviewed-on: https://chromium-review.googlesource.com/1175208Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#583339}
-
Tim Dresser authored
Bug: None Change-Id: I00f80dc9050109303747534b78216b67a9f310d3 Reviewed-on: https://chromium-review.googlesource.com/1176109Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#583338}
-
Becky Zhou authored
Use AppCompatButton in modal_dialog_view so that the text appearance can be applied to pre L devices. Bug: 872212 Change-Id: Ib84be209d086306983267cff5be0151202093ad6 Reviewed-on: https://chromium-review.googlesource.com/1173450 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#583337}
-
Ned Nguyen authored
1) Merge the abstract class _Top25RuntimeStats with V8Top25RuntimeStats since it's the only one inherit from the abstract class. 2) Remove the disabling Android in perf/expectations.config & switch to use SUPPORTED_PLATFORMS which is meant for permanent disabling logic like this case Change-Id: I07fecfd3d9cce3e7d35ac71b274bb9416f0cdcac TBR=perezju@chromium.org Change-Id: I07fecfd3d9cce3e7d35ac71b274bb9416f0cdcac Reviewed-on: https://chromium-review.googlesource.com/1175928Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#583336}
-
Avi Drissman authored
This relands 3dcaec6e with a fix to the test. BUG=873080 TEST=as in bug Change-Id: Ie68b197fc6b92447e9633f233354a68fefcf20c7 Reviewed-on: https://chromium-review.googlesource.com/1175925Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#583335}
-
Filip Gorski authored
* While investigating the problem of not reporting triggering on some pages, I discovered a race condition in fetching canonical URL -> in some cases the tab does not provide correct infromation yet. * This patch postpones fetching of canonical URL until later, when we are about to perform the fetch. * Fetching URLs would also cause some problems with marking fetch as in progress, which could prevent actual fetch from happening. * It appears to also be positively affecting the EoC start time when loading a page for the first time. Bug: 873004, 841811 Change-Id: Ic7e91579d083efd54a695a10e251ec245797ba84 Reviewed-on: https://chromium-review.googlesource.com/1175108Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
-
Ryan Daum authored
- Issue 'tap' gesture events while panning or zooming, to avoid idle screen during interaction. - Properly disable magnification when magnification gesture is turned off. Bug: internal b/112615721 Bug: internal b/112612596 Test: manual Change-Id: If6ec273ddab0f70d0c56743e38c0c40b49a579c4 Reviewed-on: https://chromium-review.googlesource.com/1175854Reviewed-by:Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Randy Rossi <rmrossi@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#583333}
-
Lei Zhang authored
TBR=tommycli@chromium.org NOTRY=true NOTREECHECKS=true Change-Id: Ib8a3268f5eefc51491ae49ef2c942c0dcb6b7a8f Reviewed-on: https://chromium-review.googlesource.com/1176192Reviewed-by:
-
Emil A Eklund authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/b6fdcf4f8bd09e065c767939125861c9dc8ff18f..7112c6413ca7a1773847fe258145cc5162420953 Bug: 873568 Change-Id: Ia6a7c9baa0bdce0bc3d4dc50c75c70c0dbbb6555 Tbr: behdad@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1174951 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#583331}
-
bsheedy authored
Updates the script used for bisecting VR/AR regressions to support bisecting binary size regressions between builds with and without VR or AR support. Bug: 874240 Change-Id: Ib37926c0d3d77570206ff267d2aab20d86a1f439 Reviewed-on: https://chromium-review.googlesource.com/1175146Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#583330}
-
Ryan Sleevi authored
Presently, CertVerifier::Verify() takes a series of per-verification flags that express the ways in which certificate verification may be configured. However, these flags represent overall verifier-wide configuration, in that they are tied to user preferences or enterprise policies. These flags are plumbed through the layers by virtue of SSLConfig, but generally do not change between verifications. As part of making the verification configuration opaque to callers, move the flags from being something passed in each verifier-call to something that is implicitly handled on the CertVerifier, via the CertVerifier::Config. All verifications started will share the same configuration, while allowing callers to focus on the per-verification parameters that are unique (such as the hostname or certificate). This sets the stage for moving the CRLSet in as explicit CertVerifier configuration, rather than passed-per-call, as well as to having the socket pools more intelligently respond to these configuration changes. TBR: zea@chromium.org, pmarko@chromium.org Bug: 848277, 854635 Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2098783f1c4100720438e2dea447a24789ebf8c9 Reviewed-on: https://chromium-review.googlesource.com/1122709 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#583329}
-
Lei Zhang authored
The NaCl plugin is built into the Chromium binary, so it does not have a real path. Instead of calling PathService::Get(chrome::FILE_NACL_PLUGIN) to get the fake path, just use a constant like the PDF plugin. Change-Id: I7487f6be7ddbdbecf6255b6faa5b104593e6193e Reviewed-on: https://chromium-review.googlesource.com/1175546 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Justin TerAvest <teravest@chromium.org> Cr-Commit-Position: refs/heads/master@{#583328}
-
Sergey Ulanov authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I99a21f1060e81a5f7930d6ec6b6b269f76a23c41 Reviewed-on: https://chromium-review.googlesource.com/1174011 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583327}
-
Lei Zhang authored
third_party/mesa/src is no longer checked out as of r582655. BUG=873321 Change-Id: I6ee0dabd58b77a2c1995b7d42df4fb4df909884c Reviewed-on: https://chromium-review.googlesource.com/1175403Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#583326}
-
Lei Zhang authored
Make methods private when possible. Move methods that can go into an anonymous namespace into one. Change-Id: Ia921b6539aae45ce145c6a4583ebdbb7b9611707 Reviewed-on: https://chromium-review.googlesource.com/1174996Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#583325}
-
Lei Zhang authored
Make it base::FilePath::CharType instead of char because that is what all its users expect. Remove uses of base::FilePath::FromUTF8Unsafe(). Do the same for ChromeContentClient::kNotPresent. Change-Id: Ifae02593f05eec02d783cc865a5c29441f606ecb Reviewed-on: https://chromium-review.googlesource.com/1175498Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#583324}
-
chaopeng authored
This patch fixes viewport scrollbars flashing page issue. The issue is causing by it has incorrect effect node. In this patch, we create the effect and correct the position for viewport scrollbars. Bug: 870520 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I954d6cddb36d811f693b597644b65ee175137dcf Reviewed-on: https://chromium-review.googlesource.com/1172919 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#583323}
-
Koji Ishii authored
The only difference from legacy at this point is when 'box-shadow' is applied to the '::first-line' style. Edge and Gecko do not support it. NOTRY=true Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I2fbfba36b9a606ea4a1f0e40dada8102fd0ed623 Reviewed-on: https://chromium-review.googlesource.com/1175755Reviewed-by:
-
Xida Chen authored
The current code has a type, it should be DISABLED_xxx TBR=wjmaclean@chromium.org NOTRY=true Bug: 872340 Change-Id: I910b6913eace9b4710a7aac990d783f0f842beee Reviewed-on: https://chromium-review.googlesource.com/1176176Reviewed-by:
-
Pavel Shmakov authored
This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1172425 Another memory leak was found in ToolbarProgressBar. It happens due because animations are not cleaned up when activity is destroyed. The references to animation listeners get stuck in android.animation.AnimationHandler, which is a singleton. From the animation listeners the chain of references leads all the way up to ChromeTabbedActivity instances. So this leak happens when user closes Chrome while the page is loading, and then the system kills the activity. It's easily reproducible with "Don't keep activities" option. Bug: 872661 Change-Id: I6eebc11a575d45c899f37be5ca7a6862923f0ee5 Reviewed-on: https://chromium-review.googlesource.com/1175795Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#583320}
-
tzik authored
The declarations of move ctors and assigns of DisjointRangeLockManager::LockRequest, ScopesLockManager::ScopeLock and ResolveProxyMsgHelper::PendingRequest have `noexcept` specifier, but their implementations don't. This is OK in C++14, but causes compile errors in C++17. This CL adds missing `noexcept` for them. Bug: 752720 Change-Id: I849f613c63c990afd23c590a9567069b772146d1 Reviewed-on: https://chromium-review.googlesource.com/1175656Reviewed-by:
-
sangwoo.ko authored
Replace old API with new API. This CL is a refactor ans has no intended behavior change. Bug: 842194 Change-Id: I46e242b51c99ef720ee6700ab6bf0fdc8c2a4720 Reviewed-on: https://chromium-review.googlesource.com/1174582Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
Bug: 855127 Change-Id: I2942e122373c210bd0bceaa59791e2619186f79b Reviewed-on: https://chromium-review.googlesource.com/1175935Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#583317}
-
Xida Chen authored
Flakiness dashboard shows that it has been flaky for a while: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=components_unittests&tests=SslCastSocketTest.TestMessageEndToEndWithRealSSL TBR=wjmaclean@chromium.org NOTRY=true Bug: 874491 Change-Id: I5c0fe9656f3c9e74d21660db6430899e4824c6d5 Reviewed-on: https://chromium-review.googlesource.com/1176170Reviewed-by:
-
