GitLab

BUG=None
TEST=try passed


Review URL: https://chromiumcodereview.appspot.com/10828246

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151221 0039d316-1c4b-4281-b951-d872f2087c98

We don't need to pass Profile because we can get it from Browser API, and we
are trying to reduce the usage of Profile.

R=pkasting@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10830254

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151220 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10855118

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151219 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116317
TEST=manual

Changes the order that DidDestroy for the untrusted plugin and the trusted
NaCl plugin are called. This allows the plugin to initiate shutdown before
the untrusted plugin, which may hang.
Review URL: https://chromiumcodereview.appspot.com/10824220

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151217 0039d316-1c4b-4281-b951-d872f2087c98

Long term, we'd like to drop this further (i.e. 1 minute) and trust THROTTLED responses in the event of widespread backend outages.
We'd like to run some stress tests of that infrastructure (at scale / under load), but in the meantime we want to address the problem
for beta channel users / M22.  We chose 5 minutes, which is a little more aggressive than the recommended value, but we believe is
safe -- happy to discuss offline.

This patch is very low risk (stability wise). although 5 minutes is a long time to wait for users who hit this due to transient failures.
Current data suggests 500s occur around 0.02% of the time, and although backoff isn't limited to 500s it's unlikely to get hit frequently,
and the user experience doesn't break down significantly.

Effectiveness wise, We can run an experiment once it hits dev channel by returning 500s and watching for expected drops in QPS.

BUG=139733,142029

Review URL: https://chromiumcodereview.appspot.com/10826194

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151216 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151215 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10837131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151214 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10823280

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151213 0039d316-1c4b-4281-b951-d872f2087c98

This is helpful so that instead of adding new binaries for each different test suite that runs on its own bots (and so increading build times), we can still keep the tests in the same binaries. Instead, the specific bots would add --run-manual and can pass the test suite names as a command line flag.
Review URL: https://chromiumcodereview.appspot.com/10825311

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151212 0039d316-1c4b-4281-b951-d872f2087c98

Fix the browser windows from going in a loop trying to steal focus from each other when activating a differnet window from the one that has a modal dialog. Instead, activate it in a posttask.

BUG=141650
Review URL: https://chromiumcodereview.appspot.com/10826253

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151211 0039d316-1c4b-4281-b951-d872f2087c98

WebSocket should ignore certificate errors when chromium starts with
--ignore-certificate-erros flag.

BUG=141762
TEST=SSLUITestIgnoreCertErrors.TestWSS


Review URL: https://chromiumcodereview.appspot.com/10830256

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151208 0039d316-1c4b-4281-b951-d872f2087c98

This reinforces that only certain thread/message_loop can be created, which also makes thread/message_loop access easier and more reliable.

Also use scoped_refptr<MessageLoopProxy> instead of raw MessageLoop pointer in various places.

BUG=none
TEST=media_unittest, content_unittest and normal <video> playback.


Review URL: https://chromiumcodereview.appspot.com/10855051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151204 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mkearney@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10826261

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151201 0039d316-1c4b-4281-b951-d872f2087c98

Problem occuired because file manager code uses the selectedIndexes property of selectionModel. But setter for this methos is implemented only for multi-selection list, but not fo single selection (which is used in the save-as dialog). It fails to restore selection and consequently fails to restore lead item. Resetting lead item stops renaming.

BUG=138975
TEST=Manual test


Review URL: https://chromiumcodereview.appspot.com/10823201

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151200 0039d316-1c4b-4281-b951-d872f2087c98

The onError function is called as a free function hence has no associated "this" object.

BUG=141809

Review URL: https://chromiumcodereview.appspot.com/10826241

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151199 0039d316-1c4b-4281-b951-d872f2087c98

This change is intended to be merged to the 1180 branch for
Chrome 21 Stable. On the trunk this change is only temporary
and will be replaced by a fix for bug 141629.

R=agl@chromium.org,rsleevi@chromium.org
BUG=142172
TEST=Visit https://www.google.com/ and https://www.facebook.com/.
Click the lock icon. The page info bubble should say
"The connection uses TLS 1.0."

Review URL: https://chromiumcodereview.appspot.com/10828272

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151198 0039d316-1c4b-4281-b951-d872f2087c98

Add metric recording in CPM for how long it takes to load a page.

BUG=130212
TEST=included browsertest


Review URL: https://chromiumcodereview.appspot.com/10829078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151197 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141949
TEST=build


Review URL: https://chromiumcodereview.appspot.com/10855111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151196 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138962
TEST=as in bug


Review URL: https://chromiumcodereview.appspot.com/10827207

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151195 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141700


Review URL: https://chromiumcodereview.appspot.com/10836185

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151194 0039d316-1c4b-4281-b951-d872f2087c98

Apparently it's possible to have the context WeakPtr not be cleared yet but have
the underlying proxy already be gone.

BUG=141880


Review URL: https://chromiumcodereview.appspot.com/10830265

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151193 0039d316-1c4b-4281-b951-d872f2087c98

to remove static_cast<> in the callers.

BUG=139130
TEST=try bots

Review URL: https://chromiumcodereview.appspot.com/10855002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151192 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds support for constrained windows to ShellWindowController which is used by platform apps.

BUG=140593
TEST=Verified that constrained windows on tab windows still work. Ran the media gallery test app and verified that opening constrained windows inside a shell window worked.


Review URL: https://chromiumcodereview.appspot.com/10823176

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151191 0039d316-1c4b-4281-b951-d872f2087c98

Regression came from change to leave panel in title-only mode
when draw attention is cleared, but mouse is over the panel title. (r137530)

BUG=None
TEST=Updated StopDrawingAttentionWhileMinimized and DragMinimizedPanelWhileDrawingAttention


Review URL: https://chromiumcodereview.appspot.com/10828220

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151190 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94925
TBR=cmp

Review URL: https://chromiumcodereview.appspot.com/10837213

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151188 0039d316-1c4b-4281-b951-d872f2087c98

This is the Cocoa version of the following two CLs:
https://chromiumcodereview.appspot.com/10696042
https://chromiumcodereview.appspot.com/10824054

Currently the extension install dialog shows permission warnings inside a multiline text field.

OAuth issues are different in that they are a list of issues, each of which can be expadned to show more details.

To support this I replaced the multiline text field with an NSOutlineView.

Screenshots:
  - OAuth issues + Warnings: http://i.imgur.com/Hbag3.png
  - Inline install + Warnings: http://i.imgur.com/gpLI9.png
  - Inline + No Warnings (outline view hidden): http://i.imgur.com/se9tH.png
  - Bundle install + Warnings: http://i.imgur.com/5H3Rm.png

XIB changes: Replaced warning and subtitle text field with outline view. Updated relevant outlets.

BUG=30206
TEST=
  1. Test OAuth issues. Run chrome with --demand-user-scope-approval. Drag/drop oauth2.crx from estade. Verify that warnings and oauth issues are displayed. Verify that expanding a oauth issue grows the dialog.
  2. Test Inline install + Warning. Navigate to https://www.google.com/chrome/intl/en/p/google-plus.html and click install. Verify that warnings are displayed.
  3. Test Inline Install + No Warnings. Navigate to http://chrome.angrybirds.com/ and click install. Verify that the outline view is hidden and that the dialog is correctly resized.
  4. Test Bundle Install. Run chrome with  --apps-gallery-url="http://www.corp.google.com/" Navigate to http://www.corp.google.com/~jstritar/bundle.html. Verify that warnings are shown.

Review URL: https://chromiumcodereview.appspot.com/10829170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151187 0039d316-1c4b-4281-b951-d872f2087c98

FindReplyACK could never have any effect, because queued_find_reply_message_
can only ever be NULL.

BUG=83097


Review URL: https://chromiumcodereview.appspot.com/10836195

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151186 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=compiles.

Review URL: https://chromiumcodereview.appspot.com/10829290

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151185 0039d316-1c4b-4281-b951-d872f2087c98

Found with:
$ git grep --files-without-match --name-only "namespace views" -- ui/views/{*.cc,*.h}

TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10827289

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151184 0039d316-1c4b-4281-b951-d872f2087c98

This was caused by a refactor to use the JSC (crrev.com/148166). I apologize for being so careless
and thank you mihaip for catching the problem so quickly.

BUG=140792

Review URL: https://chromiumcodereview.appspot.com/10829273

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151183 0039d316-1c4b-4281-b951-d872f2087c98

This flag is not feature complete on mac and linux, it's premature to enable field trials.

BUG=133602,140866


Review URL: https://chromiumcodereview.appspot.com/10824271

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151182 0039d316-1c4b-4281-b951-d872f2087c98

The original patch introduced a crash (GetCompositor() can return NULL), but
reverting the whole thing is not possible without a lot of other reverts, and
the proper fix is fairly involve (likely not reasonable to patch to the branch).

This only reverts the problematic part, and a follow up will do a proper fix.

BUG=141756


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151153

Review URL: https://chromiumcodereview.appspot.com/10828262

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151181 0039d316-1c4b-4281-b951-d872f2087c98

Also added comment about how to use TokenService from tests.

BUG=141123
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10834262

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151180 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10837210

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151179 0039d316-1c4b-4281-b951-d872f2087c98

We were failing to associate the mobile bookmarks folder at sync startup time.
This could result in various seemingly-random bookmark unrecoverable errors.
We now associate the bookmark folder if it's there, and condition triggering
an association error on whether we expected it to be there (which we only do
on ANDROID platforms).

BUG=121587
TEST=Sign in to sync with a clean profile, but synced mobile bookmarks existing
in the mobile bookmarks folder on the server. Bookmarks should appear on the
desktop client.


Review URL: https://chromiumcodereview.appspot.com/10828268

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151178 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141389
TEST=Run with --force-device-scale-factor=2, go to a page with standard scroll bars and observe that they are crisp.

Review URL: https://chromiumcodereview.appspot.com/10837205

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151177 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10832236

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151176 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10825304

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151175 0039d316-1c4b-4281-b951-d872f2087c98

- Reduce col padding for invalid transition to 15px and use a 50px for first
  column;
- Fix a problem that invalid transition gets reset when touch scroll is more
  than 100%;

BUG=none.
TEST=Verify icon moves less when attempting touch scroll to an invalid page.  Also invalid move is not abruptly reset in the middle while dragging the touch.

R=sky@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10832255

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151174 0039d316-1c4b-4281-b951-d872f2087c98

I believe the crash (see bug link) is caused because we remove the delegate
connection, but we never stop observing the WebContents. I haven't reproduced
the crash, but I think this should fix the root cause. I've put in a bandaid as
well, which might be redundant, but good for safety. Will remove it once I can
confirm the fix works.

BUG=141875
R=sky@chromium.org
TEST=This type of crash (see bug) should go away.

Review URL: https://chromiumcodereview.appspot.com/10829284

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151173 0039d316-1c4b-4281-b951-d872f2087c98