GitLab

This is a reland of 022292aa

Changes from original are from Patchset 1 on. I added a java_group
which contains both the services dep and the original java dep so this
doesn't break //clank. After this lands I'll fix up clank to point
to the right deps and remove the java_group.

Original change's description:
> Split out minimal target for PaymentDetailsUpdateService
>
> We are investigated using isolated splits for Chrome, and splitting
> //chrome code into a DFM. Due to b/169196314, all service classes must
> be present in the base module. See go/isolated-splits-clank for more
> details.
>
> This change creates a new minimal target for PaymentDetailsUpdateService
> which the base module will depend on.
>
> Bug: 1126301
> Change-Id: Ib4396073bbc4254c0400bccec1f4acac3ba88ad8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459508
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Danyao Wang <danyao@chromium.org>
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#815649}

Bug: 1126301
Change-Id: If5077fa7d6a03f893aa0057be8a26cf5863230b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463649Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816679}

R=khorimoto@chromium.org

Bug: 126802
Test: none
Change-Id: I851f765ea02d92bf1adbc36e591cff2301b1ceff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462624Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816678}

This flag is used to specify cases where YUV should not be used.
Rather than relying on the client to pass in this flag we specify
that YUV decoding happens only when DecodeToYUV is called. Calling
Decode(size_t), as in DecodeFrameBufferAtIndex(size_t), will prevent
YUV decoding.

Additionally remove JPEGImageDecoder::SetDecodeToYuvForTesting method.

Bug: 1090949, 1062187
Change-Id: I389a20729f56facd49acf6cf670408001f5ed076
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240249
Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816677}

All datatypes (except proxy types) are non-blocking, so there is little
point in maintaining code that keeps track of which precise "group" each
datatype maps to.

In this patch, most code is deleted except for the internals of
SyncBackendRegistrar, which is more complicated.

Change-Id: I4ad2d219e8032cbb0dca16125958c6e66c117cf6
Bug: 1102835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467918
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816676}

Currently, such lookups are accidentally recorded under
kLocalFontLookupByUniqueOrFamilyName due to a typo. This affects the
metrics recording for the identifiability study

Bug: 1136921
Change-Id: Ibf4a28a6edfabff0a570bd35c09686b5b020957d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463702Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816675}

This uses the same test configs as android-pie-x86-rel.

Bug: 1099916
Change-Id: I05a018f56d0121d69c2384644e41b8e2f5539b8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454729Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#816674}

When the ForceEphemeralProfiles policy is enabled, Chrome tries to
clean up sensitive files when the last window in a profile is closed.
However, the Custom Dictionary.txt file is still populated, and it
can contain sensitive (e.g., a customer's name that was added to
spellcheck).

With this patch, the Custom Dictionary.txt file is properly cleared
when the last window in an ephemeral profile closes.

TESTED=Created a new profile in epehemeral mode, added some dictionary
       words, then closed it. Checked that
       Custom Dictionary.txt{,.backup} didn't contain the words. Also
       tested with Sync turned on, to make sure the words were not
       cleared from synced data.

Bug: 1132950
Change-Id: If50f0f78fc89a7bbdbc1b563856bc36288c53c5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441947Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Guillaume Jenkins <gujen@google.com>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816673}

Fixed: 1137858
Change-Id: I7eefc389cce69d1cd5fd271ab1009ab4faade4ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468336
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Chris Thompson <cthomp@chromium.org>
Reviewed-by: Chris Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816672}

This is a reland of 7ea4118e

The reland fixes the wrong `defines` declaration in
//chromeos/ui/frame/BUILD.gn :

- defines = [ "IS_CHROMEOS_UI_FRAME" ]
+ defines = [ "IS_CHROMEOS_UI_FRAME_IMPL" ]

which was causing the wrong symbols being loaded.

Original change's description:
> Move //ash/public/cpp/caption_buttons to //chromeos/ui
>
> This is step 1.2 on the design document [1].
>
> [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/edit
>
> BUG=1113900
> R=jamescook@chromium.org, sky@chromium.org
>
> Change-Id: Ic625b887b00538d758260a3f35426c346bcdbabf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458768
> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#816200}

TBR=jamescook@chromium.org

Bug: 1113900
Change-Id: I332e087c0eadd333aef96e2acb7d9f0c9a259f26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466739Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: James Cook <jamescook@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#816671}

This recent CL [1] and made the `ice_config_fetcher' network traffic
annotation ChromeOS-only. Because it only changed a BUILD file, and not
the actual source code, CQ did not catch the change.

This CL updates annotations.xml to reflect the change in supported
platforms.

[1] https://crrev.com/c/2441025

TBR=rhalavati@chromium.org

Change-Id: If1b728c0ace48351e39e4b5294ab47c982a67bca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468637Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816670}

Previously when there is composited foreground layer, the outline was
painted on both the main graphics layer and the foreground layer.

Change-Id: I9c0bcf14ce4acb1f41a732e480b9c1a4126f69bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466620Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816669}

BUG=1136972
TEST=bots
R=kbr@chromium.org

Change-Id: Ib0c769e88bae1d3a5a092610bc49896d8ccfe040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464102Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816668}

Ensure that queued read tasks don't make use of a null
MojoDataPipeReader.  Also ensure that error_callback_ is invoked at
most once per RemotingSender.

Bug: 1081111
Change-Id: I75d808bf2c7e747d6306543aedcac5ce26acfa97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446992
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816667}

Add enums to the browser protocol in prep for the devtools frontend
work.

This CL also updates the network_handler to insert the new values.

Bug: 1136839
Change-Id: I23f9d47bffde3dce3917d41d5c01070646b3d366
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461595Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Steven Bingler <bingler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816666}

The latency of "pause" is unusually high on the Skylake Client
architecture. This is likely not affecting us though, as the spinning
loop is short. Add a comment noting this (with a link to the Intel
optimization manual), and follow the best practice highlighted in the
manual, namely exponential backoff with "pause".

Bug: 1125999
Change-Id: Ia233aa5ae4b9cd58b24897537861b60c7d4ca05a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465745Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816665}

When we shipped longtasks with buffered flag, we forgot to remove a
check that would prevent longtask creation when there's no observer.
This CL fixes this and adds a test for this case. It also moves the
UseCounter to the observe() method.

Bug: 1131385
Change-Id: I2911b9ab044db7394bcf64f64b1e599959cbdc37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463594Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816664}

libva is dlopened regardless

Change-Id: Ice577ef78ea15ab7041db4b386eb91237d46a3d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442189Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816663}

Reland "[Paint Preview] Split PaintPreviewCompositor memory metrics from the general Utility process metrics"

This is a reland of 8711fb9a

//components/services/paint_preview_compositor/public/mojom:mojom
is now added to process_memory_metrics_emitter.cc dependencies in
chrome/browser/BUILD.gn to fix the dependency error.

Original change's description:
> [Paint Preview] Split PaintPreviewCompositor memory metrics from the general Utility process metrics
>
> Change-Id: I6067aad3959c054181389c1e1b82e464eacd9a4b
> Bug: 1135217
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441263
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
> Commit-Queue: Yashar Dabiran <yashard@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#815285}

Bug: 1135217
Change-Id: I7c72463b23060b5e352c4421be5b14d1fee4c574
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462640Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Yashar Dabiran <yashard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816662}

As of https://chromium-review.googlesource.com/c/chromium/src/+/1986325
we no longer replace nested <use/> elements with <g> elements when
populating shadow trees and instead support <use/> inside shadow trees
directly (as per the current spec).  Remove the check for this case
from LayoutSVGTransformableContainer as it has been dead for a while.

Change-Id: Iad3a09fe4779cdd54edd0ae98aaaac07fc1bcfb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462227
Commit-Queue: George Steel <gtsteel@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816661}

This patch adds a new descriptor to change the glyph advances by a given
percentage. For example, the following makes all glyph advances 50%
larger than before:

advance-proportional-override: 150%

The implementation is almost identical to 'advance-override', except
in ShapeResultSpacing::ComputeSpacing() where we calculate the delta
to each glyph advance.

Note: The spec discussion hasn't settled. This patch is only for making
experiments easier, so that it's easier to find a better solution to
reduce font-caused CLS.

Bug: 1137633
Change-Id: I24c9d25f11c07f897eb37f07b75cbc3dd4ec6574
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467017Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816660}

Updates the expires_after attribute for 158 histograms that show
frequent access in the past 90 days.  These are the 93% most
frequently used histograms over that time that do not already
have a date later than or within 60 days of 2021-01-11.

TBR=chromium-metrics-reviews@google.com

Change-Id: I766b6816bc90876675c821ddec807dc2df22fe1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467760Reviewed-by: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Cr-Commit-Position: refs/heads/master@{#816659}

Tests whether a firewall is blocking HTTPS port 443.

TEST=unit_tests --gtest_filter=HttpsFirewallRoutineTest.*
BUG=chromium:956783

Change-Id: I43d91fc87b52ef303beb18ec06bff18f055a5eff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391419Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kartik Hegde <khegde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816658}

Using wpt-import in Chromium 506099f5.
With Chromium commits locally applied on WPT:
099c04c7 "[layout] Fix -webkit-line-clamp with text-overflow: ellipsis"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
drott@chromium.org, kojii@chromium.org:
  external/wpt/css/css-fonts

NOAUTOREVERT=true
TBR=smcgruer@google.com

No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel
Change-Id: Ia087639196af6db7500d5d4ea737b3fd32ebbf0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467687Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#816657}

This change just renames that namespace everywhere.

Bug: 1097204
Change-Id: I45f9bc9b0e44386e2b7b80f99bf43f57a7b81cc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453869Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816656}

This CL fixes issue with bluetooth device list items in tray
menu losing focus and reading out device name repeatedly. This
was caused because all item views in the list are recreated
every time the device list updates. Fixed this by re-using and
re-ordering existing view items instead of deleting and
re-creating every time.

Fixed: 1111166, 1007371
Change-Id: I38c31e80fafec0bc80dd62bf37ff1b926ccf0014
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465518
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816655}

Bug: 1132403
Change-Id: I414ca14eb4b4b8f39231969d62e0f8c09e37e80e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467296Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816654}

32-bit Chrome continues to hit out-of-memory crashes. Some of these are
presumed to be out-of-address-space crashes which are particularly easy
to hit when running on 32-bit Windows where 32-bit Chrome will only get
2 GiB of address space.

This change lowers the default stack size for Chrome to 0.5 MiB. This
will not affect Chrome's main thread (it uses a fiber to create a larger
stack) but it will affect Windows thread pool worker threads and a few
other threads that we do not directly control.

This change also lowers the stack size for threads that Chrome creates,
but to minimize risk this is only done when running on 32-bit Windows,
where the risk of running out of address space is most severe.

This has been seen to save 25 MiB of address space (50 threads going
from 1 MiB to 0.5 MiB).

Bug: 981238, 1023804
Change-Id: Ia7fc03e0d4b79550cb67cb491892beaae08d5c0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461589Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816653}

identifiability study.

This API is suspected of leaking information to sites about users'
machines that can be used to help track their identitiy across different
domains.

The IDL instrumentation reports digests of the return values of this
method to UKM for analysis.

Bug: 973801
Change-Id: I4dcb3519c784b2f103c87744187ee15cb21fb3bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463326Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/master@{#816652}

The problem is because damage of a frame may not contain the whole
render pass area, and then the overlay backing will not be drawn
completely. Fix the problem by ignoring the frame damage area.
This CL also fixes some sync token issues.

Bug: 1135727
Change-Id: I6354b235fb9a7ffdeffe9c9270576ee648a7ba4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464914
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816651}

In AXTreeConverter, use ConvertToFuchsiaNodeId to handle node id edge
cases.

Test: AXTreeConverterTest
Bug: fuchsia:60692
Change-Id: I2fe50a5f522d2a58d8cb88bf3f086173a6c6ea62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466617
Commit-Queue: Sharon Yang <yangsharon@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816650}

This is a reland of 4bf05b95 with
updated ArcVmClientAdapterTest unitests.

Original change's description:
> arc: Only call StopVm() if ARCVM is running
>
> This change adds a check in ArcVmClientAdapter::StopArcInstance() to see
> if a VM is running (current_cid_ is set). If not, skip calling
> ConciergeClient::StopVm() and notify observers that ARCVM is stopped
> right away.
>
> BUG=b:169893632
> TEST=arc.AuthPerf.unmanaged_vm
>
> Change-Id: Ic927f122cacea0e89cacffbbcd67a217772dba43
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462573
> Commit-Queue: Willie Koomson <wvk@google.com>
> Reviewed-by: Yusuke Sato <yusukes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#816221}

BUG=b:169893632
TEST=components_unittests --gtest_filter="ArcVmClientAdapterTest.*"

Change-Id: I3f9440333f7339687e3a4bd36799de06376b9351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466559Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Willie Koomson <wvk@google.com>
Cr-Commit-Position: refs/heads/master@{#816649}

The step in LocalFrameView has been merged into CompositingCommit
(PaintArtifactCompositor::Update) in http://crrev.com/815947.

Bug: 1132717
Change-Id: I69417ad86ae3b7507641ad693255aca9e58958ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462068Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816648}

Updates the expires_after attribute for 32 histograms that have
been used to generate alerts in the past 90 days and do not already have
a date later than or within 60 days of 2021-01-11.

TBR=chromium-metrics-reviews@google.com

Change-Id: I5b4b211108beb83581913b1937703415dd1a8600
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467759Reviewed-by: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Cr-Commit-Position: refs/heads/master@{#816647}

- Add customized notification view to phone hub notification controller.
- Add "From Phone" to the notification's header.
- Add IDs to NotificationViewMD to access the header in the view.

Screenshot: https://screenshot.googleplex.com/3kW99Ch5wGvVrGz

BUG=1106937,1126208

Change-Id: I0d0726d0d05c967384db702a557ba7a2895d77c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464163
Commit-Queue: Andre Le <leandre@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816646}

Privacy review:
https://docs.google.com/document/d/1L93H6TYrtq4qRWzvEa3H7uKZhwWCtTTJ_bT6QFdg_ys/edit#heading=h.k5jx6iluw4yt

Bug: 1133883
Change-Id: I07a89ebca144e8ee7d5600f2b5eba79b7069a64c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450610
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816645}

Despite what the current name implies, ComponentExtensionIMEManagerImpl
is NOT an implementation of ComponentExtensionIMEManager interface
(that's actually a concrete class, only ever subclassed by its mock).
This is extremely confusing in terms of readability.

In fact, ComponentExtensionIMEManagerImpl [sic] is an implementation
of ComponentExtensionIMEManagerDelegate interface. An instance of the
latter is dependency-injected for use by ComponentExtensionIMEManager
itself. The already confusing misnomer is thus exacerbated, as both
ComponentExtensionIMEManager and ComponentExtensionIMEManagerImpl [sic]
tend to appear together while bearing no inheritance relationship.

In this patch, ComponentExtensionIMEManagerImpl [sic] is renamed to
ComponentExtensionIMEManagerDelegateImpl to reflect what it really is.
Descriptiveness and conciseness improvements are out of scope.

Also:
- Extract ComponentExtensionIMEManagerDelegate to its own .h file.
- Fix pre-existing std::unique_ptr usage as flagged by presubmit errors.
- Replace pre-existing NULL with nullptr as flagged by presubmit errors.

Bug: 1134465
Change-Id: If36b7d4c17ee19cdfc773c22ad4f384779b2a4fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440381
Auto-Submit: Bao-Duy Tran <tranbaoduy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Keith Lee <keithlee@chromium.org>
Reviewed-by: David Vallet <dvallet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816644}

When the app is backgrounded and foregrounded again,
DisclosureNotification#onStartWithNative is called again, but
DisclosureController hasn't updated the model to reflect that the
notification has already been shown.

Change-Id: I96463c61e6e611528f47dd68f7c5a0cc4e34ec54
Bug: 1136477
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467978Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816643}

This CL extracts code that tests X11-specific event logic into test
binaries that only run on X11 bots.

Bug: 1109112
Change-Id: I3ff177c911e170a4899455e98437da7aa3615238
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466245
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Alexander Dunaev <adunaev@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816642}

Consider this code:
  <style>i { white-space: pre-line }</style>
  X<i> </i><i>&#10;</i>

The first time that NGInlineNode::CollectInlines runs, the text data
will be "X", then "X ", and then AppendForcedBreakCollapseWhitespace
will remove the trailing whitespace before inserting the forced break,
so we get "X\n".

But if some text is appended dynamically, CollectInlines will run again,
and this time it will try to reuse existing items in AppendTextReusing.
Before this patch, this would produce "X \n", which would trigger a
DCHECK failure in ComputeOffsetMapping because it's a different string.

Therefore, this patch prevents AppendTextReusing from reusing existing
items if the last item to collapse with ends with collapsible spaces and
the first item to reuse has 'white-space:pre' and begins with a newline.

Bug: 1136688

TEST=external/wpt/css/css-text/white-space/pre-line-with-space-and-newline.html

Change-Id: I0ff71b125b66256ec3b5c263605c3c116f9ac55f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466279Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#816641}

https://dawn.googlesource.com/dawn.git/+log/d1bca09f4ab3..ccaef8525710

2020-10-13 rharrison@chromium.org Add running spirv-val on output of Tint

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC enga@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: enga@google.com
Change-Id: Ia7ffaa02a5368ca3e365f350ad88e198187fb013
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468140Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#816640}