- 13 Nov, 2020 40 commits
-
-
Peng Huang authored
Some client resources (video, etc) will need to wait on a ResourceFence before returning them to client. That fence is released when all GPU work for the root render pass are finished on GPU. However, on macOS, there isn't a root render pass for every frames, and all related client resources will never be released. To fix the problem, we have to release the fence for each GPU tasks (drawing non root render passes, drawing render pass overlays, etc). Bug: 1143042 Change-Id: I335e4a7c4a36557315cede7edd834b028c7b015d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537112Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#827445}
-
Cattalyya Nuengsigkapian authored
- supply CaptureParams as an argument of IsCaptureAllowed(). Bug: 1145606 Test: Manual test Change-Id: If73b39eff906ce1b44253522aedcde69bab444fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530290Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Cr-Commit-Position: refs/heads/master@{#827444}
-
Jan Krcal authored
This CL further improves the algorithm of color selection to: 1) Disallow colors with very low saturation (currently the first line in the color picker). 2) Prefer colors with lightness similar to the lightness of the current profile (this disallows the very dark colors for the very light colors and vice versa). Bug: 1108295 Change-Id: I3adcc347b84285d5d2659f1972f075e992e0bebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532565 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:David Roger <droger@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#827443}
-
John Delaney authored
Enables intervention by default in the Chrome binary, and removes it's associated testing config which is no longer needed. Bug: 959849 Change-Id: I5963aebd84894a94d37af053a99b8050394f3426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535550Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#827442}
-
Jesse Schettler authored
When a cancel completes, run the cancel callback instead of the completion callback. This prevents clients from having to wait for and handle two separate callbacks when canceling a scan. Bug: 1059779 Change-Id: I80083a1aed002abbdbf117ddad527c531e32bfba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537052Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#827441}
-
Maksim Sadym authored
1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`. 2. Use `WebSettingsImpl::SetMainFrameClipsContent(false)` to force the whole page to be rendered. 3. Set `hide_scrollbars` to avoid artificial scrollbars. 4. Set `record_whole_document` to force the whole page to be rendered. 5. Removed DCHECK from `third_party/blink/renderer/core/frame/visual_viewport.cc`, as soon as it didn't expect to have preferences to be changed "on the flight". Details: https://bugs.chromium.org/p/chromium/issues/detail?id=1003629#c37 Screenshots: - Before: https://i.imgur.com/yt6WZRx.png - Patchset #1: https://i.imgur.com/VsocJ3L.png - artificial scrollbars. - Patchset #3: * https://imgur.com/UVqpzUQ - line breaks are not exactly the same as in original view. * https://imgur.com/MXpgHOl * https://imgur.com/haxemcr - not aligned with the node. * https://imgur.com/RbdlYVT - Patchset #18: * https://imgur.com/EWUmn0O * https://imgur.com/DUrQ1yF * https://imgur.com/cT5oBSi - perfectly aligned. * https://imgur.com/Jy4UWtf - no artificial scrollbars (because of the view extended). Bug: 1003629 Change-Id: I6bbc85cd0995626a8b1fb748ec9048c9d586200e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470876 Commit-Queue: Maksim Sadym <sadym@chromium.org> Auto-Submit: Maksim Sadym <sadym@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827440}
-
Miguel Casas authored
This CL queries the driver for the encoding quality range and, if available and the device is considered "low power" (celeron, pentium and Core -Y devices), sets it to its maximum value, for highest speed and lowest power consumption, albeit at lower encoding quality. The quality difference should not be noticeable for video conference scenarios. I followed the code in both of Intel's VA backends. For the legacy i965: - VP8 supports values 1-2 [1]. (ENCODER_LOW_QUALITY is 2 so at least this CL can supersede the patch in [2] which is what it was set off to do). - AVC1 and VP9 support 1-7 [3,4], ENCODER_QUALITY_RANGE_(AVC,VP9) == 7 see [5], but this only on Gen9 [6a, 6b] (VP9 encoding is only available in Gen9+ FTR). For the modern intel-media-driver iHD, values are configured with names, 1 being TARGETUSAGE_BEST_QUALITY ([7] and its following lines). By default, the TARGETUSAGE_RT_SPEED == 4 is used, and 7 would be TARGETUSAGE_BEST_SPEED. Improvements depend on the input content. I measured kohaku with EncodeAccelPerf.h264_1080p_i420 and when ToT is ~204fps, 4.75W, with this CL I see ~220 fps, 4.42W. [1] https://github.com/intel/intel-vaapi-driver/blob/d87db2111a33b157d1913415f15d201cc5182850/src/i965_drv_video.c#L1151 [2] https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/third_party/chromiumos-overlay/x11-libs/libva-intel-driver/files/vp8-encoder-Workaround-to-force-perforamce-mode-enco.patch;l=36 [3] https://github.com/intel/intel-vaapi-driver/blob/d87db2111a33b157d1913415f15d201cc5182850/src/i965_drv_video.c#L1142 [4] https://github.com/intel/intel-vaapi-driver/blob/d87db2111a33b157d1913415f15d201cc5182850/src/i965_drv_video.c#L1149 [5] https://github.com/intel/intel-vaapi-driver/blob/021bcb79d1bd873bbd9fbca55f40320344bab866/src/i965_drv_video.h#L76 [6a] https://github.com/intel/intel-vaapi-driver/blob/021bcb79d1bd873bbd9fbca55f40320344bab866/src/i965_encoder.c#L1599 [6b] https://github.com/intel/intel-vaapi-driver/blob/021bcb79d1bd873bbd9fbca55f40320344bab866/src/i965_encoder.c#L1653 [7] https://github.com/intel/media-driver/blob/105f0341a21324ae3bc458cfa6c25c7df0517f3a/media_driver/agnostic/common/codec/shared/codec_def_common.h#L333 Bug: b:141147405 Change-Id: I7e5c54f1e5a7ac7a51c5503f37168db16f9e99f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344526 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Sreerenj Balachandran <sreerenj.balachandran@intel.com> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#827439}
-
Nick Burris authored
Max suggested I join components/payments/OWNERS :) Also update the component since UI>Browser>Payments was removed in favor of Blink>Payments. Change-Id: I604bb739dab79bc13652993299bca7e839fd0421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536900Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#827438}
-
Scott Little authored
This reverts commit 9912841b. Reason for revert: The linker has started segfaulting consistently: https://ci.chromium.org/p/chromium/builders/ci/Mac%20Builder/124684 Original change's description: > mac: Use response files instead of -filelist, but just a little bit. > > This is a partial reland of > https://chromium-review.googlesource.com/c/chromium/src/+/2530350 > > For reasons not yet understood, that change sometimes makes the > linker segfault -- but only hours after it goes in. But once it > happens, it's sticky. > > So reland a smaller version of this change to see if it still happens. > - Use `-Wl,@rsp` instead of `@rsp` so that the clang driver doesn't > read the response file just to write it out again -- instead we > pass the response file to the linker directly for now. > - Only put {{inputs}} in the response file for now, not yet > {{frameworks}} {{swiftmodules}} {{solibs}} {{libs}} > > Bug: 1147968 > Change-Id: If5c03c881e2469fa2a3c1d3297975ef4c3d19587 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538011 > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Brett Wilson <brettw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827424} TBR=thakis@chromium.org,brettw@chromium.org,mark@chromium.org Change-Id: Ibdb3f64f745e89d63ab5df2dec2c6bda55bdf7d7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1147968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538177Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#827437}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605255855-dc6a80021d99bde94e7af4afa11767b88ac6fee3.profdata to chrome-win64-master-1605268075-daeeb1bc6080c8b4d9f48b3dab7bc22bf5a02dcb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie1a82ebeb7d6021f9550c82363074eeab4f13459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538091Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827436}
-
Olga Gerchikov authored
- Added WheelEventRegions runtime feature flag. - Changed mouse coordinates in wheel-event-target.html test to accommodate for rounding per [1]. - Changed wheel event handler region in layer-scroll-rects-get.js to enforce not empty wheel handler region. [1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/platform/graphics/paint/paint_controller.cc;l=49;bpv=1;bpt=1?q=RecordHitTestData&ss=chromium%2Fchromium%2Fsrc Bug: 1136588 Change-Id: I437c87d7c8a53f107f676b647d737ce1de7827f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521354Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Sam Fortiner <samfort@microsoft.com> Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/master@{#827435}
-
James Cook authored
BUG=1146734 TEST=Ran locally. Change-Id: Iba08d7f3c205c023b3b93b15e8e49f50ce3d5424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536577Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#827434}
-
Chris Lu authored
Updated based on Legal's recommendation. Bug: 1138603 Change-Id: I7383f2c95d5bee73ef899cab08aa9eca136a27cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535660 Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#827433}
-
Jiaqi Han authored
This change disables supports_multiple_windows by default to Webview controller, in order to open new window navigations in the current view. Bug: b/170218696 Test: Sample website on Chromecast navigates on the current view. Change-Id: I44cb7d7e9c8ffa42789f7019779fc9c87935ba92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533679Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Jiaqi Han <jiaqih@google.com> Cr-Commit-Position: refs/heads/master@{#827432}
-
Christoph Schwering authored
The parsing patterns currently in autofill_regex_constants.{h,cc) are about to be migrated to regex_patterns.json. This JSON file is loaded asynchronously by the component updater. However, tests need to load the JSON synchronously to avoid race conditions. This CL compiles the JSON file to C++, so that the default patterns are available from the start. With this CL, the JSON is not loaded at all during runtime. Enabling the component updater is left for a follow-up CL. The growth of the binary size will be compensated when autofill_regex_constants.{cc,h} are removed. Bug: 1147608 Change-Id: Ibbdc9161ae253a80917cc7dd6154342e8fd7ed47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532562 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:Matthias Körber <koerber@google.com> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#827431}
-
kenkangxgwe authored
Bug: b/173015334 Test: run Tongol on device and check available processors. Change-Id: I4acfe6b02c364a6b2e57d91d76c7bb58f98f47c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533554Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Mingyu Kang <kenkangxgwe@google.com> Cr-Commit-Position: refs/heads/master@{#827430}
-
Vincent Boisselle authored
Bug: 1148445 Change-Id: I01c5e75559f9d00a264d3330edb81811ab149ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533549Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#827429}
-
adoneria authored
Configure them to: 1. run on any changes to //chrome/updater. 2. list under `Choose Tryjobs` for luci.chromium.try Bug: 1120836 Change-Id: I519c632b6b99fa41f256b2f6a70d8e300f4941a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536032 Commit-Queue: Anjali Doneria <adoneria@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#827428}
-
evliu authored
This CL adds a check to prevent binding the speech recognition context if the mojo pipe to the speech recognition service is not bound. This can occur if the Speech On-Device API (SODA) files were not found. Bug: 1147226 Change-Id: I86fe0a4b9fe80de0449e196b451423cbcf2b8a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538054Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#827427}
-
Dave Tapuska authored
Collapse common implementation of HandleKeyEvent into one. There is a path that checks for embeds that support keyboard focus and a tab character, ensure this code is kept. fast/plugins/keypress-event.html tests that condition. BUG=1097816 Change-Id: Ic9c88a6c0a768f26980bb97645f853f651caf9ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536151 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#827426}
-
Chong Gu authored
Bug: 1148926 Change-Id: I7b1c44967147d3674479544871973f9b39032bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538163 Commit-Queue: Chong Gu <chonggu@google.com> Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#827425}
-
Nico Weber authored
This is a partial reland of https://chromium-review.googlesource.com/c/chromium/src/+/2530350 For reasons not yet understood, that change sometimes makes the linker segfault -- but only hours after it goes in. But once it happens, it's sticky. So reland a smaller version of this change to see if it still happens. - Use `-Wl,@rsp` instead of `@rsp` so that the clang driver doesn't read the response file just to write it out again -- instead we pass the response file to the linker directly for now. - Only put {{inputs}} in the response file for now, not yet {{frameworks}} {{swiftmodules}} {{solibs}} {{libs}} Bug: 1147968 Change-Id: If5c03c881e2469fa2a3c1d3297975ef4c3d19587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538011 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#827424}
-
Theresa Wellington authored
NightModeStateProvider is owned by ChromeBaseAppCompat so most usages cast a Context or Activity in order to retrieve the object. ColorUtils#inNightMode, in contrast, just needs a Context. Replaces usage of NightModeStateProvider with ColorUtils and makes ChromeBaseAppCompatActvity#getNightModeProvider protected. Also removes references to ChromeBaseAppCompatActvity from night_mode package. Bug: 1139525, 1148614 Change-Id: I9768c3c4a686e4df3e0b71d29ba631e0c2cbb458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537230Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#827423}
-
Chris Lu authored
For both IsInRemoveFirstRunPromptGroup() and IsInFirstRunModalGroup() experiment groups the native location prompt should not show after First Run finishes. The prompt will show after the user taps the action button in the modal. Bug: 1146456 Change-Id: I65dad9dcd3e46e45d783df79e1f3fe9aa5d2ea52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537922 Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
-
Liquan (Max) Gu authored
Before the CL, only the non-minimal UIs invokes the "onCompleteCalled" "onCompleteReplied" callbacks on the test observers. Since the callback names indicate that they are agnostic to minimal UI, they should be applied to all UIs. After the CL, the minimal UIs also invokes these callbacks. This CL also cleans up the PaymentUiService#onPaymentRequestComplete javadoc. Bug: 1131059 Change-Id: Ic0b1a381083f9ad024c4bd84eb85e8500c034617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535872 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827421}
-
Sorin Jianu authored
The IDL file is split in three parts: public, internal, and legacy definitions. This is a fairly straightforward change, which consists of suffixing the path to the typelib in the executable file with a //<index> where the index matches one of the there source IDLs above. Further work is needed to properly generate the GUIDs depending on the which IDL the GUIDs belong to. Some of the GUIDs must depend on branding, and some of the GUIDs must depend on branding and version. Bug: 1140562 Change-Id: I6030977d3961ff24bbc8bc33392415d59884feec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527822Reviewed-by:
S. Ganesh <ganesh@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827420}
-
David Bienvenu authored
Bug: 1007807 Change-Id: I979b461f6d1ef5b6a9f01a9b272683d01112cc96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533732 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
-
Karandeep Bhatia authored
The session rules are not indexed and evaluated yet. This will be done in a follow-up. Skipping presubmit since this seems to be hitting crbug.com/956368. BUG=1043200 Doc=https://docs.google.com/document/d/1_I6jHA_jCa0UbR2QVUZsBApt_GqEuMz7qnpQdt1LEv0/edit?usp=sharing (Internal only) No-Presubmit: True Change-Id: Id15783af14ff1f4a88900680d29d71d07794b4e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495511 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#827418}
-
Becca Hughes authored
This is a reland of dde3defc The fix here is too disable MediaKeysListenerManagerImplTest on CrOS since MediaKeysListenerManager is disabled too. Original change's description: > Reland "[Media Session] Fix for Lacros" > > This is a reland of ddb531f7 > > There is a fix in media_session_service.cc to allow the tests to pass > when ash-chrome is not running. > > Original change's description: > > [Media Session] Fix for Lacros > > > > At the moment in Lacros there are two instances of the > > Media Session Service (MSS) one hosted in ash-chrome and > > the other in lacros-chrome. This means that sessions in > > either browser process cannot see sessions from the other. > > > > This changes it so when a client asks for lacros-chrome > > MSS instead of providing a locally hosted MSS it binds > > the MSS in ash-chrome. > > > > BUG=1140215 > > > > Change-Id: Ic155a6cd928f0735095f849f309f9075dbb1d36f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485850 > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Erik Chen <erikchen@chromium.org> > > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#825016} > > Bug: 1140215 > Change-Id: I64834d9be778998b42bf3447444a6955265215ef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525851 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825439} Bug: 1140215 Change-Id: I43d916d2d5726a02baf5fc9307e86a36e99b67fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529730Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#827417}
-
Rohit Rao authored
ContentSuggestionsCoordinator assumes that TemplateURLService's GetDefaultSearchProvider() always returns a valid object, which is not true when the default search engine is disabled (for example, via policy). BUG=1148903 Change-Id: I2ba16b900e89c1f3e6c9420b42ea34f9a065f126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536899Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#827416}
-
Ivan Murashov authored
The switch allow-pre-commit-input was moved from //content to //third_party/blink in the change https://chromium-review.googlesource.com/c/chromium/src/+/2232804/. But accidentally it was back to the //content in the change https://chromium-review.googlesource.com/c/chromium/src/+/2225528/ between patchsets 10 and 11. Bug: 1073560 Change-Id: I712d6df7786d26590872efc1b5fcdd96d046dd63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537701Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
-
Nate Fischer authored
This reverts commit 6d24e357. Reason for revert: launcher icons cause problems for work profile (crbug/1148909) Original change's description: > [AW][Dev-UI] always include icon resource > > Standalone & Trichrome WebView now unconditionally includes > LauncherActivity (defined in DeveloperUiLauncherManifest), and > conditionally set the enabled state to true/false based on GN args > (webview_devui_show_icon, which is configured by android_channel). > > This is a step toward resolving https://crbug.com/1047824, although this > is not a complete solution since this doesn't change the monochrome > behavior. > > Fixed: 1140741 > Bug: 1047824 > Test: aapt dump xmltree TrichromeWebViewGoogle.apk AndroidManifest.xml | grep -A 2 'LauncherActivity' > Test: Same for TrichromeWebViewGoogleBeta, TrichromeWebViewGoogleStable, SystemWebViewGoogle, SystemWebView > Test: adb shell pm enable com.google.android.webview.debug/org.chromium.android_webview.devui.LauncherActivity > Test: adb shell pm disable com.google.android.webview.debug/org.chromium.android_webview.devui.LauncherActivity > Change-Id: Id996965643a6fea31a34ebe39fb5b2b8ac5f5c0a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500435 > Reviewed-by: Hazem Ashmawy <hazems@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Richard Coles <torne@chromium.org> > Auto-Submit: Nate Fischer <ntfschr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822231} TBR=torne@chromium.org,ntfschr@chromium.org,hazems@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1047824 Bug: 1148909 Bug: b/173091361 Change-Id: Ibf176cb5daaaf27063d9f5bacc5cfb86eb49f5bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538153 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#827414}
-
Daniel Hosseinian authored
operator<() needs to be overloaded so base::GUID can be used in set containers. Per the style guide, overload all other comparison operators. Bug: 1026195 Change-Id: I9c36f0aee13b34c3bbdfdc3581a84a9c23485e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533649 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#827413}
-
W. James MacLean authored
Add information to the DwoC output to help determine if this is a start- up or shut-down issue. Bug: 1148542 Change-Id: I3ecf8db05beb6b94a7489389fdbdcf9e4694607c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537576 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#827412}
-
Rakib M. Hasan authored
This skew test will updated daily by uploading new CIPD packages for each tag created in the M88 branch. The m88 reference will point to the most recent package uploaded. Bug: 1147459, 1147455, 1099017, 1041619 Change-Id: Ib9ae51d2a7379d478cbab68a334c7d2488bf0e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538152 Auto-Submit: Rakib Hasan <rmhasan@google.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#827411}
-
Adithya Srinivasan authored
This reverts commit 55c31ae8. Reason for revert: Supect this is causing ARC failures in chrome_all_tast_tests (https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/11172) Original change's description: > Add desktop focus state change event > > This change add a new event for desktop window focus state change. > With this change, ARC can have different behavior when Chrome window > or ChromeOS desktop get activated. > > BUG=b:171450038 > TEST=Active different window between Chrome/ARC and logcat events > > Change-Id: I11cee5d5279ad12524092518cadd05fff67bab72 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519686 > Commit-Queue: Shengsong Tan <sstan@google.com> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827122} TBR=oshima@chromium.org,sstan@google.com Change-Id: I20b7407b417b3d54fb6b29dfb08de640592f1b21 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:171450038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538115Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#827410}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4543697b3755..c4ad6062fd17 2020-11-13 perkj@webrtc.org Ensure EncoderSink::OnBitrateAllocationUpdated not called after Stop If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1143311 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic269443757e2e7ee9b5b2dc2a950a1123ded4465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537178Reviewed-by:
-
dpapad authored
Before this CL, the only way to include generated files in a generated grd file was to use |manifest_files| as input to generated_grd(), forcing us to use preprocess_grit() even when not necessary. With this CL, |input_files| can hold generated files directly. Bug: 1132403 Change-Id: I6f71458387b3c3cb2284019787f8836326c31b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537595 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#827408}
-
Alexander Cooper authored
The OT infrastrucutre requires a single UseCounter to measure. This adds a use counter for RequestLightProbe, which must be gotten before either of the other Light Estimation API methods can be used. Bug: 1148871 Change-Id: Ic9ac4b81fca1460497d4ff0753b7ceadcb982dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538132 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#827407}
-
Scott Little authored
This test is flaky on multiple platforms, so I'm disabling this test. Example failure: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42845 TBR=ryansturm@chromium.org,adithyas@chromium.org Bug: 994068 Change-Id: I1ca4f95ea9388e9eb7cb5184d0e821ee242ea91d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537937Reviewed-by:
-
