- 11 Jan, 2021 40 commits
-
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I9fb2c28603eeb7b0c64c61154b8ef87e2cc7f25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621693Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842097}
-
Ian Elliott authored
We've seen a number of flaky failures with Windows7 FYI AMD bots lately (i.e. different tests occasionally fail once). This is taking too much Wrangler attention. This CL should quiet down the flakes. Bug: angleproject:5513 Change-Id: Ic5af13c71da76c1f5a9edb7746201559d455df23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619318Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com> Auto-Submit: Ian Elliott <ianelliott@google.com> Cr-Commit-Position: refs/heads/master@{#842096}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/eddc7d0df5d1..3bf3659d351a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5f0cf03d1b55e98e026403e1cbabb7eedaa7da6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621876Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842095}
-
David Roger authored
See discussions: 1) https://docs.google.com/presentation/d/1Mrt7ZQV_VwJ6IBpmA-GFKk-lVx7RkdAJHo3ADSooIAY/edit?disco=AAAAIzo6kto 2) https://docs.google.com/presentation/d/1Mrt7ZQV_VwJ6IBpmA-GFKk-lVx7RkdAJHo3ADSooIAY/edit?disco=AAAAHlUIHWE Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/88cd55b4bf04fb8e41c5196e0570d72599088733 Change-Id: I921bf31a5a9978c07f8110b23ab2bb4d8f996564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622313Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#842094}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/8144af91b4f9..1d9935cf37fd 2021-01-11 rharrison@chromium.org Revert 3 fuzzing CLs, since they are preventing rolling into Chromium. 2021-01-11 dsinclair@chromium.org Convert ScopeStack over to symbols. 2021-01-11 dneto@google.com spirv-reader: Reject dref sampling with Bias or Grad 2021-01-08 dneto@google.com Roll third party dependencies 2021-01-08 dneto@google.com spirv-reader: rename variable 2021-01-08 rharrison@chromium.org Adding fuzzing for Transforms 2021-01-07 rharrison@chromium.org Add fuzzers for various emission paths 2021-01-07 rharrison@chromium.org Create common utility class for fuzzing 2021-01-07 bclayton@google.com Add tool to check the WGSL spec examples compile If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I57e6941520001e04b1436eb03dc915818e6a6b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621880Reviewed-by:
-
Josh Nohle authored
Currently, if the sum of attachment sizes exceeds 25MB, WebRTC will be disabled regardless of the user's data-usage setting. Because we already provide the user an option to only use unmetered connections, we make changes in this CL to respect the user's setting regardless of attachment size. We also add additional logging of supported mediums. Manually tested that the correct mediums are sent to Nearby Connections; however, there is an outstanding bug in Nearby Connections (b/176432167) that supported medium choices are not respected. Fixed: 1164688 Change-Id: I749ab72aaf48feac7e799561f1ad1bbb961f5e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619319 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#842092}
-
David Roger authored
See discussion here: https://docs.google.com/presentation/d/1Mrt7ZQV_VwJ6IBpmA-GFKk-lVx7RkdAJHo3ADSooIAY/edit?disco=AAAALEzRChg Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/01b5644780ba124b0c8cd95bad41ce935e3e26a2 Change-Id: I7830f13efd02fc1f5619bdd75b9117503fb10065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622172 Commit-Queue: David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
-
Joon Ahn authored
http://screen/4wX4sJuYUhvc3ub Bug: 1125150 Change-Id: I88ab06756737b97c39de9c7d409395b0ef55db53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599425 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#842090}
-
Andrew Grieve authored
I've seen it come in code reviews several times where devs are thinking that android:debuggable="true" should be added. This is caused because the AndroidManifest.xml expecations check will locally tell you to add it if you build without is_official_build=true. There is no risk of this attribute slipping in unnoticed since play store won't allow apps to be uploaded with it set, so this filters it out to remove the annoyance. Bug: None Change-Id: I1459f6af3f78f34f12cc9f6e14157e97fe7d91e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620643 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#842089}
-
Maksim Moskvitin authored
If device was successfully registered with unknown epoch/trusted vault key, first DownloadKeys call won't have any key available and incoming keys validation should be skipped. Note: strictly speaking, there is a constant key; but performing validation using it doesn't add any value, while would make future changes harder. Bug: 1113598 Change-Id: Ib978987b4ba1304f40c54414ea79ef08d7ebb6ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620262 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#842088}
-
Michael Hansen authored
In certain cases the default device name can be generated without the user's given name, e.g. just "Chromebook". This occurs when adding a second user account to a device, where the default device name is generated immediately on completing login but before user details have been downloaded. This updated logic caches the default device name in the NearbyShareLocalDeviceDataManagerImpl rather than storing it in prefs. Fixed: 1151667 Change-Id: Ica79907506624647f630a798f08d9201ea381a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622592Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#842087}
-
Laís Minchillo authored
Add a setProxyOverride method that takes in a boolean for reverse_bypass. This will be exposed via androidx.webkit APIs. Add a new test in proxy_config_service_android_unittest and in AwProxyControllerTest to test the newly added reverse_bypass option. Bug: 1162255 Test: run_net_unittests -f *ProxyConfigServiceAndroidTest* Test: run_webview_instrumentation_test_apk -f *AwProxyControllerTest* Change-Id: Icc82656809b9237d6a8defb125b57727d59777ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544645 Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#842086}
-
Dave Tapuska authored
Add a new interface PepperHungDetectorHost that is used on the renderer's IO thread to inform the browser about a hang of an out of process pepper plugin. BUG=1157519 Change-Id: I98c9fe3ead8544fae697f021456a72724c80b81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618287 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#842085}
-
Daniel Nicoara authored
https://chromium-review.googlesource.com/c/chromium/src/+/2613152 updated the NativeDisplayDelegate API. Update the usecase to fix the build. Bug: b:177105618 Test: Build cast_shell internally Change-Id: I9234a35d2dcdb6585dd1df6be8f650254eb7c01a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622275 Commit-Queue: Gil Dekel <gildekel@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Gil Dekel <gildekel@chromium.org> Cr-Commit-Position: refs/heads/master@{#842084}
-
Wez authored
Change-Id: I8a9076cc0b392b1efcd411c2f666349af3e0ea2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622112 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#842083}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1f19c9cd819c..04314b1d8edb 2021-01-11 ahassani@chromium.org cros_flash: Remove --install flag for USB flash 2021-01-09 yyanagisawa@chromium.org Make GomaConfig.DEFAULT map to a Goma RBE cros build. 2021-01-09 mmortensen@google.com cros_logging: Improvements for CloudLogging initialization. 2021-01-08 jaredloucks@google.com constants: update skylab package pin from a constant CIPD instance ID to a label which can be moved between instances. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ia867e0298ab617a1e654f58f4895d022720297e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621773Reviewed-by:
-
Gabriel Charette authored
This is a reland of 2ecb8d17 Revert reason seemed unrelated, but FindIt is strangely convinced. The TSAN issue was fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2618393 nonetheless. Original change's description: > [base] Fix trace events and blocking types when blocked on modal dialogs > > Sheriff notes: This is expected to artificially reduce IOJank* metrics. > > Modal dialogs launched via GetAppOutputInternal in launch_posix.cc > are guaranteed to block and thus should use WILL_BLOCK semantics > (as opposed to MAY_BLOCK like it did). > > However, Process::WaitForExit can't use WILL_BLOCK semantics because > of an existing workaround for TestLauncher to not use > ScopedBlockingCallWithBaseSyncPrimitives when waiting on processes or > TestLauncher ends up creating or TestLauncher ends up flooding > the pool to 256 workers regardless of --test-launcher-jobs > (it posts each test as a task right off the bat and expects the > pool to cap the parallelism...). > > The best solution to get proper tracing and thread restrictions > right is thus to add custom trace events and keep assertions > that waiting is allowed when launching the process. > > Each platform was doing something slightly different here, this > CL brings all platforms inline with annotations that are visible > in tracing but ignored by IOJank metrics. > > Example broken trace showing up in IOJank slow reports on Linux: > https://goto.google.com/btbzu (SS: https://snipboard.io/7sDO1r.jpg) > > R=fdoray@chromium.org > > Bug: 1064645, 1144161, 899897 > Change-Id: Id087f91df8c2201ca10db5438456c638f9b791e9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233299 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Joe Downing <joedow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837874} TBR=fdoray@chromium.org,wez@chromium.org (identical as before) Bug: 1064645 Bug: 1144161 Bug: 899897 Change-Id: I8f4161d9c614db1670648b54d5949fdfe49a6b02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621912Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#842081}
-
Sorin Jianu authored
This CL fixes a minor coding style issue. https://google.github.io/styleguide/cppguide.html#Rvalue_references According to the coding style, rvalue refs can only be used in a couple of scenarios, and they do not include returning rvalue references, or passing by rvalue reference, except in a specific case. This CL also fixes a couple of places where const pass by value was used instead of pass by ref to const. Since the initial intention of the code was to use move semantics, that intention has been preserved, especially to allow move semantics here: TagArgsBuilder& WithApp(AppArgs app) { this->inner_.apps.push_back(std::move(app)); return *this; } Due to how the code is used later on, move semantics for the TagArgsBuilder is not really needed but the implementation was retained to make TagArgsBuilder and AppArgsBuilder similar. The CL code is slightly less efficient than the original code but efficiency is not a first order concern in this module. Bug: 1164718 Change-Id: I8b7ff4d225728b1ed00b0b387649672f5553c3f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620401Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842080}
-
Avi Drissman authored
Soon, with TargetChannel, an instance of Chrome on the disk might be upgraded to an instance of Chrome of a different channel. Cache the channel information on startup, so that even if it's changed, the channel information of the current running instance is available. This relands aa20f9b8 with a fix. Fixed: 1163159 Change-Id: If1e3da89ff70da765782dd4dbdf0505da67c4e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620839Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#842079}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I1be953d59463c72467af4087b8557401568379e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619226Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f926db13. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ie020a0143608345a25eb082e2975e789a8bad4e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621632Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842077}
-
Tanmoy Mollik authored
Methods OnPrimaryAccountSet/Cleared() are deprecated, so this CL changes the chrome/browser/* to override the method OnPrimaryAccountChanged(). Bug: 1158855 Change-Id: Ide097c4908e4c92338e54565f8fa72cff2b0b4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621752Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#842076}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1670c5184b9e..99c3a691c23d 2021-01-11 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 9bacbe1b34a3 to f51d965befa1 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Ic94d775c62f8e431ad16ccf57eef77f65e45baca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621879Reviewed-by:
-
John Budorick authored
Bug: 1007101 Change-Id: I02608689ba9cb1c0aa72a146cf82c732d3949049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620678Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#842074}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/348ba200aa29..009667d5f97c 2021-01-11 srisser@google.com Implement VK_EXT_separate_stencil_usage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I3baebe3a58d81c790e1a401ab4e5f19ea3bae08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619229Reviewed-by:
-
Maksim Moskvitin authored
This CL adds support for authentication factor registration with unknown epoch/last key version. If that's the case, ListSecurityDomains request is sent first in order to detect the actual security domain epoch if it already exists and ensure that "last" trusted vault key is actually the last. Afterwards, JoinSecurityDomainsRequest is sent with detected epoch or with epoch=0 if security domain doesn't exist. In latter case, actual epoch will be detected using JoinSecurityDomainsResponse. Bug: 1113598 Change-Id: Ie7bc4104e0a909b9aece077c1b9eedbbcf1e8ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567157 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Frédéric Wang authored
This CL removes the following methods: SchemeRegistry::RegisterURLSchemeAsLocal SchemeRegistry::RegisterURLSchemeAsSecure SchemeRegistry::ShouldTreatURLSchemeAsLocal SchemeRegistry::ShouldTreatURLSchemeAsSecure The initially registered schemes are based on the results of url::GetSecureSchemes() and url::GetLocalSchemes() when the URLSchemesRegistry instance is created but they are not updated afterwards, which can lead to inconsistencies [1]. Instead, this CL migrates to direct use of the corresponding url utils APIs. Note that the registration methods are not used outside tests, so there should be no observable behavior change in Chrome. It makes easier to compare SecurityOrigin::IsSecure and SecurityOrigin::IsPotentiallyTrustworthy with network::IsURLPotentiallyTrustworthy, to facilitate unification of all these APIs [2]. Finally, this CL adds back the test for custom schemes that was removed in [3], now that the SecurityOrigin APIs are compatible with url utils. [1] crbug.com/1153336 [2] crbug.com/1163060 [3] https://chromium-review.googlesource.com/c/chromium/src/+/2595424 Bug: 1153336, 1163060 Change-Id: Iedf0a7ec6585ab3664712e9dfe49901f1159427a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614784 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#842071}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610338418-1bf01a8f47d2b9b410b39a25bf178b364099d014.profdata to chrome-win64-master-1610365490-7c6abe53577006e61aa7c1c42d7ef337c3924953.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I137312227da2482af9d815b8b53a2b7e416831f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621615Reviewed-by:
-
Zhenyao Mo authored
The test only runs on Mac with dual GPUs right now. Mark it as flaky to unblock CQ until we resolve the real issue underlying. BUG=1164647 TEST=bots R=kbr@chromium.org Change-Id: I0b9d2469abc6dbfd1c59809ce1c7c5455c860047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620088 Auto-Submit: Zhenyao Mo <zmo@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3bf3659d351a..fff8e7632e28 2021-01-11 simonmacm@google.com Merge "Add trace_config_pbtxt to the metadata in TraceMetadata." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I376a795d47e33a7c084c94baf31c64d32aa96359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621872Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cfaba518..2779617a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia9172f978ecf0a14e9f3fe24794079b35d61e452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618983Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842067}
-
Fredrik Söderqvist authored
SVGPatternElement::CollectPatternAttributes() rejects linked <pattern> elements that are not attached, so we need to make sure that they re- evaluate their attributes if a referenced element gets/loses a LayoutObject. Bug: 1164735 Change-Id: I0f1e28c890f7f91cacbfa0f8be133d919df5c7db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620564Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#842066}
-
Ana SollanoKim authored
out of flow items" This is a reland of f08bc1d7 Original change: https://chromium-review.googlesource.com/c/chromium/src/+/2567573 Revert of the original change: https://chromium-review.googlesource.com/c/chromium/src/+/2613550 Marked: virtual/layout-ng-grid/external/wpt/css/css-grid/abspos/grid-positioned -items-gaps-001.html virtual/layout-ng-grid/external/wpt/css/css-grid/abspos/grid-positioned -items-gaps-rtl-001.html virtual/layout-ng-grid/external/wpt/css/css-grid/abspos/grid-positioned -items-within-grid-implicit-track-001.html virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-column- axis-alignment-positioned-items-[012-016].html virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-row- axis-alignment-positioned-items-[012-016].html virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-self- alignment-positioned-items-with-margin-border-padding-[011-016].html as failing in all builders. Original change's description: > [GridNG] Computation of static offsets edges and grid area for out of > flow items > > 1. Function ResolveOutOfFlowItemGridLines: The column and row span of > the grid area for the out of flow item is obtained through > GridPositionResolver, and the grid lines of the out of flow item are > computed. > > 2. Refactor of CacheItemSetIndices: For in flow items, computation of > the set indices remains the same. To compute the indices for out of flow > items we take into account the following: > a. If both the start and end line of the out of flow item are not > 'auto', then the indices are computed as if they were in flow items. > b. If either is 'auto', then its value is kNotFound. > c. If either is attempting to create a new line in the grid, then they > are treated as 'auto'. > > 3. Helper method ComputeOffsetAndSize: the computation of the offset and > size of each item was generalized to include the cases where either or > both of the set indices are auto in out of flow items. Additionally, > inline and block edges are computed. > > Bug: 1045599 > Change-Id: I15b680d1866cdb81b42d626bcd6948ae1b7132ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567573 > Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840701} Bug: 1045599 Change-Id: Ie2fee60c6717740fc70f5b0d285919b47f521bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616242 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#842065}
-
Wez authored
ICU is configured with the currently-configured locale in each WebEngine process when it starts up. In the browser process the locale is monitored and changes applied at run-time, to ensure that e.g. accept-language headers are up to date. The locale is passed by the browser process to some child processes (e.g. renderers) when they are started. Renderers in particular cannot have their locale re-configured dynamically once started. Bug: 1156404, 1157244 Bug: b/168161909 Change-Id: Id7ff526f1d371b103632c7a284bd16fa694654a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595368 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842064}
-
Sebastien Lalancette authored
SmokeTestCase/testAppLaunchManagerBackgroundAndForegroundApp is flaky on simulators. crbug.com/1164446 Bug: 1164446 Change-Id: I4b6db5a9d497a0341a43ebc6b14551e6d7f076ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617581 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#842063}
-
Adithya Srinivasan authored
Looking at the callsites of SetPageFocus, we only set is_focused for main frame RWHs. Change-Id: Ib28e28ea83d4815469484c509921dcde4143135c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611945Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#842062}
-
Josh Karlin authored
Bug: 1160263 Change-Id: I7712b046ebe6533451260bcd425ccb00300912b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597462 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#842061}
-
Marc Treib authored
This adds a new feature param (and corresponding about:flags entry) which, when set to true, makes the profile store the default one for new users. Bug: 1160655 Change-Id: I549b624fdc4cf3f01fdfb0425cc12299d58ed9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599529 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#842060}
-
Peng Huang authored
Right now, chromium only supports linking ANGLE statically on Android, to make it easier to work and on related changes on Linux, we should\ support it on all platforms. Bug: 1161513 Change-Id: I9aaef20e88aa14be9881260d6d2b34c8417610a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608029Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#842059}
-
Peter E Conn authored
Change-Id: I785b071c73e7006bf68b25c3fbd6f852d470299a Bug: 1164866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621062Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#842058}
-
