- 29 Sep, 2020 40 commits
-
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /components/paint_preview This CL was uploaded by git cl split. R=mahmoudi@chromium.org Change-Id: I64f78a148bd456e687c1f0948904776925d3ba3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435699 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#811733}
-
Randy Rossi authored
Switching flutter bridge to use the default action verb kClick rather than the boolean attribute kClickable. The boolean attribute was added specifically for Android and has unwanted side-effects including not allowing nodes marked clickable to have navigable descendants. This CL removes a previous work around that was caused by using clickable attribute. Also changing the touch exploration controller to always issue a simulated tap. Ax gestures do not always get propagated to the tap listener via the flutter bridge. This will make for a better user experience for some ui elements that require simulated taps. Bug: None Test: Local display assistant build, unittests Change-Id: I8bb9204d78ef61bb8afc727b9b6b41e2ca05390c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431557Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#811732}
-
Mandy Chen authored
Shortcut deletion result should be false when the shortcut file isn't deleted. Currently the condition is the opposite, which indicates the file is deleted. Bug: 1108109 Change-Id: Id002221b24f50d4b8e3ed931ad71fe9001a0635a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427425Reviewed-by:
Phillis Tang <phillis@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#811731}
-
Haiyang Pan authored
This reverts commit f6c32bf7. Reason for revert: The pool is in a good shape now: http://shortn/_50OsDGj4Ll, and Pie and M CQ do not have test regression Original change's description: > Revert "luci: increase the experimental percentage to 20 from 5 for MM-x86-rel" > > This reverts commit 4f50dcad. > > Reason for revert: Revert to release resource for Android M CQ builder as the bot usage is high now: http://shortn/_6Egeg4knUp > > Original change's description: > > luci: increase the experimental percentage to 20 from 5 for MM-x86-rel > > > > The builder runs a smaller test suite since crrev.com/c/2422710. > > The GCE capacity should be able to hold more traffic. > > > > Bug: 997376, 1127110 > > Change-Id: I23c9bb5b55aa5f335dea3bdc1817c4793fcf9eb0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429249 > > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > > Commit-Queue: Haiyang Pan <hypan@google.com> > > Cr-Commit-Position: refs/heads/master@{#811299} > > TBR=liaoyuke@chromium.org,hypan@google.com > > Change-Id: Iddef5694a45ec74fcfd4bb478008963bde2fcf5c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 997376 > Bug: 1127110 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436854 > Reviewed-by: Haiyang Pan <hypan@google.com> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#811409} TBR=liaoyuke@chromium.org,hypan@google.com # Not skipping CQ checks because this is a reland. Bug: 997376 Bug: 1127110 Change-Id: I33eca2c7caf5991ed82835d5f01d66daf871eec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437700Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#811730}
-
Ahmed Fakhry authored
This reverts commit 58ff1ecf. Reason for revert: Causes consistent failures on linux-chromeos-chrome BUG=1133358 Original change's description: > [Autofill] Add fieldtrial testing config for feature > AutofillEnableStickyBubbleAndUpdatedLogging. > > For more details about the feature please refer to > go/sticky-payments-bubble-dd. > > This feature is currently running 50% in Canary/Dev. > So added this to fieldtrial_testing_config and get ready for Beta. > > Also fixed some tests that will be obsolete when this feature is > launched. > > Bug: 1070799 > Change-Id: I3061a5de8c94e5a7e453e84615d9807fc0baa6b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424078 > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Commit-Queue: Siyu An <siyua@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811449} TBR=mpearson@chromium.org,estade@chromium.org,siyua@chromium.org Change-Id: I7dd8c3382a31cd66a0e9f6876346d8feb0224954 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1070799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438609Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#811729}
-
Bill Budge authored
- Adds a check that V8 did serialize the Wasm Module when receiving the OnModuleCompiled callback. Bug: chromium:1126862 Change-Id: Ie329372b14785a3975f5f8dce5f9ef49b74ec95c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406589Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#811728}
-
Thomas Lukaszewicz authored
This CL adds a UMA histogram to track the API performance of the getTabs() API for TabSearch. Matching WebUI CL below: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3291206 Bug: 1099917 Change-Id: I8ddfddd5197f0d0641a3dcc3bf6c86fe118c07fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432589 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#811727}
-
Tomasz Śniatowski authored
Make it so targets that set enable_desugar=false end up with desugar disabled, instead of still enabled. This affects at least the following targets that tried to disable desugar but it didn't work until now: //third_party/byte_buddy //third_party/accessibility_test_framework //third_party/google-truth Change-Id: I074c26e988311cc6d04dc0173da676f33b225283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437376 Commit-Queue: Tomasz Śniatowski <tsniatowski@vewd.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#811726}
-
Alice Wang authored
This is a reland of a5707a7d Original change's description: > [Android][Signin] Add observer to listen to monogram update > > This CL adds an observer to update ProfileDataCache when user's profile > photo(include monogram) from IdentityManager is updated. > > Bug: 1127886 > Change-Id: I0c70f72708e50dceb63eb122055315f7818cba06 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430984 > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Commit-Queue: Alice Wang <aliceywang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811237} Bug: 1127886 Change-Id: I999a07675d63595cd9e321fa3a224a4cfb7a0f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437430 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#811725}
-
Martin Rodriguez authored
This metric extend cl/2047063. This allow to collect the same metrics when policies are load from disk. Bug: 653849 Change-Id: I044c8236be37d28ea43c94c508088faa7e5b6d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422785 Commit-Queue: Martin Rodriguez <rodmartin@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#811724}
-
DimanNe authored
R=ioanap@chromium.org Bug: 1112804 Change-Id: Ib821db81a139c3bd01d22ca1319b2c749d45dda2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421738Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#811723}
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /components/plugins This CL was uploaded by git cl split. R=tommycli@chromium.org Change-Id: Ic82fae77b2f270d0b10e9354d903498d7c33117a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435331 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#811722}
-
Tommy Li authored
Add some comments about URLFixer, which should not be used on anything other than user-typed strings. Also warn that URLFixer deviates from GURL's logic with segmentation, which leads to Chrome parsing strings differently from GURL and Javascript's URL object. That is troublesome. This CL makes no code changes, just commentary updates. Bug: 1130091 Change-Id: Ib0302db96870c1fa4258541b2cd8a76a729b669a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437071Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#811721}
-
Egor Pasko authored
Tbr: erikchen@chromium.org Bug: 801006 Change-Id: I177ad5a127c2ff5e17b0d036351fe735f862b173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437436Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#811720}
-
Clemens Arbesser authored
Currently, we don't have a good way of transitioning lite scripts from CCT to regular tab. This changes the activity, but does not update the dependencies of the lite scripts, thus leading to crash when accessing those dependencies. As a workaround, this CL disables stops lite scripts when transitioning from CCT to regular tab. This is an edge case, so disabling this should not affect the scheduled LE. For a proper fix, we need to investigate how to update the dependencies such that lite scripts can continue safely. Bug: b/167947210 Change-Id: I1524805015766c69f463892a9bec4d5b9c5a284e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431484Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#811719}
-
Chris Sharp authored
Bug: 1018157 Change-Id: Ia4d5e4f1e09e5fa659c09b0eb68406b566e8a6eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435665Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#811718}
-
Dan McArdle authored
The fuzzer discovered an input that uncovers non-idempotency in ContentSettingsPattern::Builder::Canonicalize. First, the function changes |parts->path| from "/.//" to "//". On a second call, the "//" is changed to "/". This CL repeats the path canonicalization until we reach a fixed point. Bug: 1117622, 1132957, 1128999 Change-Id: I96da902e50a4a9b654a7d4184ef4ad2c0689e705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406332 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#811717}
-
Clemens Arbesser authored
This is not a proper fix, but the workaround is safe and simple. There does not appear to be a good way for listeners of the BottomSheet to tell the difference between a swipe-down to PEEK state versus a swipe-down to dismiss. However, since lite scripts disable the PEEK state altogether, we can use the onSheetClosed(SWIPE) notification to workaround this issue for now. Bug: b/169237887 Change-Id: Iaf8158aa01d2259f993553860cb0825ca3a76ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428887Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#811716}
-
Anastasiia N authored
Point account_manager_* per-file OWNERS to OWNERS of Chrome OS Account Manager. Change-Id: Ie7d1a218182eaafdd5df6f06e950f1b4707c093d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438249Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#811715}
-
Michael Thiessen authored
The Feed setup isn't used by most tests and is required to happen once per process init, which make batching tests that use ChromeTabbedActivityTestRule more difficult. There's already a rule to do what CTATestRule was doing, so I've migrated the only test that seems to care about that setup to the FeedDataInjectRule. Bug: 989569 Change-Id: I8142a3904276a294356789f246d977c93f6e48a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437691Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#811714}
-
Guido Urdaneta authored
This allows enterprises to use deprecated protocols (to be disabled by default) for compatibility reasons. Bug: webrtc:10261 Change-Id: I07747b397ab10fb1b2e7f9ba88db9921898f9090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364614Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#811713}
-
Aya ElAttar authored
- Changed the strings of toasts shown on clipboard data access failure to include the hostname of the source of the clipboard data. Bug: 1096461 Change-Id: If86451d115b41da99d4d897b2dec9e1f327924d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436729 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#811712}
-
Anastasiia N authored
Pass session_type to lacros-chrome and use it in Profile::IsGuestSession and profiles::IsPublicSession. Change-Id: I998ffa0015a354d587e071152e047cba53549c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424252Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#811711}
-
Colin Blundell authored
The comment refers to a "Delegate" class that is actually SubresourceFilterClient. Bug: 1116095 Change-Id: I1fc0d00149bd640b19f7f42c98e7990cecad171f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435111Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#811710}
-
Vladimir Levin authored
This patch generalizes the find-in-page fix we had previously to also apply to other methods that can use to scroll the viewport to the element in a locked subtree. Specifically, this keep the lock unlocked for two frames to ensure that the visibility notification kicks in to keep it unlocked until the user scrolls away. R=chrishtr@chromium.org Bug: 1132869 Change-Id: I598f82f73429e41839a6675321eb6fb1eb84f6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435808Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#811709}
-
Yaron Friedman authored
Also some cleanup unifying/simplifying the setup fixture. Change-Id: I6cbbcb5cbbd01f548ac87f80a71cc2b8f656f7ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431450Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#811708}
-
Gavin Williams authored
Delete printer-status-icon-cros element as it's no longer needed/being used in print preview. Replaced with a dedicated printer status icon SVG. Bug: 1123754 Change-Id: Ie4c2bf0c91c655fdead9a9ecf3387d94a3585502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433305 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#811707}
-
Yi Gu authored
Sample failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/38003 TBR=msw@chromium.org Bug: 1066607 Change-Id: I1fb2fda946b8852ff46a03beac69f8137cd323dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437738Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811706}
-
proberge authored
The histogram is occasionally used to measure CTR on the prompt. Presubmit told me to run histogram_paths.py, which re-ordered the renderer/renderer4 histograms. Maybe sorting works differently on Windows vs Linux? Bug: 1089504 Change-Id: Iad2b2ec12df0d618f6fbac8de77f29c5d954ca4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435467 Commit-Queue: proberge <proberge@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#811705}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601358844-3b872c2864f88be4ab51b10f2fd5f4046a4261fe.profdata to chrome-mac-master-1601380366-c2cef07ee462371a6daba327da84ce5730b353c6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ica4cde95f617584d56bdf0a08dbfb4dd7dc54cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437516Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811704}
-
Laís Minchillo authored
Bug: 1122903 Change-Id: Ia323b20dc976b38cf5c513d7147bf3b2fbe11b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437814 Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#811703}
-
Yi Gu authored
This reverts commit 7b693e30. Reason for revert: caused test flakiness on several bots. e.g. https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/12320 Original change's description: > [iOS][Password Check] Rewriting Passwords test with new details screen > > This change rewrites Passwords tests with new Password Details screen. > Obsolete tests are deleted. Fixed flakiness for > testSearchAndDeleteAllPasswords. > > Bug: 1075494, 1129441 > Change-Id: Id6d44a2f77c20edb1788f1d3dcaa04e9e645cdb5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418853 > Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811668} TBR=eugenebut@chromium.org,gambard@chromium.org,vsemeniuk@google.com Change-Id: I9bd75ad7f3173c30e9174e0728575f77d8abdd10 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1075494 Bug: 1129441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438430Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811702}
-
kylechar authored
The test passed 100 of 100 runs locally so I think we can remove the test expectations for RetryOnFailure. Bug: 1097962 Change-Id: I2bb483528c5307011e128a738bf779b66d92df37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435283Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#811701}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601358844-b8defbe977309018021c72a700e18c84f94d16d4.profdata to chrome-linux-master-1601380366-03c4c1b9f0c0034a1b47d4510e955a5823e9948c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com Change-Id: I9d8dadae361e1d1684465474da6b385872f5ff2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438164Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811700}
-
Tomas Popela authored
The main reason for the flag is so called dialog hell, when you try to share the screen on Wayland through PipeWire. To address it we've created two changes, that are currently under review[0][1]. Once the review is done and code merged, then the testing needs to be figured out[2]. Once that's done the flag could be removed. [0] - https://webrtc-review.googlesource.com/c/src/+/160649 [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1942327 [2] - https://bugs.chromium.org/p/chromium/issues/detail?id=1124347 Bug: 682122 Change-Id: Ifbe91fda3d58d5eeaace7aff438cc0c0e08dbde7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438054 Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Tomáš Popela <tomas.popela@gmail.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#811699}
-
Yi Gu authored
See bug for details. TBR=hansenmichael@google.com Bug: 1133295 Change-Id: I18353dee3eac0b18a1e5f4ccb6d333c3f0561662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438192Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811698}
-
Hidehiko Abe authored
This reverts commit 465489da. Reason for revert: The original CL was reverted in order to revert the depending CL. Now the fix there is available, relanding this CL. Original change's description: > Revert "exo: Send keysym on zwp_test_input_v1_send_keysym." > > This reverts commit f4423821. > > Reason for revert: Blocking the revert of a CL that blocks chrome-uprev. See issue 1132766. > > BUG=1132766 > > Original change's description: > > exo: Send keysym on zwp_test_input_v1_send_keysym. > > > > According to the document, the zwp_test_input_v1_send_keysym's argument > > named |code| should be XKB keysym. > > Currently, XKB keycode is sent, so fixed to the collect one. > > > > BUG=1123705 > > TEST=Ran locally. Made sure expected keysym is sent to client. > > > > Change-Id: I9db31cf84b21a7c9a400d75bcbec2fbfe69a2ad4 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432165 > > Reviewed-by: Jun Mukai <mukai@chromium.org> > > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#810912} > > TBR=mukai@chromium.org,hidehiko@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1123705 > Change-Id: I7852ff3d577044e82cd2f8fb5c859f1947b1b3fa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436509 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811362} TBR=mukai@chromium.org,hidehiko@chromium.org,afakhry@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1132766 Bug: 1123705 Change-Id: I6ba86f015ba597625a4c2ff8ffaba5d7b796d272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437545 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#811697}
-
Laís Minchillo authored
Bug: 1111789 Change-Id: I53dec0cac2c6a28ea70aa7ee215cd4c1325ef054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421653 Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#811696}
-
Tanmoy Mollik authored
Add a sign-out icon on the sign-out row in AccountManagementFragment Screenshot: https://crbug.com/1131891#c2 Bug: 1131891 Change-Id: I3820aab37d54d7e9dd0e525dc0141072b884ef07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435193 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#811695}
-
Martin Šrámek authored
Although there already is a histogram tracking NTP promo clicks in general, we need to also add an action, so that we can measure the funnel from this promotion to the actions the user takes in settings on the action sequencing dashboard. Bug: 1015841 Change-Id: Ic68918b48339402af7d700d7d134eb242ee8537f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429048Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#811694}
-