- 17 Jun, 2020 12 commits
-
-
Mustafa Emre Acer authored
This CL adds a new enum (IDNSpoofChecker::Result) and returns it from IDN spoof checking code. This result will then be used to convert some punycode fallback cases to other types of UI (interstitials or safety tips). Bug: 1095120 Change-Id: I68c1b3c639edc3f71a0f2c4d3d5adbce7a689c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246833 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#779095}
-
Nigel Tao authored
In general, if M files #include a utility header and that header file also #include's N files then, very roughly speaking, compilation has to process O(M * N) lines of code. This can get increasingly expensive the more a utility library becomes a dumping ground of all manner of miscellaneous helpers, increasing both M and N. A general counter- measure is to move #includes out of the .h file and into the .cc files that actually depend on the specific type (e.g. FilePath, TimeDelta, UnguessableToken, etc). This commit does that for the base::Time and base::TimeDelta types. Bug: 1086733 Change-Id: Id6009c8377d27eea5c48f1b22c757410e2f13f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247938Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#779094}
-
Mei Liang authored
This CL does the following: 1. Let LayoutTab extends PropertyModel and converts all the private variables to a PropertyKey. 2. Updates all setters and getters to use the PropertyModel#set() and PropertyModel#get(). 3. Delete all FloatProperty 4. Move all computational logic out of LayoutTab. Change-Id: Ia9c74c79b90b52f13d554198fda05837b3ab79ec Bug: 1070284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149626Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#779093}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/959037e082f6..f4e6ae915eda 2020-06-16 stuartmorgan@google.com Fixes missing newlines in headers 2020-06-16 syoussefi@chromium.org Vulkan: Use GPU path for copy to sRGB textures 2020-06-16 timvp@google.com Remove mProgramState from ProgramExecutable::isCompute() 2020-06-16 timvp@google.com Remove mProgramState from ProgramExecutable::updateActiveImages() 2020-06-16 m.maiya@samsung.com Vulkan: Ensure tiling mode compatibility while deciding copy path If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Test: Test: Build/CQ Change-Id: I7ebce81a53473bbca5c8b0ad7dcc00c81fddeb04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248938Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779092}
-
Xiang Ji authored
Minor changes: - Add pyperclip in the test lib - Only two clients machine in AD is enough for WebProtect tests Bug: 1090582 Change-Id: I3bfa3e12b531f65eaeb29712e01695769fc0491f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246849Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Xiang Ji <jxiang@google.com> Cr-Commit-Position: refs/heads/master@{#779091}
-
Cammie Smith Barnes authored
There were several occurrences of "Replaced With PageLoad.Cients.Ads" among obsolete histograms. Change-Id: I4b6f09f0397825af7dc633059a0b9794a45e69c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247325Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#779090}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0811b8c48729..b1201523fc7a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC liberato@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1091256,chromium:1092340,chromium:1095517 Tbr: liberato@google.com Change-Id: I6168ce247f3825029a10a7b199e5bf426e58dee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248920Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779089}
-
Sven Zheng authored
Change-Id: I1a932db9798696bc293da6b791031115def0daa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248881 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#779088}
-
Peter Kasting authored
* Fix typos in readme. * Add remaining aliases to functional.h. * Add TODOs for remaining range-based algorithms in algorithm.h. * Provide implementation and test for ranges::lower_bound(). Bug: 1095795 Change-Id: Icfdb99d91dabab4d68013a25b86451ce8c0ed6d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248886 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#779087}
-
Nate Fischer authored
No change to logic, only adds logs. This adds logs to see how users are interacting with the crash UI. Bug: 1084179 Test: Manual - locally add Log.i() calls and verify this works correctly Change-Id: I007f4ddf5871d63a746b2f405a20c543015a42e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241463 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#779086}
-
Darwin Huang authored
https://chromium.googlesource.com/chromium/deps/sqlite.git/+log/b5399f70d477..0879314d807e $ git log b5399f70d..0879314d8 --date=short --no-merges --format='%ad %ae %s' 2020-06-16 huangdarwin Identifiers "TRUE" and "FALSE" cannot take on their boolean constant values if they are operands of the "." operator. Created with: roll-dep src/third_party/sqlite/src Bug: 1094247 Change-Id: I6539c874bb2cc04d283b61b9e6dee3060f08bf0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248668 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779085}
-
danakj authored
R=avi@chromium.org Bug: 866140 Change-Id: Iacc56bf472eaa3eab2938889089dad7a7132e143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248175Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#779084}
-
- 16 Jun, 2020 28 commits
-
-
chrome://flagsRyan Sturm authored
This CL marks omnibox-spare-renderer as enabled in chrome://flags until M92 as we investigate the feature again. Bug: 730587 Change-Id: I96f0ddb6027aca8daf5c72ca4dcbb72a4ca963ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247344Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#779083}
-
Brian Sheedy authored
Switches the unittests in //build/android off the version of pymock from //third_party and onto the version made available via vpython. Bug: 1094489 Change-Id: I0fe024c582b1335eecf1e0b9d05e18122284da07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246190 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#779082}
-
Ben Joyce authored
Last set of test filters to convert. Bug: 1005891 Change-Id: Ie0692a52eda6f3b38debda2a12a7e5b4398b14ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248882Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#779081}
-
Alex Ilin authored
This CL replaces custom keydown handlers in SigninEmailConfirmationDialog and in SigninErrorDialog with "autofocus" HTML attribute. The custom handlers were added to make "confirm" default action when pressing enter. Autofocus achieves the same goal with less code and better accessibility. This CL is a continuation of https://crrev.com/c/2238154. Bug: 1084479 Change-Id: I3a61d325052d42cf0d5b1b213f7e6e1a4c821dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245903Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779080}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ad327885..50097bb2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib80d7aa917637333fb80779c7fba7710e0077dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248839Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779079}
-
Li Lin authored
Bug: b/158798335 Test: unit tests Change-Id: If70621c33e7b6f6da85e8ed570b3c412874503d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242574 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779078}
-
Bailey Berro authored
This change extends the timeout of the DisplayChangeDialog from 10 seconds 15 seconds Bug: 860097 Change-Id: I68dfdde3778ffd42dcb1e92d64df6c392b89541b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245678 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#779077}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/103a73ea1ff1..2e94de596ef3 2020-06-16 tommi@webrtc.org Add GetSctpStats to PeerConnectionInternal, remove sctp_data_channels() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2f5c905398516c44cd6f3b7f1a1a84b81528d4c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247089Reviewed-by:
-
Marco Paniconi authored
https://chromium.googlesource.com/webm/libvpx.git/+log/c1765573149e..5174eb5b9236 $ git log c17655731..5174eb5b9 --date=short --no-merges --format='%ad %ae %s' 2020-06-15 marpan vp9-svc: Fix to dynamic resize for svc denoising 2020-06-11 angiebird Let SetExternalGroupOfPicturesMap use c-style arr 2020-06-08 angiebird Fix assertion error in simple_encode.cc 2020-05-29 angiebird Refactor simple_encode_test.cc Created with: roll-dep src/third_party/libvpx/source/libvpx Change-Id: I64c9f20e7795bfe513e39b76607ad555de05b48b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248481Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Marco Paniconi <marpan@google.com> Cr-Commit-Position: refs/heads/master@{#779075}
-
Joe Laughlin authored
Events were logged with the keyword set to 0, and bits in the reserved range were used to enable logging. Additional details about keywords: Bits 48..55 have predefined Microsoft semantics, as documented in winmeta.h. Using these bits for something other than the predefined Microsoft semantics is unsupported and may cause unexpected behavior. Bits 56..63 (the top 8 bits) have predefined semantics for Event Log. Using these bits for anything other than the normal Event Log purposes will make it impossible to ever use these events in Event Log. Some ETW decoders are aware of these special definitions and might assume that you are using the bits for their documented purpose. That may cause confusing results based on how the decoder treats the events. None of this is fatal, and none of this will cause huge issues, but the ETW team cannot recommend the use of reserved bits for alternative meanings, and we may add new special behaviors to these bits in the future. Note: The format of events logged also changes to look more like manifested ETW events and includes the keyword value for the category groups specified at the logging site. R=brucedawson@chromium.org, nuskos@chromium.org Bug: 1076230 Change-Id: Iaecbf01744ff2dd3607023e5f61f60dfcd29ade0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171974 Commit-Queue: Joe Laughlin <joel@microsoft.com> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#779074}
-
Maxime Charland authored
Copy original Incognito Tab Switcher body string and remove period. Add screenshot for new string. Change-Id: I9cf696f114e663fde5feb892074bcf2309f52424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245890Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Maxime Charland <mcharland@google.com> Cr-Commit-Position: refs/heads/master@{#779073}
-
David Bertoni authored
These tests were disabled on Mac ASAN for flakiness, due to bug 496955. That bug has been fixed and these tests are no longer flaky. Bug: 851854, 496955 Change-Id: Idd52325c2103cb5518dc058242abeb27c1107451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238339Reviewed-by:
Archana Simha <archanasimha@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#779072}
-
Henrique Nakashima authored
Also pull WebContentsState out of TabState. Bug: 1090048 Change-Id: I82eb800afbe7748944e8529c797f57a8ba2b6b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241863Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#779071}
-
Xing Liu authored
Now we can see the date time picker when choose download later option in the download later dialog. Also fix an issue that DownloadDateTimePickerDialogTest failed on Android L when mocking WindowAndroid. Bug: 1078454,1094925 Change-Id: If203ac4a544c90eaad885198add745b46700c083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248449Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
-
Anupam Snigdha authored
This patch contains the CSS environment variables for the virtual keyboard rectangle that are updated when geometry change occurs. This was a feedback from TAG review: (https://github.com/w3ctag/design-reviews/issues/507) Bug: 856269 Change-Id: I1cf5bd234f388fbab0083398f46f70ed7a1482a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244196Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Robert Kaplow authored
Bug: 1088044 Change-Id: Ib47ad031d3d851093119ae42576da6bec6c4b82b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222902 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Xing Liu authored
The Android IPC INotificationManager.enqueueNotificationWithTag() might be corrupted when we processing web notifications. This CL only catches the exception, the root cause is still unknown. Bug: 1077027 Change-Id: I180ff015031d38cb1ae0abbbde05a732e22cd153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247539 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#779067}
-
Adam Ettenberger authored
Minor change to move the test-only class DispatchStub into its own file so it may be shared between multiple unittest files. Split out from : https://chromium-review.googlesource.com/c/chromium/src/+/2188057 Bug: 928948 Change-Id: I8bf6338304a1ddb90c4696c98b15b58cc49e3c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244453 Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#779066}
-
Yue Li authored
Bug: 1088592 Test: Manual Test Change-Id: If6a3b674872e40eea57eef623d35beb47d86b4c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242753Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#779065}
-
Xiaoqian Dai authored
ones. Rename them per the request from UX. Pure renaming, no functional change. Bug: 972162 Change-Id: I73c5d4b03f9424afe954f8f4afc5345477e63cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248670Reviewed-by:
-
Taylor Bergquist authored
Bug: 1093528 Change-Id: I0b40ecc88a70faba6f602fa286c1e16fb09c575b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248177Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#779063}
-
Raymond Toy authored
Instead of processing the data one sample at a time, we can process a block at a time by doing large memcpy's and then some vector operations to interpolate the samples. As a final micro-optimization, if the interpolation factor is 0, we can skip the interpolation phase altogether. Using (a slightly modified) Spotify's Web Audio Bench, we have the following results using 500 runs of 10 sec each (the default) on a linux machine: Without CL: TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV Baseline 594 594 740 751 761 3215 757.82 146.55 Delay-default 331 331 387 405 416 2124 406.47 81.65 Delay-0.1 344 344 401 423 440 834 425.68 41.04 DelayAutomation-a-rate 675 675 748 763 779 1262 768.23 42.97 DelayAutomation-k-rate 365 365 424 444 460 1036 446.24 38.61 With CL: TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV Baseline 736 736 747 756 765 901 758.57 17.76 Delay-default 180 180 230 249 267 1467 256.75 77.1 Delay-0.1 233 233 302 317 332 2402 322.39 96.86 DelayAutomation-a-rate 612 612 683 698 713 983 701.78 33.85 DelayAutomation-k-rate 206 206 281 299 318 522 305.34 37.96 As we can see, the CL speeds up processing the default by 38%, delay-0.1 25% and k-rate by 32% (using the mean and not us results). One layout test needed to be updated to handle numerical differences for mac. The implementation of Vsma on mac is different from linux and windows. and this difference shows up in the test. (Mac uses VDSP_vsma, instead of our hand-written Vsma. VDSP_vsma might be using an FMA which has different round properties.) Bug: 1087071 Change-Id: I2b95096fef9fd1e5f7c87e4f4bdfa7d52f5b8d58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171843 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779062}
-
Dirk Pranke authored
The //docs/contributing.md file talks about how all code in Chromium must be relevant to the project, but as written it was somewhat circular ("should be in service of other code"); this CL updates the wording a bit to try and clarify how completely new top-level things (like //fuchsia) get approved. R=jochen@chromium.org, haraken@chromium.org, darin@chromium.org Change-Id: I35246fff40d3cec0700e55d904f63973db2eaee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246830Reviewed-by:Darin Fisher <darin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#779061}
-
Olga Gerchikov authored
animations change https://chromium-review.googlesource.com/c/chromium/src/+/2223998 change introduced memory regression as a result of adding HeapHashSet data member to NodeRareData. This change replaces HeapHashSet with Member<HeapHashSet...>, thus reducing additional memory from 24 to 16 bytes on windows per NodeRareData. Bug: 1093776 Change-Id: Iaaecd9fc7d2221313f3949a790408a2c88a64b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241190Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/master@{#779060}
-
Omer Katz authored
Users of Oilpan should not manually call the write barrier. Bug: 986235 Change-Id: Iacf133c5f3f2ea10bde9041da65c9754b889a8ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246571 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#779059}
-
Michael Montvelishsky authored
Bug: 159159163 Test: build and run Change-Id: I1217ca75f722bb1bcac019a3b0a3d4debc524925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248888 Auto-Submit: Michael Montvelishsky <mont@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#779058}
-
Clark DuVall authored
This fixes some padding issues with views that use RippleBackgroundHelper and matches what Chrome does. Bug: 1019922 Change-Id: Icc7424715e7494529d7fb519127ea7bd6bd249ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248861 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#779057}
-
David Benjamin authored
This helper class is all but unused. Probably a remnant of another crypto backend. Also remove a redundant EVP_CIPHER_CTX scoper since BoringSSL already provides one. Bug: none Change-Id: Ie4594313fbe4ecc0b0352a92c361ca3e77665eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245889 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#779056}
-
