- 15 Feb, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/651be6222cab..af985a85c457 git log 651be6222cab..af985a85c457 --date=short --first-parent --format='%ad %ae %s' 2020-02-15 treehugger-gerrit@google.com Merge "processor: Accept TrackEvents without valid incremental state" Created with: gclient setdep -r src/third_party/perfetto@af985a85c457 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I760ca0aba67b95bbf0eaf6831606f3bc8710642a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058452Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741732}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I2b458ce3eef960632cf1ed94ed62438108efe65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058455Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: If791a7def5b896fec4e7ac8c376d83951076ce03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058011Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741730}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e3925648df2d..55e300fa1098 git log e3925648df2d..55e300fa1098 --date=short --first-parent --format='%ad %ae %s' 2020-02-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@55e300fa1098 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I549c75e12c7eec2d9800df3710ea83ce66d3c861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058451Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b15b7e551c39..1d3482867b00 Created with: gclient setdep -r src-internal@1d3482867b00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I00774c79dc3e7a02e4400c02a24df179f334978c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058449Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741728}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8f64176566f7..651be6222cab git log 8f64176566f7..651be6222cab --date=short --first-parent --format='%ad %ae %s' 2020-02-15 eseckler@google.com Merge "processor: Parse StreamingProfilePacket timestamps during tokenization" Created with: gclient setdep -r src/third_party/perfetto@651be6222cab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ibb0beb6c308d3fdb4ace63cc51563a51750f79ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058450Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/41a0cf2b997a..b15b7e551c39 Created with: gclient setdep -r src-internal@b15b7e551c39 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia7bb852b07bd6bb62fbf36cb17cb2c75eabb4e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058348Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/05676f7bc238..b7ceaa8efd2b git log 05676f7bc238..b7ceaa8efd2b --date=short --first-parent --format='%ad %ae %s' 2020-02-15 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps Created with: gclient setdep -r src/third_party/skia@b7ceaa8efd2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: I7869c1e3d23c418040071b09c41d5a945f8ad280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058343Reviewed-by:
-
Wei Lee authored
Bug: 980846 Test: Launch CCA with no error shows Change-Id: Id089b788f3d7746cbae13f2fa82c9793ed8e5ae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054658 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#741724}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3db5c03ac2cd..41a0cf2b997a Created with: gclient setdep -r src-internal@41a0cf2b997a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I35f5affa7f4b640ce8c2c0226c32c26da42df2e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058137Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/12a36dd9ea4a..798a83759956 git log 12a36dd9ea4a..798a83759956 --date=short --first-parent --format='%ad %ae %s' 2020-02-15 jmadill@chromium.org Vulkan: Add more debug labels handling with graph off. Created with: gclient setdep -r src/third_party/angle@798a83759956 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I0aec321d83d150ab9a99c6b1e3581a89171135d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058135Reviewed-by:
-
Wei Lee authored
Bug: 980846 Test: Launch CCA with no error shows Change-Id: Ibfeaa29d07a8ddd76ff47aad85e1527df6fff1c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053869 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d8c8ba85..676acee7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icb744b55e84431cf4e48a391c7dcfc24787d430c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057011Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741720}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/38e9e47300ac..3db5c03ac2cd Created with: gclient setdep -r src-internal@3db5c03ac2cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If955684c5faedf4aad6eef2e39cdd2e3951bf141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058133Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4cf033f54a80..e3925648df2d git log 4cf033f54a80..e3925648df2d --date=short --first-parent --format='%ad %ae %s' 2020-02-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@e3925648df2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I149879ed91d71ddfd2f099037846586632f75004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058134Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/08b11cafae02..966bcc4bd5cc git log 08b11cafae02..966bcc4bd5cc --date=short --first-parent --format='%ad %ae %s' 2020-02-15 tkchin@webrtc.org Revert "Update RTCEncodedImage to not use deprecated mutable_data call." Created with: gclient setdep -r src/third_party/webrtc@966bcc4bd5cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9d705cc641724ba24c87abb907b189a1a0e5fc09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058132Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/591a14bda6ae..4cf033f54a80 git log 591a14bda6ae..4cf033f54a80 --date=short --first-parent --format='%ad %ae %s' 2020-02-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@4cf033f54a80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I60223493a6f43d8a61f8e2cf801b51d6e3621e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056577Reviewed-by:
-
Simon Que authored
This reverts commit 765c53e1. Reason for revert: iOS build does not fully work on RBE: crbug.com/1050976 Original change's description: > infra: Migrate builders to Goma RBE (iOS Week 1a) > > These are the two builders in webrtc.fyi: > - WebRTC Chromium FYI ios-device > - WebRTC Chromium FYI ios-simulator > > These builders are small. They are expected to have a peak traffic of > 15 QPS: > https://docs.google.com/spreadsheets/d/1-XKh-CqSoUcXEqCETVywjmIo1C18P0qEBDCY50ozBb0/edit#gid=1721756715 > > Schedule of migration: > https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 > > R=agable@chromium.org, bpastene@chromium.org, jbudorick@chromium.org, tikuta@chromium.org > > Bug: 950413 > Change-Id: Id47cc7887bbefaf4dfe9f72275b80c8f04c428a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043185 > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Reviewed-by: smut <smut@google.com> > Commit-Queue: Simon Que <sque@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739771} TBR=sque@chromium.org,agable@chromium.org,yyanagisawa@google.com,smut@google.com,tikuta@chromium.org,bpastene@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 950413 Change-Id: I6b79ddba47c65381139130ce7532afcfd3395562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056527Reviewed-by:
Simon Que <sque@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#741715}
-
Wei Lee authored
Bug: 980846 Test: Launch CCA with no error shows Change-Id: I8471337e432683dcb8eccbd4a9ec68e45948de99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053868 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0aebddcb..d8c8ba85 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9d893611fb1ad4c75b168d7d1fe544fd4b162e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057010Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bb7534ee99ce..12a36dd9ea4a git log bb7534ee99ce..12a36dd9ea4a --date=short --first-parent --format='%ad %ae %s' 2020-02-15 jmadill@chromium.org Vulkan: Add debug utils functions to wrapper. Created with: gclient setdep -r src/third_party/angle@12a36dd9ea4a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I566f4f529ab5d4a18d2b4cfcaee073e303c7f1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056573Reviewed-by:
-
rbpotter authored
- Autogenerate P3 versions of prefs.js and prefs_behavior.js - Add targets as necessary, add files to grdp - Autogenerate tests for P3 version of prefs. Bug: 1026426 Change-Id: Ia54cbced589fdb4bc1af4cd08f33e78a8396ac62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058009 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#741711}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I5e12e8b1512f45419345a90637daaadc0ab30058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057246Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741710}
-
Wei Lee authored
Bug: 980846 Test: Launch CCA with no error shows Change-Id: Iaa7e9ac65f55b49c2a656e17794f5892248cbece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053867 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
-
Amy Huang authored
This change makes clang build with a new debug info mode (added to LLVM in https://github.com/llvm/llvm-project/commit/651128f5) with the goal of reducing debug info size. The new debug mode only emits class type info when a constructor is emitted. This avoids emitting class type info everywhere a class is used. I built chrome with and without this change on Windows and Linux: Change in .obj files on Windows: Before: 38416945 kb After: 22485379 kb % diff: 41.5% Change in .o and .dwo files on Linux: Before: 12996366 | 16508965 kb After: 12155224 | 6409893 kb % diff: 6.5% | 61.2% Change in total build directory size on Windows | Linux: Before: 51483873 | 37913685 kb After: 35213926 | 26766367 kb % diff: 31.6% | 29.4% I did some local non goma builds and they seem to be slightly faster some of the time. For the full chrome build, before | after Linux: 1:47:11 | 1:45:52 Windows: 52:55 | 50:26 In an incremental build, linking chrome.dll on Windows took around 32-37 seconds before and 28-31 seconds after. I can't see a noticeable difference for incremental builds on linux. I also built a random cc_unittest on Windows and the debug info in Visual Studio looks the same. Change-Id: I02b86d74a859922274be292d1af49fc6030476f0 Bug: 1050118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040441 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#741708}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/71b3dd56da8d..215b5370bc4f git log 71b3dd56da8d..215b5370bc4f --date=short --first-parent --format='%ad %ae %s' 2020-02-15 cwallez@chromium.org CMake: Add support for the OpenGL backend Created with: gclient setdep -r src/third_party/dawn@215b5370bc4f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I7493a6a9f106cd3861c5260be8a63eebe7afb4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056572Reviewed-by:
-
Demetrios Papadopoulos authored
Originally landed at https://chromium-review.googlesource.com/c/chromium/src/+/2045171 but reverted because of a test failure in linux-chromeos-dbg. Fix for the test failure is included here. Bug: 1026426 Change-Id: Ia8b824ac020239b1c041f24c71c5e8da1a6706ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051028 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#741706}
-
chrome://extensionsToby Huang authored
This CL reverts the changes in crrev.com/c/1956227 and restores the enable toggles instead of buttons on the chrome://extensions page to ask for parental approval. This design reversal was made after deciding to launch the parent approval dialog on the chrome://extensions page directly instead of jumping to Chrome Web Store in a new tab. If an extension is disabled pending custodian approval, clicking the enable toggle should launch the parent approval dialog on the chrome://extensions page directly, once the dialog is ready. If the enable attempt succeeds, the toggle remains enabled. Otherwise, the toggle automatically goes back to the off state. Bug: 1045509 Change-Id: Ib2e0995942568027ea70168f16ccc00ac51aba40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040195 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Sammie Quon authored
It was a clause that was always returning true, thus skipping the next clause which happens only if: 1) User is in snapped splitview with desks. 2) User drags window on top of splitview window, up to the same side as the desks bar, and then across to the desk bar (and reverse), almost as if to intentionally avoid the desk bar. With this CL, users who follow the above steps will get a slightly better UX. Test: manual Bug: none Change-Id: Ib7d352466fadaf4a61e3a0534c66982a42752380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057595 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#741704}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ab921263..0aebddcb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I451e6783490515ca9ffff1f763e8f371fd78e216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057824Reviewed-by:
-
Robbie McElrath authored
This CL makes WebView record a new Variations.DownloadJobFetchTime metric from WebView's service via a new IVariationsSeedServerCallback AIDL interface. See doc/1qNASRaqCeRdpbH84IpqsSPzR8R8U6M-sUyHeAZCVrzw for more details. Test: out/aw/bin/run_webview_instrumentation_test_apk -f \ Test: 'AwVariationsSeedFetcherTest#*' Test: out/aw/bin/run_webview_instrumentation_test_apk -f \ Test: 'VariationsSeedLoaderTest#*' Test: out/aw/bin/run_webview_instrumentation_test_apk -f \ Test: 'VariationsSeedServerTest#*' Test: Manually verified correct metrics were being recorded by adding Test: logging when recording the metrics. Bug: 1047536 Change-Id: I5a34df24a3dc9c6250a45dce976c2f759fd8c0a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039812Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#741702}
-
rbpotter authored
- Replace exportPath() with updatePrefPath_() in prefs.js - Make exportPath() fully private in cr.js and remove parameters that are only used from prefs.js. Bug: 1026426 Change-Id: I58e1da64902ee07ad4298060544056d16cce3413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056609Reviewed-by:
-
Matt Mueller authored
Bug: 991247 Change-Id: I598a9130b5d5f15aa24041a6f739abf578842c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052612Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#741700}
-
Philip Rogers authored
This treewalk can eventually move into the prepaint tree walk but for now just put it in the correct lifecycle step. When CompositeAfterPaint launches, much of the descendant dependent update will be removed and it will be easy to incorporate it into the existing prepaint walk. Bug: 941180 Change-Id: I53f38f36552a824fe6086f37e90c4f958e969f6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044453Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#741699}
-
Thomas Guilbert authored
The fix in 0b6135a7 introduced a new flake. It's possible for the video.rAF callback to be fired by the second video's first frame size, before the seek even completes. This CL fixes the issue by queueing the video.rAF call for the second frame size after the first frame size has painted. Bug: 993671 Change-Id: Iecf1601cdc5b76361ddfb9a62a718092ace90468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033628 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#741698}
-
Regan Hsu authored
This CL records user action focus when the settings window focuses and blurs when the settings window blurs. Bug: 1049830 Change-Id: Id229e6baae50daa3ef44d7b58497004ce25e5941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042748Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
Chris Harrelson authored
It launched a few releases ago. Bug: 603193 Change-Id: Ie91cdc164ea86eb4dcd702fb8a898fee7a481c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057867Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#741696}
-
Andrew Xu authored
There is the legacy code in ScrollableShelfView::HandleMouseWheelEvent: if the shelf is horizontally aligned, ScrollableShelfView checks whether it should handle the mouse wheel event and if not it will redirect the event to Shelf (to affect the launcher visibility). In fact, event redirection is unnecessary in the current code. On one hand, for the touchpad scroll (which may be also received by View::OnMouseEvent), ScrollableShelfView::OnScrollEvent will check whether the scroll event should be handled here or by Shelf. In addition, OnScrollEvent is hit before OnMouseEvent. On the other hand, for the real mouse wheel event, from the perspective of the expected UI behavior, it does not make sense that ScrollableShelfView redirects the event to Shelf. Because when scrollableShelfView receives the mouse wheel event, it implies that the mouse cursor is within the bounds of ScrollableShelfView. In this CL, this part of legacy code is removed. Besides test cases related with the touchpad event and mouse wheel event are created. Bug: 1052191 Change-Id: I8b42545ad89edba23ebec2b4ae19f4c5dbf2505c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057095 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#741695}
-
Alex Cooper authored
This is a reland of 96d43c20 Changes for reland: * SERVER_PORT variable moved from individual tests to XrTestFramework * XrTestFramework configures embedded test server to use HTTPS * RenderTests set their port explicitly. * Tests that were setting server port/not expecting HTTPS were updated * Re-add GetFileUrlForHtmlTestFile for use by testFileUrlEmphasis * Update Goldens as a result of URLs changing from file to server, and from the default http to https. (Goldens pulled from Patchset 3 of this CL). Original change's description: > Switch Android VR tests to use embedded test server > > As part of the work to use the permissions prompt by default, instead of > the custom consent dialogs, tests will need to be updated to use the > embedded test server rather than directly navigating to a file. This is > due to the fact that the Permissions code will DCHECK if saving the > permission for a file-type URL. > > Bug: 1043241 > Change-Id: Iaa820812fac0bc389af47c22f8e069e81929b05a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047987 > Commit-Queue: Alexander Cooper <alcooper@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740399} Bug: 1043241 Change-Id: I208c6f0517bfc2f382466631f3844fc11cec5375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049839 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#741694}
-
Jazz Xu authored
This CL fix the issue by updating pip availability when media loading is complete. Bug: 1051142 Change-Id: Iea84f73aca6af85d951f4e7ca20240b597ef0ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044657 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#741693}
-
