- 21 Nov, 2018 22 commits
-
-
Noel Gordon authored
No change in test behavior, no new tests. Bug: 905934, 847729 No-try: true Change-Id: Ic1a9b352260670b643bb60cae6cfb5483f80ea70 Reviewed-on: https://chromium-review.googlesource.com/c/1345374 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#609879}
-
John Z Wu authored
//ios/web_view clients would like to know if a suggestion is for a password form or not. Change-Id: I557857494d3e7889713f2fe8462a37a215111fbc Reviewed-on: https://chromium-review.googlesource.com/c/1345423 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#609878}
-
Becky Zhou authored
+ Use PropertyModel for all modal dialogs + Remove ModalDialogView.Params + Fix cancel on touch outside not being able to cancel on some area for app modal dialogs Bug: 899318 Change-Id: Ib3f9160d57483ade1aa54f1522aa7fe73eaa4212 Reviewed-on: https://chromium-review.googlesource.com/c/1344435 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#609877}
-
edchin authored
Test Case '-[FullscreenTestCase testLongPDFScroll]' started. ../../ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm:207: error: -[FullscreenTestCase testLongPDFScroll] : Exception: AssertionFailedException Exception Name: AssertionFailedException Exception Reason: ((base::test::ios::WaitUntilConditionOrTimeout( kWaitForToolbarAnimationTimeout, condition)) is true) failed Exception Details: Toolbar was visible Bundle ID: org.chromium.gtest.generic-unit-test Stack Trace: ( 0 EarlGrey 0x0000000124b14446 -[GREYDefaultFailureHandler handleException:details:] + 1302 1 ios_chrome_ui_egtests 0x000000010e983a30 +[ChromeEarlGreyUI waitForToolbarVisible:] + 1952 2 ios_chrome_ui_egtests 0x000000010ea3cc9c -[FullscreenTestCase testLongPDFScroll] + 780 TBR=gambard@chromium.org, kkhorimoto@chromium.org, justincohen@chromium.org Change-Id: Id9d1a6e9c3a3a047e9241cf5a1838721899a4fb6 Reviewed-on: https://chromium-review.googlesource.com/c/1345420Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609876}
-
Nate Fischer authored
This connects the cache settings from AwSettings to the network service code path, which fixes 2 related tests. This creates the net_helpers file to share common logic between both the network service and legacy code paths. Right now, this only contains WebView's logic to translate WebView cache settings into net layer load_flags. Bug: 904890 Bug: 893573 Bug: 893574 Test: run_webview_instrumentation_test_apk \ Test: --enable-features=NetworkService,NetworkServiceInProcess \ Test: -f=ClientOnReceivedError*Test#test*CacheMiss Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: Ic2d62dfedd5f0c1ddfa04469454aea7d43df9373 Reviewed-on: https://chromium-review.googlesource.com/c/1339720Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#609875}
-
Geoff Lang authored
Replace '<' with '<=', this was not found until recently because it required that the result was being copied into the exact last element of a much larger buffer. BUG=874402 TBR=piman@chromium.org Change-Id: Ib35552f331f0d9f1f1d19aa4914d1d14ec75ee2d Reviewed-on: https://chromium-review.googlesource.com/c/1344214 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#609874}
-
Jonathan Metzman authored
Call CoInitiliazeEx once before fuzzing so that CoCreateInstance succeeds. Change-Id: I6e6c1fed60da7967a2294b3d781c2d1bd468bbbb Bug: 904877 Reviewed-on: https://chromium-review.googlesource.com/c/1342620Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#609873}
-
Kevin Strohbehn authored
Bug: 902957 Change-Id: Ie0ddf3d189bcedd7a7e6f40a4b5db919b8554878 Reviewed-on: https://chromium-review.googlesource.com/c/1332427Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#609872}
-
Kristi Park authored
When checking for updated tiles, wait for the tiles to reload instead of opening another NTP. Also fix the incorrect removeEventListener in local_ntp_test_utils. Bug: 903265 Change-Id: If48fac6eced637721c6b199492db2edee06370c4 Reviewed-on: https://chromium-review.googlesource.com/c/1334807 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#609871}
-
Lukasz Anforowicz authored
Before this CL, after RemoteFrame is detached, it would be kept alive by FocusController::focused_frame_. Before this CL, LocalFrame::DetachImpl would clear FocusController::focused_frame_ if needed. After this CL this is done from Frame::Detach (and so covers both LocalFrame and RemoteFrame). Before and after this CL, FocusController::focused_frame_ stores either a LocalFrame or RemoteFrame, but FocusController::FocusedFrame only exposes LocalFrame. This CL preserves this approach of handling RemoteFrame internally within FocusController, by introducing FocusController::FrameDetached(Frame* detached_frame) method which can directly compare |detached_frame| with |focused_frame_| (without going through local-vs-remote considerations and/or casts). Bug: 906809 Change-Id: I47f3a725db87f3a887ad96c7a4739b4fc02496ed Reviewed-on: https://chromium-review.googlesource.com/c/1344254 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#609870}
-
edchin authored
Change-Id: I0e9a96d8129aee20610eb3dcd7c82a75e854f40a Reviewed-on: https://chromium-review.googlesource.com/c/1345530Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609869}
-
Sadrul Habib Chowdhury authored
Remove DisplayScheduler.ShouldNotDraw.* UMA metrics, since it is no longer needed anymore. The collected metrics shows that almost ~100% of the time, the reason for not drawing is DrawNotNeeded, and almost never any of the others. BUG=899956 Change-Id: Ibe775a26936de910ad33745dad0e7e1e4369d429 Reviewed-on: https://chromium-review.googlesource.com/c/1343566Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#609868}
-
Noel Gordon authored
unittest_util is a js_library: it is not js_unittest, best I can tell. No change in behavior, no new tests. Bug: 905934 No-try: true Change-Id: Ib508c7380ca7babf970895ce7d69545d219daaa6 Reviewed-on: https://chromium-review.googlesource.com/c/1345370 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#609867}
-
Nate Fischer authored
No change to production logic. This adds a newly added test to the network service test filter: LoadDataWithBaseUrlTest#testXhrForHttpSchemeUrl. This was added during http://crrev/c/1340999. R=jam@chromium.org Bug: 898589, 900528, 896059 Test: CQ Change-Id: I6e83bc3da5389c27761cf2c80620c8990bb6a850 Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Reviewed-on: https://chromium-review.googlesource.com/c/1345246Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#609866}
-
zork@chromium.org authored
Bug: 891460 Change-Id: Idf387481e050593788a6f2e5139f81bb0d19b641 Reviewed-on: https://chromium-review.googlesource.com/c/1341024Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Zachary Kuznia <zork@chromium.org> Cr-Commit-Position: refs/heads/master@{#609865}
-
Fabio Tirelo authored
Bug: 905669 Change-Id: Id22625bd314b2affe80aff481dd305bbaae20c03 Reviewed-on: https://chromium-review.googlesource.com/c/1342397 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#609864}
-
Kent Tamura authored
instead of empty FileChooserResult. Receivers of the message, Blink and Pepper, still assume the null FileChooserResult and the empty FileChooserResult have same meaning. However this CL makes it possible to fix crbug.com/2508. This CL doesn't have user-visible behavior changes. Bug: 2508 Change-Id: I14b17e68116d475d6fd49f4a965d8a6c49418b32 Reviewed-on: https://chromium-review.googlesource.com/c/1343815Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#609863}
-
John Budorick authored
Tbr: martiniss@chromium.org,thakis@chromium.org Bug: 868024 Change-Id: I4a21b8b2c42fa46752bea47c04b0ea501fc13981 Reviewed-on: https://chromium-review.googlesource.com/c/1345073Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#609862}
-
Henrique Nakashima authored
This reverts commit a061c829. Reason for revert: Suspect in crbug.com/906242 Original change's description: > Flatten UpdateMetricsUsagePrefs - skip Metrics and Reporting service. > > UpdateMetricsUsagePrefs() is a chain of calls: > - ChromeDataUseMeasurement::UpdateDataUseToMetricsService() > -> UpdateMetricsUsagePrefs() > -> MetricsService::UpdateMetricsUsagePrefs() > -> ReportingService::UpdateMetricsUsagePrefs() > -> DataUseTracker::UpdateMetricsUsagePrefs() > > It can be reduced to: > - ChromeDataUseMeasurement::UpdateDataUseToMetricsService() > -> UpdateMetricsUsagePrefs() > -> DataUseTracker::UpdateMetricsUsagePrefs() > > This removes the dependency from ChromeDataUseMeasurement to > MetricsService and ReportingService. > > Bug: 902791 > Change-Id: I38a6d22d1ff823134c79bc342ea32be0f89cda77 > Reviewed-on: https://chromium-review.googlesource.com/c/1334267 > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: rajendrant <rajendrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608567} TBR=asvitkine@chromium.org,bcwhite@chromium.org,rajendrant@chromium.org,hnakashima@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 902791 Change-Id: Iad1f49a8bae42e60ae5a9c68509d4cb38db683ef Reviewed-on: https://chromium-review.googlesource.com/c/1344817Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#609861}
-
Casey Piper authored
When a signature request is received from Cryptotoken, proxy that request to WebAuthn. Bug: 904527 Change-Id: If44e39cb1a9032306b21beed69ce3a06fe1df5be Reviewed-on: https://chromium-review.googlesource.com/c/1331951 Commit-Queue: Casey Piper <piperc@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#609860}
-
Sebastien Lalancette authored
Details: Flag name: kChromeCleanupExtensionsFeature When ON, extensions are included when prompting the user for UwS cleanup. When OFF, extensions are NOT included when prompting the user for UwS cleanup. Bug: 904958 Change-Id: Ie483ddb64de11de015429557343f0ee5c4676ff5 Reviewed-on: https://chromium-review.googlesource.com/c/1337790 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#609859}
-
Sara Kato authored
This change exposes text location data for a node, by calling refreshWithExtraData on Android side. This is exposed to s2s on chrome side to allow spoken words to be highlighted respectively. go/s2s-arc for design document detailing change, and summarizing design iterations Android side change: https://googleplex-android-review.git.corp.google.com/c/platform/vendor/google_arc/+/5361958 Bug: b/72793987 Test: Manual Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I3cd01b80d12b21bd77c0133b0d78a2a44516b670 Reviewed-on: https://chromium-review.googlesource.com/c/1212442Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#609858}
-
- 20 Nov, 2018 18 commits
-
-
Charlie Andrews authored
BLINK_PLATFORM_EXPORT can't be safely removed without causing a linker error on Windows and this fact isn't going away. Bug: 691714 Change-Id: Ie2399c50877e16fa80f9cb3ebe455c56493e6cce Reviewed-on: https://chromium-review.googlesource.com/c/1343291 Commit-Queue: Charlie Andrews <charliea@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#609857}
-
Bo Liu authored
This matches old behavior. Note that fragment navigation is strict subset of in-page navigations. in-page navigations also include history.replaceState and history.pushState Bug: 902722, 896022 Change-Id: I002fab4982620e7e13b84a7d96547e105c7338bb Reviewed-on: https://chromium-review.googlesource.com/c/1345229Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#609856}
-
Aiden Benner authored
Adds an interface JniStaticTestMocker and an anonymous implementation in each generated class created by the JniProcessor. The TEST_HOOKS field contains a method that will set the mock that is used when testing is enabled. When testing is disabled, TEST_HOOKS will never be called and should be optimized away by proguard/R8. This should allow for generic JUnit rules that work with all static mockable 'proxy' natives. Bug: 898261 Change-Id: I026858957e7f98cbbe16da0772dc3e68d38717bb Reviewed-on: https://chromium-review.googlesource.com/c/1342805 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#609855}
-
Luciano Pacheco authored
Change directory tree icon override to also override for volume-type-icon which makes tests that uses selectVolume helper to be able to continue to select Downloads folder. This will be properly fixed and removed when MyFilesVolume is fully rolled out. Bug: 873539 Change-Id: I38a36aaacf4a52b68237466846cbd468ee60b0b9 Reviewed-on: https://chromium-review.googlesource.com/c/1343594Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#609854}
-
Michael Spang authored
Rather than allowing arbitrary scales, only allow integer scales and 1.5 (for 1080p). This means we won't apply strange scales that may not work well when using a non-standard resolution. There's no change for standard TV resolutions. Bug: b/117782357 Test: cast_graphics_unittests Change-Id: Ied44492232fbe7bf61d0d48e99ab5a6038f28031 Reviewed-on: https://chromium-review.googlesource.com/c/1344904 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#609853}
-
Jeremy Apthorp authored
This allows usage on windows of non-goma build wrappers (e.g. sccache[1]) for us lowly non-googlers. We've been using this in Electron for several months[2]. [1]: https://github.com/mozilla/sccache [2]: https://github.com/electron/electron/blob/d56617e5d009fc03f4faa684ca1e6fbe0e1d2e51/patches/common/chromium/windows_cc_wrapper.patch Change-Id: I2de68eac93bfbf3343e04b3253330dfa28e6048b Reviewed-on: https://chromium-review.googlesource.com/c/1343518 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#609852}
-
Xiaohan Wang authored
If the current video stream is encrypted, set PROTECTED_VIDEO in the decoded video frame. Notes: - clear leads in an encrypted video stream also have PROTECTED_VIDEO set - For clear stream, even though we are using the CDM to decode it, PROTECTED_VIDEO will NOT be set Bug: 849464 Change-Id: Iae3257aaa122af8073f815278d8b65b55946f3f3 Reviewed-on: https://chromium-review.googlesource.com/c/1337486 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#609851}
-
Tatiana Buldina authored
Bug: chromedriver:2658 Change-Id: Id1acd6fbab55a47f42858d5c82aec9210dacf845 Reviewed-on: https://chromium-review.googlesource.com/c/1343371Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#609850}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5db7ecf7859e..0d23e71a1714 Created with: gclient setdep -r src-internal@0d23e71a1714 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2d0023c01ba387fb7ea645d70c03f804a0f3ffc4 Reviewed-on: https://chromium-review.googlesource.com/c/1344899Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609849}
-
Etienne Pierre-Doray authored
In an effort to avoid creating threads from the main thread, this CL avoids the creation of a new idle thread after waking up the current idle thread from the main thread. This is done by moving a call to MaintainAtLeastOneIdleWorkerLockRequired() from WakeUpOneWorkerLockRequired() to GetWork(). Note that a call to MaintainAtLeastOneIdleWorkerLockRequired() is still done before waking up a worker in WakeUpOneWorkerLockRequired(), in case no idle thread was created yet. Bug: 847501 Change-Id: Ib3903c117a781a72f9d6a6aaeceee6554e5b9803 Reviewed-on: https://chromium-review.googlesource.com/c/1338382 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#609848}
-
Philip Rogers authored
According to the spec, filtering should apply before clipping (https://drafts.fxtf.org/css-masking-1/#placement): "...effects are applied to the element in order: filter effects, clipping, masking and opacity." This patch fixes clip-path order with BlinkGenPropertyTrees (BGPT) which exposed the issue of filter and clip order. Testcases have been added showing the fixed behavior with BGPT, and the non-BGPT results have been marked as failing. NOTRY=true Bug: 906154, 907175 Change-Id: I5e9c7dbb7c694afc623fbc3bb2c7f2f8cc458195 Reviewed-on: https://chromium-review.googlesource.com/c/1344217 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#609847}
-
Clark DuVall authored
This adds a test for clearing the bad proxy cache when DRP is turned off, and implements that functionality with network service. Bug: 721403 Change-Id: I12f441191de6dfb890c7a042b72a5a87f72e41aa Reviewed-on: https://chromium-review.googlesource.com/c/1343352Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#609846}
-
Marc-Antoine Ruel authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/7f463e66e1c4..b6e9e23e4e79 $ git log 7f463e66e..b6e9e23e4 --date=short --no-merges --format='%ad %ae %s' 2018-11-20 maruel [client]: fix undefined class reference 2018-11-19 vadimsh [proto] Fix google/rpc/*_pb2.py, it has wrong proto paths in it. 2018-11-19 maruel protobuf: upgrade to 3.6.1 from 3.5.1 2018-11-19 jchinlee [client] Print time with tasks update message. Also increase frequency. Created with: roll-dep src/tools/swarming_client R=jchinlee@chromium.org Bug: 905012 Change-Id: I5e397d787e27223d94dd85b35d3c2826dc93febe Reviewed-on: https://chromium-review.googlesource.com/c/1343666Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#609845}
-
Wenzhao Zang authored
When ephemeral user selects a new wallpaper, it's not saved to disk. But we should still be able to keep this wallpaper before user logout. The wallpaper is already cached in memory, but we ignored the cache for ephemeral users: so when lock screen or wallpaper app calls ShowUserWallpaper, it always thinks that ephemeral users never set a wallpaper and then display the default wallpaper. Bug: 825237, 902327 Change-Id: Id9a811c91243b04c7459f3ee20569ec4fdff14b0 Reviewed-on: https://chromium-review.googlesource.com/c/1343105 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#609844}
-
Sergey Ulanov authored
Change-Id: Ia1f21d38b2e3eb04377cba774d19172718f82e91 Reviewed-on: https://chromium-review.googlesource.com/c/1344878Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#609843}
-
Min Chen authored
Changes in this cl: - Make sure ShelfLayoutManager doesn't handle the following gesture events after ET_GESTURE_SCROLL_BEGIN for auto_hide shelf. Then they can still be propagated to ShelfButton to process the drag and drop. - Start the gesture drag and ink drop timer of the shelf item only if the shelf is visible. Then gesture drag on the item in AUTO_HIDE_HIDDEN shelf will not activate the ink drop of the shelf item. - Update the shelf visibility in ShelfView::OnMenuClosed only if there is no shelf item in drag. Since shelf should be kept as visible during drag even the menu is closed. Bug: 905847 Change-Id: I384b4c4b3bc2d240820cea338c4ddc59d8cc517a Reviewed-on: https://chromium-review.googlesource.com/c/1340952 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#609842}
-
Ben Pastene authored
Should have enough bots. R=jbudorick, dpranke Bug: 902468 Change-Id: If699354b2747c77a11741972fe8b531d9d500234 Reviewed-on: https://chromium-review.googlesource.com/c/1344689Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#609841}
-
Thomas Guilbert authored
The RemotePlaybackAppLauncher CL was reverted due to a regression (see cb04d0bc). Since the revert, needs have changed, and we no longer need a fully dynamically chosen app ID. This CL adds the ability to define a custom RemotePlayback app ID from the AndroidManifest, which can be overriden downstream. The info is stored in a static field, since it does not change at runtime. Bug: 790766 Change-Id: I2b2d466304234f4c07a4b617dc336f936aabc585 Reviewed-on: https://chromium-review.googlesource.com/c/1334660 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#609840}
-