- 06 Jan, 2021 40 commits
-
-
Tibor Goldschwendt authored
Fixed: 1154738 Change-Id: I319269ac2ad02fbf8fb5776e0904ca2fcd4c9b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611700 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#840657}
-
Brian Sheedy authored
Removes chrome_public_test_vr_apk from the two Android L-based builders it was being run on, as we have decided that it's no longer worth the effort to try to keep the tests running on that version of Android. Bug: 1159619 Change-Id: I22722da53fbb288e7ab90f34afffcbe8f463eddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611900 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#840656}
-
Mihai Sardarescu authored
Methods OnUnconsentedPrimaryAccountChanged is deprecated, so this CL changes the chrome/browser/profiles/* and c/b/safe_browsing/* to override the method OnPrimaryAccountChanged(). Bug: 1163126 Change-Id: I0dbabb38085373cf44de5f7273812d4f44fe7969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611091Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#840655}
-
Mihai Sardarescu authored
Methods OnUnconsentedPrimaryAccountChanged is deprecated, so this CL changes the chrome/browser/ui/views/profiles/* to override the method OnPrimaryAccountChanged(). Bug: 1163126 Change-Id: Ia0168bae3070c7c5eefd9919598919b9d0ae4e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611711Reviewed-by:
-
John Delaney authored
This is a reland of 53e3903f This now correctly initializes the was_opener_suppressed_ member on NavigationRequest. Original change's description: > [conversions] Route impressions alongside rel="noopener" anchor navs > > What: > Route impressions for the Conversion Measurement API to the browser > process for anchor tags with rel="noopener". > > Why: > We currently drop impressions for anchor clicks which have noopener > set because the impressions do not get forwarded to the browser process. > > Anchor click navigations with the rel="noopener" attribute use a > different navigation path than those without the attribute, in which > the window creation mojo also navigates the frame to the target url. > This navigation is not annotated with an impression. > > How: > Add an Impression member to CreateNewWindowParams which will get > forwarded as a LoadURLParam for the subsequent navigation of the > window. > > This change also fixes a bug in which initiator_frame_tokens are not > set for noopener navigations. > > As of https://chromium-review.googlesource.com/c/chromium/src/+/2327963, > the lack of an initiator frame tokens are used to to indicate whether > an opener was suppressed for a navigation. Because attaching the token > breaks this logic, we route a new |was_opener_suppressed| param through > the NavigationController:LoadUrlWithParams() flow to recover the > behavior. > > Bug: 1155577 > Change-Id: I84739a9f4ec0df9a867f91397f80b46eea1bcee6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575223 > Commit-Queue: John Delaney <johnidel@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838275} Bug: 1155577 Change-Id: I1ab5bf85e62525e898bd9e9a6986ed844a7a5c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600016 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#840653}
-
Yi Gu authored
Bug: 1015645, 1138322 Change-Id: I88a989a5cfad63383dbd47b95bfe665837d57c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595257Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840652}
-
Alex Ilin authored
The size of a cr-theme-icon element is computed incorrectly if the element doesn't have `display: block` property. This leads to a subtle bug when displaying a `box-shadow` around a focused element. Fixed: 1161116 Change-Id: I908b5e997c01db0db00574319c49029ef438b3ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611025 Auto-Submit: Alex Ilin <alexilin@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/4089217d30c1..61649cc4962e 2021-01-06 rharrison@google.com Roll 4 dependencies (#1165) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I53ea97bc1eda49cdd8cc0ab1a1bc60582eb168e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613123Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840650}
-
Chris Lu authored
Since this is a client-side driven experiment, the client must turn it on to 45% stable. Bug: 1138603 Change-Id: Ibe97fd2b7f92e19e3461ad635bbce9b5f6ee94a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588301Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#840649}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8a3bba16ba86..3fcecc11721e 2021-01-06 jacktfranklin@chromium.org Add body context menu to data-grid If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1150793 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I70445696bbb55c006342a76dd27f8f670026bd58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613226Reviewed-by:
-
Sorin Jianu authored
It uses the idiomatic TestTimeouts::action_max_timeout() instead. Also, it fixes an assert to keep lint happy. Bug: 1163363 Change-Id: I76289b8216e5d8d6dcb729628129835253bcc25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611641 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#840647}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/de6e3a9d85af..e212b425e90f 2021-01-06 johnchen@chromium.org Revert "devil: make devil_env_test pass under py3." 2021-01-06 jbudorick@chromium.org Revert "devil: make decorators_test pass under py3." 2021-01-06 bsheedy@chromium.org [Telemetry] Disable ResultSink on nested tests 2021-01-05 jbudorick@chromium.org devil: make decorators_test pass under py3. 2021-01-05 jbudorick@chromium.org devil: make devil_env_test pass under py3. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1007101,chromium:1159139,chromium:1163340 Tbr: nuskos@google.com Change-Id: Icb4ffd462151ddf111387fe78da12ac0ddf62bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613118Reviewed-by:
-
Egor Pasko authored
Readability of this class suffers from (perhaps premature) optimizations to eliminate locks in a few places where the class is used only on a single thread. I believe avoiding these locks does not affect correctness in practice, but explaining and maintaining the proper ways to use these classes becomes more time consuming. In this change I: * Annotated the fields that are indeed guarded by the main lock. * Expanded the explanation of the use of the secondary lock. * Also added a few short-lived synchronized blocks, where an explanation of why it can be avoided is long and brittle. This adds more locking, but I believe it won't affect performance noticeably. * Moved a few unguarded fields above the lock, so that the latter can guard everything 'below'. * Made a few minor corrections in comments, now that I looked at this code a bit longer. Bug: 1154224 Change-Id: I346d358a4b2a465cecdec1881908026e17fef7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602285Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#840645}
-
Stephen Roe authored
third_party/zstd has been replaced with third_party/zstd-linux-arm64 and third_party/zstd-linux-x64. Bug: 1154022 Change-Id: I87c58d5bbf1bf57a5a64c03255e4731cd1df0eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611897Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#840644}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4f3fa1b39ec3..875b30eb4cdf 2021-01-06 saklein@chromium.org cros-sdk: Use os.ST_NOSUID constant. 2021-01-06 liaoyuke@chromium.org Lacros: Support --deploy-lacros in cros_run_test 2021-01-06 jintao@google.com usergroup_baseline: Add ap-group-manager to gwifi 2021-01-06 bpastene@chromium.org cros_test: Add args to specify tast sharding parameters. 2021-01-06 liaoyuke@chromium.org Lacros: fix a deployment bug where ash-chrome is not restarted 2021-01-06 saklein@chromium.org dependency_lib: New lib for dependency functionality. 2021-01-05 liaoyuke@chromium.org Support --tast-var in cros_run_tests 2021-01-05 pprabhu@chromium.org Update API bindings 2021-01-05 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ia5d1dfc3ea2798faa5a20ea175997516b16a7f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613116Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4dde23fea599..cee13faaf357 2021-01-06 fmayer@google.com Add end to end test for symbolization. 2021-01-06 primiano@google.com Win port: Introduce //base/ctrl_c_handler.h If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:174454879 Tbr: perfetto-bugs@google.com Change-Id: I0d2c2b14e4f4828413411e4a0c5320fde2fe5f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613119Reviewed-by:
-
Ben Pastene authored
This removes every reference but the "--master/-m" cmd-line arg and the "masters" mb_config.pyl key, which will be removed in a follow-up once all users of mb.py (ie: recipes) have switched over. "builder_group" is also the term we're using when replacing "master" in recipe code: crbug.com/1109276. So we should conform on using that term going forward. Bug: 1117773 Change-Id: I10a3c7a4bc5fd5146bc88d670564a745cb3fce2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605225 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Daniel Rubery authored
The code to extract DOM features is undergoing a moderate-size refactoring and this metric could be useful in diagnosing a regression. Fixed: 1160884 Change-Id: I9e970610a5b69e2a31d5d4e829cf87b1ec2fccd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610956 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#840640}
-
Robbie McElrath authored
This adds missing dependencies and adds nogncheck comments to any includes in //chrome/browser/updates to files that live in //chrome/browser:browser. Bug: 949535 Change-Id: Icdac512e2dc1d4df7620713ae7f912829e214892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585665Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#840639}
-
sczs authored
Since diffable data source has been turned off we can remove this workaround. Bug: 1162429, 1162427 Change-Id: I45d786022312bc85fa19ad4e9b96920ce88572a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612565Reviewed-by:
Adam Trudeau-Arcaro <adamta@google.com> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#840638}
-
David Bokan authored
The feature shipped on Android long ago. It remains disabled on desktop as it doesn't really apply there so the base::Feature remains but we can remove the about:flag. Bug: 903260 Change-Id: I7889b33a52f6a13edf16b1268da5af2cfc29f053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605882Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#840637}
-
Mehran Mahmoudi authored
Some URLs are invalid now due to refactorings. This CL updates them. Change-Id: Ibc4350c6797abee3d0c7c4fbb14142142b49233d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612926 Auto-Submit: Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#840636}
-
Stephen McGruer authored
Bug: 997202 Change-Id: I670d9134fc8770c58f8688366a16830ba9a6435e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575454 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#840635}
-
Mihai Sardarescu authored
Methods OnPrimaryAccountSet/Cleared() are deprecated, so this CL changes the signin_profile_attributes_updater.(h|ccc} to override the method OnPrimaryAccountChanged(). Note that is also have a slight change of behavior by updating the auth info even when the unconsent primary account changed. Bug: 1163126 Change-Id: I5f1c739787e3ead98c8dcedc7ca486eeda2bc216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611717Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This reverts commit 55b69ae2. Reason for revert: Breaking iOS 12 FirstRunTestCase Original change's description: > [iOS] Dismiss unified consent screen from Recent Tabs. > > Fixes a bug where the unified consent screen is not dismissed when > interrupted by a Siri search on the Recent Tabs page. > > - Performs complete view controller cleanup on interrupt. > - Dismisses UnifiedConsentViewController when explicitly required. > - Does not explicitly release SigninCoordinator in scene controller, > this is already handled in the completion callback. > > Bug: 1115997 > Change-Id: Ib4663fe1136a394020020abc76969761c5e0f170 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600835 > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840588} TBR=gambard@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,fernandex@chromium.org Change-Id: I09e836432fc7ce4d6091a3cf3795763c12a91fb5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1115997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612969Reviewed-by:
-
Becca Hughes authored
Kaleidoscope has been turned down. Change-Id: Ia7808eff9d37b46fcf8d1eba95d9d52e456ca34b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596439 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#840632}
-
David Tseng authored
<settings-switch-access-action-assignment-dialog id="switchAccessActionAssignmentDialog" on-close="onSwitchAccessActionAssignmentDialogClose_" action="[[action_]]"> is how a dialog is expected to be used (from the switch access subpage). switch_access_awction_assignment_dialog_test neglects to set |action| above, leading to a test-only failure. Previously, SwitchAccessActionAssignmentDialog's |this.assignemnts| did not depend on |this.action| for its initial value; it now does. Fix by assigning action in test. Original change description This change implements the infrastructure for assignment and capture of Switch Access keys tied to a specific type of input device (internal, usb, bluetooth). Along the way, it also cleans up unused code, obsoleted preferences. It does not hook up the final UI for the device type which will be handled separately once UX is finalized. TBR=jamescook@chromium.org,dtseng@chromium.org,michaelpg@chromium.org,josiahk@google.com,zentaro@chromium.org,rhalavati@chromium.org Test: preexisting ash_unittests AX-Relnotes: n/a Bug: 1163226 Change-Id: Iad97fb938e84240eee15cc3f5bc009368ed22c4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613009Reviewed-by:David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#840631}
-
Ryan Hansberry authored
Fixed: 1160907 Change-Id: Ib38775ae2d687fe624a36f1fcf63226a541ffc9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612032 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609923503-9b9894a01ac9daf80ce951069eff07585fba216a.profdata to chrome-win64-master-1609934346-02960af12c9c6cfb124c9f1bb5033b3eb2b936e3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0e71659c33f971023e3b9bff43b34ab53fecd1b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613113Reviewed-by:
-
Jun Kokatsu authored
This change clean up unnecessary test cases in the NoTrustedTypesViolation test. Also added few things that makes debugging of the test failure more easier. Bug: 1115643 Change-Id: I12e77b3038046337f8002850f5c28806dd722acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610486Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#840628}
-
Ella Ge authored
These usages of ChromeActivity can be easily replaced by Activity. Bug: 1155353, 1155804 Change-Id: I307cc9708dde7237b9d4e4630c03cd58dc1f7a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605877Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#840627}
-
Monica Basta authored
Rename the label from 'Chrome name and picture' to 'Customize your Chrome profile' if the spaces experiment is on. Bug: 1147088 Change-Id: I717c4b403bdb3452b13ba170ad5a251219370a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612887Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202101060600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/_2IUiaMakoAVmovMPZQalk_OvCtn2wuY52u81Pw-egYC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: I9d4bd14fce4121b65963e7402ea56f7fa37c0733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613165Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840625}
-
Austin Sullivan authored
Currently, there are two methods to create a FileWriter via its Manager. One of these methods used to return a raw pointer to the FileWriter. Now, it returns a WeakPtr. Bug: N/A Change-Id: I00af3d05c762362a9b26f359510f475ed6827bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599671 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#840624}
-
Maksim Sisov authored
This is a reland of a489cfcd 1144179 is a P0 issue. Instead of reverting the entire patch, just disable overlay delegation for non-lacros. Original change's description: > [ozone/wayland] Ensure root_surface is committed last in a frame > > wl_surface.commits of a frame can happen asynchronously due to wl_buffer > import delay, frame callbacks, etc. This asynchrony can cause visual > glitches when the root_surface commits before its subsurfaces commit. > > This CL ensures that a root_surface commit always happens after other > commits in a frame. > > Change-Id: I7c83e122c4cdee42e6b8aca74875fa71b6c1ab5a > Bug: 1144179 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547395 > Commit-Queue: Kramer Ge <fangzhoug@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Maksim Sisov (GMT+2) <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#834327} Bug: 1144179, 1162867 Change-Id: Ibad3c9b44378967b826496971205a12d55a1417c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611709 Auto-Submit: Maksim Sisov <msisov@igalia.com> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#840623}
-
Morten Stenshorne authored
This reverts commit ac10443d. Reason for revert: Probably breaking mini_installer_tests and ProcessSnapshotTest.CrashpadInfoChild https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/112543 Original change's description: > [PartitionAlloc] Better freelist corruption detection. > > Some PartitionAlloc crashes are likely due to freelist > corruption. PartitionAlloc has two types of freelists: in the central > allocator, and in the thread cache. The central allocator one already > has a DCHECK() to verify that subsequent entries belong the same > superpage, which doesn't hold for the thread cache freelists. > > This CL: > - Makes these crash lead to a NOINLINE function > - Add an interity check to all freelists. > > This is not meant to be a security mitigation, but to prevent against > accidental issues. > > Bug: 998048 > Change-Id: I21aedfe2b6363069362514a8edd6cd5bdea1acfc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582218 > Commit-Queue: Benoit L <lizeb@chromium.org> > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840587} TBR=palmer@chromium.org,haraken@chromium.org,lizeb@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Idd7f8213dae35146d4ada835cd443505f88749ce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 998048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612968Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#840622}
-
Clemens Arbesser authored
This brings them in line with regular script preconditions. Bug: b/175785117 Change-Id: I3fbc991b6c7a97c6b8134b989795cc4e96c44311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611718 Commit-Queue: Clemens Arbesser <arbesser@google.com> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#840621}
-
Daniel Murphy authored
This flag is used by developers for automated webapp testing. Extending the life, and re-assigning myself as owner. Bug: 1159277 Change-Id: Ib10f09aa4deaa1bdb3de8a3ced87053dab37e6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612487Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#840620}
-
Nancy Wang authored
The new ModifyWindowInfo function will be used by FullRestoreSaveHandler::SaveWindowInfo in CL:2597519 to modify and save the window information for the restore data. Modify the unit tests to verify the window info modification function. Move the position of the AppRestoreData constructor function, and the field restore_bounds name to consistent with the WindowInfo structure. BUG=1146900 Change-Id: I0e5755ffdf966d29139be67bf9a9a00a981c7df6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598084Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840619}
-
Dave Tapuska authored
This is a reland of crrev.com/3da5569e with a rename of the class PepperPluginInstance to PepperPluginInstanceHost on the browser side. The two classes named the same caused vtable confusion on the debug build and the browser side class was getting called from the renderer code. Naming the classes separately avoids this confusion. This adds some base plumbing for pepper plugin instance handling. The pepper renderer code allocates and manages the PepperPluginInstanceImpl, this creates the correct encapsulation moving code out of RenderFrameImpl. On the browser side a PepperPluginInstance is created to handle the messages and relay them to the WebContentsImpl which use to handle the processing of Pepper messages. BUG=1157519 Change-Id: I45b238ce76bde0db35a9fd74baddb04333ebb593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611047Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#840618}
-
