- 02 Apr, 2020 40 commits
-
-
Sara Kato authored
Test: manual. Press ctrl+/-/0 ensure that it is recorded in chrome: //user-actions. Bug: 152466126 Change-Id: I4ff152672ac53b2ad77e78be172a06ff7b081862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120839Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#755999}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/07dc402b0545..4400d32f044c git log 07dc402b0545..4400d32f044c --date=short --first-parent --format='%ad %ae %s' 2020-04-02 jophba@chromium.org Add cast socket messages to the standalone receiver Created with: gclient setdep -r src/third_party/openscreen/src@4400d32f044c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I1975e4065b5888c20247cb2f52edfec7c4ae0565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134364Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755998}
-
Matthew Mourgos authored
This change updates the string descriptions used for the gesture navigation accessibility setting. Bug: 1066310 Change-Id: I75f1c3609a0cf1cd68e784cd66cf2e8db8e104a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130683Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#755997}
-
Dan Harrington authored
- Added new ZeroStateSlice - The UI now should receive a zero state slice if loading fails. I've changed SurfaceInterface so that the initial state isn't provided on a different function call. This makes things a bit easier in FeedStream. Bug: 1044139 Change-Id: Ia8c3ec15fa0460b0add78ee5ba28e21f8a643237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133231Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#755996}
-
Tao Bai authored
Extend one more milestone because of M82 is skipped. Bug: 1066014 Change-Id: I03ce2a3672f5206dbb447a1a3734938391e5ca71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131150Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#755995}
-
Mikel Astiz authored
This reverts commit be06dabb. Reason for revert: the feature is not ready yet. Original change's description: > Reland "Enable sync trusted vault support by default" > > This is a reland of f52179a5 > > The feature was disabled by default before branching because some > implementation parts were missing on Android. > > Original change's description: > > Enable sync trusted vault support by default > > > > The feature is in a working state can be enabled by default. > > > > Bug: 1000146 > > Change-Id: I66ef6f65d97234f47eaa76d1daafb8d3637692ed > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000702 > > Reviewed-by: Marc Treib <treib@chromium.org> > > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#731898} > > Bug: 1000146 > Change-Id: If2c11c87bbc021daaa6656f9e85b592302dd8327 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035966 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738548} TBR=treib@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1000146 Change-Id: I44607cf1822145fb8a98e4a72a1361dbae274b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127091 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#755994}
-
Reilly Grant authored
On Windows separate device nodes are created for each function of a composite USB device. This change implements the additional steps necessary to collect all of the device paths for these child nodes when the parent USB device node is enumerated. As implemented this works for devices that are already connected when enumeration is performed but not for devices that are detected after startup because the DBT_DEVICEARRIVAL window message is delivered before these nodes are created. This will be addressed in a follow-up. Bug: 637404 Change-Id: I080e40104c422e446f07e3d5dee47291802a7728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132532 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#755993}
-
Dan Sanders authored
Change-Id: If11171fae55dc0b4fa492908884ab48d1805b18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092692 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#755992}
-
Haiyang Pan authored
Also rework the code logic so that it prints logcat link even if there is an exception Bug: 1065170 Change-Id: I1b128d9cdef42a2ea2489d7ce6e9db41e3a9374f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128969Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#755991}
-
Xiyuan Xia authored
Enable the test after fix in https://crrev.com/c/2132683. Bug: 1032993 Change-Id: Iec720cc1d61962b453a519624e43077f0c56b162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133882Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#755990}
-
Yulun Wu authored
Bug: 1061793 Change-Id: Ia4220faffaf01be3a2a7b62da80143af93b97dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106957Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#755989}
-
Jeff Yoon authored
Migrating ios-simulator JSON config to Chromium recipe configs. - test definitions in test_suites.pyl for ios-simulator. new sim variants introduced into variants.pyl - chromium recipe and xcode property references set in *.star files. - Also add flexibility for executable specification on mac_ios_builder in ci.star - re-use ios_sim_debug_static_bot mb config Bug: 1055164,912681 Change-Id: I375512304959d90545019497f32b7f415c3d9ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071585 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755988}
-
Istiaque Ahmed authored
Use raw string literals instead to avoid hurting readers' eyes (note: no one should read them though). For example, this CL turns const char kUsb[] = "{\"functions\":[{\"parameters\":[{\"$ref\":... to const char kUsb[] = R"R({"functions":[{"parameters":[{"$ref":... in gen/extensions/common/api/generated_schemas.cc This makes generated .cc file size slightly smaller: e.g. in linux cros build, the sizes in bytes are (before->after): gen/chrome/../apps/platform_apps/../generated_schemas.cc 14137 -> 12396 gen/chrome/../extensions/../generated_schemas.cc 426698 -> 367237 gen/extensions/../generated_schemas.cc 369079 -> 318170 gen/extensions/shell/../generated_schemas.cc 1632 -> 1535 Note that this should not have any impact on binary size. Bug: None Test: None, no visible changes expected. Change-Id: I432c510396ead6e86fae71f63a3e2c099420b485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133658Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#755987}
-
Alex Gough authored
This will inform changes to the size of the |policy_maker_| in the Windows sandbox. Bug: 1059129 Change-Id: I75fd61ae909eea8fdb3fde5565d828d7220c21f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127409Reviewed-by:
James Forshaw <forshaw@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#755986}
-
Bence Béky authored
Bug: 1062700 Change-Id: I3b25b0e49f07c40a72eeb170d2f9d218aa56ba3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117316Reviewed-by:
Renjie Tang <renjietang@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#755985}
-
My Nguyen authored
MVP. Use the old CandidateWindow for UI. Screenshot view here http://screen/RMd0QQFyoNo Emoji-map lives in Google3, view here http://google3/i18n/input/javascript/chos/ui/resource/emoji/emoji-map.csv Interactions: -Tab,Right,Enter commit the chosen emoji -Up,Down moves to choose candidates Bug: 1065308 Change-Id: If1b3a662a3a6e7e410099c1abca8cfce3d2a1a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123494 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#755984}
-
Elly Fong-Jones authored
Fixed: 1064138 Change-Id: I6693327ee56c6d70eac93a2bb1fabe81a4a45e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134389 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#755983}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cd454025b331..4ecdd22b0b60 git log cd454025b331..4ecdd22b0b60 --date=short --first-parent --format='%ad %ae %s' 2020-04-02 vapier@chromium.org repo: update to 2.5 launcher Created with: gclient setdep -r src/third_party/depot_tools@4ecdd22b0b60 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I92bc6fe08e37fc2c6111ea2f3cb04ed88bf8afd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134363Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755982}
-
Mikel Astiz authored
Because flags cannot map to two feature toggles, the patch also merges the two relevant feature toggles into one. Change-Id: I79bb0eaee505d35713db34d8a5df677cbb19c09d Bug: 1000146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134008 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#755981}
-
Juanmi Huertas authored
https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-shadowoffsetx The standard in the above link says that shadow offset should not be modified by the transform matrix. Adding a test to verify that, and fixing it so the offset does not get modified by the transform matrix. I tried to add a html reference test, simulating a shadow but there is some slightly aliasing errors due to the change in the way the compositor handles the shadow and the blur. Adding a png reference test to validate that it will still work in the future. I'm also removing an unnecessary c-style cast in: composite_flags.setBlendMode((SkBlendMode)GetState().GlobalComposite()); Bug: 1044803 Change-Id: Ib98a35d9b9fdcb71c0cccca114099e985b569fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128766Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#755980}
-
Sammie Quon authored
Test: none Fixed: 1022599 Change-Id: I44cf265ddb3877912ed565f87a4e6b0cd2552065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131018Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#755979}
-
Gang Wu authored
Change-Id: If62caac724f9f2bcb163bdf1710c592ebe927834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118396 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#755978}
-
Yuly Novikov authored
Since we have SwANGLE bots now to run these, we can offload the GPU bots. Also, possibly reduce the flakiness on them due to anglebug.com/4396. Bug: 1007018 Change-Id: I3023bfb163804fe5aacb0d8a0fa93523b757feda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132945Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#755977}
-
Charlene Yan authored
Bug: 1067062 Change-Id: If52f744b7471d11f00601c85754fa5019b982805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134614Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#755976}
-
Kevin Ellis authored
CSS transtions use transition keyframe models instead of string keyframe models. With this patch, the model is replaced with a string keyframe model when setKeyframes is called if required. Bug: 835818 Change-Id: Ie77a1b38e6ac4392b4b29b22af8d78cb504ce8fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134613Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#755975}
-
Jose Lopes authored
This closure is run in the control flow of: * https://source.chromium.org/chromium/chromium/src/+/master:media/base/android/media_service_throttler.cc;drc=d9b91db0b32bcaed524db17b05f614c7e86326bc;l=196 Which is called repeatedly, e.g., from the following locations: * https://source.chromium.org/chromium/chromium/src/+/master:media/base/android/media_service_throttler.cc;drc=d9b91db0b32bcaed524db17b05f614c7e86326bc;l=95 * https://source.chromium.org/chromium/chromium/src/+/master:media/base/android/media_service_throttler.cc;drc=d9b91db0b32bcaed524db17b05f614c7e86326bc;l=117 This is part of the base::Callback migration. Context: http://doc/1J4N3V5UmzZL9BZGNrn95E4xJu4cz3ynbg21zXR-J_qA#heading=h.uxpxu8vg4k4r Bug: 1007799 Change-Id: I05acf0276840888a5771d02f83a88128017e7997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111320 Commit-Queue: Jose Lopes <jabolopes@google.com> Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#755974}
-
Natalie Chouinard authored
Test succeeded 10/10 times locally, and no log data available on the bug or flakiness dashboard (disabled >6 months ago). Re-enabling to monitor whether flakiness still exists. Pre-emptively increasing timeout to MediumTest either way since this test is more than a simple unit test. Bug: 994726 Change-Id: Iaa645356906b17ff17c44cc49c4c76c7b9dac4d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134204Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#755973}
-
Varun Khaneja authored
It is being replaced by SafeBrowsingProtectionLevel that was already landed via https://crrev.com/c/2129284 Bug: 1056483,1066371 Change-Id: Ibe8eeaa6d1563f770fd2c29001745f819764bf0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134201 Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#755972}
-
Vidhan authored
Bug: 1045401 Change-Id: I419495ab251cb8b2bd69e183eb39a402c4d58fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095058 Commit-Queue: Vidhan Jain <vidhanj@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#755971}
-
Ulan Degenbaev authored
The corresponding UKM metrics already exist and were approved by privacy team: https://goo.gl/X5eYHh The metrics will help evaluate the upcoming young generation GC optimizations. Bug:1054771 Change-Id: I8caa8cce5e7b253aee76714f980a9ecd6242c530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130186Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#755970}
-
David Bertoni authored
This test was disabled because it was flaky on ChromeOS. I ran it for 3000 iterations on the bots and there were no flakes on any platform. Bug: 1019669 Change-Id: I7e4e7665375903d531e1fbfc9862b14e25b2c024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132602Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#755969}
-
Peng Huang authored
This CL enables the ExternalVkImageBacking on Windows platform, but it only supports pixel copy code path for now, the vulkan external memory extension is not used. Bug: None Change-Id: I44955572175d218ec613b41eddf40eb0655fac07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125705Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#755968}
-
Yao Xiao authored
Bug: 1032681 Change-Id: Iafad2367d8887afb1df67094aef996a2f2873da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121657Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#755967}
-
Sophie Chang authored
Bug: 1064414 Change-Id: Ib81bea9adf5bfe04b65b324c98779caf616e1e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119224Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#755966}
-
Patrick Monette authored
This reverts commit 5047802a. Reason for revert: https://crbug.com/1066450 Original change's description: > Reland "[PM] Connect dedicated workers to their client frames in the graph." > > This is a reland of 8e70db4d > > Original change's description: > > [PM] Connect dedicated workers to their client frames in the graph. > > > > Bug: 993029 > > Change-Id: Iae20fa0ede4421782fc5fbf2851d21c83cfbf4c8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095452 > > Commit-Queue: Patrick Monette <pmonette@chromium.org> > > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#753319} > > Bug: 993029 > Change-Id: I859f004b938164a02e43b74e6f9225d25e90d083 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122476 > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754620} TBR=pmonette@chromium.org,siggi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 993029, 1066450 Change-Id: I738ef7877b1b841eb9aea5af0a3427959e5857cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134199 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#755965}
-
Sammie Quon authored
This requires some changes to WindowMiniView to make it more customizeable as UX specifically only wants shadows on overview and not alt-tab. Changes made were to apply effects on an icon supplied through a window property, in this case a shadow. Also, adding shadow to a label will shift the text. Since we want to keep the text right aligned with the icon, make OverviewItemView header layout code custom (previously was using the default from WindowMiniView FlexLayout). Test: manual Fixed: 1028845 Change-Id: Ief8e9bbccc42fa198ff31729b735edc519d78270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128835Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#755964}
-
Xianzhu Wang authored
We have fixed crbug.com/1064341. TBR=pdr@chromium.org Bug: 1064341 Change-Id: I0d156a40c590c5b2bd5dbd01a6a9bf2f4e3d50e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134203Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#755963}
-
Dave Tapuska authored
maxlength-number.html sends multiple keys in one call. Iterate across the keys string to send more than one character. Move another test that uses the actions API to the unsupported section. Reland 39760144 without the pause.html expectation removed. Change-Id: I9cb0a2f68a5792615c711d59e29dbca9830e2f44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133872 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#755962}
-
Archana Simha authored
Bug: 1066117 Change-Id: I816361f5ff166cc6888e3634a7f624fae2e11f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134388Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#755961}
-
rajendrant authored
Handles the following cases: 1. When the litepages server and the origin server both fail the response, it should not go into a infinite loop. 2. When the initial image itself is a litepages URL, no redirect should happen and no metrics recorded. TBR=tbansal@chromium.org Bug: 1059606 Change-Id: I477839ab09493445a085d646a4da4fb22c5981c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128944 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#755960}
-