GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/925e218b..10d5ae79

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iba61344a3128d6a360674f0b2e9a6cce9744a304
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893752Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711511}

This updates a temporarily disabled network tool test to expect
timeouts. The test will be rebaselined and re-enabled after
has landed and DEPS has rolled


https: //chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1881592
Bug: 963183
Change-Id: Id1abfbc2b032c75d37011991a61912f8015a48c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893508Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#711510}

This reverts commit 411235fc.

Reason for revert: Introduced a flaky test case. See issue 1020342.

Original change's description:
> WebUI Tab Strip: Only track thumbnails for visible tabs
> 
> - Track thumbnails only if they are currently in view or are
> just a standard finger swipe away.
> - Do not track thumbnails for pinned tabs.
> - Do not track thumbnails when the tab strip is closed.
> 
> Note that this CL does not implement actually untracking thumbnails.
> It merely calls the method in the C++ side that will eventually do it.
> 
> Bug: 1015132
> Change-Id: I86f7a8ea284395fc97dfed60fbb0452a0dfaa8ca
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885504
> Commit-Queue: John Lee <johntlee@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711109}

TBR=dpapad@chromium.org,johntlee@chromium.org

Bug: 1015132
Change-Id: Ibf55975b9009734f58a744faa0bbea069ea9986c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894326Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711509}

There's a few NOTIMPLEMENTED in BinaryFCMService that really should
just do nothing. This CL removes them.

Fixed: 1019875
Change-Id: I6b63e687b69d2da268d4dd12bcf0d892556f45f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893524
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711508}

This test has recently started flaking consistently on linux. Disabling for now.
This is failing locally due to receiving valid paint updates for the main frame,
which is not expected for a seamless iframe. Indicates the problem may be coming
from blink. Test is only flaking 1/100 times, making a fix hard to verify quickly.

TBR=csharrison@chromium.org

Bug: 986642
Change-Id: Icc55950e549361169a8d07a1764c6ed06490e301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894106Reviewed-by: John Delaney <johnidel@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Auto-Submit: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711507}

This fixes an ambiguous reference when building against MSSTL:

In file included from ../../content/browser/webauth/virtual_authenticator.cc:5:
In file included from ../..\content/browser/webauth/virtual_authenticator.h:16:
In file included from ../..\device/fido/virtual_fido_device.h:17:
../..\base/containers/span.h(501,21): error: call to 'data' is ambiguous
  return span<T, N>(data(container), size(container));
                    ^~~~
../../content/browser/webauth/virtual_authenticator.cc(148,29): note: in instantiation of function template specialization 'base::make_span<32, std::vector<unsigned char, std::allocator<unsigned char> >, unsigned char, void>' requested here

                      base::make_span<device::kRpIdHashLength>(
                            ^
_NODISCARD constexpr auto data(_Container& _Cont) -> decltype(_Cont.data()) { // get data() for container
                          ^
../..\base/stl_util.h(116,16): note: candidate function [with Container = std::vector<unsigned char, std::allocator<unsigned char> >]
constexpr auto data(Container& c) -> decltype(c.data()) {
               ^
_NODISCARD constexpr auto data(const _Container& _Cont)
                          ^
../..\base/stl_util.h(133,16): note: candidate function [with Container = std::vector<unsigned char, std::allocator<unsigned char> >]
constexpr auto data(const Container& c) -> decltype(c.data()) {
               ^
1 error generated.

C: \projects\src\out\Default\..\..\..\..\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.23.28105\include\xutility(1168,27): note: candidate function [with _Container = std::vector<unsigned char, std::allocator<unsigned char> >]
C: \projects\src\out\Default\..\..\..\..\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.23.28105\include\xutility(1173,27): note: candidate function [with _Container = std::vector<unsigned char, std::allocator<unsigned char> >]
Change-Id: Icf64aecbc5501a9aa3a9938befef0a703745d5ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894264
Commit-Queue: Jeremy Apthorp <jeremya@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Jeremy Apthorp <jeremya@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711506}

Check all testable files, not just source files.

Bug: 1018801
Change-Id: I94e1fe78e57304dacaa59bb12d4004cffc7d6580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893503Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711505}

Implemented the tab swithcer longpress menu on the bottom.
In the meanwhile, decreased the menu width to match the design spec.

Bug: 1011012
Change-Id: If1edc83bf9b10d332fc7627e9b88b2aed191a201
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856729Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/master@{#711504}

This reverts commit 8657999c.

Reason for revert: Caused crash crbug.com/1020181.

Original change's description:
> Don't create GraphicsLayers for VisualViewport
> 
> Now VisualViewport creates cc::Layers instead of GraphicsLayers, and
> creates foreign layers directly during painting instead of by collecting
> GraphicsLayers. This makes VisualViewport use the same code for CAP and
> pre-CAP.
> 
> PaintLayerScrollableArea still uses GraphicsLayers which are created by
> PaintLayerCompositor/CompositedLayerMapping.
> 
> GraphicsLayers created by PaintLayerCompositor/CompositedLayerMapping
> no longer need to attach to VisualViewport which no longer creates
> GraphicsLayers.
> 
> Bug: 1012594
> Change-Id: I5ce76a3b5728d3810d85d536357cb437eea5fc4f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869126
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710881}

TBR=wangxianzhu@chromium.org,bokan@chromium.org,pdr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1012594, 1020181
Change-Id: I3e0f5fa0b3698d8af7cd9f6d6f81e34f40c8b30d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894110
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711503}

Provide developers with guidance on how to adapt to the changes
introduced in manifest version 3.

Change-Id: Ie25a3bc6e09e3621e3c78a736057006cf954c9f9
Bug: 1018443
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880695
Commit-Queue: Simeon Vincent <simeonv@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711502}

This change adds a PredictionModelFetcher to the PredictionManager
to update the models and host model features it manages. The
models returned from the fetch are stored in the in-memory maps
owned by the prediction manager.

Future changes will asynchronously store the models in a leveldb store
and create a schedule of when fetch attempts should be made.

and I've already spent a non-trivial amount of time trying
to reduce its size that is mostly due to a new proto being added.

Bug: 1001194
Change-Id: I38d8e6f69f469e0d83e9e6e3910325e4da9b913a
Binary-Size: Increase needed to implement a new feature,
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846561
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Auto-Submit: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711501}

- Change the dialog title.

Bug: 1020283
Change-Id: I794834076f17bf95880f737f30598a4bc234f9fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894172
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Auto-Submit: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711500}

This CL fixes the histogram name PluginVm.EngagementTime.PluginVm in
histograms.xml to match the code, PluginVm.EngagementTime.PluginVmTotal.
This name is computed in the code dynamically by
GuestOsEngagementMetrics::RecordEngagementTimeToUmaIfNeeded().

Bug: 990252
Change-Id: I33389fe949a0594d4d506033478d7ec0cccf2cd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892472
Auto-Submit: Timothy Loh <timloh@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711499}

Bug: None
Change-Id: If2039c5071a352c0ae6733a2b2270c584a32edd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891124
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711498}

When trying to disable tests via the instantiation name tests were still running when they should have been disabled.

TBR=hbos@chromium.org

Bug: 993020
Change-Id: Ic1df1c65158acc39714bc2393668d2b21240c7bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894313Reviewed-by: Caroline Rising <corising@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711497}

In exo::Pointer, SetCursorType provides system wide cursor shape change
while UpdateCursor updates the cursor per Widget. Because of that, by
followng the steps below, we can cause a glitch. In order to prevent
that, we should call UpdateCursor at the end of SetFocus.

1. Initially, the cursor is normal on both windows.
   Window #1: cursor kPointer(focused), Window #2: cursor kPointer
   Shown cursor: kPointer
2. ARC calls SetCursorType(kNone).
   Window #1: cursor kNone(focused), Window #2: cursor kPointer
   Shown cursor: kNone
3. Press Alt-Tab to focus Window #2. ARC calls SetCursorType(kPointer).
   Window #1: cursor kNone, Window #2: cursor kPointer (focused)
   Shown cursor: kPointer
4. Move the cursor to the location in Window #1. ARC thinks it should be
   kPointer, but SetCursorType is not called as it's already called.
   As a result, kNone is shown although kPointer should be shown.
   Window #1: cursor kNone, Window #2: cursor kPointer (focused)
   Shown cursor: kNone

TEST=manual(Follow the repro steps in #2 of the bug)
BUG=b:132095671

Change-Id: Iea860a0f2099b6b1d5d20dc8483ec1ae975792bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885130Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711496}

We used (or wanted to used it) for the projects:
 - NavigationMojoResponse.
 - PerNavigationMojoInterface
 - NavigationImmediateResponse.

Everything landed.

Moreover, after dgozman@ works, receiving CommitNavigation() and sending
back DidCommitNavigation() are done in a single task. Previous worries
about delay caused by task scheduling are gone.

These histogram are not really useful anymore. They are ranked 98th
percentile by storage size. We should remove them.

Bug: 882710,984406,1019038
Change-Id: Ia138074043390f424f752ae28cdceeab056fe803
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893269Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711495}

Removes PlayStateUpdateScope for Animation::play and aligns its
implementation with the web-animations spec found here:

https://drafts.csswg.org/web-animations/#playing-an-animation-section

Cleanup patches are still needed to transition from tracking the
active playback rate to the pending playback rate and to remove
dependencies on flags that are being deprecated.

BUG: 960944
Change-Id: Ie5fbbd46c7a4d0f61cdb0e511cc9d8b8569f2d37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891125Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711494}

The flag is used in the pathbuilder impl in cert_verify_tool, and
will also be useful in unittests.

Change-Id: I4613701d01a1e4e96bcfd8501074ecdb965150da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894104Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711493}

This reverts commit ed064683.

Reason for revert: Running out of capacity, see https://crbug.com/1020376

Original change's description:
> android-pie-arm64-rel cq experiment to 100%.
> 
> Bug: 765833
> Change-Id: I9558db3934ebae0252f0fd4f2861c3c4441d7020
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871639
> Auto-Submit: Andrew Luo <aluo@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>
> Commit-Queue: Aaron Gable <agable@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711093}

TBR=agable@chromium.org,aluo@chromium.org

Change-Id: I074d0a0dd94d53b6967496b7df42c9fa3ccf39e7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 765833
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894045Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711492}

The previous format string failed to account for the fact that int64_t
is sometimes a long, sometimes a long long depending on architecture.

Now, using int32_t which should be sufficiently large for our needs.

Bug: 1019711
Change-Id: Ib509b00c4340ed085ac78596af04f46c97878cfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891575Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#711491}

The previous CL was reverted because it assumes that the title of the
first shelf icon is "Chromium", which is not true under official
build. This CL replaces the hard-code check with the function to
fetch the icon's title. Meanwhile, this CL merges shelf_widget_test_api
into shelf_test_api.

///////////////////////////////////////////////////////////////////////
Previous CL description:

This CL accomplishes the following things:

(1) Designate the previous/next focusable widget for navigation widget,
hotseat widget and status area widget. It prevents the accessibility
ring from being trapped in one widget.

(2) Ensures that the hotseat is shown when the shelf app icon gets
the accessibility focus.

(3) Implements the test api to facilitate browser tests to access
the shelf widget code.

Bug: 1010219
Change-Id: Ibe522a6396c61f8b9bb7af01f34106f21500fdf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892155
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711490}

Previously DevUiLoaderThrottle::OnDevUiDfmInstallWithStatus() calls
CancelDeferredNavigation() and passes BLOCK_REQUEST. However, this is
not an allowed value, and triggers a DCHECK in
NavigationRequest::CancelDeferredNavigationInternal(). This CL fixes
the bug by replacing BLOCK_REQUEST with CANCEL.

Bug: 1020272
Change-Id: I32c442bed726cf28f81864a683ca87d051555fa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894116
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711489}

The Autofill enablement toggle switch was broken up a while back into
separate toggles for addresses and payments; this CL logs them
separately.

It also cleans up some prefs/test code that was still using the overall
toggle function, which is actually a little confusing since the original
pref is no longer used.

Fixed: 1017950
Change-Id: I63ca53cff3f4133b0dae1f35f0c6da5c4dd557f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880206
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Matthias Körber <koerber@google.com>
Cr-Commit-Position: refs/heads/master@{#711488}

This check verified that either concurrent marking was enabled, or
the worklist for keeping v8 references found by concurrent markers
is empty.
Checking that the worklist is empty when concurrent markers are
active results in a data race. Switching the order of the conditions
in the DCHECK means will only check the worklist if we don't have any
concurrent markers.

Bug: 986235
Change-Id: I0c4b15c944c3d52dc72fb150b47b97b03d475f17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892772
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711487}

This will fix the zoom not working issue when running on desktop.
I probably forgot to remove this before sending.

Bug: None

Change-Id: Ia2f50b46aefb427a80cbb84c32f7233ad010b0d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893357Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711486}

aemu-linux-arm64 is an optional third_party package added by gclient
which should not be checked in to git.

Bug: 1000907
Change-Id: I97d083b9c1949eea8264ed280ef3004b4c566a1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893973Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Stephen Roe <steveroe@google.com>
Cr-Commit-Position: refs/heads/master@{#711485}

Bug: 1007981, 693741, 959941, 979352, 979002
Change-Id: I62ad1fcefb403e5998029fbeec043154e399c75d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890994
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711484}

But allow flag override. Uses max of 8 and URL limit of 7.
Desktop only. Will be managed by a Finch roll-out.

Bug: 964049
Change-Id: I29db26586dda34c2eaeda2744feb5718010c2648
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891458
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711483}

The incognito icons are visually a little big. This CL is going to replace
the resources of icons on tab switcher mode.

Bug: 1013272
Change-Id: I591166cb85995ab9bb61c57f3ef3cb5705fcfa49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887844
Commit-Queue: Lijin Shen <lazzzis@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711482}

This is more aligned with Android style guide.

Change-Id: I2c31408f8a4d8c59de187e8015981e46eb1d4105
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894314
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711481}

https://chromium.googlesource.com/angle/angle.git/+log/3ff097ff2055..ba65c156cf76

git log 3ff097ff2055..ba65c156cf76 --date=short --no-merges --format='%ad %ae %s'
2019-10-31 jmadill@chromium.org Capture/Replay: Implement GetFramebufferParameter capture.

Created with:
  gclient setdep -r src/third_party/angle@ba65c156cf76

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@google.com

Bug: None
Change-Id: I5d579ce2ae74ca520aaa4b5737ba8fd519e60705
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893147Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711480}

RadioButtonWithDescription & friends don't support adding via code.
This change wraps up the view properly to allow for inflation and adds
a layout to host the buttons and proxy checked events between the
custom code and the standard callbacks.

Bug: 1015218
Change-Id: Ic4bc5e1d01ee982a4513f9c9b202c40646b8739f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869024
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Ender <ender@google.com>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711479}

Reverts the recent change to automatically trigger
try-nougat-phone-tester and android-oreo-arm64-dbg on VR CLs. It
appears that there isn't quite enough capacity for these two builders to
support regular tryjob runs. The Pie tester should still catch most
VR-related issues before CLs land.

TBR=bpastene@chromium.org

Change-Id: I0e127af80d0c1a5d7153d779991dce172fdb6eb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894394Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711478}

https://skia.googlesource.com/skia.git/+log/7823aeb8d6da..5b6ccbb6b599

git log 7823aeb8d6da..5b6ccbb6b599 --date=short --no-merges --format='%ad %ae %s'
2019-10-31 benjaminwagner@google.com [infra] Upgrade MacBookAir to 10.15.
2019-10-31 herb@google.com ...finally!
2019-10-31 michaelludwig@google.com Move tessellation math into GrQuadUtils
2019-10-31 benjaminwagner@google.com Add Pixel4 jobs

Created with:
  gclient setdep -r src/third_party/skia@5b6ccbb6b599

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Bug: None
Change-Id: Ib64a85da78e47841407032d75eb6d9066a2bd39f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894255Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711477}

gsync error message from alexclarke@

(inside 'host_os == "linux" and checkout_fuchsia and checkout_fuchsia_for_arm64_host')

ValueError: invalid "and": exactly 2 operands required
Bug: 1000901
Change-Id: Iea261c3cbbc65c92a3c79a43c1abfdaa1e3e1411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893190Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Stephen Roe <steveroe@google.com>
Cr-Commit-Position: refs/heads/master@{#711476}

R=robertocn@chromium.org

Bug: 1013608
Change-Id: Icf9fd7235a22d91adacc1b1595353e0060147175
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893375Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711475}

https://android.googlesource.com/platform/external/perfetto.git/+log/7aa214a27bca..f016a6633058

git log 7aa214a27bca..f016a6633058 --date=short --no-merges --format='%ad %ae %s'
2019-10-31 primiano@google.com Merge "UI: Simplify WASM interop"
2019-10-31 fmayer@google.com Merge "Fix next ID."

Created with:
  gclient setdep -r src/third_party/perfetto@f016a6633058

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: Id4939f00a44e482e6551ba5b30c42e4a31698d5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893146Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711474}

That class is specific to the Gamepad API integration that was used by
WebVR, so we can remove it now.

Bug: 1017848
Change-Id: I8b3022fbf59bd12ead6678b39b744efb2e57f428
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888120
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711473}

On Stable 1 GB corresponds to the 60th percentile for total resident
set, setting the limit to 1GB will let Chrome work fine with 3-4 tabs.

Bug: 980965
Change-Id: If4f0b6171eb159c3781290b8060617d57d399327
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893580
Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711472}