- 15 Jan, 2021 40 commits
-
-
Liquan (Max) Gu authored
Motivation: Now, payment handler supports pages of any mime type on Android. This exposes payment handlers to the vulnerabilities of some less maintained mime-types. In order to make payment handlers safer to use, this CL limits the mime types of payment handlers on Android by allowlisting. Changes: * Moved the WebContents user data setting logic into markPaymentHandlerWebContents() to payment_handler_navigation_throttle.cc. * Let both Android & desktop's payment handler coordinators use the method to annotate a payment handler web-contents. * Moved the throttle from //chrome/browser to //components to make it more convenient to depend on. Bug: 1165367, 1159267 Change-Id: Ibc75bad9b47b2586e4222c2556c4bf6fb6bd28cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614918 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843892}
-
Dominic Mazzoni authored
Bug: 1161541 Change-Id: Ie6c0614bc7fc4c53e341639a0b2635dd8414362c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622654 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#843891}
-
David Black authored
Addresses two issues: 1. When shelf alignment/config changed any previews that were in the process of being removed were appropriately destroyed. However, we failed to call `OnOldItemsRemoved()` after so any new/existing items weren't animated/shifted into position. The result was missing and misplaced previews. 2. The translation calculation in `OnShelfConfigChanged()` was slightly off. Fixed with index based calculation. Bug: 1166804 Change-Id: Ifda6a6a4fa527bfc6753840a7257fc92c9446a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631293Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#843890}
-
Andre Vincent authored
Screenshots: screenshot/PJsKP6DzT2ecYab screenshot/3NPEiJuMVCY75hL Bug: 1166737 Change-Id: I94f7e714beb85550658f9c57d8030b4a52160c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630407Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Andre Vincent <andrevincent@google.com> Cr-Commit-Position: refs/heads/master@{#843889}
-
Anders Hartvoll Ruud authored
The DependsOnContainerQueries flag was already added to ComputedStyle, but until now nothing actually set it (outside unit tests). This CL sets the flag whenever we match a container query-dependent rule (regardless of the result of the query). Note that I'm deliberately avoiding mutation of ComputedStyle directly from ElementRuleCollector, since we're trying to get rid of the mutable reference. Hence the flag is transported via MatchResult instead. Note also that this doesn't quite work correctly for pseudo-elements: we need to mark in PseudoStyleForElements, and also handle dynamic_pseudo matches in ElementRuleCollector, but that will be done in a separate CL. Bug: 1145970 Change-Id: Id48bd88d3f0580c8f58802565bc77a7ff1497d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627150 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#843888}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d3664703dfa9..e75ecf38f24b 2021-01-14 tsepez@chromium.org Add tagging for fxjs per-isolate data. 2021-01-13 tsepez@chromium.org Fix typo in cpdf_occontext.cpp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Idf49e7def4bd8a567bb51bb7cc677021949629e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631207Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843887}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2241db8a1f6c..091f5ac0a64c 2021-01-14 sokcevic@google.com Use real default branch in gclient If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1156318 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I4e0ac49a960d915304ea662f02ce1bbb31bb208f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631585Reviewed-by:
-
David Van Cleve authored
This change disables RepeatableQueriesServiceTest.SignedIn_DefaultSearchProviderChanged because it's been failing every now and then on multiple platforms since at least November. R=mahmadi Bug: 1158533 Change-Id: I32acb06a8e55e99f0a504f94c4c73e6def1596da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631625 Commit-Queue: David Van Cleve <davidvc@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#843885}
-
Keishi Hattori authored
cbor decoder's ELEMENT() macro is rewriting CheckedPtr without going through BackupRefPtrImpl::WrapRawPt() because it is reinterpreting the CheckedPtr memory as void*. This causes AddRef/Release mismatch so when we try to decrement the refcnt, we cause a UseAfterFree. Bug: 1154799 Change-Id: Ica91c688a310ce6e3e0f2c5d9f6fa2988699bb12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626608Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#843884}
-
Darren Shen authored
NativeInputMethodEngine can now commit some text and move the cursor to the beginning of the committed text in the same atomic operation. Bug: 1155331 Change-Id: I85007fc84af1574f834467a4bc0fd4df2c5fac10 Fixed: 1155331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626680Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#843883}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I27785425caddb41455f9007d567cf5e7daebb2e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630589Reviewed-by:
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/foreground/js/: - actions_controller.js - import_controller.js - import_controller_unittest.js Conversion of externs: //ui/file_manager/externs/command_handler_deps.js Bug: 1133186 Change-Id: I65d231c4c82fe92ac956845ab19b601b1636c8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629328 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#843881}
-
Dominic Mazzoni authored
Android ignores AssistData from Chrome that doesn't arrive within 3.0 seconds. The Assistant team reports that this frequently times out with Chrome or WebView. To maximize the chances results are returned in time, set a timeout of 2.0 seconds to get the accessibility tree snapshot. Our underlying assumption here is that some results are better than no results. Note that we already had been using a limit of 5000 nodes, but the time to populate 5000 nodes wasn't very consistent. Using a timeout will be much more reliable. Bug: 1161541 Change-Id: I6dfa7c37f5dc11c5a4ccd69de8533b833de00e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629406Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
Leo Zhang authored
Skip decoder check for the ime_spec when it's M17N request. Bug: 1166064 Change-Id: Ib02db10805d5c222c9767e54c46367b00096587d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626864Reviewed-by:
Leo Zhang <googleo@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#843879}
-
My Nguyen authored
This reverts commit bca5f7be. Reason for revert: Tree is closed because of https://ci.chromium.org/ui/p/chromium/builders/ci/android-marshmallow-arm64-rel/24224/overview Original change's description: > Declare T as a base class of the BrowserAssociatedInterface<T> helper. > > When a class uses BrowserAssociatedInterface<T>, it should implement the > mojo interface T. Force that to be the case by making T a suclass of > BrowserAssociatedInterface<T>. > > Change-Id: Ide8ecd46c298ec86de57b229593ec7d6c4b6a3a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629670 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843845} TBR=avi@chromium.org,dcheng@chromium.org,reillyg@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I0dea0f28378f7256bdd09f8196315905b8803da8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631806 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#843878}
-
Ajit Narayanan authored
While Select-to-speak uses the global TTS speech rate by default, it now allows users to override this rate if they want to use a specific rate for a specific type of content. This CL records the override speech rate multiplier used when speaking. AX-Relnotes: n/a Bug: 1143814 Change-Id: Ia2a5e8313d17f8abfbffc7b293af19e3b7b65018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606678 Commit-Queue: Ajit Narayanan <ajitnarayanan@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#843877}
-
Henrique Ferreiro authored
The enum values were all in uppercase. This CL changes them to conform to the style guide: https://google.github.io/styleguide/cppguide.html#Enumerator_Names. Bug: 711332 Change-Id: I4bf4cff76d15509a088df2e022942e2f87b1b5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626652 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#843876}
-
Toni Barzic authored
Also, clear the tray icon when hiding previews (as this cancels any pending update timers). BUG=None Change-Id: I9647ff70b3359bd803a434d39b64d3cd6f1186b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631193Reviewed-by:
-
Jeffrey Kardatzke authored
This fixes multi-slice content. The proper way of doing it is to aggregate all of the encryption parameters into one buffer for all the slices and send that. Previously it was sending an encryption parameter buffer for each slice. BUG=b:153111783 TEST=Encrypted H264/HEVC work with single and multi-slice Change-Id: I57abbc839d1c6878da7c6a13b8b6da9889329179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631466 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#843874}
-
Yuta Hijikata authored
This is a mechanical change replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) to ensure that switching lacros' target_os from linux to chromeos will not affect the lacros binary. More detail on http://go/lacros-macros. Bug: 1052397 Change-Id: Id4b8f4ea0605a897cadbf2140201e2b8efe7acd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627653Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#843873}
-
Yuta Hijikata authored
This is a mechanical change replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) to ensure switching lacros' target_os from linux to chromeos does not affect the lacros binary. More detail on http://go/lacros-macros. Bug: 1052397 Change-Id: I2018adb0173f1c0ec56e1f0228bb73fa343da83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627199Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#843872}
-
Brandon Jones authored
Trace function was calling the wrong superclass. Bug: 1166921 Change-Id: I477b68c7ba6b39deddd4d32f2f4f092d6c696f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631285 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#843871}
-
David Van Cleve authored
This test has been failing intermittently recently. Flake Portal link: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyawsSBUZsYWtlImBjaHJvbWl1bUBicm93c2VyX3Rlc3RzQEFkc1BhZ2VMb2FkTWV0cmljc09ic2VydmVyQnJvd3NlclRlc3QuUGFnZUFkRGVuc2l0eUlnbm9yZURpc3BsYXlOb25lRnJhbWUM It's already been disabled on Windows, but it's been failing on other platforms, too. I've added a few labels to the linked bug to help track. R=johnidel Bug: 1121444 Change-Id: I5ab328a6967437203c6390f71e6fe13f5c24eb81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631192 Commit-Queue: David Van Cleve <davidvc@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#843870}
-
Sky Malice authored
Bug: 1166575 Change-Id: I6e1cd55c14234e01eda672dcc720188bb5aec5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631196Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#843869}
-
Adam Norberg authored
This is going to get populated with a JSONFileDeserializer. Bug: 1154901 Change-Id: I5285b3b24a4d574c311addd44e34572b9e863c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598004 Commit-Queue: Adam Norberg <norberg@google.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843868}
-
Jinsuk Kim authored
IntentMetadata is a holder for some info on the intent used for the toolbar in an Activity. This CL moves it from chrome_java to toolbar/ target to facilitate the modularization. This change allows a few more classes to be moved to the modularized target: - HomeButtonCoordinator+test - ToggleStackButton+test - TabCountProvider - TabSwitcherDrawable Bug: 1127732 Change-Id: Id6280436464fb74d2bde636c6e6e8df783f7ba85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619244Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#843867}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d2fb128052ae..5a6fda1a6fcc 2021-01-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 0f4638b9e499 to 0a68b365ebff (4 revisions) 2021-01-14 bclayton@google.com Convert StorageTextureTests to WGSL Also rolling transitive DEPS: https://dawn.googlesource.com/tint from 0f4638b9e499 to 0a68b365ebff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Ie4a5244610f500c05ab32f9f44ff4f436f4e9cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631165Reviewed-by:
-
Shakti Sahu authored
There was a bug due to which the tutorial manager didn't return the summary card correctly. This CL fixes that. Bug: 1166765 Change-Id: I0775f827f5ab96dd209b85c482ce33ef86ff70e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629461 Auto-Submit: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843865}
-
rajendrant authored
Fix the path used in test server. Bug: 1166280 Change-Id: I34fc06dc911c69d00f8dc4d193052d088f99816a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626022Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#843864}
-
Gordon Seto authored
Clean up button_bar state by replacing ButtonState.HIDDEN with undefined. Bug: 1093185 Change-Id: I24e5562adfc0eb1cc7acd89fe8586e31b5d0371a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630627 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#843863}
-
Scott Violet authored
Weblayer seems to be triggering a crash with this config. BUG=1166748 TEST=none No-Try: true Change-Id: I6fa2ae167347a1a72905be846946c6037443fb6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629663Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#843862}
-
Victor Costan authored
Change-Id: I1d2585cd45684f25b3f319e54c9a2b02fb3c0a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631454Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#843861}
-
Sunny Sachanandani authored
GL_RG8_EXT is part of GL_EXT_texture_rg which is an ES2 extension, so we must follow ES2 semantics like GL_R8_EXT i.e. internal format must match data format. Just something I noticed while doing some related work, probably doesn't matter in practice if we're not creating RG8 textures with glTexImage2D, etc. Bug: 1116101 Change-Id: If6042f2432eec13df6b2d27602d87674e19cc78d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629665Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#843860}
-
Leonid Baraz authored
Change-Id: I8283cdbb148fe05335d82fae80485fe443be7e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631448 Auto-Submit: Leonid Baraz <lbaraz@chromium.org> Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#843859}
-
Xiaodan Zhu authored
This CL implements desks reordering with drag & drop. The main changes are listed as below: - Added response methods for mouse pressed, drag and released events in desk preview to trigger drag and drop. - Added *DragDesk methods in desks bar view to handle drag and drop. - Added a new class DeskDragProxy to create a proxy of desk being dragged. - Added a method PerformMiniViewReorderAnimation to animate the movement of desks while reordering. Bug: 1154038 Change-Id: I7633970a94d69e1326cf09eaede3929ca0acb811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602859 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#843858}
-
John Delaney authored
What: Adds new chrome/ layer embedder controls for the Conversion Measurement API which proxy to privacy sandbox settings. Why: The existing integration only checks for 3P cookie blocking, whereas the privacy sandbox settings check whether 3Ps are allowed for a given context. This also fixes a privacy sandbox settings bug in which the wrong origin was supplied when checking if a report can be sent for a given set of origins. Note: This was previously https://ccrev.com/c/2613686, but that change was accidentally deleted. Bug: 1163721 Change-Id: I10aba286ad7c641fe8f19f8ad327cf6eabdc3c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627093 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#843857}
-
tby authored
This CL does two things. 1. The previous CL only checked the value of the content toggle at initialization, meaning a user wouldn't immediately stop seeing suggestions after disabling, or start seeing them after reenabling. This CL moves the check to just before display time instead. 2. This also adds a content toggle check to the local file provider, rather than just Drive in the previous CL. The UX of having one but not the other wasn't very good. Bug: 1034842 Change-Id: I4f408d8d1e40ef44e4a80906aa10ad7333a49eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628709Reviewed-by:
Rachel Wong <wrong@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#843856}
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/4c6cbd7a1be7..676d3c095a28 2021-01-14 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 586c46b96b62 to fb2ab876edcd (1 revision) 2021-01-14 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 820179bf4689 to a5eaf2f44a5d (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com,dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: radial-bots+chrome-roll@google.com,timvp@google.com,dsinclair@google.com Change-Id: I952a9b110b63f41e9c88b428b01ccb0dc8ad15e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629473Reviewed-by:
-
Ted Meyer authored
Just in case it ever gets called twice, we don't want to move the error out. Change-Id: I6d091b2c56fa7e07ce0b1ca08f079d87621d592e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631188Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#843854}
-
Dominic Mazzoni authored
THe box-shadow property isn't shown in forced colors mode, so give the realbox a real border instead. Bug: 1166383 Change-Id: I8a1aa58d965a0fed1a69b0210273a984c8478a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628077Reviewed-by:
-
