- 27 Feb, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/005269a51304..29d5cf85ac28 git log 005269a51304..29d5cf85ac28 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 gregorynisbet@google.com fix git cl presubmit Created with: gclient setdep -r src/third_party/depot_tools@29d5cf85ac28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1056534 Tbr: agable@chromium.org Change-Id: I2f2d2ec62d34b8127145c005f526832bec1b54bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077578Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744990}
-
Michael Lippautz authored
Convert to idiomatic tracing on the way. Bug: 1056170 Change-Id: I6158eac8746953abc1a451a2785e4aa921f057f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075657Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#744989}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d8e762cd820b..c11ee67062ce git log d8e762cd820b..c11ee67062ce --date=short --first-parent --format='%ad %ae %s' 2020-02-27 gabriel.luong@gmail.com Typecheck common/AppProvider.js, common/Runnable.js and common/StringOutputStream.js with TypeScript Created with: gclient setdep -r src/third_party/devtools-frontend/src@c11ee67062ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7e203a73d8167d379f60a3e5e0f99077687e5b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077581Reviewed-by:
-
Miyoung Shin authored
This reverts commit d5df8b85. Reason for revert: Memory Regression Original change's description: > Replace blink::TextDirection with base::i18n::TextDirection > > This is a precursor CL to replace ExternalPopupMenu class by a > mojo connection, and replace blink::TextDirection with > base::i18n::TextDirection. > > Bug: 1044268 > Change-Id: I0b6802201b05c48abaf19de78e81a848d5dc94b3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061985 > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743450} TBR=haraken@chromium.org,myid.shin@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1044268, 1055696 Change-Id: I4b7d7073ffaf729e23272c83573a957fc3c03a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076755 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
Henrique Ferreiro authored
This is a precursor CL to allow Blink to depend on ui::Cursor. To do that, ui::Cursor and ui::CursorSize are moved to a new target //ui/base/cursor that does not depend on //ui/base. Bug: 1040499 Change-Id: I26c0349f9c98fb269bdb474e9dcf3a280d268365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054087 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#744986}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I497155445308b7731b904d138f8bc0ff03cdbe11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077279Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744985}
-
Matthias Körber authored
The feature is launched and the experiment can be removed. Note that the feature was enabled by default and is already removed from the fieldtrial config. Change-Id: I8d60a8ba24e2df71cf1f34db6b0ecbc1b0f80d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077477 Auto-Submit: Matthias Körber <koerber@google.com> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#744984}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/50148dbfcb7b..65dd8440ec78 git log 50148dbfcb7b..65dd8440ec78 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 fancl@chromium.org Using Match result for monitored status Created with: gclient setdep -r src/third_party/catapult@65dd8440ec78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1052720 Tbr: sadrul@google.com Change-Id: I9f9ded8bff4f1f8da1a2366e6d8ec27766624fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077580Reviewed-by:
-
Frédéric Wang authored
A platform API for the OpenType MATH table has been added in [1] but the code is not verified by blink_platform_unittests. This CL adds a few tests for fonts with or without a MATH table as well as constants related to script scale down, fractions and radicals. This is not exhaustive but at least cover all the return statements of OpenTypeMathSupport::HasMathData and OpenTypeMathSupport::MathConstant. This also modifies the result of OpenTypeMathSupport::MathConstant for fonts without a MATH table: Instead of returning HarfBuzz's zero value, the function returns a null optional so that callers can decide the default value to use. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2041485 Bug: 6606, 1050596 Change-Id: I4e7f329bbabb1759f6a1adeaa74b49912812ba8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073721 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#744982}
-
Mohamed Amir Yosef authored
As per the linked bug, tests in PasswordSaveUpdateWithAccountStoreViewTest falkily timeout. They have been however doing well for like 2 weeks before getting flaky. I am considering enabling one of the simple test again to see if the problem still exists or not. Change-Id: I1452e7ee7e70ec7b3d63289527b4ae2134d4e81a Bug: 1054629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073881Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#744981}
-
Side Yilmaz authored
This CL update the profile passing to TrackerFactory from ToolbarPhone. Currently, it is always regular profile, however it is not safe because of possible data leakage from incognito to regular profile. Therefore, this CL uses |isIncognito| function at ToolbarLayout class to get correct profile object(i.e., regular or off-the-record profile). Bug: 1041781 Change-Id: I12324730ed6183ba7019138e5064b8fd98d1b45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074677Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#744980}
-
Jose Lopes authored
The callback is used in multiple locations, e.g., the destructor: * https://cs.chromium.org/chromium/src/media/mojo/clients/mojo_video_decoder.cc?rcl=867cd77410eaf2030f9a4f2071e75266626a110d&l=129 and IPC handler: * https://cs.chromium.org/chromium/src/media/mojo/clients/mojo_video_decoder.cc?rcl=867cd77410eaf2030f9a4f2071e75266626a110d&l=400 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: Ia5956521c43f6783f3767697bbca2cf8c4c705d1 TBR=thakis@chromium.org,jam@chromium.org Change-Id: Ia5956521c43f6783f3767697bbca2cf8c4c705d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056476 Commit-Queue: Jose Lopes <jabolopes@google.com> Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744979}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8d1f44cb67cc..e9368975a2f5 Created with: gclient setdep -r src-internal@e9368975a2f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I3ac9495a7534a15b80b29dd1529aba20fd079748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076804Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744978}
-
Jose Lopes authored
This callback is used in 2 places but in different ways. The service uses this callback as a once callback (explained below). And the provider uses it as a repeating callback because the provider works like a factory class. So this CL splits the callback definition into 2 separate callbacks. A detailed explanation of why the service behaves like a once callback. This callback is executed in an IPC handler: * https://cs.chromium.org/chromium/src/media/mojo/services/mojo_video_encode_accelerator_service.cc?rcl=389b555af3ca96ce205c8e231429119a59aab50b&l=47 This callback is used to create an encoder, and once the class holds a valid encoder the Initialize method can no longer be called because of the check in: * https://cs.chromium.org/chromium/src/media/mojo/services/mojo_video_encode_accelerator_service.cc?rcl=389b555af3ca96ce205c8e231429119a59aab50b&l=53 In theory, if the method fails it could be called repeatedly until it succeeds. But looking at the callers it seems this doesn't happen. The only mojo caller is in: * https://cs.chromium.org/chromium/src/media/mojo/clients/mojo_video_encode_accelerator.cc?g=0&l=123 And that method is documented that it can only be called once: * https://cs.chromium.org/chromium/src/media/video/video_encode_accelerator.h?g=0&l=237 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I1f51ff76b679c891740d2848e9d4c573ef315db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069329Reviewed-by:
-
Jack Franklin authored
`String.prototype.toBase64` is being removed from the DevTools frontend [1] and this test has been moved into unit tests in frontend. Bug: 1032561 Change-Id: I8b6d75d2751404c9a012fe8a9fda63a4b2039052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061757 Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#744976}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3f0406a3..f58705e5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4a3f76d357a584332d18d24e9cd3f0d955f986cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075241Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744975}
-
Gauthier Ambard authored
UseWKWebViewLoading is launched and the code has been removed. The field trial config can now be removed. Bug: none Change-Id: Ia41383a4c6016c8bce57c1f31ec01b04bafae691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074879Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#744974}
-
Hiroki Nakagawa authored
This CL adds tests for dedicated/shared worker creation in data URL contexts (iframe and dedicated worker) whose origins are opaque. For dedicated worker creation: 1. Creating a dedicated worker in a data URL iframe 2. Creating a dedicated worker in a data URL dedicated worker 3. Creating a data URL dedicated worker in a data URL iframe 4. Creating a data URL dedicated worker in a data URL dedicated worker Expected behavior: - For 1 and 2, they are expected to asynchronously fail worker construction because the same-origin policy is supposed to be checked during the fetch algorithm based on request's "same-origin" mode. - For 3 and 4, they are expected to succeed in worker construction because fetching a data URL from a data URL context is allowed. Chrome behavior - For 1 and 2, Chrome synchronously fails the cases because the same-origin policy is checked in the Worker constructor (i.e., SecurityOrigin::CanReadContent() call in AbstractWorker::ResolveURL()). See issue 1055697. For shared workers: 5. Creating a shared worker in a data URL iframe 6. Creating a data URL shared worker in a data URL iframe Expected behavior: - For 5, this is expected to asynchronously fail worker construction because the same-origin policy is supposed to be checked during the fetch algorithm based on request's "same-origin" mode. - For 6, this is expected to succeed in worker construction because fetching a data URL from a data URL context is allowed. Chrome behavior - For 5, Chrome synchronously fails worker construction because the same-origin policy is checked in the SharedWorker constructor. This is the same as 1 and 2. See Chrome behavior for 1 and 2. - For 6, Chrome synchronously fails worker construction because of issue 1055693. Chrome doesn't support creating shared workers in dedicated workers and vice versa, so this CL doesn't contain those cases. Note that these are allowed in the HTML spec, so it would be nice to have WPTs for the cases, but it's out of the scope of this CL. Bug: 1053382, 1055693, 1055697 Change-Id: I8480b6079d4fb271855656cedcffc86e6e6c0fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043533 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Eriko Kurimoto <elkurin@chromium.org> Cr-Commit-Position: refs/heads/master@{#744973}
-
Luciano Pacheco authored
This CL removes the animation when updating the thumbnail image. This animation is very quick and hardly noticed and some code paths weren't even using the animation. This fixes 2 issues: 1. Old images weren't removed when there animation wasn't used. 2. The event listener for 'animationend' wasn't removed. No change in functionality for the user, so no new tests added. Test: Manually checked that file list and grid display and update their thumbnails. Bug: 1056443 Change-Id: I8a6bd050c2bbb358387934ff9371c075a6703508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076749 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#744972}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c3a0d11aff58..d8e762cd820b git log c3a0d11aff58..d8e762cd820b --date=short --first-parent --format='%ad %ae %s' 2020-02-27 yangguo@chromium.org Add Jack to OWNERS Created with: gclient setdep -r src/third_party/devtools-frontend/src@d8e762cd820b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I49bac170b9a14b46b19f921651eaf3853152b1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076809Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e763c61a2c3b..3caf4532c490 git log e763c61a2c3b..3caf4532c490 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 04383ff2..b53f5caa (392 commits) Created with: gclient setdep -r src/third_party/skia@3caf4532c490 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I4257574dce0b918c648e87f1739792dae48d2bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076806Reviewed-by:
-
Matthew Mourgos authored
Bug: 976949 Change-Id: Iceabe5a61f3ced8bc6a4c03dd05c460a35552dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068007Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#744969}
-
Eriko Kurimoto authored
This CL adds util::PassKey<ModuleScriptLoader> to the arguments of ModuleScriptFetcher constructor. ModuleScriptFetcher is allowed to be called only from ModuleScriptLoader but currently it can be called from elsewhere as an implementation. To prohibit accessing from other classes, we use PassKey. PassKey value must be private, but we allow accessing this value from outside only for testing via ModuleScriptLoader::CreatePassKeyForTest(). Also, ModuleScriptFetcher::Fetch() must be called only once and this change clarifies this restriction as the comments. Change-Id: If284f4d5ff4ab21fe7f672ac98017d3835497889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071336Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#744968}
-
Gauthier Ambard authored
This CL removes the code that was doing the switch for the feature to use the WKWebView loading property. The property is enabled to 100%. Bug: 1006012,767092 Change-Id: Id4a4ca3ad18b24cb97e79c32aece943470d9d0a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074641 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#744967}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 82-4044.15-1581938780-benchmark-82.0.4065.0-r1 to 82-4044.25-1582542147-benchmark-82.0.4065.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Id108e556b062cecba010571d1cf23e51852f8783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076810Reviewed-by:
-
chrome://flagsAlexey Baskakov authored
This flag enables the new Web Applications platform, independent of Chrome Extensions (Project BMO). Bug: 877898 Change-Id: I1120418f858d8cfedc01a7ccac3e94e46220accf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076753 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#744965}
-
Henrique Ferreiro authored
ui::Cursor::GetBitmap/Hotspot() depend on CursorLoader. This CL extracts those methods as functions in cursor_lookup.h/.cc as a precursor for creating a separate target for ui::Cursor that will allow its usage in Blink. Bug: 1040499 Change-Id: I7c0e4469261621877305996daae0585354fdd4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052783 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Andreas Haas authored
DOMArrayBufferView can be used instead of the ArrayBufferView, and the ArrayBufferView is fetched from the DOMArrayBufferView anyways. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I288ddddf43641e9afae3c9e8e5b4b986279e51b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075377Reviewed-by:
-
Takashi Sakamoto authored
This reverts commit 04f3c8a3. Reason for revert: LoadingPredictorBrowserTestWithOptimizationGuide.UsesPredictionsFromOptimizationGuideIfAvailable is still flaky on linux-chromeos-rel and deterministically fails (TIMEOUT) on linux-chromeos-chrome Sample build: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3532 3532, 3533, ..., and 3539 also reports the test's failure. Sample log: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8887348194941922560/+/steps/browser_tests/0/logs/Deterministic_failure:_LoadingPredictorBrowserTestWithOptimizationGuide.UsesPredictionsFromOptimizationGuideIfAvailable__status_TIMEOUT_/0 Original change's description: > Reland "Reland "Add support for loading predictor to use hints from optimization guide"" > > This is a reland of 9a31f5ab > > Original change's description: > > Reland "Add support for loading predictor to use hints from optimization guide" > > > > This is a reland of eed7024d > > TBR=tbansal@chromium.org for chrome/browser/predictors/... > > > > Original change's description: > > > Add support for loading predictor to use hints from optimization guide > > > > > > Will add metrics in a subsequent CL. This shouldn't affect any current > > > metrics since the support is all behind a feature flag. > > > > > > Bug: 1050101 > > > Change-Id: If6f98dbae86bb5842803cdb3c1b052d99711e62f > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067241 > > > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > > > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > > > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#743767} > > > > Bug: 1050101 > > Change-Id: I796d2bbd322fee835bfc42f3f3bc903b65554291 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068313 > > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#744088} > > Bug: 1050101 > Change-Id: I3450fa6cab159b22d0659532ea8f2524bf4944fc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071380 > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744839} TBR=tbansal@chromium.org,sophiechang@chromium.org,ryansturm@chromium.org Change-Id: I7c1fc5920524e193f0f1d68656f89f55ff111c64 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076868Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#744962}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8b8dc561f00f..cb7f5f4a2acc git log 8b8dc561f00f..cb7f5f4a2acc --date=short --first-parent --format='%ad %ae %s' 2020-02-27 ianelliott@google.com Vulkan: Updated expectations after SwS fixed 4259 Created with: gclient setdep -r src/third_party/angle@cb7f5f4a2acc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: I97439eed923d76a9ad2866d7e038fcc0d8424dcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076803Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4d40271e3f09..4b34ee3de531 git log 4d40271e3f09..4b34ee3de531 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 jmadill@chromium.org Fix comparison of specialization constant keys. Created with: gclient setdep -r src/third_party/swiftshader@4b34ee3de531 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I4957f3c629371ee6b8bc23488ad0182df549c13d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076676Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/d3db56259396..cd2eb2e2d632 git log d3db56259396..cd2eb2e2d632 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 dschuff@chromium.org Add DEPS to hashed build system sources in toolchain_build Created with: gclient setdep -r src/native_client@cd2eb2e2d632 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: mseaborn@chromium.org Change-Id: I9e4e80f712d2557c416aa71ffa976fd2d7a520a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076802Reviewed-by:
-
Koji Ishii authored
This patch supports FragmentItem in |NGBoxFragmentBuilder:: GetChildOffset()|. Fixes 1 NOTREACHED failure. Note, |GetChildOffset| was moved to |NGBoxFragmentBuilder| in <crrev.com/c/2076745>. Bug: 982194 Change-Id: I5e3d00b551b84ae0efa90228369b6aa5f0c8fc21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076824 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#744958}
-
Jiewei Qian authored
This CL adds support to allow individual origins in content settings. Also force allow chrome-untrusted://terminal origin to Clipboard API. Bug: 1035255 Change-Id: Id69840764fdb8c3aba85b6671e913f077f5ea015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064230 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#744957}
-
Tal Pressman authored
Change-Id: I1e28b5287fcbfb706e8c50dad6227161e16855a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076220Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#744956}
-
Eric Willigers authored
The test suite HostedOrBookmarkAppTes is renamed to HostedOrWebAppTest. The test now run with and without the DesktopPWAsWithoutExtensions flag enabled. Bug: 1055236 Change-Id: I91721a970d88f6f056a06a919749d2d78ef825d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076640 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#744955}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/913a2ec17514..e763c61a2c3b git log 913a2ec17514..e763c61a2c3b --date=short --first-parent --format='%ad %ae %s' 2020-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader da659b374113..4d40271e3f09 (2 commits) Created with: gclient setdep -r src/third_party/skia@e763c61a2c3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I20bd7d11968c9f35e1afb629e99b6b9839fea793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076673Reviewed-by:
-
Hirokazu Honda authored
This is a workaround of the failure at 1080p video encoding test on grunt. Originally vaCreateImage is created with a coded frame size. However, it causes SEGV_MAPERR on vaPutImage, which copies vaImage to vaSurface. As a result of experiments, the vaImage size needs to be the same as va surface size. Since this is not stated in VA-API document, so this might be a bug of AMD gallium driver. Besides of the workaround, this CL copies visible size area of VideoFrame to the VAImage. Bug: 1048908 Bug: 1050377 Bug: b:148744040 Test: video.EncodeAcel.* on grunt, eve and soraka Test: camera.* on grunt, eve and soraka Change-Id: I1ee853964387846d2452e72cfbd4c939f0a18f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041382 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#744953}
-
Toni Barzic authored
Introduces a new hotseat state for hotseat inside the clamshell shelf. This state was previously covered by kShown state. While the widget placement within the shelf does not change too much for the new state, the distinction between "shown" state in tablet mode and "shown" state in clamshell (i.e. the new hotseat state) is useful for animating hotseat state related shelf transitions. For example, HotseatTransitionAnimator should not animate the shelf background when transitioning in or out of tablet mode, and is currently keeping track of whether a tablet mode transition is in progress using tablet mode controller observers - it sets the "in tablet mode transition" flag when the transition starting observer is called, and resets it when the transition end observer is called. This approach is fragile, given that the hotseat state transition can changed by other tablet mode observers (so whether the animator correctly detects whether tablet mode is transitioning depends on the tablet mode controller observer order). Having separate state for the clamshell state makes it easier to detect that the shelf/hotseat state is changing as part of tablet mode transition, without having to worry about in which order tablet mode controller observers are added. BUG=1054647,1056478 Change-Id: I3bc83b2c586206c6734bc6cfde913178818eed0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067553 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#744952}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f0a0e26ccade..50148dbfcb7b git log f0a0e26ccade..50148dbfcb7b --date=short --first-parent --format='%ad %ae %s' 2020-02-27 fancl@chromium.org Reusing sheriff-config client Created with: gclient setdep -r src/third_party/catapult@50148dbfcb7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1052720 Tbr: sadrul@google.com Change-Id: I77b5fd4359b6d0248aad9cae5d808bab6811117e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076674Reviewed-by:
-
