- 06 Dec, 2017 40 commits
-
-
Chris Mumford authored
1. Returned more specific errors in OnHandleReady/TransferSomeBytes. 2. Described returned errors in header documentation. 3. Not mapping MOJO_RESULT_ALREADY_EXISTS as that will not be returned. Bug: none Change-Id: Icaa78bd347995c175cc50eb807d9a400d21e96e4 Reviewed-on: https://chromium-review.googlesource.com/809324Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#522106}
-
Łukasz Anforowicz authored
This reverts commit 39603d88. Reason for revert: This CL has caused renderer kills during CrOS login - see https://crbug.com/792500 Original change's description: > Reject IPC requests for isolated origin, sent by non-isolated renderer. > > The CL tweaks StoragePartitonInterceptor (in > isolated_origin_browsertest.cc) so that it can be configured to inject > different origins, depending on needs of individual tests. This tweak > is supported by changes in base/lazy_instance.h (adding of inequality > operator implemented on top of the already existing equality operator), > and in render_process_host_impl.cc/.h (to support creating a test-only > StoragePartitionService via a base::Callback, rather than via a function > pointer). > > Tweaks of StoragePartitonInterceptor allow forking of > IsolatedOriginTest.LocalStorageOriginEnforcement test into 2 separate > tests: > - LocalStorageOriginEnforcement_IsolatedAccessingNonIsolated > - LocalStorageOriginEnforcement_NonIsolatedAccessingIsolated > The second test is introduced by this CL and was failing before this CL. > > Tweaks of ChildProcessSecurityPolicyImpl::CanAccessDataForOrigin > disallow requests from non-isolated renderers (in which case > CheckOriginLock will return NO_LOCK) if the request is for > an isolated origin. This makes the new test pass. > > Bug: 509125, 764958 > Change-Id: Ibfff2c91cb2ac51966e1d89295f10592a3814c08 > Reviewed-on: https://chromium-review.googlesource.com/775060 > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521838} TBR=thestig@chromium.org,alexmos@chromium.org,lukasza@chromium.org Change-Id: Id395a4be8f2127f2fbdc7e4f75e0fbd05272012f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 509125, 764958 Reviewed-on: https://chromium-review.googlesource.com/810986Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#522105}
-
Fredrik Söderquist authored
(last use probably removed by https://codereview.chromium.org/2750293003 and similar earlier CLs.) ShadowList: :Blend and BasicShape::Blend/CanBlend are no longer used Change-Id: I3d9690768f64fa8c602b55cb1a0bf8654100e04c Reviewed-on: https://chromium-review.googlesource.com/809012Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#522104}
-
Morten Stenshorne authored
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I3ad8e07a5b15d0e0c1b8549d5c9397a9b0ca812f Reviewed-on: https://chromium-review.googlesource.com/809154Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#522103}
-
Dmitry Gozman authored
This removes unneeded abstraction and plumbing and reduces dependencies from core/page to former Web classes which will be gone at some point. Bug: none Change-Id: Id637a60132687b26a438342cfc38cf86828307ee Reviewed-on: https://chromium-review.googlesource.com/772902Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#522102}
-
Marc Treib authored
As of https://crrev.com/c/790511, this code isn't built on Android anymore. This also adds compile-time checks to many Instant headers to make sure they're not accidentally built on Android. Bug: 787830 Change-Id: I88026ce703158ac5b1580f02e621dea325a6fd64 Reviewed-on: https://chromium-review.googlesource.com/803280 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#522101}
-
Fady Samuel authored
If a view is shown then it should have a primary surface. Today, the primary surface may be lost due to frame eviction but we don't re-set it on showing a view and so it was possible to end up with an empty tab. Bug: 672962, 791342 Change-Id: I0ade2a58e9b78e82011e81af441a406b872b7710 Reviewed-on: https://chromium-review.googlesource.com/809935Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#522100}
-
Fabio Tirelo authored
Bug: Change-Id: I51c7f5c4b508b2846ba7af0feeee8085ca5e362c Reviewed-on: https://chromium-review.googlesource.com/810054Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#522099}
-
Becca Hughes authored
Move the UA resource counter into ImageResource itself. This means it will always line up with the corresponding Resource counter and there is no chance of a miscount. BUG=790979 Change-Id: Icbb514b151cf9b2800807e3a201db51bdd506076 Reviewed-on: https://chromium-review.googlesource.com/803347 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#522098}
-
deejay authored
According from ARIA 1.1 [1], default values for aria-valuenow were changed as below. - scrollbar, slider : half way between aria-valuemin and aria-valuemax - separator : 50 - spinbutton : 0 [1] https://www.w3.org/WAI/ARIA/wiki/ARIA_1.1_Changes BUG=768126 Change-Id: I670ea1a0c940665161598b0b3e81bcbe1583419a Reviewed-on: https://chromium-review.googlesource.com/652091 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#522097}
-
Morten Stenshorne authored
I'm not sure what this test really provides. The name suggests that it has something to do with column rules, but there are no column rules defined. There is something that looks like rules, but they are in fact absolutely positioned boxes placed in the middle of the column gaps. Anyway, let's at least use the same offsets in the test and in the ref, instead of being slightly off. Bug: 788337 Change-Id: Ic6a07e7020d54e545413c1c7a68f5acdd52019a4 Reviewed-on: https://chromium-review.googlesource.com/810966Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#522096}
-
Jeremy Roman authored
Bug: 791121 Change-Id: Ief7110aae72a25201af687e03c82a88821fd7a2b Reviewed-on: https://chromium-review.googlesource.com/809906Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#522095}
-
Luna Lu authored
1. Vibrate features: Nav / safe browing team would like to collect URLs where vibrate is used when: a. from the top frame or iframe (ads); b. vibrate with user gestures. 2. Touch events: understanding reasons where scrolling is prevented without using touch-action. Features listed above all have shown <1% of page views from chromestatus.com and satisfy UKM privacy constraints. Bug: 706389, 123004 Change-Id: I3d2d48e1e7703d2cc4c05c35b7d4ba6d613d1ca7 Reviewed-on: https://chromium-review.googlesource.com/801754 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#522094}
-
Hui(Andy) Wu authored
Many web sites set autocomplete to wrong tel types. For example, they set it to tel but then expects a national number(Sephora.com). This change overrides all fields with autocomplete attribute set to tel/tel-* with server predictions, as long as server thinks it's a phone number field as well. Bug: 791569 Change-Id: If2c8bea2e0f7d1fed71f019d4756670e62e8ce1c Reviewed-on: https://chromium-review.googlesource.com/809092 Commit-Queue: Hui Wu <wuandy@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#522093}
-
liberato@chromium.org authored
This CL removes the WIP D3D11 VDA in favor of the D3D11 Mojo Video Decoder WIP. Bug: 775577 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie84276b35e274dff5e271be7ecad25e59ea4e7c3 Reviewed-on: https://chromium-review.googlesource.com/806237 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#522092}
-
Mohamad Ahmadi authored
These methods are repeated in AutofillDriverIOSBridge and invoked in AutofillDriverIOS. They're never invoked in AutofillClientIOS. Change-Id: I9f8f6401d7680b3cfcbe98f6d85748f1bea4e280 Reviewed-on: https://chromium-review.googlesource.com/809664Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#522091}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/f9af55641a6d..1946aaf15ca0 $ git log f9af55641..1946aaf15 --date=short --no-merges --format='%ad %ae %s' 2017-12-06 kjlubick Disable ThermalManager for Nexus5x Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: I5d9cba8dc120bd45ba413943d8f8df03148a32f0 Reviewed-on: https://chromium-review.googlesource.com/810924Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522090}
-
Mikel Astiz authored
The use of WaitForGetFavicon() is unnecessary and misleading because it introduces a nested runloop where many things can happen, including model changes that call BookmarksMatchVerifierChecker::IsExitConditionSatisfied() and hence make it reentrant. It is unnecessary because, starting with 55b3fe20, a loading favicon is guaranteed to ultimately notify a model change, which will trigger MultiClientStatusChangeChecker::OnStateChanged() and hence IsExitConditionSatisfied(). Bug: 783774 Change-Id: I02c7623e3bb173b25b9c715b7bdf9c646300e3ee Reviewed-on: https://chromium-review.googlesource.com/785091 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#522089}
-
Dave Tapuska authored
Repurpose spell checking code that was testing for the mojo channel to common code. Write a test that causes the showGuessPanel selector to be sent and verify the panel is requested to be shown. BUG=782836 Change-Id: I9d8ac59ac3bf96bbcd7e538f794eac71e0bc7553 Reviewed-on: https://chromium-review.googlesource.com/786260 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#522088}
-
stkhapugin@chromium.org authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/7f8fefabedf2..f1a87d73fc60 $ git log 7f8fefabe..247a3d8e5 --date=short --no-merges --format='%ad %ae %s' 2017-11-07 whame@users.noreply.github.com Fixes issue #826 by treating MinGW as "non-Windows" when determining colored output 2017-10-29 thielen@hs-worms.de remove markdown stars (bold) from code examples 2017-10-25 arkady.shapkin@gmail.com Enable CI for VS2017 2016-10-21 romain.geissler@gmail.com Remove gcc 6 misleading indentations. 2017-06-08 arkady.shapkin@gmail.com Fix gmock tests when std::unary_function unavailable 2017-05-03 arkady.shapkin@gmail.com Fix tests with VS2015 and VS2017 2017-05-03 arkady.shapkin@gmail.com Enable C++11 features for VS2015 and VS2017 2017-10-17 manojgupta@google.com googletest: Add GTEST_API_ attribute to ThreadLocal class. 2017-10-18 gennadiycivil@users.noreply.github.com Workaround for Travis issue https://goo.gl/d5eV8o 2017-10-18 gennadiycivil@users.noreply.github.com Revert "Workaround for Travis issue https://github.com/travis-ci/travis-ci/is…" 2017-10-18 gennadiycivil@users.noreply.github.com Workaround for Travis issue https://github.com/travis-ci/travis-ci/issues/8552 2017-10-14 dariusz.ostolski@gmail.com #1282: Doc typo fix 2017-10-07 joe@robotgoblin.co.uk Updated README with information about C runtime dynamic/static linking issues in Windows 2017-09-27 jwakely@redhat.com Use gender-neutral pronouns in comments and docs 2017-09-21 gennadiycivil@users.noreply.github.com Revert "Allow macros inside of parametrized test names." 2017-09-19 stkhapugin@chromium.org Swap reinterpret_cast for static_cast 2017-09-16 benjamin.kircher@gmail.com Remove redundant declaration 2017-09-14 31530391+ly2048@users.noreply.github.com Add explicit `CMAKE_DEBUG_POSTFIX` option 2017-09-01 sokolov@google.com Make the failure messages from EXPECT_EQ and friends actually symmetric, 2017-09-08 31780593+yursha@users.noreply.github.com Fix ellipsis position in examples 2017-09-07 thielen@hs-worms.de use GTEST_ATTRIBUTE_UNUSED_ instead of dummy function 2017-09-07 gaspardpetit@gmail.com Removed flush scopes around GTEST_LOG(FATAL) and exit call since FATAL is expected to abort() 2017-09-05 thielen@hs-worms.de remove unused variables from travis environment 2017-09-05 thielen@hs-worms.de drop unused valgrind package from installation 2017-09-05 thielen@hs-worms.de reset ccache statistics at install 2017-09-05 thielen@hs-worms.de show ccache statistics in log 2017-09-05 thielen@hs-worms.de call clang via ccache on Linux 2017-09-05 stkhapugin@google.com add a cast 2017-09-05 thielen@hs-worms.de remove obsolete link_directories command 2017-09-04 thielen@hs-worms.de limit processors to use in Travis build to 4 2017-09-04 thielen@hs-worms.de install ccache on travis osx build slave 2017-09-04 thielen@hs-worms.de set MAKEFLAGS to use multiple processors on Travis CI 2017-09-02 thielen@hs-worms.de cache ccache 2017-08-30 thielen@hs-worms.de avoid warning about unused variable 2017-09-04 thielen@hs-worms.de avoid -Wshadow warning on GCC 2016-02-10 bauerb@chromium.org Add a non-parametrized test. 2016-02-04 bauerb@chromium.org Allow macros inside of parametrized test names. 2017-08-30 thielen@hs-worms.de treat all warnings as errors for GCC (-Werror) 2017-08-30 thielen@hs-worms.de switch one build to Release mode 2016-12-30 lebedev.ri@gmail.com CMake: use threads if allowed and found, not just if found. 2017-08-31 thielen@hs-worms.de change links from former code.google.com to current github repository 2017-08-31 thielen@hs-worms.de fix example's comment 2016-09-05 arkady.shapkin@gmail.com AppVeyor MinGW-w64 test build 2017-08-30 thielen@hs-worms.de create different python based tests for single and multi configuration build generators 2017-08-30 thielen@hs-worms.de Revert "ask cmake for per-configuration output subdir" 2017-08-30 thielen@hs-worms.de ask cmake for per-configuration output subdir 2017-08-30 thielen@hs-worms.de remove obsolete comment regarding python tests on linux 2017-08-30 thielen@hs-worms.de use upper-case build type 2017-08-30 thielen@hs-worms.de use build type set in .travis.yml 2017-08-29 thielen@hs-worms.de remove non-existing gmock_build_samples switch 2017-05-09 thielen@hs-worms.de remove unused TestCase import 2017-08-14 gaspard.petit@eidosmontreal.com Removed extra colon in error log 2017-08-14 gaspard.petit@eidosmontreal.com Use GTEST_LOG instead of printf 2017-07-02 chehsunliu@gmail.com Update googletest README.md 2017-02-13 olivier.clavel@gmail.com googlemock version must be changed as well 2017-02-13 olivier.clavel@gmail.com Wrong version reported (1.7.0 should be 1.8.0) 2016-10-08 adriyetichaves@gmail.com Fix WhenSorted() documentation example 2016-08-30 claus.stovgaard@gmail.com Moved the ignoring of *.pyc files to top level for also covering googlemock python scripts. 2016-05-22 tobbi.bugs@googlemail.com Performance fixes reported by cppcheck Created with: roll-dep ./src/third_party/googletest/src Bug: Change-Id: I72edf5c1ec21f34aab852f661fec6a58bedbd365 Reviewed-on: https://chromium-review.googlesource.com/681214 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#522087}
-
Egor Pasko authored
Update to the new way of getting the HTTP and HTTPS ports for the WebPageReplay server, which was introduced in: https://chromium-review.googlesource.com/c/catapult/+/796863 Bug: 792421 Change-Id: I62b8b18043aff03781fcfba2ac63eaf0e5921b28 Reviewed-on: https://chromium-review.googlesource.com/810967Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#522086}
-
Becca Hughes authored
This adds two histograms to MediaEngagementPreloadedList. The first is used when the list is loaded and will allow us to see if the loads are failing and why. The second is used when the list is checked and will allow us to see if the list has not been loaded or is empty, as well as how often the list is matching. BUG=787464 Change-Id: I935405ef56aa197a2f32fbd85df7c9ae4851b12a Reviewed-on: https://chromium-review.googlesource.com/808305 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#522085}
-
Sergey Poromov authored
There is currently no logging for any events in AutomaticRebootManager and due to that it's hard to investigate issues with non-rebooting devices. These logs will be triggered on Chrome OS devices only: * on AutomaticRebootManager initialization * when reboot policies "UpdateLimit" or "RebootAfterUpdate" change * reboot is required due to an update BUG=b/69546724 Change-Id: I488bb3b1b398d390f8ff2e5613a532e8494449bf Reviewed-on: https://chromium-review.googlesource.com/808886Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#522084}
-
Julian Pastarmov authored
There were a few cases where due to mismatch between policy defintions and entries in the policy_tests_cases.json file. The tests have failed when Chrome was uprevved. This CL aims at making this a little harder by enforcing a proper match between policy lifetime and their tests. BUG: 791125 TEST: browser_tests.exe --gtest_filter=PolicyPrefsTest.PolicyToPrefsMapping Change-Id: I75fdef47081c27184c05ded7cd2bc6a3e355ac79 Reviewed-on: https://chromium-review.googlesource.com/808184 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#522083}
-
Yutaka Hirano authored
Bug: 615313 Change-Id: Ie608f427083303af5afd98e8939dcfc43a266942 Reviewed-on: https://chromium-review.googlesource.com/805395Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#522082}
-
Gyuyoung Kim authored
Latest spec has used USVString instead of DOMString for url argument. - spec: https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers This CL replaces DOMString type with USVString type according to the spec. Bug: 790860 Change-Id: I179144780bd345bc71e9b9beeaea3470a8e3d302 Reviewed-on: https://chromium-review.googlesource.com/781320Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#522081}
-
Henrik Boström authored
This reverts commit f9eaa531. Reason for revert: Suspected cause of Win8 Tester failures https://build.chromium.org/deprecated/chromium.webrtc/builders/Win8%20Tester/builds/38865 Original change's description: > Win video capture: use IMFCaptureEngine for Media Foundation > > - Full rewrite of the MediaFoundation implementation video part to use > IMFCaptureEngine > - Implementation of takePhoto, setPhotoOptions and getPhotoCapabilities > - takePhoto triggers a still image capture with the highest available > resolution without stopping the video stream thanks to IMFCaptureEngine > > TEST=adapted video_capture_device_unittest.cc and > webrtc_image_capture_browsertest.cc; launch Chrome with > --force-mediafoundation on Win8+ and capture video using > e.g. https://webrtc.github.io/samples/src/content/getusermedia/gum/ > > R=mcasas@chromium.org > > Bug: 730068 > Change-Id: Ib8e7f475d8120a63dd08c7b215c1eaf2c6f3d800 > Reviewed-on: https://chromium-review.googlesource.com/734042 > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Christian Fremerey <chfremer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521435} TBR=mcasas@chromium.org,chfremer@chromium.org,alaoui.rda@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 730068 Change-Id: I439af305a6bb45c26efb1b395e69088344a71536 Reviewed-on: https://chromium-review.googlesource.com/810624Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#522080}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e184205c. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/6970 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org, tyoshino@chromium.org: external/wpt/streams TBR=robertma No-Export: true Change-Id: I6f434687ef6249d16f63db28a6d0d95593a1513a Reviewed-on: https://chromium-review.googlesource.com/809732 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522079}
-
Renee Wright authored
I think this should fix the reason this originally was reverted https://chromium-review.googlesource.com/c/chromium/src/+/810324 I have removed the last two lines of ComputedStyleCSSValueMapping::Get. This CL also changes the behavior for ColumnRuleColor. It used to call VisitedDependentColor(CSSPropertyOutlineColor), but that seemed wrong so I changed it to use VisitedDependentColor(CSSPropertyColumnRuleColor). There will be more CLs immediately following to finish Ribbonizing this class. Please ping me for a link to the design doc. Bug: 775360 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0bca0a6ef9dde73d20aad9f733d7f63ce194a50e Reviewed-on: https://chromium-review.googlesource.com/810001Reviewed-by:
meade_UTC10 <meade@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#522078}
-
stkhapugin@chromium.org authored
The two workarounds that were fixing strikethrough issues introduced in iOS 10.3 and iOS 11 seem to no longer be necessary with iOS 11.2. correctly struck through. Try typing in the omnibox and navigating to and from such a website; only "https" should be struck through. Bug: 711367, 760964 TEST: Navigate to a website with bad SSL and observe that "https" is Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id4f73b49281df024e2fbb621a74243440759b138 Reviewed-on: https://chromium-review.googlesource.com/805276Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#522077}
-
Peter Beverloo authored
Rename variables to be clearer in their intention, use a switch statement instead of an if/else if/else blocks and wrap the whole thing as a step function to properly catch failing asserts. Bug: Change-Id: I89c92d7a5071728bfdd8c9827f08ae3af94377db Reviewed-on: https://chromium-review.googlesource.com/809425Reviewed-by:
Anita Woodruff <awdf@chromium.org> Commit-Queue: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#522076}
-
Robert Sesek authored
Bug: 598854 Change-Id: Icb9b7586a8b14772dded0b4c1c323a3668dba371 Reviewed-on: https://chromium-review.googlesource.com/804350Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#522075}
-
Max Morin authored
Also rearrange parameter ordering in AIDI::Create. Both of these changes are to simplify callback binding for the new factory in https://chromium-review.googlesource.com/c/chromium/src/+/771196. Bug: 653871 Change-Id: I825b519e664c0e4cafecff85f199d3bc145c8fda Reviewed-on: https://chromium-review.googlesource.com/795970 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#522074}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/a9cf2fa54a33..307c9f954dc5 $ git log a9cf2fa54..307c9f954 --date=short --no-merges --format='%ad %ae %s' 2017-12-06 perezju [Telemetry] Cleanup android_forwarder code Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I49d420746ee0dcba3eb77afd52d0427dafb322c4 Reviewed-on: https://chromium-review.googlesource.com/809721 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522073}
-
Marc Treib authored
in preparation for using it in more tests (UI tests in particular). Also contains some other minor cleanups. Bug: 791066 Change-Id: I5bd2c7e3e99655e3ff453fc447c69f1484ce3d5b Reviewed-on: https://chromium-review.googlesource.com/808764Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#522072}
-
Marti Wong authored
Make the trailingAnchor of the stackView inside bookmarkTableCell always equals to contentView's trailingAnchor. This can prevent crbug.com/778231 where the stackView's width doesn't grow as expected when editing folder name on iOS 10. Bug: 791976 Change-Id: I71fac7e335561fe7f54beb1062602976b0b2a280 Reviewed-on: https://chromium-review.googlesource.com/809988Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/heads/master@{#522071}
-
Roman Sorokin authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/5c4b603461a7..e494ee7de6e2 $ git log 5c4b60346..e494ee7de --date=short --no-merges --format='%ad %ae %s' 2017-12-01 ljusten authpolicy: Add GetUserStatusRequest and OU errors R=ljusten@chromium.org Created with: roll-dep src/third_party/cros_system_api BUG=chromium:782695 Change-Id: I14032dae5bcbd811fb9afa0561b2e6d4173167df Reviewed-on: https://chromium-review.googlesource.com/809112 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#522070}
-
Henrik Boström authored
This is in preparation for ReplaceTrack. When we have ReplaceTrack, the WebRTCRtpSender is modifiable. Having an internal ref counted class ensures that if one WebRTCRtpSender is modified, this is reflected in all shallow copies of the class. In other words, this CL enables content::RTCRtpSender having internal modifiable states separate from the webrtc::RtpSenderInterface. Made some misc fly-by changes like renaming "webrtc_rtp_sender" variables/methods to "webrtc_sender" and making WebRTCRtpSender::Track() return by value instead of pointer (since there is a "null" value). Bug: 790007 Change-Id: I3f11b2af7457b6c3b9e6de5d97c32085bf050280 Reviewed-on: https://chromium-review.googlesource.com/806161Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#522069}
-
Becca Hughes authored
Add a tool to generate preload data in DAFSA format and add a MediaEngagementPreloadedList class to read it. BUG=787464 TBR=dpranke@chromium.org Change-Id: If0d99a2e1091d0b23699f2173d8146582173ee54 Reviewed-on: https://chromium-review.googlesource.com/803994 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#522068}
-
Matthew Cary authored
This relands crrev.com/c/691663 which confirms that nostate prefetch sets cookies on all fetches. In the interim a test for cross-domain fetches has been added. The original CL was reverted due to flakes on windows. I could not reliably reproduce the flakes, but in addition to the usual CQ, I've run this several times on the windows bots, and it is no longer flaking. Perhaps commit e23356c2 which moved browser_test_utils to mojo access of cookies removed whatever race existed, or perhaps using PostDelayedTask instead of sleeping fixed it. Bug: Change-Id: I71ef3053c71da53e21093dc57d977e3992d279ef Reviewed-on: https://chromium-review.googlesource.com/695221 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#522067}
-