- 30 Sep, 2020 21 commits
-
-
Keren Zhu authored
* Add Finch to control snooze duration experiment. * Add UMA to track 4 events, all with the count of previous snoozes. 1) Tab Group IPH trigger. 2) Tab Group IPH dismiss by dismiss button. 3) Tab Group IPH dismiss by right-click on tab. 4) Tab Group IPH snooze. Bug: 1121399 Change-Id: Ib5aa2ed0c92d5bf8cfe2f1744d596ac2d03e6a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425230 Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#811904}
-
Sammie Quon authored
Test: none Change-Id: If8a7d3c203a36f342440f4046c5c1fc789c4e9b2 Fixed: 1088590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438873Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#811903}
-
Keishi Hattori authored
This reverts commit 6c5fa707. Reason for revert: VTConfigUtil.FormatDescriptionBT709 and FormatDescriptionInvalid are failing on mac https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/58972 Original change's description: > Add media::GetFormatDescriptionColorSpace > > This function is nearly identical to media::GetImageBufferColorSpace, > but instead operates on a CMFormatDescriptionRef. > > Add DCHECKs that the behavior of the two functions be the same, that is, > the kCVImageBuffer-prefixed and kCMFormatDescription-prefixed > constants be equal. > > Use base::mac::CFCast instead of reinterpret_casts. > > The next patch in this sequence will move these two functions over > to media/base/mac, because it will be accessed in capture. > > Bug: 959962 > Change-Id: I8a4d8468abc866a13cb6181cbd49d9ee04288124 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436513 > Commit-Queue: ccameron <ccameron@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811829} TBR=dalecurtis@chromium.org,ccameron@chromium.org Change-Id: Iaa57cf20273eb0bcdace23a1ee9e588da15ea733 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 959962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438551Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#811902}
-
Nela Kaczmarek authored
This CL adds a new parameter to all AffiliationFetcherDelegate virtual methods - a pointer to AffiliationFetcher. This change is required to later handle multiple pending fetchers logic in AffiliationServiceImpl to process each result per specific fetcher. Bug: 1117045 Change-Id: I26ad49ba7bca605c2117ce8a88ce017de2dda276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433927 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#811901}
-
Bailey Berro authored
Change-Id: I6ad2476f440e02c5ce2580a540b0e76a2afcb1f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439536Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#811900}
-
Andrew Xu authored
This CL accomplishes two things: (1) Select the first menu item as default after the multipaste menu shows. (2) Update the selected menu item after item deletion. Bug: 1130737, 1128720 Change-Id: I2ddc0923679b0e95ebe0f746d790dfc11a146668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434365 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#811899}
-
Noel Gordon authored
piex-wasm assumes a fileSystemURL input as the RAW image source. Allow other users to input the RAW image source in a File. Add readFile helper, and make fileSystemURL and File source inputs use it to read the file. fileSystemURL case has automated test coverage, so readFIle is tested, so no change in files app behavior. Bug: 1132695 Change-Id: Ic05c5b5a2178826445221448824f8ef41dc81ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437084Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#811898}
-
Austin Eng authored
This is not needed and should only be done for promise_test. Change-Id: I53aaee9d8f500c85a7d74be0f92ffcb6164b2424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436654 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#811897}
-
Jared Saul authored
The FidoAuthenticationStrikeDatabase was added in https://chromium-review.googlesource.com/c/chromium/src/+/1824362. However, the "Autofill.StrikeDatabase.NthStrikeAdded" and "Autofill.StrikeDatabase.StrikesPresentWhenStrikeExpired" histograms are part of strike_database_integrator_base.cc, which all project-specific Autofill strike databases inherit from. As a result, CL 1824362 missed updating histograms.xml at the time, since it was the superclass doing new automatic logging. Change-Id: Ie791e52dfd51139986553e29230ad23960ee46f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437018 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
-
Simeon Anfinrud authored
This ensures that leaving the Cast Activity by pressing Back on the remote will return to the Home screen, rather than whatever app had been in the foreground previously. Bug: Internal b/163998933 Test: launch Netflix with remote, Cast YouTube, press Back Change-Id: Ib8936e874a80441a4e5c163794ff2576ffbef717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438991 Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Luke Halliwell (slow) <halliwell@chromium.org> Auto-Submit: Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#811895}
-
Derek Basehore authored
This changes the location of the chrome_renderers freezer cgroup to match pending changes. /sys/fs/cgroup/freezer/early_freezer/chrome_renderers/to_be_frozen/tasks file Bug: b/134792837 Test: suspend_stress_test and check for PIDs in Change-Id: Ibf76f4e2f6cbb527dd738194f3baea506447f8d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337546 Commit-Queue: Derek Basehore <dbasehore@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#811894}
-
Avi Drissman authored
Bad logic in PowerMonitorDeviceSource::IsOnBatteryPowerImpl() meant that Macs with no batteries were reported as being on battery power. Fixed: 1132422 Change-Id: Ifa174a0164c4d4d31bdd2dc494b2b7f83fd48bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432765 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#811893}
-
Michael Thiessen authored
Bug: 989569 Change-Id: I2c76acfbcf05454aa73e298ffc4acae689441756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437702 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#811892}
-
Michael Thiessen authored
See https://chromium-review.googlesource.com/c/chromium/src/+/2435724/ for more thorough explanation. Bug: 989569 Change-Id: Icd7d64e2a3716e8aaf66dd757ea4d0433c3a2209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435814 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
-
Avi Drissman authored
Removing cross-origin dialogs is being worked on in https://chromestatus.com/feature/5148698084376576. Make sure that the relevant UMAs don't expire. Fixed: 1130653 Bug: 1065085 Change-Id: I1fb2167f80e9b8337d4169f2236c84822dbce973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438891 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#811890}
-
Rachel Wong authored
The text color is currently set to a dark shade of grey. However, devices with dark launchers can have dark backgrounds and this makes the dark grey text unreadable. This CL updates the text color to be determined by the app list color provider instead, which will take into account the dark or light theme of the launcher. Bug: 1079169 Change-Id: Ica64fffb6e7f83b1e028088af4649c470c4f36fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437075Reviewed-by:
-
Ryan Hansberry authored
Bug: 1129023 Change-Id: Icae4a8c1de05954f7467edae7c477ec41f4fa183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438037 Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#811888}
-
Lukasz Anforowicz authored
This CL updates CheckedPtr docs: - Rewrite examples are provided (e.g. |SomeClass*| -> |CheckedPtr<SomeClass|). - Updated the "Benefits and costs of CheckedPtr" section to reflect BackupRefPtr's characteristics (avoiding dereference-time checks and instead working in ctor/dtor to quarantine the freed memory). - Moved and updated the section on unions - because BackupRefPtr requires CheckedPtr to have a non-trivial destructor, it is incompatible with union fields. - Removed most of the "Runtime errors" section, since with BackupRefPtr: - `operator*` no longer needs to compare tags (as with CheckedPtr2) and therefore should work fine with sentinel values - Converting into a raw pointer no longer performs any checks and therefore dangling pointers can be safely passed around (as long as they are not dereferences afterwards). Other minor updates: - Linking to go/miracleptr - Mentioning that initially the rewrite will not target renderer code Change-Id: Ia1903572a01180f81af39c3a91498dad796e9baf Bug: 1073933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419378 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#811887}
-
Weilun Shi authored
Update the description to emphasize that newly marked obsolete histograms don't need to be moved into this file. Bug: 1132741 Change-Id: I6691db75b9579db09445e00d7b4ecbda16ad97a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438691 Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
Darren Shen authored
On a typical textfield, the IME surrounding text change event is triggered by [1]. However, this is guarded by a check for inputmode != NONE. Whilst this makes sense for a virtual keyboard IME since inputmode of NONE means no virtual keyboard, it doesn't make sense for a physical keyboard IME as inputmode doesn't apply to the physical keyboard. Move the selection update check outside and only check for input type != NONE since it applies to both virtual and physical keyboard. This fixes incorrect surrounding text information on the Google sheets "input field" that that appears when pressing a key on a cell. Note: The comments for [1] suggests that it's only used for a11y, but actually it is crucial to getting the right surrounding text information to IMEs. [1] https://source.chromium.org/chromium/chromium/src/+/master:content/browser/renderer_host/render_widget_host_view_aura.cc;l=2483;drc=ca19c6d8767e8c7e9c0d01c223587183a2e1278d Bug: 1114559 Change-Id: I1b360a4f81d7c5e6479fab8f8fba4d1632881da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344331Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#811885}
-
Yi Gu authored
This reverts commit 7927c8a6. Reason for revert: suspecting that this patch caused consistent test failure on chromeos: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/8852 Original change's description: > Use JS modules for the NTP module > > Uses JS modules for the NTP module and updates > closure so it can resolve chrome://kaleidoscope. > > Change-Id: I985b20a7faca215bd5194a4a21c790d5a4ff0262 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435441 > Reviewed-by: calamity <calamity@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811807} TBR=calamity@chromium.org,beccahughes@chromium.org,steimel@chromium.org Change-Id: I3d4fed8789ad99a9c289ed604b83d22a2c243dc4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438042Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811884}
-
- 29 Sep, 2020 19 commits
-
-
Boris Sazonov authored
Adds code to rollback MobileIdentityConsistency: when the feature is disabled, SigninManager will trigger a signout if there's only primary account, but no sync consent. Bug: 1132290 Change-Id: Ia9f0143b908c1867743e0b89b7589ddbb03bff02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434330 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#811883}
-
Chait Pinnamaneni authored
Bug: 1002914 Change-Id: I393bc371972d8140cf87308723af8852f5b80dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432130Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com> Cr-Commit-Position: refs/heads/master@{#811882}
-
Xiaohan Wang authored
In the last CL, "cpu_arch_full" was set to "arm64-highbd" for Windows ARM64, which seems not needed because "arm64 windows has it's own folder for vp9_rtcd.h etc". This CL revert that part of the change so Windows restores to the previous behavior. Tbr: jzern@google.com Bug: 1133301 Change-Id: Iba23fe496841965f491704d5a503b388c1859b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437745Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#811881}
-
Patrick Noland authored
This reverts commit f218ef61. Reason for revert: Breaking downstream build. Feel free to reland once you have downstream fix ready to go, but I don't think we can let downstream be broken until then Original change's description: > Modularize Omaha on Android: modularized identity/ from //chrome/android > > New location: //chrome/browser/uid; this is a dependency of Omaha on Android. > > Bug: 1131415 > Change-Id: Id65534f432adb733c9b1224f8fc770f30cbf00df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426045 > Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> > Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Natalie Chouinard <chouinard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811874} TBR=nyquist@chromium.org,msarda@chromium.org,waffles@chromium.org,bsazonov@chromium.org,chouinard@chromium.org,andzaytsev@google.com Change-Id: I729d7bc353cf44d2f6e32e7a764726c82b6dd83a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439026Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#811880}
-
Alexei Svitkine authored
This was never added to histograms.xml, but is being logged. Bug: none Change-Id: Id77fbd584c72d363e2dc7537f4a2ae5ebb65749a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438637 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#811879}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //buildtools. Bug: 1113033 Change-Id: I54fdf94f060220d189ce9c843e02fc22f12df623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438877 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#811878}
-
Matthew Mourgos authored
This change makes ShelfController and AppListControllerImpl a MessageCenterObserver. This allows them to hide/show the app badges from being shown whenever quiet mode is enabled/disabled. Bug: 1130940 Change-Id: Ia26890b266b1d8ba26529afddf8347f21729bfb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436859Reviewed-by:
-
Bo Liu authored
This is logged when webview is used in multiple processes in the same app, the warm up connection hits a service used by another process and is not retried again. It's not catastrophic, since launching a renderer process for real will still succeed. So lower it to a warning. Change-Id: Ic9b8bbdda4b6c5cbf45ea7ce15abca7289692625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438894Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811876}
-
Sophie Chang authored
Bug: 1117115, 1089311 Change-Id: I2d5c33342cdccf03554fb7ca287545e69120e592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438886Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#811875}
-
Andrey Zaytsev authored
New location: //chrome/browser/uid; this is a dependency of Omaha on Android. Bug: 1131415 Change-Id: Id65534f432adb733c9b1224f8fc770f30cbf00df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426045 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#811874}
-
Domenic Denicola authored
Fixed: 1127960 Change-Id: I23af107492b2db6d51d05c804398823c1fdef606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426995 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#811873}
-
Henrique Nakashima authored
With this CL, whole packages can be supplied to print_class_dependencies.py so that dependencies from/to all classes in those packages are printed out. Bug: 1133017 Change-Id: I3cae0c6037905113e7250bf518c7100a9367d43b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436411 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#811872}
-
Xing Liu authored
When startForeground called with a cancelled notification update, startForeground() will be bypassed in DownloadForegroundServiceManager. startOrUpdateForegroundService(). This leads to an Android crash. Instead we need to create an dummy notification and still call startForeground() with it to avoid the crash. This dummy notification will be dropped immediately in DownloadNotificationService. Bug: 1121096 Change-Id: I0f68bff47403b7478f504af6ee03f154c727c82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436511 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#811871}
-
Yi Gu authored
TBR=dmazzoni@chromium.org Bug: 1084871 Change-Id: I21e47bc71cdf5655a4b741ee938b155c77bb2d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438734Reviewed-by:
-
Hiroki Nakagawa authored
These were added by https://codereview.chromium.org/6625066 for the legacy prerender, but these are not used for the current no-state-prefetch. Bug: 755921 Change-Id: I7536260cbf2f33f7f99da8bfa458fdc1702bff55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437553Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#811869}
-
Patrick Noland authored
Disables testTabSwitcherModeTriggeredBeyondThreshold and testTabSwitcherModeNotTriggeredWithinThreshold Bug: 1130696 Change-Id: Iea001954b5bcff71be17d0e6ec7b29de8ba9c610 TBR: wychen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437746Reviewed-by:
-
Dominic Mazzoni authored
This is one more step towards enabling the flag AccessibilityExposeHTMLElementEnabled to include the HTML element in the accessibility tree. Bug: 1063155 Change-Id: I19a1e7e8daba1f2186db3428cfab5c0cc9ee41a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427878 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#811867}
-
David Dorwin authored
Also renames both methods in feedback_registration.h to be more accurate. This is a follow-up to https://crrev.com/c/2315796. Change-Id: I4960a7b1cc076ee00bd22e043e08e44ec476a57c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422155 Commit-Queue: David Dorwin <ddorwin@chromium.org> Auto-Submit: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#811866}
-
Patrick Noland authored
This reverts commit 773b24b9. Reason for revert: Tests are failing on android-arm-official-tests https://ci.chromium.org/p/chrome/builders/ci/android-arm-official-tests/1369 Original change's description: > [Android] Implement tests for SyncErrorCardPreference > > This cl adds render tests for different types of sync errors in > SyncErrorCardPreference. > > Bug: 1107420 > Change-Id: I3ebc308932eadb677310ea041559bb54bbb1765c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353255 > Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Alice Wang <aliceywang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811273} TBR=treib@chromium.org,triploblastic@chromium.org,aliceywang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1107420 Change-Id: Ib86c9353dd3f5389ec7446add5c60b1031f59893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438611Reviewed-by:
-
