- 22 Jun, 2018 40 commits
-
-
David 'Digit' Turner authored
Android App Bundle support requires using recent versions of the bundletool and aapt2 programs, which are not part of the Android SDK copies used by internal and public Chrome checkouts at the moment. Also, these tools are still evolving quickly, and their latest releases are not part of official Android releases yet. To solve this, this CL adds two new directories under third_party/android_build_tools/, in order to store their corresponding files. Note that each tool's binary files are distributed through DEPS as CIPD packages. For reference, bundletool is officially distributed from github (see https://github.com/google/bundletool), and aapt2 from Google Maven. Note that in the latter case, our script at tools/android/roll/android_deps/fetch_all.py cannot be used, because the corresponding .jar file contains Linux-specific binaries (executable and libraries), and our Maven-handling Gradle plugin doesn't know how to deal with these. BUG=845405 R=agrieve@chromium.org,jbudorick@chromium.org,thakis@chromium.org,benmason@chromium.org,chromium-third-party@google.com Change-Id: Id650acb9eb55f361fe18f6aa0995776aee832eec Reviewed-on: https://chromium-review.googlesource.com/1110225Reviewed-by:
Grace Kloba <klobag@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#569577}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 47afd98b. With Chromium commits locally applied on WPT: 3d33f9c5 "Sec-Metadata: Strings are quoted in structured headers." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19953 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure jsbell@chromium.org: external/wpt/resources TBR=robertma No-Export: true Change-Id: I6347c427a57bca1b9f979d8321e783971178e28e Reviewed-on: https://chromium-review.googlesource.com/1111695 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#569576}
-
Vaclav Brozek authored
Forms with only "new password" fields, i.e., fields which should contain previously unknown passwords, are generally not to be filled. A previously unknown password is unlikely to be among those stored with Chrome. However, due to errors in form field classification, it can happen that despite Chrome's conclusion, the form actually contains fields worth filling. This CL makes it possible to fill such fields on-demand. Bug: 854123 Change-Id: I800290c4aabb91fb0fd661d083dc76af02c6895c Reviewed-on: https://chromium-review.googlesource.com/1108209 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#569575}
-
Friedrich Horschig authored
With this CL, a tapped suggestion in the passwords keyboard accessory sheet is filled into the last selected input for field. If that form field is not a password field but the selected credential is, nothing will happen. The autofill_agent has detailed knowledge of the form field and tracks the last selected input field. The password_autofill_agent queries the autofill_agent for that field and fills it with the selected credential. Bug: 811747, 854152 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id8ac5330269bcc8b8326a5e050789260e119d5e8 Reviewed-on: https://chromium-review.googlesource.com/1104338 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#569574}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/120b2e4f2660..7999d926809f git log 120b2e4f2660..7999d926809f --date=short --no-merges --format='%ad %ae %s' 2018-06-22 sergiyb@chromium.org Revert "cpplint: Pull in upstream changes" Created with: gclient setdep -r src/third_party/depot_tools@7999d926809f The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:852898 TBR=agable@chromium.org Change-Id: I86c1fb4b07615d8f4569fb5271a4cc04bed8e8da Reviewed-on: https://chromium-review.googlesource.com/1111696Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569573}
-
François Beaufort authored
This make sures the close icon in the Picture-in-Picture window is centered properly. Screenshot: https://imgur.com/a/3n6fNDW Bug: 836389 Change-Id: Id3418ad003440ab60c28ba748096237b853d2c61 Reviewed-on: https://chromium-review.googlesource.com/1109937Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#569572}
-
jdoerrie authored
This CL changes the title of the autofill section to use sentence case. TBR=hcarmona Bug: 854562 Change-Id: I362f8516bd2854f3f6a65ccf5790b3d1f06456f8 Reviewed-on: https://chromium-review.googlesource.com/1111713Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#569571}
-
Haruka Matsumura authored
RecordInfo.cpp was removed the condition of HeapListHashSet from the list of types that we check the inlineCapacity. Because HeapLishHaseSet has inline capacity. Also, we fixed a test, so stubs.h was removed ConditionalDestructor. Change-Id: I32a950fea200918c8ede8eccfdd3c015e2fa575d Reviewed-on: https://chromium-review.googlesource.com/1111739Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Haruka Matsumura <harukamt@google.com> Cr-Commit-Position: refs/heads/master@{#569570}
-
jdoerrie authored
This change updates the section headers of the passwords and autofill section to reflect the Autofill Home proposal Bug: 854562 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: If582fadf067ad02b1a5642aca8f6f5083497e37e Reviewed-on: https://chromium-review.googlesource.com/1107704 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#569569}
-
Adam Rice authored
value_or() called value() to get the value, but that resulted in executing a redundant CHECK() statement. This is not guaranteed to be optimised out. Also it is annoying when stepping through in a debugger. Access the value directly rather than calling value(). Change-Id: I0037abf32e1fe0417ee8083ca8e4ae67c8446de7 Reviewed-on: https://chromium-review.googlesource.com/1110178Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#569568}
-
Marc Treib authored
Before this CL, StartupController had an explicit setup_in_progress_ flag, which was set and cleared by ProfileSyncService. This was unnecessary, since a) ProfileSyncService itself knows that state anyway (hence no need to forward IsSetupInProgress queries to the StartupController), and b) StartupController only needs it within TryStart, where we can just pass it in. Bug: 854978 Change-Id: Ia5eed20a993de78d1efaacb6709ca680035856fd Reviewed-on: https://chromium-review.googlesource.com/1110226 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#569567}
-
stkhapugin@chromium.org authored
Styles the popup per spec: * removes shadows * makes background match the toolbar background Bug: 821817 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9073e78aa6a83b00ab97d45abf590b01ce90886e Reviewed-on: https://chromium-review.googlesource.com/1108210Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569566}
-
Ulan Degenbaev authored
This changes the guard of lazy mojo channel construction from the one that is based on observer list emptiness to a separate boolean flag. The existing guard is fragile because the observer list can become empty after channel construction. See details in the bug and the test. Bug: 855114 Tbr: fdoray@chromium.org Change-Id: I5585c3ac2aa6425d9401bebd3a6c132199f2e011 Reviewed-on: https://chromium-review.googlesource.com/1110365Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#569565}
-
Aleksei Loshkarev authored
Now we have notifications for all sync service crypto state changes except changes of passphrase type. This CL makes all things the same. Change-Id: Idd9cf978f9bfb6b8a45ac1891b815d42af834890 Reviewed-on: https://chromium-review.googlesource.com/1109968Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Aleksei Loshkarev <lixan@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#569564}
-
Wez authored
These tests previously relied upon QuitCurrent*Deprecated() to terminate RunLoops when the expected conditions arose. Bug: 844016 Change-Id: I290599b94936b2ef253925f6f58b67d017b4603b Reviewed-on: https://chromium-review.googlesource.com/1107242Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#569563}
-
Hitoshi Yoshida authored
Some code (in)directly include generated header files, and this CL adds a dependency edge to clarify it. It needs to be in public_deps in case a dependent target on dom/ is the main target. Bug: 852358 Change-Id: Ie652ba66095a5f3466fad661ec7be0a03b32e05d Reviewed-on: https://chromium-review.googlesource.com/1111491Reviewed-by:
-
Boris Sazonov authored
This CL is a follow-up to https://crrev.com/c/1108214. It starts populating "Sync and Google services" preference screen by adding "Use sync and all services" toggle and two expandable preference sections: "Sync and personalization" and "Non-personalized services". This CL also populates "Non-personalized services" section by adding a bunch of preferences that currently reside in "Privacy" section. Bug: 814728 Change-Id: I7cbc99dc25baf104c006b40bf269cd783c29ee15 Reviewed-on: https://chromium-review.googlesource.com/1110371Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#569561}
-
Alex Clarke authored
Change-Id: Iae9e4222ab27f783b4bf565f87355b3c0559783d Reviewed-on: https://chromium-review.googlesource.com/1111705Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#569560}
-
Jennifer Apacible authored
Change-Id: I01418997ece8abc89d5556df7c2439972ad8e348 Reviewed-on: https://chromium-review.googlesource.com/1108567 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#569559}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1e9dd44a. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19952 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=robertma No-Export: true Change-Id: Ib418ff8736097f1f4a3600ac7d1af2dac66636d7 Reviewed-on: https://chromium-review.googlesource.com/1111689 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Ramin Halavati authored
test_traffic_annotation_auditor.py was limited to less compile targets on Windows to investigate an existing bug. The targets are returned to 'all'. Bug: 844014 Change-Id: I0bb49ddeb1872a60afc6d055370ab825e34bf3ed TBR: dpranke@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1111700Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#569557}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7a5731ed..cd58665a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I64f9eab63263a32abb63e52052c965f06e66083b Reviewed-on: https://chromium-review.googlesource.com/1111688Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569556}
-
Xiaocheng Hu authored
When hit testing a text fragment, current code checks the hit test request against its containing box fragment to decide if the text is visible to hit test request. This gives wrong result when there are culled inlines between the two fragments, for example: <div><span inert>foo</span></div> This patch fixes the issue by using the text fragment itself for the visibility check. Bug: 851075 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2b318260c6a108c091d66b30e46d3d64d5f8a408 Reviewed-on: https://chromium-review.googlesource.com/1110524Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#569555}
-
Mike West authored
So this patch adds quotes. See https://tools.ietf.org/html/draft-ietf-httpbis-header-structure-06#section-3.7 and https://github.com/mikewest/sec-metadata/commit/98f7c1253e8dd8a0e1606c2f443772b0c9d562b4. Bug: 843478 Change-Id: I29dfa3a87e3c65a1b64009e173faa6d0f41b40f4 Reviewed-on: https://chromium-review.googlesource.com/1109819 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#569554}
-
Mohamed Amir Yosef authored
This CL adds anonymous namespace around SingleClientBookmarksSyncTest and TwoClientBookmarksSyncTest. Bug: 516866 Change-Id: I1e13f555bc894a36cb509a71aeb57f079d895112 Reviewed-on: https://chromium-review.googlesource.com/1110127 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch implements |NGAbstractInlineTextBox::CharacterWidths()| as follow-up of the patch[1] introduced stub version. This patch makes following three layout tests to pass: 1. accessibility/inline-text-bidi-bounds-for-range.html 2. accessibility/inline-text-bounds-for-range-br.html 3. accessibility/inline-text-bounds-for-range.html [1] http://crrev.com/c/1104082 [LayoutNG] Adapt accessibility module to LayoutNG; Bug: 774229 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I479b394e810a7a81cb8e46d94a0d7db0b5c3fac3 Reviewed-on: https://chromium-review.googlesource.com/1109797 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Trent Apted authored
Currently video taller than the aspect of the gallery window can have its scrubber controls overlapped by the thumbnail ribbon at the bottom. This just adds a CSS rule to moves the video element away from the top and bottom edges when the ribbon is visible. If the video is "wide" enough, there's no effect. Bug: 850372 Change-Id: I26db28fab80ef5be136692b25c14b704a4a3f7b2 Reviewed-on: https://chromium-review.googlesource.com/1109442Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#569551}
-
Xiaocheng Hu authored
This patch implements the behavior that, when clicking at the end of a line, we set an upstream caret selection to indicate that the the selection is at the end of the first line instead of the beginning of the second line, though they may have the same DOM position. This patch fixes accessibility/selection-affinity.html, whose failure is no longer relevant to Range.getClientRects(). Bug: 811502 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0e2d9a9b93e9371a0fb604a0550a376b6035e09d Reviewed-on: https://chromium-review.googlesource.com/1111466 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Tetsui Ohkubo authored
When date in system tray is clicked, it should show WebUI settings when it's available, and otherwise it should show time dialog. This CL also fixes bug in ClockModel::IsLoggedIn and sets initial values to avoid undefined behavior. TEST=manual BUG=none Change-Id: I64eebe3632e1c02d0633e5191d136d83107f869c Reviewed-on: https://chromium-review.googlesource.com/1111492Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#569549}
-
Tetsui Ohkubo authored
According to UX spec, the width of a feature pod button is 84 dip, instead of 80 dip. The spec says the width is 80dip but the label hover has horizontal insets of -2dip. UX spec: http://shortn/_TCL8k5SzY6 TEST=manual BUG=854590 Change-Id: If024af5b0d79041fdedf1a8fdf696eac718eb875 Reviewed-on: https://chromium-review.googlesource.com/1111481Reviewed-by:
-
Jennifer Apacible authored
This change adds the views::Widget API for setting the aspect ratio and implements it for Linux. Bug: 853276 Change-Id: I9fe4dbc2059c2c7ee3a6d84b55aa29b11a31112c Reviewed-on: https://chromium-review.googlesource.com/1102881 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#569547}
-
Hajime Hoshi authored
The check existed at MediaElementEventQueue, but I lost this when merging this into EventQueueImpl at https://chromium-review.googlesource.com/c/chromium/src/+/1098742 This CL adds this check again. Bug: 854892, 854775 Change-Id: I0f851fbb3514c3ce59622f1accdaaa9743e316a0 Reviewed-on: https://chromium-review.googlesource.com/1109594Reviewed-by:
-
Naoki Fukino authored
Bug: 851844 Test: The new label is manually checked. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I879ea833ab2da5dc5b6293cfbb06e3fa589d408b Reviewed-on: https://chromium-review.googlesource.com/1111494Reviewed-by:
-
Matt Falkenhagen authored
This test is slow because it does a lot of navigations. Bug: 854913 Change-Id: I2b5f984ba4b656af0d735b3c2c14952fdac5867b Reviewed-on: https://chromium-review.googlesource.com/1111493 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#569544}
-
Matt Falkenhagen authored
Enables: external/wpt/workers/semantics/structured-clone/dedicated.html external/wpt/workers/semantics/structured-clone/shared.html The upstream test changed and now these have stable failing results. Bug: 855009 Change-Id: I2f0c6a800668f58ad17eea1871af688fc5dfd781 TBR: tkent Reviewed-on: https://chromium-review.googlesource.com/1111745Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium fba6c32c. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19951 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-ui TBR=robertma No-Export: true Change-Id: I215e740449459cab350a520dd1f9e7c6075fbe6d Reviewed-on: https://chromium-review.googlesource.com/1111650 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This CL increases -j of win10_chromium_x64_rel_ng and linux-chromeos-rel builder, focusing on slow compile builds like below. win10_chromium_x64_rel_ng 5677s https://ci.chromium.org/b/8943086967459344576 4456s https://ci.chromium.org/b/8943127831308898304 4453s https://ci.chromium.org/b/8943098321824561792 4397s https://ci.chromium.org/b/8943061293045421456 linux-chromeos-rel 4966s https://ci.chromium.org/b/8943086967459344528 4742s https://ci.chromium.org/b/8943095152002623936 4273s https://ci.chromium.org/b/8943131794249185872 4182s https://ci.chromium.org/b/8943098321824561744 Bug: 804251 Change-Id: I4eca1267876e472daad8dbecb46a7bae734d1ad9 Reviewed-on: https://chromium-review.googlesource.com/1111487 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#569541}
-
Xiaocheng Hu authored
crrev.com/c/1108509 fixes some hit test behavior, but also reveals a bug that we compute the wrong line height in quirks mode in some cases. Since quirks mode is of low priority for now, this patch converts some quirks mode layout tests to standards mode to unblock crrev.com/c/1108509. Bug: 854840, 851075 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0177d9a395368c5e361d191e1e742732f4fc0c52 Reviewed-on: https://chromium-review.googlesource.com/1111002Reviewed-by:
-
Uzair Jaleel authored
Below change removes gpu_memory_buffer_support.h header inclusion which might have been introduced by mistake. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic27a6699a4e238947df59628b7c15221c552cf5c Reviewed-on: https://chromium-review.googlesource.com/1106057Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#569539}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dccc282b3734..87eefd4f1143 git log dccc282b3734..87eefd4f1143 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 nathanrogers@google.com [fuchsia] Add thread priority to fuchsia importer Created with: gclient setdep -r src/third_party/catapult@87eefd4f1143 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I25853b4e622916109a9ca5799c67ec439ebcdc58 Reviewed-on: https://chromium-review.googlesource.com/1111649Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569538}
-
