- 21 Oct, 2019 40 commits
-
-
Ella Ge authored
Test flaky on Mac and Linux debug bot TBR=masonfreed@chromium.org No-Try: true Bug: 1016457 Change-Id: I7a09aade8fedcc3dd21ab06a2d1af379706e6d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871637Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#707883}
-
Evan Stade authored
This reverts commit f72a8099. Reason for revert: in-flight conflict with 734ea5e7 Original change's description: > WebLayer: add tests for DownloadDelegate > > Credit to sky@ for EventUtils.java (salvaged from > 47bd294d, which got reverted) > > Bug: none > Change-Id: Iadb75c6b9c77185536c753504b6cefa1ba4796de > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866987 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707864} TBR=sky@chromium.org,estade@chromium.org Change-Id: I5d2d6604fb0e2e633ac65109d23da7eb2826e6a1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872746Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#707882}
-
Ian Barkley-Yeung authored
We're responsible for the feedback component, so we should own it. R=jkardatzke@chromium.org Bug: None Change-Id: I37bd77b513032927976a2b58cfd753b5428ad81b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868843 Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Commit-Queue: J Kardatzke <jkardatzke@chromium.org> Cr-Commit-Position: refs/heads/master@{#707881}
-
Nicolás Peña Moreno authored
virtual/layout_ng_experimental/fast/multicol/span/abspos-containing-block-outside-spanner.html can timeout, as shown at https://ci.chromium.org/p/chromium/builders/try/win10_chromium_x64_rel_ng/400058 Bug: 591099 Change-Id: Ib76017bdf7cb0c0157c2b03907a1849bf4e80197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872153Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#707880}
-
Ella Ge authored
Add a new prediction evaluation system to compare a predicted point to a real point that occurred at the same timestamp. The new class PredictionMetricsHandler buffers last predicted and real events received to associate at each predicted point an interpolated real event. The CL introduces 5 new metrics to compare a predicted point to a real point : OverPredictionMetric, UnderPredictionMetric, WrongDirectionMetric, PredictionJitterMetric and VisualJitterMetric. Here is a link to the corresponding design doc: https://docs.google.com/document/d/172-3YZUIRK5OdUilDiUzc06tUObQa3EoMRniaV_queE/edit?usp=sharing The OverPredictionMetric measures the overshoot distance in pixels between a predicted scroll position and the corresponding interpolated real scroll position that occurred at the prediction time. The UnderPredictionMetric measures the undershoot distance in pixels between a predicted scroll position and the corresponding interpolated real scroll position that occurred at the prediction time. The WrongDirectionMetric measures whether the prediction is in the same direction as the real trajectory at the same prediction time. The PredictionJitterMetric measures the Euclidean distance in pixels between two successive variations of scroll deltas which are the difference between a predicted scroll position and its corresponding interpolated real position that occurred at prediction time. The VisualJitterMetric measures the Euclidean distance in pixels between two successive variations of scroll deltas which are the difference between a predicted scroll position and the interpolated real position that occurred at frame time. Bug: 996353 Change-Id: Ia3676bcbf4308b64ccc83bb6b77097c3876b337a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764409Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
-
Xiang Ji authored
Change-Id: Idd3ac9f20e100368603e5d890d5726410e0c4121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869969Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Xiang Ji <jxiang@google.com> Cr-Commit-Position: refs/heads/master@{#707878}
-
Ilia Samsonov authored
Moving this logic to TestEventListener will avoid executing overriding SetUp and TearDown methods. Change-Id: I98f625dc86280c2f2f590a0cac55d46e46a4fa99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804070 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#707877}
-
Sammie Quon authored
This is a reland of fac39a19 Original change's description: > overview: Fixed aspect ratio for overview items in splitview. > > Overview items now match the aspect ratio of the window bounds if they > get snapped. This will happen if splitview is active on either side, or > if the window is getting dragged close enough to an edge. A videos of > before and after this patch is in the bug. > > Follow up: > Make this work for tablet mode with 6 or more windows. In that case > the positioning logic follows a different path. > Match the exact dimensions in the spec, this patch only does rough > clipping. > > Test: added tests, manual > Bug: 1011973 > Change-Id: I3d9d341c54b58d0e86440045ad1408ca3a0fd27d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849175 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707426} Bug: 1011973 Change-Id: I6ff9ce5c4ecebf2a2006abd26821c5c12b82e5e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872453Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#707876}
-
Philip Rogers authored
The heads up display (hud) layer is used to show layer overlay information such as the fps meter and repaint rects. This layer should be excluded from the 3d layers view. This code has not been implemented behind IsInspectorLayer because the hud layer is used for more than just the inspector, such as when --show-paint-rects is used. This has been tested manually by ensuring no extra layer is present. Bug: 1015918 Change-Id: I044ad1c7dc61385bdeb0fae916c7515dbd8aee4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869820Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#707875}
-
Miyoung Shin authored
This CL converts Camera3CallbackOps{Ptr, Request} in media to the new Mojo type, and uses pending_remote<Camera3CallbackOps> in camera3.mojom. Bug: 955171 Change-Id: I2653e925a82b1c3c17d8676f3d0c13e1418676b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862442 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#707874}
-
Matt Menke authored
HTTP auth credentials will need to be separated by NetworkIsolationKey, as otherwise they can be used much like a cross-site cookie. Also rename the method to LookupServerBasicAuthCredentials, as it no longer returns auth credentials for proxies (That change was in an earlier CL). The one consumer of this API (MediaResourceGetterImpl) still needs to be updated to get the right NetworkIsolationKey. Figuring out how to do this may take some work, so this is not done in this CL, though it will need to be resolved before we can enable separating the auth cache by NetworkIsolationKey, at least on Android. Bug: 993806 Change-Id: Ifc3eec8a4cdd2f38112116c0dc9d7e7c5c296566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865406 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#707873}
-
Martin Robinson authored
Orca would like to use this text attribute to detect when text is expressed with a superscript or subscript. This matches the behavior of Firefox's ATK support. Bug: 1014198 Change-Id: I034437426252ca54774e0cef2aca8442eb72f3c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862439 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#707872}
-
Eric Willigers authored
Command id IDC_LOAD_NEW_TAB_PAGE is no longer used. Change-Id: Ia6746b248845863ff3f2f3bf57b60aafc10fbcec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868567 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#707871}
-
Ella Ge authored
Test timeout. TBR=fserb@chromium.org No-Try: true Bug: 1010472 Change-Id: I2ecbe78f2a7e0c97504021e7c8205891d0f7b921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872718Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/61386966b2ad..b74d5548a435 git log 61386966b2ad..b74d5548a435 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 michaelludwig@google.com Track device coordinate space as matrix Created with: gclient setdep -r src/third_party/skia@b74d5548a435 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I8bec8999ed3d1e7170bb16d8dd13029b784cad47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872115Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707869}
-
Mohamed Heikal authored
The check_android_configuration gn arg is only used by the android-binary-size trybot. This cl changes the behavior of the arg to instead of breaking the build to touch a stamp file that will be looked for by the trybot. This allows the trybot to calculate the binary size differences before failing. Bug: 1011227 Change-Id: I5ac888c32e93264b38da707ad86a46b11c6cbb1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854499 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#707868}
-
sczs authored
Records metrics and makes the dispatcher call to display the SaveCard modal. Creates a helper method to record Badge metrics. Bug: 1014652 Change-Id: Ib881bff0b4b17fe201692bbcbee2137ce37aa6c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869380 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#707867}
-
sczs authored
If IsSaveCardInfobarMessagesUIEnabled() is enabled then a InfobarSaveCardCoordinator will be used to create the SaveCard InfoBarIOS object. This will cause SaveCard to be presented using the new Messages UI. Bug: 1014652 Change-Id: Ib3aae8939bf2a8720938dee4484adfbd8cf3c5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869712Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#707866}
-
Will Harris authored
Setting the same key twice is allowed but a different key is still something that should never happen. This permits service such as network process to run in-process and also fixes --single-process mode. BUG=1000799,1016384 Change-Id: I9da8221adc763d1188b64589dafedeee866d585f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872155Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#707865}
-
Evan Stade authored
Credit to sky@ for EventUtils.java (salvaged from 47bd294d, which got reverted) Bug: none Change-Id: Iadb75c6b9c77185536c753504b6cefa1ba4796de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866987Reviewed-by:
-
Ben Pastene authored
R=jbudorick Change-Id: I2d8c84a4dba8f022450c5ac8e6d094667c4e4fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872154 Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#707863}
-
Brandon Wylie authored
Revert "Prepare explore_sites unittests for imminent switching on of the HistoryServiceUsesTaskScheduler experiment." This reverts commit 02be9723. Reason for revert: Broke the build here: https://ci.chromium.org/p/chromium/builders/ci/Android%20x86%20Builder%20(dbg)/42327 Original change's description: > Prepare explore_sites unittests for imminent switching on of the HistoryServiceUsesTaskScheduler experiment. > > The feature will soon be flipped to ENABLED_BY_DEFAULT. This will make HistoryServiceBackend's task runner > dispatch to the ThreadPool instead of a dedicated base::Thread. The tests need to be > prepared to stay functional when that happens. > > This is done as the last mile of the chrome-wide effort to coalesce as much work as possible > to the ThreadPool. > > Bug: 661143 > Change-Id: I7e08e21c212c2852891d30d0db70b946d932dd4d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865595 > Reviewed-by: Justin DeWitt <dewittj@chromium.org> > Commit-Queue: Oliver Li <olivierli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707832} TBR=dewittj@chromium.org,olivierli@chromium.org Change-Id: I0d07815c8e1c7c145c970df7b173e58c660e41ce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 661143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872127Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#707862}
-
Clark DuVall authored
ExecuteScriptTest.testBasicScript was flaking because it seems the page was not completely loaded when the script was run. Changing the wait for navigation code to wait for the navigationComplete and load stop events hopefully will fix this. Change-Id: I91ca7b68b242d36b547072bddef336933d388c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869849Reviewed-by:
-
Fredrik Söderquist authored
Primarily to cast the condition for validating 'values' animations into a slightly more readable form. Also take this opportunity to change certain conditions so that one can see where they are the same - for instance by swapping left and right sides of comparisons, adding extra nesting or negating/applying De-Morgan. Also make To/From/ByValue() private. Bug: 998526 Change-Id: Ia902ad76dad37d0c0cda3de1283583bb4e4c4afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868999 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#707860}
-
Elly Fong-Jones authored
This change removes all the easy cases of this override. Virtually all of these create a single simple type of view (usually a button or a link) and sometimes store it in a member variable; these have all been migrated to anonymous functions when extra customization is needed or direct calls to view constructors when it is not. Bug: 1011446 Change-Id: I26f5c507b6c7650febf30f04c7fe6483a93bdcdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869290Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#707859}
-
Jarryd authored
This change renames Show() and ShowForReal() to ShowIfNotOffTheRecordProfile() and ShowBubble(), respectively. The old function names are a bit confusing to somebody scanning the code, so the renaming will make it easier for a passive reader to understand the functionality in each. Also, this change fixes the return type of Show(), now known as ShowIfNotOffTheRecordProfile(). Nothing was actually listening to the return value of this function, this changes return type to void from bool. Change-Id: If6ad659bd38369a264ac0b2964295b9f540132ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834830Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#707858}
-
Jonathan Wright authored
$ git log 9d3bf3e96..bc1357852 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 jonathan.wright Implement slow IDCT using Arm NEON intrinsics Created with: roll-dep src/third_party/libjpeg_turbo Bug: 922430 Change-Id: I71f446ec2ef5c30ac2074b73d09cff0aa52f5602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872051Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Jonathan Wright <jonathan.wright@arm.com> Cr-Commit-Position: refs/heads/master@{#707857}
-
Kaan Alsan authored
This is a follow up to attaching SnapContainerData to ScrollableArea. Now that ScrollableArea has the snap container data, we don't need the snap coordinator to execute scroll snapping. Moved GetSnapPosition, SnapAtCurrentPosition, SnapForEndPosition, SnapForDirection, SnapForEndAndDirection, and PerformSnapping from SnapCoordinator to ScrollableArea. This revealed a bug in the logic for choosing the ScrollableArea to execute the snapping on; in the case where we are snapping the global root scroller we should be scrolling the RootFrameViewport. Currently, we are only scrolling the RootFrameViewport if the layout box is the layout view. This will be addressed in a follow up CL. Bug: 853295 Change-Id: Icde1a3263c84d0b8b5062d5dbb62d171b6a176ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862703Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Kaan Alsan <alsan@google.com> Cr-Commit-Position: refs/heads/master@{#707856}
-
Vadym Doroshenko authored
Bug: 999871 Change-Id: I7150887216de2fcb0245def70c60ca00bbfe9192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869219 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#707855}
-
edchin authored
There was a bug where the startup logo was not properly sized in the fake launch screen. Forcing layout fixes this issue. Bug: 1014841 Change-Id: Iadfcfb9fb15b01fdca4b7623bdbcc49c42175757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872450Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#707854}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f0a4d95ef687..80bbce361517 git log f0a4d95ef687..80bbce361517 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 lalitm@google.com Merge "trace_processor: change UpdateSetBits and RemoveIf to use new iterators" Created with: gclient setdep -r src/third_party/perfetto@80bbce361517 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I93c6f0953a9ed76bf5bf46a16ab1e32bea4735bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872349Reviewed-by:
-
Charlie Hu authored
Add fields of DocumentPolicy to SecurityContext(Document) and render_frame_host_impl. Rename document_policy in renderer/core to dom_document_policy to avoid name conflict. Implement DocumentPolicy::IsPolicyCompatible Bug: 993790 Change-Id: If3e3965b5d7822abc4bb74079da810dd7885d800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814938 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#707852}
-
Anastasiia Nikolaienko authored
Change-Id: I8b16f6c73bfcba4271c571db36846b8ea43f3e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864685 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#707851}
-
Andrew Grieve authored
Also renames the nested targets to follow current conventions and to ensure that any bot that does still depend on the _apk target will fail because of this. TBR=agrieve # trivial test update Change-Id: Ic958e1e74dd2f9628512369bd5a7ce01dd9c19cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857571 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Yue Ru Sun authored
When the extension sync is disabled, purge all sources whose URL has `chrome-extension` scheme and all events from these sources, from both in-memory recordings as well as compressed reports in the unsent log store. Bug: 948881 Change-Id: I67bc5bd7c4a0b9c9ed02353dddceaf090eb655c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829953 Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Jaeyong Bae authored
This patch does remove generation_popup_was_shown as param on SetGenerationPopupWasShown function. Because it is always true. Bug: 831123 Change-Id: I04004b5c77c62f8ab425866c3e93197b60522ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872073Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#707848}
-
Chris Lu authored
To improve accessibility, the selectAndScrollToVisibleMatch() JavaScript function will now also return a string containing the selected match and words in the nodes before and after the match. This string will then be sent out as a UIAccessibilityAnnouncementNotification. Bug: 979707 Change-Id: I767530460b5d58c8d99bda3feb2fe29c56fb5f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857280 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#707847}
-
Michael Ludwig authored
This updated the two leaf drawing functions, DrawSingleImage and DrawColoredQuad, to take optional RPDQ parameters and apply them to the current SkCanvas. It also cleans up DrawRenderPassQuad to rely on these utility functions instead of drawing everything directly. Bug: 1013735 Change-Id: I1f731b5ad84db708d2d072eee5f012f861bde1bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860298 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#707846}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6efb3466e0f2..1d2ab0dfbb1b git log 6efb3466e0f2..1d2ab0dfbb1b --date=short --no-merges --format='%ad %ae %s' 2019-10-21 mmortensen@google.com Check whether a board builds a version before setting chrome version. Created with: gclient setdep -r src/third_party/chromite@1d2ab0dfbb1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I11c06b3610fa6941fbe386649df37c65713d69fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872113Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/26c6c4a5eb83..4100b733bf4c git log 26c6c4a5eb83..4100b733bf4c --date=short --no-merges --format='%ad %ae %s' 2019-10-21 sugoi@google.com Fix queries with arrays containing other structures Created with: gclient setdep -r src/third_party/swiftshader@4100b733bf4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/142740524 Change-Id: I4ed9d2592c45de088cfe65809743435e4ed38a62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872116Reviewed-by:
-
