- 22 Oct, 2020 40 commits
-
-
Hoch Hochkeppel authored
Adding a class to represent the Windows DataWriterFactory class within tests, as well as basic unit tests to validate the test class behaviors. The class behaves similarly to the Windows equivalent, except it includes gtest validations for expected usage (and does not implement methods that fall outside the expected usage). Bug: 1035527 Change-Id: Icea55a3d5055d77f0b88ab6f71ce34fe9b285a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491121Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#820005}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ib59ad6cb250eff0e46d576e40849528445d294ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493280Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820004}
-
Manas Verma authored
Adding metrics for the offer project that keeps track of how often cards are suggested with linked cashback, and how often those cards are selected. Bug: 1093057 Change-Id: I30aed407683fd378ba077aed23cdad3a7ac48139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473797 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#820003}
-
Yashar Dabiran authored
So far, PaintPreviewRecorderImpl::CapturePaintPreview() has supported captures with rects that start from the top left of the screen. Supporting custom rect inputs would facilitate the capture of only parts of a page. Bug: 1141436 Change-Id: If871d00a833bd951303a16e8ac71d40034269d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490941Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Yashar Dabiran <yashard@chromium.org> Cr-Commit-Position: refs/heads/master@{#820002}
-
Ben Joyce authored
Bug: 1141105 Change-Id: Id80148a1ba2ec4a070bc8b3dbfe2efd8e17a7ca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490874 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#820001}
-
Alex Gough authored
If hardware enforced shadow stacks are supported and enabled we verify that we crash if we attempt to return to an address that is different from the one stored in the shadow stack. Bug: 1131225 Change-Id: I1df1a20b2ac08405f53d232cc18f28885e7f2240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489929Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#820000}
-
Kyle Horimoto authored
A previous CL [1] removed the "Phone Hub notification badge" feature, but accidentally forgot to update the size of the kPhoneHubSubFeatures array. This caused an issue which would accidentally read past the array and cause incorrect FeatureStates to be provided. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2462225 Bug: 1106937 Change-Id: Iabe0d5adceb321f5998989e5ba4524b63f477476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493220 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819999}
-
Jamie Madill authored
This is the final test suite we need to switch to the standalone runner. Instead of re-sharding this test with a new name it's easier to just remove it from the waterfall. We will be moving these tests to the chromium.angle / angle waterfalls. Includes a git cl format change required by presubmit. Bug: angleproject:5124 Bug: 1137628 Change-Id: Ib39e1a92c2d1a3e7d0ca98f51366428092921b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491525Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#819998}
-
John Lee authored
Previously, the a11y test was calling getDeepActiveElement() to get the h1 element to confirm that the landing page was being shown. This is flaky because this is a browser test and the focus is moved to h1 after a afterNextRender call. This CL updates the check to query the element itself instead of trying to grab it using focused state. Fixed: 1141113 Change-Id: I6bcb52ca642a2502eca99d8933341a1d24791987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490982 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#819997}
-
Angus L. M. McLean IV authored
This is to make labels and symbol names more accurate, since both screen shots and screen recordings will be shown in the holding area. Bug: 1140212 Change-Id: Id263fa282e2503520ac874bbbc3c2956f7a2a993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490021 Commit-Queue: Angus McLean <angusmclean@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#819996}
-
Yue Zhang authored
This CL adds the enable_launch_bug_fix field trial and utility method for M87 FastPath. Bug: 1141275 Change-Id: I52d7c744364cb532689f993c1b689025d8e4e9d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491485Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#819995}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603367983-f14ef1ec6eb1e2af5431460b8d6073dd67a6ea14.profdata to chrome-linux-master-1603389584-2bc38f3ea5293ebadf0ddb7fc3a88d54d7569967.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia5fbe9dbfdf755d70cc39836e3c5de4cc0a71cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493020Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819994}
-
Eugene But authored
This will allow to distinguish user feedback sent from Tools Menu vs. SadTab Bug: 1138523 Change-Id: Id84c9d548a4f8b607bc6996a644d66fdeb356626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490392Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#819993}
-
Andrew Xu authored
Enable the menu selection traversal with the tab key. In detail: (1) If a menu item is under selection and its delete button is hidden, after pressing the tab key, the delete button should show. (2) If a menu item's delete button is under pseudo focus, after pressing the tab key, the next selectable menu item after the current one is selected. (3) A menu item view is removed from the root menu asynchronously since the item to be deleted may be accessed by MenuController. Bug: 1134422, 1106847 Change-Id: I71abdbca619266f21543172d670960bea8580049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448674Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c1aeb6318c47..74711eb54218 2020-10-22 brgoddar@microsoft.com Revert "Animations: make the full node text visible when keyboard focused." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1139833 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4adb9a8ed704556969055f3c23ebef4f495eaabc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492570Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/22505a5afe1f..2ce1d927e98a 2020-10-22 cwallez@chromium.org SwapChainVk: handle mismatching size and usage with a blit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I27dd7005300d6a677cf17be28ee191f24eb2694a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491669Reviewed-by:
-
Roberto Carrillo authored
This reverts commit 593a7819. Reason for revert: Suspect this of breaking the build https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-cast/97040? Original change's description: > Revert "Introduce gfx::MaskFilterInfo to define a filter based mask on a layer." > > This reverts commit 41d30701. > > Reason for revert: to investigate crbug.com/1139657. I did run revert and ony saw 0.5~0.9% improvements. I'll revert this first and reland with ctor change. > > Original change's description: > > Introduce gfx::MaskFilterInfo to define a filter based mask on a layer. > > > > This is a preparation to add GradientMask[1] support. > > > > [1] https://docs.google.com/document/d/1AXgfk66ROEr225roqAuPxrqWNsnDh91lHCQJ_cw8RrI/edit# > > > > Bug: 1039003 > > Change-Id: Ib452c83e3408a1cbdcfb743e0a5ce819258f5ff3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459429 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Khushal <khushalsagar@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#817987} > > TBR=sky@chromium.org,dcheng@chromium.org,oshima@chromium.org,khushalsagar@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1039003 > Change-Id: If5c3d49100e0bbb4dcd712b0e158c29536f79d34 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491242 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819954} TBR=sky@chromium.org,dcheng@chromium.org,oshima@chromium.org,khushalsagar@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1039003 Change-Id: I135ae3074fb1e4af6bc44b21fb10910e7f09b5b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493221Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#819989}
-
Ian Struiksma authored
Test PrefillFormAndFill often fails on some Mac versions (10.11, 10.13) This CL attempts to fix by moving CreateTestProfile to before the NavigateUrl step. All other tests have this order, and it could perhaps help with execution without flake Bug: 1141208 Change-Id: I5192b00f4aa0746839b0109bd4552ceffadb10e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491404 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#819988}
-
rbpotter authored
Delete unpack_pak and associated logic, since all users have been migrated to preprocess_grit. CL was reverted due to a breakage from the sheriff reverting a CL it depended on, which has now been relanded (after fixing the cause of the revert). Bug: 1132403 Change-Id: Iffdeccfb763683eb0be40132b6113f3aefd2899d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492178Reviewed-by:
-
Haiyang Pan authored
Also update android-10 AVD to include the fix in crrev.com/c/2486288 Bug: 1137474 Change-Id: I29402c7bd083f97d322cf0db37e272216a332092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490267 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
benjamin joyce <bjoyce@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#819986}
-
Yue Zhang authored
Bug: 1135926 Change-Id: I96b1eee0e4c972c252fedbef01d1e69013d41598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492306Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#819985}
-
kylechar authored
Compositing.CompositorFrameSinkSupport.ShouldSendBeginFrame has expired so remove the histogram. Fixed: 1121212 Change-Id: Ia0145d49c5fe98707d516ade461f72dafb8ce38a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485783 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#819984}
-
Leonard Grey authored
This will be the entry point to show/hide commander from a command or hotkey. The logic is: - If nothing is showing, show the UI attached to the given browser. - If the UI is showing and attached to the given browser, hide the UI. - If the UI is showing on a different browser, hide it and then show it on the given browser. Bug: 1014639 Change-Id: I97dab906694dd1e34095b9bee0077968b9ea51c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454379 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#819983}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c4af5cd3397d..2e5b59565826 2020-10-22 hjd@google.com Merge "ui: Handle additional RPC responses" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie5de95a50f9381ba386eaf30ec6b93981d88eb9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491670Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I8db75b2365576f76442f74e886230a7181953e7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491319Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#819981}
-
Andrey Zaytsev authored
Bug: 1133664, 1015841 Change-Id: I83633ac7da172a5d5230cf91d11d629fb0645616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489860 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#819980}
-
Elly Fong-Jones authored
This change removes CrostiniAppRestartView, replacing it with: * Construction and configuration of a bare View + DialogDelegate pair * A pair of public functions that create and show this dialog This change also adds some unit test coverage for this dialog to ensure that I didn't break it when doing this refactor. This change also fixes a bug in the dialog found by the new tests: the message used for the body was being given a parameter that was never used, which would have caused a crash if it had ever happened in a debug build. Bug: 1075649 Change-Id: Ia29640e1e47bd96c2996eba6c39722c477ff4aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490345 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#819545} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490518 Cr-Commit-Position: refs/heads/master@{#819979}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I5a893ecb7ac4756396d9e5e47799900840207894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492564Reviewed-by:
-
Bence Béky authored
See upstream change at https://quiche.googlesource.com/quiche/+/557dfbcce6630971df1722e6add40c5c1db44144. Also rename ElideSpdyHeaderBlockForNetLog* and SpdyHeaderBlockNetLogParams accordingly. Change-Id: I6980bafe2eaa7a1830dbd59d1b407aee356d9a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491314 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Dianna Hu <diannahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819977}
-
John Delaney authored
What: Adds new output for all newly obsoleted histograms. Why: It can be useful when modifying histogram suffixes to see what histograms are being obsoleted, especially when removing individual prefixes. One motivating case is: https://crrev.com/c/2441189 This change also updates extract_histograms.py to support pulling the obsolete reason of <affected_histogram> tags. Bug: 1133522 Change-Id: I376d7ae54c40609c6784a97dd595419fdeb31d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490923 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#819976}
-
Chris Fredrickson authored
Change-Id: I0168ff4b278c1542600313dc7f3c1d7bed3d580b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492600 Commit-Queue: Chris Fredrickson <cfredric@google.com> Commit-Queue: Asanka Herath <asanka@chromium.org> Auto-Submit: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#819975}
-
Kevin McNee authored
This field is unused. Bug: 482049, 1015882 Change-Id: Iea504c2c9589db5dc3fe63e8970ff77b3ccb117f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490257 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#819974}
-
James Cook authored
This file has to be updated every time a new OS settings section is added, so let OS settings owners review it. Bug: none Change-Id: If3e5c431512c00665081edd823e3b2f64ae69d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492941Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#819973}
-
Henrique Nakashima authored
Instead, refer to Android Activity and ActivityLifecycleDispatcher. Bug: 1123209 Change-Id: Ib073793ec0f78b7c7b1e0fcd9216f2fb9bf9b757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472614Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#819972}
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: I99157fecb5c912d38521bec33946e2e92824895e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485518 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
-
Paul Moy authored
Not all lorgnette scanners have model names which include the manufacturer. Check for the manufacturer at the beginning of the model, and if it does not exist, add the manufacturer to the display name. Bug: b:171478580 Change-Id: Idd0bfdeca538e055c9ef7a7a5ad7e04f4b059bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492545Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#819970}
-
Xiaohui Chen authored
QuickAnswers is a sub-feature from the Assistant team. Bug: None Change-Id: Ia706c1d595d4915fcd22d18bb04545950575fb31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478022 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#819969}
-
Will Harris authored
BUG=1140170 Change-Id: Ia48e945f7b0c16d76daa28a12bf63afd646d2224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485149Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#819968}
-
Mariam Ali authored
This CL adds new color id for Guest Avatar icon and rename the current color ID to be incognito specific. Screenshot: https://screenshot.googleplex.com/33fFdKX72CHeaEm.png Bug: 1105763 Change-Id: Ie2e6c37c7898dbfa11eacc02804f01f3128ca461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489890Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Mariam Ali <alimariam@google.com> Cr-Commit-Position: refs/heads/master@{#819967}
-
Clark DuVall authored
Some meta-data attributes need to be in the base module's manifest to make Play happy when uploading. This moves all the meta-data attributes for consistency. Bug: 1141430, 1126301 Change-Id: I62924da23532739de1ca370be88a5ac69eeeb83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491986 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#819966}
-
