- 29 May, 2020 40 commits
-
-
Sujie Zhu authored
We limit the nickname input maxlength to 25 and valid the nickname input to ensure no digit is used as nickname. Display the error message, and disable save button when the nickname input is invalid. Local build test video (googlers only): https://drive.google.com/file/d/1l2Dck63oktdCus6GS8ywNAXFU7iJ0lxV/view?usp=sharing The follow up CL is to fine-tune the CSS layout (width & margins) once we finalize the UI. Bug: 1082013 Change-Id: I2996c8a388e4dc4d282e3d9f4e769e4e00f60581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217091Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Sujie Zhu <sujiezhu@google.com> Cr-Commit-Position: refs/heads/master@{#773296}
-
Rohit Rao authored
The webkit build invokes the "copypng" command, which is in /usr/bin. BUG=None Change-Id: I3a343f5620531665bc6d0f3f7a73c7e84c290912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220881Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#773295}
-
Nicolás Peña Moreno authored
This CL adds another UKM for EndReason which is similar to the existing one but explicitly calls out when the "End" is due to the page becoming hidden. UKM collection review: https://docs.google.com/document/d/1RvLL-L5vfhRVkwAiDskCStED5cqHNweROyfz62g4WiA/edit?ts=5ecb9da9#heading=h.k5jx6iluw4yt Bug: 1049260 Change-Id: I7a7112b4a71a0a6fc9045387d32ec1b104e76109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211052 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#773294}
-
Thomas Guilbert authored
This test has been flaking consistently on android-pie-arm64-rel and a few other bots. TBR=mlamouri Bug: 1087794 Change-Id: I2655b11bf7b5580d497df0958e3ea9a8564cb9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222184 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#773293}
-
Etienne Bergeron authored
This CL is refactoring RenderText to use in-declaration initializers. This CL has no functional change. R=pkasting@chromium.org Bug: 1025561 Change-Id: Ibd38890d8d9dbaea913ab703187aff1fd8871673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220070 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#773292}
-
Rohit Rao authored
The previous non-block-based API dated back to iOS 3 and is deprecated starting with iOS 13. BUG=1086653 Change-Id: Id53e8f7e3b7938d056a38cc439733722179a3425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220485Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#773291}
-
Jimmy Gong authored
- Will be implemented once a policy is created to gate this capability. Bug: 1087942 Change-Id: I0887004a8ecb237a93feb877e47a79feba9266af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220876 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#773290}
-
Nate Chapin authored
Change-Id: I511771cfc43fca4d12b2f8e9b1239708d8fc8a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211939 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#773289}
-
Elly Fong-Jones authored
Bug: 1076487 Change-Id: I56c86e4097d2309b97ffc614767d53d860d52291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2221425 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773288}
-
Wan-Teh Chang authored
In ColorSpace::ToSkYUVColorSpace(), do not map MatrixID::SMPTE240M to kRec601_SkYUVColorSpace. In ITU-T H.273, the matrix coefficients of SMPTE 240M are KR = 0.212 and KB = 0.087, which are quite different from the matrix coefficients of BT.470 B, G and SMPTE 240M (KR = 0.299 and KB = 0.114). If we just need a close match, then the matrix coefficients of BT.709 (KR = 0.2126 and KB = 0.0722) would be a closer match. Change-Id: I280df566a031437115f4bbb284ea8603cfb5136d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188630Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#773287}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 84-4136.1-1589799722-benchmark-84.0.4147.17-r1 to 84-4142.0-1590399482-benchmark-84.0.4147.27-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Idab805ef26505226c6fb127fe2ffd70516d8c9ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222681 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773286}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/4c32bd0b7d6b..0357eed7de15 2020-05-29 cwallez@chromium.org Revert "Check FP16 support on vulkan backend" 2020-05-29 enga@chromium.org Ensure dynamic buffer offset bindings are sorted in increasing order If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1087896 Tbr: cwallez@google.com Change-Id: I9ffc6ee6e93e7f5439d08cca0f665ca19517e8c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222499Reviewed-by:
-
Sorin Jianu authored
This CL hooks up download progress notifications from the WinHTTP network client up to AppInstall. BUG: 1014590. Change-Id: I18cc3276284a221a93f2d7ca05005eb1bf3dc71d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216035Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#773284}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590739125-6c79d7b2f103e2693202dab38de41a1a724cbc3e.profdata to chrome-win64-master-1590767663-bfa6fb46c573202b6713bcacc5afb7fbf40f8033.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I9f538c6840787dc538579bdae1cb0e1b90868392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2221427Reviewed-by:
-
Regan Hsu authored
* On mousedown, the search input will highlight the entire query text. * When the dropdown is closed, hovering over the search input causes a pointer cursor instead of the text cursor. Video: https://drive.google.com/file/d/1Ytl8MLiZ7Q0JY05Y5421NjvKs7HMaiqf/view Fixed: 1086774 Change-Id: I9d2b9e938d425b78c29b57f515b7b80fd6f56ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219010Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#773282}
-
Maksim Moskvitin authored
Removed functionality is a part of Directory Nigori implementation, which isn't longer used. Bug: 1083924 Change-Id: Iff2c6fcd10f09cb7e9752a2c8c4e829893594fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218126Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#773281}
-
Matt Reynolds authored
On Mac, the physical device ID is the location ID rendered as a string. The location ID is a system-supplied device identifier that describes how the device is connected to the system. HID devices that are exposed by the same physical device have the same location ID. BUG=1011499 Change-Id: I04284c62e22b057f2ccaf256acb03c655043308f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972329Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#773280}
-
Brian Sheedy authored
This reverts commit e191ee0f. Reason for revert: New images approved, tests should now pass. Original change's description: > Disable failing VrBrowserWebInputEditingTest#testFullscreenVideoControls on N+ > > This test started failing recently on Nougat and Oreo > Phone Testers. > > BUG=1087857 > TBR=bsheedy@chromium.org,alcooper@chromium.org > > Change-Id: I4d33d534aafb116d826179e934c9a182a6bc66ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220034 > Reviewed-by: Tim Volodine <timvolodine@chromium.org> > Commit-Queue: Tim Volodine <timvolodine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773174} TBR=timvolodine@chromium.org,bsheedy@chromium.org,alcooper@chromium.org Change-Id: Idf4e2e61edc8ff7db7cbb8c1c4218ed34a9e948d Bug: 1087857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219281 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#773279}
-
spdonghao authored
Bug: 1076139 Change-Id: Ibad8ba93103049fffb9e2ddc5f240c969d1b382a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194178Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#773278}
-
Bo Liu authored
When the fragment is retained but activity is recreated for a configuration change such as rotation, the active web contents loses visibility for a moment, which would not happen if the activity handled the config change. On slow pages that listen to page visibility, this can cause extra work that delays page layout. Avoid this by detecting config change: check for non-zero getChangingConfigurations in onStop, and avoid marking web contents as invisible if it's the case. Bug: 1084500 Change-Id: Id7cedc5a6c8c09735620732bc873d461544d540b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216311Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#773277}
-
Ken Rockot authored
Mojom types marked [Stable] must preserve backward-compatibility over time. This presubmit tool checks for unsafe changes to any such types. Fixed: 1070663 Change-Id: Ie1d3ca30d608dd95e256c782593c9df910512e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219020 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
Matt Menke authored
Users don't generally view this file in a text editor, so we should not pretty print this file, to both speed up loading and reduce our disk footprint. We'll soon be keying Expect-CT data by NetworkIsolationKey, which will also bloat up this file a bit, so let's decrease its size before that happens. Bug: 699461, 969893 Change-Id: I2d6815997dd41e2fcfa98f144c783bdd0f5ef583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220907Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#773275}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/52014ab2d7f2..adf56e58b7f6 2020-05-29 dberris@chromium.org auto-bisect: Do not bisect ignored and recovered anomalies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1087799 Tbr: nuskos@google.com Change-Id: I4283ab14421ad9489dd720ae2e2ec0cb46685add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222495Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia744776883332009893141f5dce40e1542888e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222547Reviewed-by:
-
danakj authored
Now that devtools has removed its uses of it, we don't need to keep this as a synonym for updateAllLifecyclePhasesAndCompositeThen(). This can land after devtools rolls into chromium with: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2208540 R=avi@chromium.org Bug: 952399 Change-Id: I65f7cc4a3356edf7b6b6ee28d50b5c0c8b68b7d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222541Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#773272}
-
Mason Freed authored
Given that the html_background_parser isn't actually threaded, it seems to make more sense to call this "can parse asynchronously". This CL should cause no behavioral changes at all. Bug: 901056 Change-Id: I689ccc3270ecb63781ed0ff92212c21dbb07a569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220628 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#773271}
-
Jeffrey Cohen authored
ComponentCallbacks have been found to be problematic in the past. https://chromium-review.googlesource.com/c/chromium/src/+/1610587 Bug: 1084466 Change-Id: Ia75fec7163bd2e58772c42e50673dddaee48d68b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219168Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#773270}
-
Xiaohan Wang authored
CdmAdapter uses the CDM origin in crash reporting. Currently the origin comes from the render process during CDM creation. This CL adds a new CdmAuxiliaryHelper::GetCdmOrigin() where the implementation is in the browser process that is more secure. This allows us to remove the |security_origin| from various CreateCdm() calls which will be done in the next CL. Bug: 1065264 Change-Id: I8db09de9586f814c4af0a43e62b0e12eb08e1d41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220214 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
-
Xinghui Lu authored
This CL is for refactor only. There is no functional change. Break RealTimeUrlLookupService into RealTimeUrlLookupServiceBase and RealTimeUrlLookupService, so that the enterprise version won't affect the consumer version. RealTimeUrlLookupServiceBase contains backoff logic and cache logic, because these functionalities will be shared with both enterprise and consumer versions. RealTimeUrlLookupServiceBase has three interfaces to be implemented: CanPerformFullURLLookup CanCheckNonMainframeURL StartLookup Another derived class EnterpriseRealTimeUrlLookupService will be added in a future CL. Bug: 1085261 Change-Id: I9445d3161d44e2402482aac9e9624cf8903d10bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204824 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#773268}
-
Clark DuVall authored
WebLayer requires using the window's Context to access resources and not the Activity, since the Activity belongs to the client and doesn't have WebLayer resources. This also doesn't even need the Activity since the DateTimeChooserAndroid constructor takes a Context. Bug: 1087894 Change-Id: I3b007ee938a67b7819f73cc9e8bc13c2dd2b56fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222622Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#773267}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f8091017..7693b668 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7e205216e56fedeea2dd1a82bc616cad8007ae25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220193Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773266}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie024e1e4ecf60605c935402e6aee9dbc9f1b0a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222700Reviewed-by:
-
Thomas Guilbert authored
This reverts commit 5930a9fd. Reason for revert: Likely causing test failures here: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Ozone%20Tester%20%28Headless%29 Original change's description: > ozone/wayland: Fix data objects initialization and ownership > > DataDevice-related wrappers initialization and ownership, for both > standard and GTK's primary selection, are quite confusing and spread > over different parts of the backend code. This CL fixes and simplifies > it by: > > - Moving {WaylandData,GtkPrimarySelection}Device ownership to their > respective DataManager wrapper class. E.g: WaylandDataDeviceManager owns > WaylandDataDevice singleton; > > - Fix WaylandClipboard initialization whether the compositor happens to > advertise GtkPrimarySelectionDeviceManager after wl_seat and > wl_data_device_manager; > > - Use dependency injection to provide DataSources with the correct > DataDevice instance at their construction time; > > - Clean up WaylandConnection by getting rid of the multiple (and almost > unused) data device getters from it as well as removing unneeded header > includes. > > Bug: 896640 > Change-Id: Ie12964fdf4e7b78bbbd9a11e133ab082613f1c7b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216320 > Reviewed-by: Maksim Sisov <msisov@igalia.com> > Commit-Queue: Nick Yamane <nickdiego@igalia.com> > Cr-Commit-Position: refs/heads/master@{#773235} TBR=msisov@igalia.com,nickdiego@igalia.com Change-Id: I74b74bd56c2dcb68bb9c28bba66fdc606b946ad9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220194Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590753475-030a2e24f1ea13d43c4c794e813316525ddd3d28.profdata to chrome-mac-master-1590767663-c9c32cda7f7963eb3f000a0ebfa31cdf13cf0117.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I5c4afff5e88d1f3040b413a2ac53f3cb05d13ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222496Reviewed-by:
-
Alexander Cooper authored
The WebXrPermissionsApi shipped with M83, as such, the feature flag can be removed. In order to remove the feature flag, places that rely on it need to be cleaned up. This change modifies the relevant UI code that used this state to determine whether or not to show the AR/VR permission entries. Since the feature is enabled by default, this logic can be removed and/or defaulted to always appearing. Change-Id: I7b6dd98da184811eaf65d94076549a23800eb82e Bug: 1064384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215455Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
-
adamta authored
Adds a section in the ContentSuggestions collection view which will later be populated by the Discover feed. Bug: 1085419 Change-Id: I36d6c55a4c3041d730d7189cdf2074d6e66ac0ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215302 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#773261}
-
Kyle Horimoto authored
This CL adds an implementation for the ancestor page hierarchy in the SearchResult field (previously, this was set to a dummy value). This CL also removes the function which generated dummy values and associated TODOs. Fixed: 1071700 Change-Id: I6e6fa75eda2dec065297502cfa982bbc1d4c5b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220189Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#773260}
-
Yao Xiao authored
It's a service that is supposed to (as some functions are incomplete) regularly compute the floc id by sim hashing the navigation history and log it to chrome sync. See floc_id_provider_impl.h for the details. Bug: 1062736 Change-Id: Iba855241e02512e627ab9f060f7c1a33b453c353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189646 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#773259}
-
Josh Karlin authored
What: Record the FCP for ad iframes in UMA like we do in UKM already. Why: It's a useful metric for understanding the impact our changes have on ad performance. Bug: 1087602 Change-Id: I00c3b9c39f914127850ed8e7c0df7f4577486735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220610 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Auto-Submit: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#773258}
-
Michael Thiessen authored
This code is very old and unused. Tests that need a Render Process Limit look like the just use @CommandLineFlags.Add(ContentSwitches.RENDER_PROCESS_LIMIT + "=1") Change-Id: Ie5841a0e2d1bdc24d0f382b99c1c1e181ddb066c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222525Reviewed-by:
-
