- 20 May, 2014 40 commits
-
-
sorin@chromium.org authored
This interface consolidates the on-demand functionality and it allows for selective friendship for the callers who are allowed to trigger an on-demand update. BUG=375315 Review URL: https://codereview.chromium.org/292203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271770 0039d316-1c4b-4281-b951-d872f2087c98
-
danakj@chromium.org authored
Move it to be non-virtual methods on SingleThreadProxy and ThreadProxy. LayerTreeHost only needs to call it on the SingleThreadProxy, and make it do that before calling Composite() instead of having Composite() early out. Merge LTH::InitializeOutputSurfaceIfNeeded into LTH::Composite. NOTRY=true R=enne BUG=374287 Review URL: https://codereview.chromium.org/286293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271769 0039d316-1c4b-4281-b951-d872f2087c98
-
mlamouri@chromium.org authored
This replaces OnDisplayBoundsChanged and add a MetricsType parameter so consumers can now which metrics has changed. The current set of MetricsType include bounds, workarea and rotation. BUG=162827 Review URL: https://codereview.chromium.org/259253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271768 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
Add a skeleton build file for content/common that lists the basic deps, and processes the sources. This can keep track of the deps that have been converted and allows easy testing of the .gypi reading. Changes content_common.gypi to separate out the public and private sources. The .gypi combines them both into the 'sources' so current users of this file should not be affected. This allows the GN build to declare the public API. Enhance the gypi-to-gn script to strip conditions and collapse variables to allow the content .gypis to be read in. Adds some simple BUILD.gn files for dependencies of content/common Fix typo in accessibility.gyp that I discovered when writing the GN build. R=jam@chromium.org Review URL: https://codereview.chromium.org/287233002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271767 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271766 0039d316-1c4b-4281-b951-d872f2087c98
-
davidben@chromium.org authored
Add a test to ensure it gets plumbed through correctly. This also rolls third_party/openssl to r270417: ------------------------------------------------------------------------ r269864 | davidben@chromium.org | 2014-05-12 16:21:12 -0400 (Mon, 12 May 2014) | 7 lines Add SSL_get_client_certificate_types. Exposes the certificate_types parameter in a CertificateRequest. BUG=165446 Review URL: https://codereview.chromium.org/254723002 ------------------------------------------------------------------------ r270417 | davidben@chromium.org | 2014-05-14 12:27:52 -0400 (Wed, 14 May 2014) | 10 lines Refactor ssl3_send_client_verify. The original logic was a confusing spaghetti and mixed up initialization for all the different cases together. Tidy it up in preparation for having to adjust this logic later to support asynchronous crypto operations. BUG=none R=agl@chromium.org Review URL: https://codereview.chromium.org//284693002 ------------------------------------------------------------------------ BUG=165446 Review URL: https://codereview.chromium.org/257513008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271765 0039d316-1c4b-4281-b951-d872f2087c98
-
jiayl@chromium.org authored
MediaStreamManager::SendMessageToNativeLog posts a task to the UI thread, which will attach the audio thread to the Android java VM. Unlike chrome created threads, the audio thread is owned by the OS and does not detach itself from the VM on exit, causing a crash. Since the log message is still crucial for diagnosing audio input issues, I'm detaching the VM after SendMessageToNativeLog, instead of removing the call on Android. BUG=365915 Review URL: https://codereview.chromium.org/294803003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271764 0039d316-1c4b-4281-b951-d872f2087c98
-
rlarocque@chromium.org authored
Modifies commit logic to include the model type of items in commit requests. The model type is implicitly specified by the presence of a sub-message in the EntitySpecifics field. Prior to this commit, only bookmarks would populate the sync entities on commit. The special case for bookmarks was introduced recently, in r265587. Unlike the bookmarks case, the non-bookmark items send up only enough specifics to identify the model type. The rest of the specifics are not set. This commit also adds some tests of the bookmark and non-bookmark deletion request behaviors. BUG=365752,373859 Review URL: https://codereview.chromium.org/298503002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271763 0039d316-1c4b-4281-b951-d872f2087c98
-
kpschoedel@chromium.org authored
R=sadrul@chromium.org Review URL: https://codereview.chromium.org/270633012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271762 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
Still a work in progress, but some of the basics are there. BUG=365012 TEST=covered by tests R=ben@chromium.org Review URL: https://codereview.chromium.org/296003003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271761 0039d316-1c4b-4281-b951-d872f2087c98
-
wtc@chromium.org authored
Rename the Net.QuicSession.PublicResetAddressMismatch histogram to Net.QuicSession.PublicResetAddressMismatch2. R=jar@chromium.org,rch@chromium.org BUG=none Review URL: https://codereview.chromium.org/294823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271759 0039d316-1c4b-4281-b951-d872f2087c98
-
spang@chromium.org authored
BUG=none TEST=build Review URL: https://codereview.chromium.org/296033003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271758 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
rather than a raw pointer, because it plays better with the JSON schema compiler generated code. Also add a TwoArguments method, and rename SingleArgument to OneArgument to be consistent with that. BUG=365732 R=rockot@chromium.org Review URL: https://codereview.chromium.org/291453002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271757 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@chromium.org authored
BUG=322664 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271459 Review URL: https://codereview.chromium.org/289003006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271756 0039d316-1c4b-4281-b951-d872f2087c98
-
alokp@chromium.org authored
This will allow us to get rid of two live rasterizers and the rasterizer delegate. BUG=367200 Review URL: https://codereview.chromium.org/290573007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271755 0039d316-1c4b-4281-b951-d872f2087c98
-
rch@chromium.org authored
to use early return. Review URL: https://codereview.chromium.org/291173003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271754 0039d316-1c4b-4281-b951-d872f2087c98
-
bruening@google.com authored
BUG=374410 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/298643004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271753 0039d316-1c4b-4281-b951-d872f2087c98
-
rtenneti@chromium.org authored
https://codereview.chromium.org/288313003/ R=wtc@chromium.org Review URL: https://codereview.chromium.org/292113002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271751 0039d316-1c4b-4281-b951-d872f2087c98
-
rdevlin.cronin@chromium.org authored
Move FileHandlersParser to /extensions. FileHandlersInfo was a struct which only contained a vector of FileHandlers. Instead, typedef a vector of FileHandlers as a FileHandlersInfo. BUG=374980 Review URL: https://codereview.chromium.org/280963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271750 0039d316-1c4b-4281-b951-d872f2087c98
-
rdevlin.cronin@chromium.org authored
Enable the promotion for the Chrome Apps and Extensions Developer Tool in all channels. BUG=365219 Review URL: https://codereview.chromium.org/296503003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271748 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Eliminates "V2" from all origin chip v2 code/names except the field trial flag name (so as not to screw up in-process field trials). Eliminates "hide on" flags and just uses a single "enabled" flag for v2. BUG=none TEST=Only one origin chip flag appears in about:flags. Review URL: https://codereview.chromium.org/287543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271746 0039d316-1c4b-4281-b951-d872f2087c98
-
bruening@google.com authored
Broaden suppression for gpu::gles2::ShaderTranslatorCache::GetTranslator uninit read. Fix name for suppression for uninit read in ToolbarOriginChipView::Update. BUG=374105,375401 TBR=gbillock@chromium.org Review URL: https://codereview.chromium.org/293513004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271745 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271743 0039d316-1c4b-4281-b951-d872f2087c98
-
https://codereview.chromium.org/296483006/fmalita@chromium.org authored
Reason for revert: Official Win build failing: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/24516/steps/compile/logs/stdio Original issue's description: > Skia roll 14765:14795 > > https://code.google.com/p/skia/source/list?num=29&start=14795 > TBR= > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271728 TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/292273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271742 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
TBR=zea@chromium.org BUG=300084 Review URL: https://codereview.chromium.org/290803006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271739 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
static_library build ICEing on some builders on mini_installer. > VS2013 Update 2 > > As discussed in the linked bug, the toolchain2013.py script in > depot_tools is no longer workable (because the update for Update 2 is > supplied as a .msp that must be applied against a system-installed > VS2013). > > As such, the Express hash here is not updated. > > The hash zip referenced here was built as follows: > - Install VS2013 Update 2 on a clean VM > - Copy DIA SDK\, VC\ > - Copy DLLs from VC\redist to sys32\ and sys64\ > - Copy win8sdk unchanged from previous .zip. > - Delete various unused arm\ subdirectories > - Delete the IDE-only Snippets, etc. subdirectories in VC\ > - Patch VC\include\xtree to disable warning 4702 per request in > http://crbug.com/346399 . > > A followup change will be to write a script that does these steps > semi-automatically, hopefully for Express too, though there is the > added complication of the WDK/ATL/MFC hacking required there. In > particular, this script will not be useful for a dev to actually run > as part of runhooks, but will be a bit useful for deployment/ > documentation of the above process. > > In the interim there are no extremely-pressing reasons for Express > users to update to Update2 that I'm aware of, so they get non-Update2 > for now. > > R=iannucci@chromium.org > BUG=372451,346399,371847,339215,350639 > > Review URL: https://codereview.chromium.org/284663003 TBR=scottmg@chromium.org Review URL: https://codereview.chromium.org/297753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271737 0039d316-1c4b-4281-b951-d872f2087c98
-
jln@chromium.org authored
R=mseaborn@chromium.org Review URL: https://codereview.chromium.org/296483005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271736 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=351479 TBR=hans@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/274533004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271732 0039d316-1c4b-4281-b951-d872f2087c98
-
piman@chromium.org authored
- Some bitmaps end up with a NULL getPixels(). Don't try to copy ot of that. - Only try to copy 32-bit bitmaps - Protect against overflow in size computation BUG=369621 Review URL: https://codereview.chromium.org/289573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271730 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271729 0039d316-1c4b-4281-b951-d872f2087c98
-
robertphillips@google.com authored
https://code.google.com/p/skia/source/list?num=29&start=14795 TBR= BUG= Review URL: https://codereview.chromium.org/296483006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271728 0039d316-1c4b-4281-b951-d872f2087c98
-
bruening@google.com authored
BUG=313788 TBR=gbillock@chromium.org Review URL: https://codereview.chromium.org/295983004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271727 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
This disables blink platform since there's an error in that file caught by this new build. TBR=scottmg Review URL: https://codereview.chromium.org/296053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271726 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
[This is take three. I believe that I've now fixed all the static initializers (including both files named debug_utils.cc that were including <iostream>), the packaging failures, and the black border on the app list as pointed out by mgiuca@.] Running chrome with the "--open-ash" parameter will create an ash desktop window. Ash on Linux has some problems, but at least we're now compiling the code into the binary. TODO: The applist isn't positioned correctly, and some details of the system tray aren't correct. BUG=300084, 303862 TBR=sky@chromium.org First Review URL: https://codereview.chromium.org/25108005 Review URL: https://codereview.chromium.org/292443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271725 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
Parameterize webrtc enabling. Add use_seccomp_pbf flag Add a webkit version target Work on ui/base GN build, especially on Windows. This target is a mess (in GYP). This patch tries to make it make a bit more sense while fixing the errors I found. Fix ui/gl target for non-Linux platform. A bunch of X11 stuff was not parameterized. Add unscaled resources target BUG= R=scottmg@chromium.org Review URL: https://codereview.chromium.org/287343006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271724 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
NOTRY=true Review URL: https://codereview.chromium.org/291163007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271723 0039d316-1c4b-4281-b951-d872f2087c98
-
danakj@chromium.org authored
This removes CompositeAndReadback support from the scheduler, since the code path is now removed. R=brianderson BUG=251936 Review URL: https://codereview.chromium.org/292533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271722 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
As discussed in the linked bug, the toolchain2013.py script in depot_tools is no longer workable (because the update for Update 2 is supplied as a .msp that must be applied against a system-installed VS2013). As such, the Express hash here is not updated. The hash zip referenced here was built as follows: - Install VS2013 Update 2 on a clean VM - Copy DIA SDK\, VC\ - Copy DLLs from VC\redist to sys32\ and sys64\ - Copy win8sdk unchanged from previous .zip. - Delete various unused arm\ subdirectories - Delete the IDE-only Snippets, etc. subdirectories in VC\ - Patch VC\include\xtree to disable warning 4702 per request in http://crbug.com/346399 . A followup change will be to write a script that does these steps semi-automatically, hopefully for Express too, though there is the added complication of the WDK/ATL/MFC hacking required there. In particular, this script will not be useful for a dev to actually run as part of runhooks, but will be a bit useful for deployment/ documentation of the above process. In the interim there are no extremely-pressing reasons for Express users to update to Update2 that I'm aware of, so they get non-Update2 for now. R=iannucci@chromium.org BUG=372451,346399,371847,339215,350639 Review URL: https://codereview.chromium.org/284663003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271721 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@chromium.org authored
Rebased version of https://codereview.chromium.org/287083003/ BUG=364604, 351655 TEST=existing tests TBR=sky,zelidrag Review URL: https://codereview.chromium.org/294033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271720 0039d316-1c4b-4281-b951-d872f2087c98
-
teravest@chromium.org authored
This lifts more manifest processing code out of the trusted plugin. Specifically, instead of the trusted plugin receiving a PP_Var with the contents of the manifest and making another method to create the manifest id, the trusted plugin now simply receives the manifest ID directly. BUG=239656 Review URL: https://codereview.chromium.org/287153006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271719 0039d316-1c4b-4281-b951-d872f2087c98
-