- 29 Jan, 2020 40 commits
-
-
Himanshu Jaju authored
Tracks the type of routing used by local device for p2p connection with other device for sharing data. Types are kept consistent with spec defined in https://w3c.github.io/webrtc-pc/#dom-rtcicecandidatetype Bug: 1021984 Change-Id: I5336e3dd50f9fbac0107b32b363d5ab9eeba7ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023495Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#736357}
-
Yuki Shiino authored
Builds the bindings of IDL enumeration generated with the new bindings generator in prod, despite that the bindings is not yet used. This patch makes it available for real use. Bug: 839389 Change-Id: Id5cafd53ab043f75c5244f8fb6a0e134c5ce861d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022124 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#736356}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/71a77c4b3b31..d7fade5738e7 git log 71a77c4b3b31..d7fade5738e7 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 srte@webrtc.org Makes all units and operations constexpr 2020-01-29 lundmark@webrtc.org Fix spelling. 2020-01-29 yvesg@webrtc.org Activate event tracing for unit tests. For good! 2020-01-29 philipel@webrtc.org Don't condition the time_controller target on rtc_include_tests. Created with: gclient setdep -r src/third_party/webrtc@d7fade5738e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I31945048f4505853e64b230e64b611e36e2759ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027575Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736355}
-
Hitoshi Yoshida authored
Without this forward declaration, pointer_event.h and v8_pointer_event.h make a cyclic inclusion. It triggers a compile error in definition of PointerEventInit because we don't have declarations of PointerEvent class. This error happens when we use the new code generator. Bug: 839389 Change-Id: I202d1c15dcc82c5800cc4ab8135784135f280086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026838Reviewed-by:
-
Ovidio Henriquez authored
This change extends the expiration by a year for: * Geolocation.AuthorizationActionExistingUser * Geolocation.AuthorizationActionNewUser * Geolocation.LocationUpdate.ErrorCode Bug: 1036861 Change-Id: I1098db07f38811886e2c2b39486fd6c5f4f73b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025580 Auto-Submit: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c57d8970ed0e..2ee95beaf33d Created with: gclient setdep -r src-internal@2ee95beaf33d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1025781 Tbr: jbudorick@google.com Change-Id: I5d2a44015a36144603a59d107986cbd4bbec7231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027574Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736352}
-
Avi Drissman authored
This conditional is true if Chromium is being built with the macOS 10.11 SDK or newer. This has been true for years. Bug: 1044838 Change-Id: Ia504b0a1b6270d31d445f2c1507716ab514cc160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025948 Commit-Queue: Primiano Tucci <primiano@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#736351}
-
Dominique Fauteux-Chapleau authored
See crrev.com/c/2025578 for test failure. The issue was that file_info_ was read by tests without being initialized. Change-Id: I2c7839fc5d1aa59f07ce1a46a5ca562c6dc86da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024497 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#736350}
-
Omer Katz authored
Bug: 986235 Change-Id: I8da55cf301177df96387e2b2aadf10f67f00ef5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027415 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#736349}
-
James Cook authored
I added SyncManualStartChromeOS so I could work on the OS sync consent dialog before we had a browser sync opt-in flow. We now have a prototype browser sync opt-in flow, so this isn't needed any more. SplitSettingsSync now disables auto-start, aligning Chrome OS with the behavior of Win/Mac/Linux/Android. Bug: 1013466, 1023854 Test: existing sync_integration_tests Change-Id: I52f8048d30c53d0e3431bc5159c752edfa9f25fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025976 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#736348}
-
Omer Katz authored
Bug: 986235 Change-Id: I896bf036203bfe7ba7d646b48cd4ee5b1018f753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026973Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/376e6d205326..1e5630eb3b47 git log 376e6d205326..1e5630eb3b47 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 lalitm@google.com tp: fix sqlite init failure in Chromium 2020-01-29 lalitm@google.com Merge "tp: refactor TypedColumn to increase code reuse and documentation" 2020-01-29 fmayer@google.com Merge "Add stat for client disconnection." 2020-01-29 eseckler@google.com Merge "trace_processor: Add cache to ClockTracker" 2020-01-28 fmayer@google.com Set stat if allocations at a callstack go backwards. 2020-01-28 eseckler@google.com Merge "processor: Export instant events on global/process tracks correctly" 2020-01-28 fmayer@google.com Merge "Handle array types for deobfuscation." 2020-01-28 fmayer@google.com Fix typo in diff_test_trace_processor. 2020-01-28 primiano@google.com Merge "Client API: use only system backend in the android tree" 2020-01-28 lalitm@google.com Merge "tp: fix bad performance when iterating on small out range" 2020-01-28 fmayer@google.com style: add { } around multi-line statement in if. 2020-01-28 lalitm@google.com Merge "tp: always try and scan out where possible" 2020-01-28 fmayer@google.com Merge "Fix alloc_space for continuous dump." 2020-01-28 fmayer@google.com Work around double-closing memfd. 2020-01-28 primiano@google.com Merge "Fix standalone build after clang rolls" 2020-01-28 oysteine@google.com Merge "Ensure sqlite3_initialize is only called once" 2020-01-27 rsavitski@google.com install-build-deps: update clang SHA Created with: gclient setdep -r src/third_party/perfetto@1e5630eb3b47 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:148396772,chromium:148437092 Tbr: perfetto-bugs@google.com Change-Id: I93772c2b2132106ca79083a92f2527dfce609e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027573Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3d23fc123c37..dc49b0ca9816 git log 3d23fc123c37..dc49b0ca9816 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 kjlubick@google.com [canvaskit] Fix support for fonts with CFF Created with: gclient setdep -r src/third_party/skia@dc49b0ca9816 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I0b90cbe3610ed9bd0d975a3b9b5d5725d22e71d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027572Reviewed-by:
-
Arthur Hemery authored
This CL lands the Cross-Origin-Opener-Policy "changes to navigation", as per: https://gist.github.com/annevk/6f2dd8c79c77123f39797f6bdac43f3e In practice, it forces a BrowsingInstance switch when we have a COOP mismatch. This is necessary but not sufficient, as we want to ensure the following behavior: (1) window.open() returned WindowProxy is closed when we know that we need to switch. (2) opener is null in opened popups. (3) window.name is empty in opened popups. This CL solves (2). Currently (1) is untested and will follow in a different patch (tests under development by pmeuleman@ at https://github.com/web-platform-tests/wpt/pull/21161) and (2) needs to be updated with some other state in DidCommit. Bug: 922191 Change-Id: I7d5169f7d53bfc28ea01a1a03c7658e0645bc492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985013 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#736344}
-
Egor Pasko authored
ServiceWorkerScriptCachedMetadataHandler::ClearCachedMetadata is probably never called with kCacheLocally, expecting no bug to be fixed with this. The implementation will be more consistent with the API declared in the parent class if the CachedMetadata gets freed from memory in this case. The bug below is only relevant because this became apparent while I was looking at the surrounding code, there is no intention to clear CachedMetadata more for SW. Bug: 1045052 Change-Id: Idc2356027ec8ab29c3319d596260d3a7a50577ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019028 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#736343}
-
Nico Weber authored
TBR=hans Bug: none Change-Id: I8349cfb68d3fc58931edc463739ea1c4f0324014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026315Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#736342}
-
Vadym Doroshenko authored
Local NOT_USERNAME prediction is based on a weak signal - that the user ignored the save prompt. So it makes sense to ignore if the server has data. Bug: 959776 Change-Id: If2f186ee47e59b8eef4271c980b6837ffeea6da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023836 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#736341}
-
Mikel Astiz authored
Permanent folders (as determined by SyncerProtoUtil::ShouldMaintainPosition() and tombstones do not require position information. Hence, the function can return early. This avoids DLOG(ERROR) spam for missing originator fields, and should otherwise influence no logic. Change-Id: I0c60facfe469fb5412eb044d87c2cd251d185c8d Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027327 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#736340}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cabeec8b..a086532c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I08859072901a0e2fd479c1ad4d985137a0ab97ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027587Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736339}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b6ff59124ce8..7867592b4950 git log b6ff59124ce8..7867592b4950 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 szuend@chromium.org Introduce more accurate breakpoint decoration waiter for web tests Created with: gclient setdep -r src/third_party/devtools-frontend/src@7867592b4950 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I44f639f621c7e8db91689069bc864e2582d0858f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027571Reviewed-by:
-
vitaliii authored
TBR=rakina@chromium.org Bug:1046440 No-Try: true Change-Id: Ibd8c38ab4521f3efb3bda8ac5901a1295de0da6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027470Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#736337}
-
Gauthier Ambard authored
This also changes the fieldtrial config to continue testing the disabled configuration. Launch bug 1018740 Change-Id: Ia6c878045d76f4a44738dda1e5a28419bd06e494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019445Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#736336}
-
Gauthier Ambard authored
This CL makes sure that the WebContent is taken into account when requesting a page. This allows the WKWebView to know how to react to the JavaScript event. In particular, this changes the navigator.platform property. It adds the corresponding tests. It also adds a new utility to find a string through all the frames of a WebState. Bug: 1031124 Change-Id: I2a794ca2bd8c7878d0676a2a9ec5d4269d68cb18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951010 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5d3173be305d..71a77c4b3b31 git log 5d3173be305d..71a77c4b3b31 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 srte@webrtc.org Adds trial to use correct overhead calculation in pacer. 2020-01-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fa85f826..dd5a54c2 (736081:736224) Created with: gclient setdep -r src/third_party/webrtc@71a77c4b3b31 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I955b906783256d7aafaab16cc457a403c199dbdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027569Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4f16d6218d1d..c57d8970ed0e Created with: gclient setdep -r src-internal@c57d8970ed0e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040143,chromium:596488 Tbr: jbudorick@google.com Change-Id: I8c2c4b7f33129fd5a04d75d2a0001449c1cd6ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027568Reviewed-by:
-
Wez authored
These tests were mistakenly disabled only on Linux, but are actually flaky on Windows, Fuchsia and Linux/TSAN bots. TBR=ccameron Bug: 1044841 Change-Id: I4b9119199860c564a495a8465f7d519e1ba821f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027455Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#736332}
-
sreejakshetty@chromium.org authored
Record the number of reloads after a history navigation and number of history navigations for all sites in the scope of the back-forward cache experiment. Add kRecordBackForwardCacheMetricsWithoutEnabling to control the allowed urls when the back-forward cache feature is disabled. Bug: 1035392 Change-Id: I4d4e9496f3142a4b7c1286e877551f1ed631e218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973817 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Jan Scheffler authored
This cl adds a test to prevent regression on crbug.com/1040080. Bug: chromium:1040080 Change-Id: I3611507c042c296e3923434b6ddc269ab63f98da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992425Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#736330}
-
arthursonzogni authored
This patch serves a dual purpose: 1) Fix use after garbage-collected. ----------------------------------- The conservative GC runs when we are under memory pressure, and a GC cannot wait until we go back to an event loop. In this case, the GC scans the native stack and treats the pointers discovered via the native stacks as part of the root set. (That's why raw pointers are used instead of handles on the native stack.) The patch: https://chromium-review.googlesource.com/c/chromium/src/+/1789389 is using a base::Optional<ContentSecurityPolicy*> on the stack with ContentSecurityPolicy* pointing to a GC object. Because of some compiler optimization, the native stack scanner is not able to find the pointer on the stack. Maybe it is stored in a register? Who knows what the compiler might try ¯\_(ツ)_/¯ This is an issue that should be investigated separately. This is fixed by not using base::Optional. 2) Simplify code, make it understandable. ----------------------------------------- A base::Optional<T*> is nullable twice. Once as an optional, once as a pointer. This is generally a bad practise. It would be better to add several boolean with explicit names explaining what "null" means. The first null meant => "loading_url_as_empty_document" The second null meant => "document_blocked_by_CSP" It turns out it is possible to compute "loading_url_as_empty_document_" later. So we don't really need a base::Optional here. -- Bug: 1044331, 1037776, 1038772 Change-Id: I9b11bc45333a2caa5a341509027c1196b8d2049e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027548 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Maria Kazinova authored
Primarily to let it keep track of fields that have user input. Done via sharing FieldDataManager between AutoFillAgent and PasswordAutofillAgent. It was done to fix the problem of some user input not being saved when the page was changed at the moment of submission. The saving criteria was changed and interaction with FieldDataManager was added to always check for user typed input instead of less trustworthy criteria (i.e. focusability that can be changed at the moment of submission). Fields that had no user typing are not saved anymore. Some browser tests were amended as well as they were written in a way that didn't imitate user typing and did just a JS injection of the input value, which we don't consider to be user-typed input anymore. Bug: 957444, 1006745 Change-Id: I6052a8e0cd4581fef840adea409dac61547c0f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991623 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#736328}
-
Roman Sorokin authored
Show overlay over the whole screen under the Gaia webview when Gaia shows its own overlay. * Also show overlay for the 3rd-party SAML page. * Hide bottom buttons for the 3rd-party SAML page. * Removed show-buttons-overlay property of the oobe-dialog Also refactored code a bit Bug: 1001281, 1024255, 1033399 Change-Id: Ie1dc2f0f8793a031a6225a81698cdd8401944e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000938 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#736327}
-
Gauthier Ambard authored
This reverts commit e04c9b25. Reason for revert: It was probably failing because of the device being in landscape Original change's description: > [iOS] Disable failing Content Suggestions test > > Disables ContentSuggestionsTestCase/testReloadPage which is failing on > iphone-device. > > TBR=gambard@chromium.org > > Bug: 1046258 > Change-Id: I8688122f2daab124b063059b6187f5fe0a7a6026 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024888 > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735815} TBR=gambard@chromium.org,javierrobles@chromium.org Change-Id: I7508c1b2b3d983c426855b194eb075972625f7f7 Bug: 1046258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027412Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#736326}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/109232bcf479..b6ff59124ce8 git log 109232bcf479..b6ff59124ce8 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 mathias@chromium.org Ensure pseudo-elements are not exposed through $0 etc. 2020-01-29 leese@chromium.org Load scripts from history only once each 2020-01-29 leese@chromium.org Truncate large wasm disassembly Created with: gclient setdep -r src/third_party/devtools-frontend/src@b6ff59124ce8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1003022,chromium:1035843 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I06c8c32ad9eae3b907bba35b97986321454859e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027224Reviewed-by:
-
Michael Ershov authored
Request full update of a WiFi service state also on removing it from a profile. Also fix FakeShillServiceClient to completely delete VPN service config when it asked to do so (instead of keeping some settings that makes sense for more persistent/real services like wifi or ethernet). Bug: 1032067 Change-Id: I19d6d2cd0e09c86e61af8a0151017fd93a545395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963860Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#736324}
-
Sylvain Defresne authored
Mark "Stars.*" histogram as obsolete since they are no longer recorded in the code (except "Stars.LaunchLocation" on Android which will be cleaned up in followup CLs). Bug: 928484 Change-Id: Iefb54af2240e1899ee6b00bf658eef1a0de610b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024887 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#736323}
-
Johannes Kron authored
Bug: chromium:1029737 Change-Id: Ia2800617dd2e6c2dbbbd3c40203cdb79e9bcaed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025109Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#736322}
-
Gauthier Ambard authored
This reverts commit b8760c06. Reason for revert: Hit a DCHECK in -[MainController mainBrowser] when running test (on the second run). Reproduced on iOS 13 iPad running settings_egtest. Original change's description: > Use Browser in CrashRestoreHelper instead of TabModel > > TabModel is provided to the CrashRestoreHelper as a SessionWindowRestore > protocol delegate. and it's used to restore sessions from there. Replace > that with browser and use sessionRestorationBrowserAgent from the > CrashRestoreHelper instead. > Also while at it, i changed the members ivars to use trailing underscore > instead of the leading underscore. > > Bug: 1010164 > Change-Id: I53360ac9a34f7f9e42aacd459e233f40c5def60b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024028 > Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736047} TBR=marq@chromium.org,mrefaat@chromium.org Change-Id: Ie3c6c3517d502d92da7f7154972501ca95f0a355 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1010164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027549Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c768c76138f9..9769628aa1d8 git log c768c76138f9..9769628aa1d8 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 phoglund@google.com Use auto instead of google::protobuf in the histogram C++ API. Created with: gclient setdep -r src/third_party/catapult@9769628aa1d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: skyostil@google.com Change-Id: I613e2878a11b2fdf7b64152200d6f231f4378380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027223Reviewed-by:
-
Alexandre Courbot authored
CreateOutputBuffers() was not checking that it was running in the right thread. Fix this. BUG=None TEST=VDAtest passes on Hana. Change-Id: Ia159b48ec9ca0a0f51049ff1753bdd213722ab29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026837 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#736319}
-
Nico Weber authored
TBR=hans Bug: none Change-Id: Icf7e780f1033e58dab17ae352eb50c9cd47390bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026473Reviewed-by:
-
