- 28 Feb, 2020 28 commits
-
-
Brandon Wylie authored
This version includes a fix for the crash reported in the attached bug. This change also rolled out to finch, but this will still crash if you build locally with an agsa version earlier than 10.98. Bug: 1053930 Change-Id: I57f83aa1861aba7e6bef58be5a969d13d15ac078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071356 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#745279}
-
Steven Bennetts authored
This CL: * Reduces log spam for "Strength" updates for non active networks. * Reduces redundant log spam for "GetShillProperties". * Increases the lines provided for network feedback logs from 400 to 4000. (Currently feedback logs are ~50000 lines or so, so the relative cost is <10% for critical networking information). Bug: 1054951 Change-Id: Ibac865efe8672b9d972a23371e72f79e39127a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068720Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#745278}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a4f9aa037585..fdf027a728e9 git log a4f9aa037585..fdf027a728e9 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 vapier@chromium.org my_activity: add short url for android CLs 2020-02-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-27 sokcevic@google.com Print content of description backup on exit 2020-02-27 ehmaldonado@google.com git-cl: Add tests for git-cl presubmit Created with: gclient setdep -r src/third_party/depot_tools@fdf027a728e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042324,chromium:1056193,chromium:1056309 Tbr: agable@chromium.org Change-Id: I1b66cb222fbb77c5ea7fee609e3793a535971077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079343Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745277}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b194b7a67c8..9c9e8d96fb56 Created with: gclient setdep -r src-internal@9c9e8d96fb56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1056809 Tbr: jbudorick@google.com Change-Id: I1cc1a7d7dce812143ecd01ef5402ea1cd76fd399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079286Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745276}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dbb0a25d1fab..a7dc87893807 git log dbb0a25d1fab..a7dc87893807 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 mtklein@google.com add some more instructions 2020-02-27 jvanverth@google.com Add GrD3DUtil. 2020-02-27 jvanverth@google.com Add DXGI_FORMAT to BackendFormat. 2020-02-27 mtklein@google.com bit_and and gather 2020-02-27 robertphillips@google.com Add a GrSimpleMeshDrawOpHelper CreatePipeline method that doesn't require a GrFlushState 2020-02-27 bsalomon@google.com Reset GrGLGpu::fBoundDrawFramebuffer on resetContext 2020-02-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-27 nifong@google.com Add SK_NO_FONTS check around font uses in skottie Created with: gclient setdep -r src/third_party/skia@a7dc87893807 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I9600e205af7cfade0f3e11f3e5169eef6d9c803e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079350Reviewed-by:
-
Lei Zhang authored
As is, touching web_ui.h results in ~4000 targets getting rebuilt. Forward declare content::WebUI in some headers, or just remove unneeded web_ui.h includes, reduces the number of rebuilt targets to ~850. Change-Id: Ia55aeb559cc16b16f5b872a7262c51cc3522205c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065433Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#745274}
-
Josh Nohle authored
Screenshot at https://storage.cloud.google.com/chromium-translation-screenshots/7fc580944eb5da2b860990438606d22fd6f90311 Fixed: 1008185 Change-Id: Ia00e85fdd1ebd7108dbb152142c8037a484ed4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008410Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#745273}
-
rbpotter authored
fake_input_method_private.js is also used by browser settings tests, so it should not be in the chromeos/ specific folder. Bug: 1026426 Change-Id: I3c88ce63115463dc2966538c6a2536d41d8d71e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076090 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Bettina authored
The experiment is no longer used anymore. Bug: 1054179 Fixes: 1054179 Change-Id: Ie00127cd5327e3313e7684db25797cd14d58ca70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067563Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#745271}
-
Vasiliy Telezhnikov authored
There is few dependencies between features: VizForWebView requires UseSkiaRenderer and UseSkiaForGLReadback. UseSkiaRenderer requires EnableSharedImageForWebview. Previously we enforced dependencies in AwMainDelegate which involves changing of command line arguments and has two problems: 1. Finch experiments are not initialized yet at that moment, so they have to enable four features instead of one. 2. Command line overrides finch trials flags. This CL changes how we check for features to enforce all dependencies. Bug: 805739 Change-Id: I34f823640f355637ea0b27d1dec1b5afc3e9bec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067349Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#745270}
-
Allen Bauer authored
Bug: 648382 Change-Id: I40d0ab4977c7f39893606a0104239cb2408956ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079511 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#745269}
-
Lukasz Anforowicz authored
GetOriginForURLLoaderFactory in render_frame_host_impl.cc calculates the expected origin (or, more precisely, the expected request_initiator_site_lock) for about:blank URLs based on the navigation's initiator (since about:blank frames should inherit their origin from the navigation's initiator). OTOH, before this CL RenderFrameHostManager::DetermineSiteInstanceForURL would ignore |source_instance| if navigating to about:blank was a result of a (webRequest-based) redirect. This meant that |request_initiator_site_lock| disagreed with the origin lock associated with the SiteInstance picked by RenderFrameHostManager, leading to a failed CHECK in the browser process. This CL fixes SiteInstance selection in RenderFrameHostManager by: - Ignoring/removing |was_server_redirect| for about:blank, while preserving the old behavior for data: URLs. - Making sure that error isolation is taken into account (otherwise ChromeNavigationBrowserTest.RedirectErrorPageReloadToAboutBlank would have started failing) - Deduplicating the code that takes error isolation into account (so that |dest_instance| and |source_instance| calculations can reuse the same helper function) This CL adds a regression test that would trigger the CHECK without the RenderFrameHostManager changes in the rest of the CL. The test uses an |opener| page to exercise opener/parent inheritance in Blink (https://crbug.com/585649) even though the regression test would repro https://crbug.com/1026738 even when using just a single page with page_with_two_frames_remote_and_local.html. Bug: 1054579 Change-Id: Icade531b7894627a8d83f8c261b2d34c8cd0b1cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064449 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#745268}
-
Frank Liberato authored
This patch adds support for 8-bit and fp16 RGB textures via KHR streams, since ANGLE almost supports it. 8-bit textures work as-is, but fp16 requires a small patch to ANGLE. However, since fp16 support is off by default in D3D11VideoDecoder anyway, it's okay to land this without ordering with respect to the ANGLE changes. Change-Id: I484760e462341bc6cad699d35f2c9733a7404c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079451Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#745267}
-
Rahul Arakeri authored
This CL turns the "Compositor Threaded Scrollbar Scrolling" on by default in master. The details about this feature can be found in the following links: Design doc: https://docs.google.com/document/d/1JqykSXnCkqwA1E3bUhhIi-IgEvM9HZdKtIu_S4Ncm6o Demo page: https://rahul8805.github.io/DemoPages/BouncyMoon.html Lightning talk: https://www.youtube.com/watch?v=FOCHCuGA_MA&t=1150s input-dev thread: https://groups.google.com/a/chromium.org/forum/#!topic/input-dev/6ACOSDoAik4 Bug: 148501 Change-Id: Iec2e4de5c79e94815629be37c5bbe4ed435e106b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048418Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#745266}
-
Rohit Rao authored
BUG=1024115 Change-Id: I01f1a5f11710a6956cd17ada97b462c250c64d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079391 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#745265}
-
Varun Khaneja authored
1. Notifier::OnStartSlowCheck(), PauseReadingBodyFromNet(), and ResumeReadingBodyFromNet() were added with the assumption that Safe Browsing checks mostly return synchronously (except a tiny percentage) so calling PauseReadingBodyFromNet() in only those few cases was a good precautionary measure. 2. The "precaution" was against overzealous AVs that may warn the user if we cache an unsafe resource; note that the resource is not used until Safe Browsing confirms it is SAFE. 3. On mobile, since connection is usually slower, we did not enable this "precaution". That's a very good indication of how good this "precaution" is :) 4. Now, with SafeBrowsingRealTimeUrlLookup enabled, a larger percentage of navigations are going to hit PauseReadingBodyFromNet(). 5. This would have been fine by itself but due to the special handling of PDFs and some other special types, as described in 1056696#c9, this completely breaks the loading of those types. 6. The "precaution" does not seem worth the breakage. See https://crbug.com/1056696#c9 and https://crbug.com/1056696#c12 for full details. R=xinghuilu Bug: 1054978,1056696 Change-Id: I0f6f48831733996e0ab91a0c0c1ab240a1923c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079338 Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/cd2eb2e2d632..21be4b46c82c git log cd2eb2e2d632..21be4b46c82c --date=short --first-parent --format='%ad %ae %s' 2020-02-27 dschuff@chromium.org Set use_system_xcode GN arg to false on mac Created with: gclient setdep -r src/native_client@21be4b46c82c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1056008 Tbr: mseaborn@chromium.org Change-Id: Icf83007415e00161295761b3730d7b78b90c4c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079285Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4d2040a6f973..78da538aed52 git log 4d2040a6f973..78da538aed52 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 rnk@chromium.org Revert "Vulkan: Disable global merge for volk" 2020-02-27 jmadill@chromium.org Capture/Replay: Capture DrawBuffersEXT. 2020-02-27 jmadill@chromium.org Fix out-of-bounds read in test. 2020-02-27 jonahr@google.com eglGetConfigAttrib validation missing extension check Created with: gclient setdep -r src/third_party/angle@78da538aed52 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1015454 Tbr: geofflang@google.com Change-Id: Ia8d67711c2e59d0511bee0a76c06f00a663fd1f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079347Reviewed-by:
-
liberato@chromium.org authored
We'd like to know "is user watching video" vs "is user scrolling around the page" when recording power. So, we allow any fullscreen-like experience to count, rather than just strictly full-screening the media element. While this is still not exact, it's much closer to what we want. Bug: 1017787 Change-Id: Idb022eb10a9f5e51f0fdef58c3a11ab5e9f40849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070836Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#745261}
-
dpapad authored
This UI is never shown to the user anymore. It was originally deleted at r704421, but that CL was later reverted at r704423. Bug: 991764 Change-Id: I37ba605350522a6d86188f21db2d058beaa0627e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079050 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#745260}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9db20bb3437e..a4b47b52e653 git log 9db20bb3437e..a4b47b52e653 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 fancl@chromium.org Increase sampling from 0.2 to 0.5 Created with: gclient setdep -r src/third_party/catapult@a4b47b52e653 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1052720 Tbr: oysteine@google.com Change-Id: Iedd03c66de6b4d0cd01f9d78c755d41448adf687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079349Reviewed-by:
-
Allen Bauer authored
Bug: 1056761 Change-Id: I0f477c21d315ae707825b43daf8a1cbfb11eb72c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078996 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#745258}
-
Toni Barzic authored
The test was flaky because it was clicking the home button while the hotseat was animating from hidden to extended state. If the mouse events came in the right time, they would be eaten up by the hotseat widget. This means that home button would not change the home launcher state, and the hotseat would remain extended. This should not be an issue any longer: * Today, the default hotseat state with spoken feedback enabled is kExtended, so the hotseat is not animating when test tries to click the home button. * Hotseat widget has since been fixed not to consume events while it's animating. BUG=1020806 Change-Id: I791810ed34eb890b834a93b1a0f26e63d54f3207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079536Reviewed-by:Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Toni Baržić <tbarzic@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#745257}
-
Miguel Casas authored
Intel Display Controller does not support AR30/AB30 framebuffers, but only their opaque XR30/XB30 versions. This CL adds a provision for these formats to |prefer_opaque| when importing a buffer. This CL was split off crrev.com/c/2072621, and is used for supporting high bit-depth framebuffers for HDR composition. Tested with that CL and by playing an HDR video: the primary framebuffer format in /sys/kernel/debug/dri/0//state correctly changes to XB30, whereas when there are not HDR quads in the BufferQueue, it's XR24. Bug: 776093 Change-Id: Iacd0414ea0f0a9dd359796c982ed60d0ee74a737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078655 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#745256}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/729310aa1810..e3e07bf979ea git log 729310aa1810..e3e07bf979ea --date=short --first-parent --format='%ad %ae %s' 2020-02-27 marinaciocea@webrtc.org Introduce frame transformer interfaces for Insertable Streams Web API. 2020-02-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4f8e062e..4ed2234c (744969:745105) Created with: gclient setdep -r src/third_party/webrtc@e3e07bf979ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8beef0caf9307b33b2776aeea6b43c528ac354ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079531Reviewed-by:
-
Josh Simmons authored
is used The CONTEXT_MENU enumeration value was incorrectly being emitted when Quick View was opened via the Selection Menu. The correct SELECTION_MENU enumeration is now emitted. Bug: 1046997 Change-Id: I24f8ec60308c323fbd22dff734e0d07e26c17ecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071163 Commit-Queue: Josh Simmons <simmonsjosh@google.com> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#745254}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2f0b41d4e7f8..0e413afc9bc3 git log 2f0b41d4e7f8..0e413afc9bc3 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 lalitm@google.com Merge "tp: cleanup json and fuchsia trace flags" 2020-02-27 ddrone@google.com Merge "Fill ChromeLatencyInfo args using proto descriptor" Created with: gclient setdep -r src/third_party/perfetto@0e413afc9bc3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I875ef1c35043b369ac0bce8c5dd99768ce313fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079337Reviewed-by:
-
Anand K. Mistry authored
Bug: 634140 Change-Id: I959c0e21765c968910f3d64faa4102fc86d032ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066491Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#745252}
-
- 27 Feb, 2020 12 commits
-
-
Anastasia Helfinstein authored
Previously, there was a bug in Switch Access where the user could set two commands to the same key, leading to ambiguity in expected behavior. This change adds validation, and un-sets any commands previously set to a key. Bug: 1056310 Change-Id: I61569cdcdca13a38923db1d34b0577fc02ec1a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075054 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#745251}
-
rbpotter authored
In Polymer 3/JS modules, there is no settings global namespace and undefined variables cause an error, so the edit dictionary page cannot simply check the global settings.languageSettingsPrivateApiForTest. Instead, use the LanguagesBrowserProxy in the edit dictionary page to get languageSettingsPrivate, and add a way to set this value in the TestLanguagesBrowserProxy so that it can be overridden for tests. Bug: 1026426 Change-Id: I8aa69ac6a3272b74195ca6bb9c1b41ad0b3bdd77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076787 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
tby authored
Note this doesn't affect TopCat. Tested manually, as this behaviour is a bit tricky to isolate from the rest of the launcher search setup. Change-Id: Ifa2f3c7cfdf2c3de39ac48f159dc584762322293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076041Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#745249}
-
Zhaoyang Li authored
This reverts commit 95ba7404. Reason for revert: This change caused ios_showcase_eg2tests_module failures since https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/2803. Original change's description: > [ios] Remove dependency of Showcase on //ios/chrome/app:app_internal > > Showcase should not depend on //ios/chrome/app (except for the hooks). > The dependencies were unnecessary and can be safely removed (after the > removal of one stale #include). > > After this CL, there is no dependency on //ios/chrome/app:app_internal: > > $ gn path out/Debug-iphonesimulator --all \ > //ios/showcase:ios_showcase_egtests \ > //ios/chrome/app:app_internal > No non-data paths found between these two targets. > > Bug: 870935 > Change-Id: I586fe8da7ce2e74dae2cedfd9720044afa97650f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067264 > Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: edchin <edchin@chromium.org> > Reviewed-by: edchin <edchin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744923} TBR=sdefresne@chromium.org,edchin@chromium.org Change-Id: I15a0b32382ac1ff8133b99adb9a317e965a8cf86 Bug: 870935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079148Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#745248}
-
Katie D authored
TBR=pfeldman@chromium.org Bug: 1013003 Change-Id: I2ac37d06ef9cedc90f250509148ddb37bacd2728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079534Reviewed-by:
-
Thomas Lukaszewicz authored
Fixed a bug in ExtraInsetsBorder where the ExtraInsetsBorder was composing the original border but neglecting to set the color in its own Border superclass. This resulted in the border painting correctly but returning the incorrect placeholder color when asked for its color through the Border's API. Added unit test to guard against regression. Bug: None Change-Id: I71613ed468384dc3780e2acb76a43351e96d3bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069498 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for settings Device power page strings from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: Ied133db18f986ab7a78d9d120d5e162403a8a0c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067460 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#745245}
-
Jeff Yoon authored
Bug: 1055330 Change-Id: I5b6adc215b87f4fee4652e22f71d32d5c62d6a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078732Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#745244}
-
Eric Orth authored
In HostResolverManager::RegisterResolveContext(), perform an initial cache "invalidation" (in this case, more of an "initialization") to load the current DnsSession (if there is one) into the ResolveContext. This will allow DoH requests and other transaction operations requiring per-context state to work if the context is created after the last config load or connection change. Bug: 1022059 Change-Id: I6c6eddd9ae992430b5c72f00caf03e9694be56a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068833Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#745243}
-
Aaron Gable authored
These testers are triggered by "Android arm Builder (dbg)". Unfortunately, these testers all have very limited capacity, e.g. only 3 hosts for "KitKat Tablet Tester" (http://shortn/_FgzmFPwSjC). In addition, it is not strictly necessary to run these testers on the branches, as they are not run as part of Branch CQ; only the compiler is mirrored onto CQ as "android_compile_dbg". This CL removes these testers from the branched CI configuration. In order to ensure that they continue to be appropriately triggered on master, it adds a munger which ensures their scheduler tasks have the appropriate names. In order to ensure that their absence doesn't break the branch builders, it adds a generator which creates no-op jobs with the appropriate names. Bug: 1049150 Change-Id: Ie87bfc88580811e357feaaea0aeda9412e001f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076703Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#745242}
-
Sam Maier authored
Bug: 1044330 Change-Id: Iebf1ec10f334cd0ecef416c5e02fa533e01de3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079135 Commit-Queue: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#745241}
-
Michael Thiessen authored
In order to avoid loading the native library really early for use cases like the SearchActivity, which caches a URL and uses it immediately on Activity creation, we can serialze and deserialze GURLs. See https://chromium-review.googlesource.com/c/chromium/src/+/2071376/6/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestion.java#244 for more context. The serialization is quite simple, as GURL is comprised of ints, bools, and a string. Further, if the version changes, instead of having to be backwards/forwards compatible, as long as the GURL is the last token and the delimiter doesn't change, the GURL can simply be re-parsed from the spec at a small startup cost due to having to load the native library early. Bug: 783819 Change-Id: I4ac94c44e8041612d672ad52a92c83247e20c37d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076400Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#745240}
-
