- 24 Jan, 2020 40 commits
-
-
Manu Cornet authored
Some tools are a bit thrown off by this occurrence of a test class that doesn't end in "Test" like all the others. Just making this a bit more consistent. Change-Id: I75885202e804d4d632ca4fe92f5f482e03051c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020402 Auto-Submit: Manu Cornet <manucornet@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735078}
-
Dale Curtis authored
For 1x1 YUV images the sample size will be larger than the height, so upon dividing the integer height by the sample size we get a result of zero chunks for processing. Additionally, since the code wasn't accounting for the last row of odd height frames, it would do nothing on a 1x1 frame. The fix is to ensure we always process an extra row in the last task when we've got an odd height frame. R=thomasanderson Fixed: 1034955 Change-Id: Ic6733ffb31bd2040769d7bc63e9096aea756cbbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016359 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#735077}
-
Weiliang Chen authored
The creation of OverlayProcessorOnGpu is not synchronous, and we might try to use it before the task is run on the gpu thread. Make sure to wait for the creation if we try to use it. R=rjkroege Bug: 1044671 Change-Id: I9c9f02368ab36b3e328a525612f4fbd481e6df97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015345 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#735076}
-
Avi Drissman authored
This changes expectations based on the macOS SDK used to build Chromium. MAC_OS_X_VERSION_10_12 is true if we use at least the macOS 10.12 SDK, which has been the case for years. MAC_OS_VERSION_10_13 is a typo and thus is never defined. Therefore, this always evaluates to true on the Mac. Bug: 1044838 Change-Id: I3a56d37e7ea9d1acb65d6b8e07996de47da37794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020163Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#735075}
-
Andrew Xu authored
This CL is a part of the effort to ensure that the target bounds of the window scaling animation are the shelf icon's final bounds. See https://crrev.com/c/1996268 for more details. This CL fixes the case 2 by accomplishing the following things: (1) Updating the visibility state before starting the window scaling animation. It assures that when the window scaling animation starts, the target hotseat bounds are already set. (2) Locking the shelf auto hide state when the back drop widget updates since the change in back drop widget should not affect the shelf. This CL should be landed after https://crrev.com/c/2004009 which fixes the tests broken by this CL. Bug: 1030819 Change-Id: Iff97f7f1731e7dec6cea36ec99cc3abbee2caa5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004052 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#735074}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/93d8e2cd12d0..53faba1c7d1d git log 93d8e2cd12d0..53faba1c7d1d --date=short --first-parent --format='%ad %ae %s' 2020-01-24 brgoddar@microsoft.com Reland "Add script that checks license headers of JavaScript files" Created with: gclient setdep -r src/third_party/devtools-frontend/src@53faba1c7d1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3a45a577efeb8b138e685d03b5fb50ec922703a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019931Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735073}
-
Dominique Fauteux-Chapleau authored
Following discussion in crrev.com/c/1991710 about using dark mode PNGs, the preferred approach is using color_utils::IsDark() instead of GetNativeTheme()->ShouldUseDarkColors(). Change-Id: I50dceb05c8c902d148827b37914addf4e213c4d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019802 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#735072}
-
yilkal authored
This cl makes sure that the navigation throttle for iframe is created even if the main frame url has been whitelisted. Bug: 1045157 Change-Id: I966a59f3a856e8d34609b013e94d6dd87bc9dc08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018095Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#735071}
-
Joshua Bell authored
A sub-test modifies Object.prototype and leaves the modifications in place longer than needed. In an async test, this can have bad side-effects across tests and interfere with the test harness itself. Modify the sub-test to behave like the others, scoping how long the Object.prototype modifications are left in place. Bug: 1045260 Change-Id: I74c1789f5f804b6f050944e5257d7a9fb3a273e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019928Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#735070}
-
Francois Doray authored
TBR=dvadym@chromium.org R=dvadym@chromium.org Bug: 1045545 Change-Id: Iaa0b63e95748d488dc97b07087c4852e981b5d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019886Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#735069}
-
Allen Bauer authored
Bug: 648382 Change-Id: I0e97983c8a5509e99bb7d33f7dab7e43be74d95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017667 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#735068}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4e98dfeaf092..453926f51ebd git log 4e98dfeaf092..453926f51ebd --date=short --first-parent --format='%ad %ae %s' 2020-01-24 syoussefi@chromium.org Vulkan: Remove inactive shader inputs in the translator 2020-01-24 syoussefi@chromium.org Fix image linking not verifying same format Created with: gclient setdep -r src/third_party/angle@453926f51ebd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: timvp@google.com Change-Id: Ia03f439e790664fc7bd490fb160bc38b62986e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019848Reviewed-by:
-
Francois Doray authored
R=eseckler@chromium.org TBR=eseckler@chromium.org Bug: 1045519, 1041392 Change-Id: Ia4ef9f7d54ad603c8a9f11cd582440c07e2777c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019788 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f368925e49f4..214a08493a82 git log f368925e49f4..214a08493a82 --date=short --first-parent --format='%ad %ae %s' 2020-01-24 taylori@google.com Merge "perfetto-ui: Fix record page" Created with: gclient setdep -r src/third_party/perfetto@214a08493a82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I11165256600ca480c009fe472ca37cd3398a4c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019849Reviewed-by:
-
Joe Downing authored
TBR: vmpstr@chromium.org Bug: 1045521 Change-Id: I81284ed75302d4dd8d144b73b6f3c936100f70c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019332Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#735064}
-
Ana Salazar authored
We have rounded corners on the shelf to clip the ink-drop effect, this causes an additional renderpass. We added an InkDropObserver to listen for the ink drop animation starting and ending and toggle the rounded corners as needed. Bug: 1021772 Change-Id: Icf4aafa6ddb1d917ec8ae07b68fb4063b0b6c995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001745Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#735063}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e37f2ef6bd6e..748ad200897b git log e37f2ef6bd6e..748ad200897b --date=short --first-parent --format='%ad %ae %s' 2020-01-24 capn@google.com Don't override vkQueuePresentKHR() failure codes with VK_SUBOPTIMAL_KHR 2020-01-24 capn@google.com Discern between per-swapchain and vkQueuePresent command results 2020-01-24 amaiorano@google.com Subzero: replace globals with external memory for constant vectors 2020-01-24 amaiorano@google.com SubzeroReactor: implement missing atomic ops Created with: gclient setdep -r src/third_party/swiftshader@748ad200897b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If866dd5f6a6e58c6f0098a6710bbaff90395aa05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019856Reviewed-by:
-
Vladimir Levin authored
This patch adds a UKM metric that tracks two boolean values recorded once per (main frame's) document: - Whether find-in-page happened on that page - Whether a find-in-page activated a render-subtree element. R=chrishtr@chromium.org, schenney@chromium.org Bug: 1044299 Change-Id: I753702069fdad5d3145f7afe822ca638304470b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013744 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#735061}
-
Joe Downing authored
This may have been introduced in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2006485 TBR: lazzzis@google.com Bug: 1045415 Change-Id: I7a12c47f4336daa97c9f7c5a8ff5820443869e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019328Reviewed-by:
-
Fredrik Söderquist authored
Introduce a small helper class TimingUpdate which carries the timing- related state for a (timing) update of the animations. This helper will be extended to handle event dispatch when seeking correctly. Bug: 1039886 Change-Id: I3dbeb64b2cd7ae4d771f80f9232573a0838248df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017333Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#735059}
-
Francois Doray authored
R=beccahughes@chromium.org TBR=beccahughes@chromium.org Bug: 1045500 Change-Id: I19500599b2c459081584dcab9145452e8a9b06d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019384Reviewed-by:
-
Haiyang Pan authored
This reverts commit 16775142. Reason for revert: Quite a few SigninInteractionControllerTestCase tests are failing on https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq and might caused the timeout on swarming task. See https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8890361013331611952/+/steps/ios_chrome_ui_eg2tests_module__iPhone_X_iOS_13.1__shard_1__with_patch__on_Mac-10.14.6/0/stdout Original change's description: > Revert "[ios][eg2] Disable all EG2 tests from SigninInteractionControllerTestCase." > > This reverts commit db9b2ce6. > > Reason for revert: Tests now pass > > Original change's description: > > [ios][eg2] Disable all EG2 tests from SigninInteractionControllerTestCase. > > > > TBR=jlebel@chromium.org > > > > Bug: 1037676,1036840 > > Change-Id: I552d7cec1cab40b5ef9dae9271bb956a625fd71f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981141 > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Commit-Queue: Eugene But <eugenebut@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#727312} > > TBR=eugenebut@chromium.org,jlebel@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1037676, 1036840 > Change-Id: Ie9c4b650360072c3e916e78d122ae331f55f424c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015408 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Jérôme Lebel <jlebel@chromium.org> > Commit-Queue: Eugene But <eugenebut@chromium.org> > Auto-Submit: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734642} TBR=eugenebut@chromium.org,jlebel@chromium.org,jlebel@google.com Change-Id: I61d15f1d257bb9836a4ac7257276abad579adeeb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1037676, 1036840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019936Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#735057}
-
Theresa Wellington authored
BUG=1036471 Change-Id: Ia387b4a5cba67581d8607016ee05df403310c864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017103 Auto-Submit: Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#735056}
-
Jan Wilken Dörrie authored
This change inlines the definition of AssertIteratorsInOrder into the string_piece.h. While the goal of the previous implementation was to avoid #including "base/logging.h", that header has already been included with r353605, thus there should be no regressions when inlining this definition. Having AssertIteratorsInOrder inline also directly supports BasicStringPieces that are not base::StringPiece or base::StringPiece16. Bug: 911896 Change-Id: I9150235dc79687b72f970872af950b0a82e1c0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019442 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#735055}
-
Eugene But authored
It is common for WKWebView to have certificateChain, which does not allow constructing net::X509Certificate. Bug: 1043736 Change-Id: I554fbf7391e1f267ac78d2eaf29f21945542b51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016330Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#735054}
-
Avi Drissman authored
BUG=1044828 Change-Id: Idd5a5f4fed6ca3d7a9bcae0a14b130e4c6ce9022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020182 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Jimmy Gong authored
- Test's previously had repeated code, interactions with private variables, and required an update to use the FakeNetworkConfig to fake connectivity status. - This refactor simplifies the test code and makes it easier to read. Bug: 1015628 Test: browser tests Change-Id: I567688fe6bf5a2b0ea8be463c2bed1c6879bcca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013913 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#735052}
-
Allen Bauer authored
Change-Id: I9c458a7fe05c2ed60c1f9498dd0cea3cc3237455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019923 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Joshua LeVasseur authored
Convert a OnceCallback to a RepeatingCallback. Bug: b/148234741 Change-Id: I32bcf351f2888925fb5c92b6cea0fd7d04b2f11f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019505 Commit-Queue: Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#735050}
-
Joe Downing authored
This test is still flaky after it was previously marked RetryOnFailure but it looks like the expectation wasn't formatted correctly so I suspect that it isn't being applied at runtime. I'm fixing the entry and we can see if the flakiness continues. TBR: zmo@chromium.org Bug: 1045339 Change-Id: I989918b4e518b099de9fcd5ddbbb5912f4c3a022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019471Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#735049}
-
Lukasz Anforowicz authored
Tab contents may get focused during some renderer-initiated navigations (e.g. navigations from an NTP-replacement extension - see the regression test added in r723022). This CL ensures that the focus decision is applied not only to navigations that go through OpenURL, but also to navigations that go through (more freqeuent, usual) BeginNavigation. This change helps ensure that we retain the right focus behavior after more navigations switch to the BeginNavigation code path (e.g. after relanding ShouldFork removal in https://crrev.com/c/1949448). The CL covers both the OpenURL and BeginNavigation code paths by handling the focus decisions in a newly added TabContentFocusingHelper class (replicating/moving the focus decisions from OpenURL-only Browser::UpdateUIForNavigationInTab). Adding a new tab-helper class is useful, because the existing, OpenURL/BeginNavigation-shared navigation notifications handlers (e.g. Browser::ScheduleUIUpdate) cannot distinguish between replaceState and new navigations (see also new steps in the OmniboxFocusInteractiveTest.NtpReplacementExtension test). While this CL changes how focus behavior is implemented, it should have no effect on end-to-end/high-level expectations of focus behavior (as observed by end users or browser tests). browser_tests do not guarantee window activation and/or focus, but before this CL navigation in browser_tests would focus WebContents. This is not happening after this CL, and requires moving a handful of focus-dependent tests from browser_tests to interactive_ui_tests. Bug: 1029161 Change-Id: Ib57c260b2f85f276ff1dad3aabedd59d1d864c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970834 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#735048}
-
Ewann authored
- Apple is hiding UIActivityViewController's contents from the host app on iPad. Screenshot: https://drive.google.com/a/google.com/file/d/1yi2FH2gXPm4WNAg7kRLuzkYkHb5tAJE5/view?usp=sharing Bug: 1044676 Change-Id: Ifc989ba6764fc2232c49333c128b1df953ad05a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019443Reviewed-by:
-
Joe Downing authored
TBR: wychen@chromium.org Bug: 1045417 Change-Id: I7ce691f95b917b451224fd7cb2e311a3122c2dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019473Reviewed-by:
-
Alexei Svitkine authored
I've not had a chance to follow up on this yet and so require more time. Bug: 1034570 Change-Id: I8455841184c0f0a1740b3ac9f1693e07cc7727a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017983Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#735045}
-
Stephan Hartmann authored
dav1d is build with C99 which does not define _GNU_SOURCE by default. However, GNU extensions are used within dav1d, e.g. RTLD_DEFAULT. clang build succeeds, because _GNU_SOURCE is defined globally. Bug: 819294 Change-Id: I1c6e024421c8c8de0b44f0d91dc0b96ef967e712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010760 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#735044}
-
Francois Doray authored
R=keishi@chromium.org TBR=keishi@chromium.org Bug: 1045510 Change-Id: Ic8ff5fb3db4d9aa0fba0c98271ea62ad5c2af4c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020162Reviewed-by:
-
Yilong Li authored
Include device handles (/dev/class/goldfish-*) which are required by Fuchsia Emulator in the sandbox policy. TEST: Run chromium on Fuchsia emulator (with the following patch) https://android-review.googlesource.com/c/device/generic/goldfish-opengl/+/1180701 chromium does not crash. BUG: fuchsia:41834 Change-Id: Ia083909f61fbdf9049bbff4361f92957b84c9606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949635Reviewed-by:Wez <wez@chromium.org> Commit-Queue: Yilong Li <liyl@google.com> Cr-Commit-Position: refs/heads/master@{#735042}
-
Ben Joyce authored
Bug: 1021634 Change-Id: Ide9d5188d36b8ca7eaa4cd890b5b3a4d123966eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018881 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#735041}
-
Dan Beam authored
This is a reland of aaab30e7 CQ_INCLUDE_TRYBOTS=luci.chromium.try:win7-rel Original change's description: > Local NTP: make past search matches change realbox icon to clock > > R=mahmadi@chromium.org > > Fixed: 1043335 > Change-Id: I98b1fbcc0a5b5e0d48334e8eb33a31c66f07a4fe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008614 > Auto-Submit: Dan Beam <dbeam@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Commit-Queue: Dan Beam <dbeam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733854} Change-Id: Ia8665be77fb6cac6da6f3f3fbc33697b2b6bc63c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013813Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#735040}
-
Stefan Zager authored
The throttling check, added in a previous CL for this bug, appears to have fixed some but not all of the crashes. It's not clear how this point in the code could be reached for a detached iframe. Nevertheless, the stack trace for the remaining crashes suggests this might be the case: When a frame becomes detached, it resets its page_ to nullptr; this is the only way that Frame::GetPage() can return nullptr. In EventHandler::HitTestResultAtLocation, if GetPage() returns nullptr, it skips trying to re-dispatch the hit test to the local frame root, and instead just falls through to PerformHitTest on the current frame. If GetPage() is in fact null, we would expect not to see any recursion in HitTestResultAtLocation; and that holds true in all of the recent crash reports. Hence the speculation that we might be trying to hit-test a detached frame. BUG=1041252 R=chrishtr@chromium.org Change-Id: I3bf8482867a26f5f7a0369a0e9015c237744c0e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017933Reviewed-by:
-
