GitLab

R=rvargas@chromium.org
Review URL: http://codereview.chromium.org/7569005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95730 0039d316-1c4b-4281-b951-d872f2087c98

TBR=vrk@chromium.org
Review URL: http://codereview.chromium.org/7541061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95729 0039d316-1c4b-4281-b951-d872f2087c98

This is needed for testing Native Client's support for Breakpad on
x86-64.  However, ultimately crash_service is only used for testing
(Google Update's crash reporter is what is used in an installation of
the official Chrome build).

Initially, crash_service.exe will only work on x86-32 processes, and
crash_service64.exe will only work on x86-64 processes.

Eventually we will want to make crash_service64.exe work for both
32-bit and 64-bit processes.

It might not be possible to make crash_service.exe work on 64-bit
processes because Windows' ReadMemory() function only works on 64-bit
target processes if the caller is a 64-bit process.

BUG=89730
TEST=NaCl's run_inbrowser_trusted_crash_in_startup_test

Review URL: http://codereview.chromium.org/7541057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95728 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95727 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r6323: (mseaborn) sel_universal: Clean up usage of threads a little
r6324: (jvoung) Fix pnacl_coordinator's usage of undefined var_arg behavior (broke on Windows)
r6325: (krasin) service_runtime: remove nacl_bottom_half because it's a dead code.
r6326: (robertm) This will allow us to do proper book-keeping of PPB_Core_AddRefResource and
r6327: (robertm) Make the pepper event loop more versatile, i.e. allow for polling and time limits.
r6328: (krasin) Revert r6325 due to build break (service_runtime: remove nacl_bottom_half because it's a dead code)
r6329: (robertm) Revert 6326 which fails memcheck
r6330: (mseaborn) Cleanup: Remove unused function NaClThreadKill()
r6331: (mseaborn) Cleanup: Remove help string for sel_ldr's '-I' option (which was removed in r6280)
r6332: (thakis) Fix a compiler warning.
r6333: (robertm) Add a few more tests to url_loader and some cleanup
r6334: (robertm) Resubmit of rev6326 after fixing memcheck issue
r6335: (mcgrathr) Parameterize in-tree test links' use of libraries
r6336: (krasin) service_runtime: remove nacl_bottom_half because it's a dead code.
r6337: (jvoung) Update compiletime perf expectations for benchmarks that compile faster
r6338: (mseaborn) Cleanup: Rename ARM's NaClGetSp() to NaClGetStackPtr() for consistency
r6339: (ncbray) Refactored ppapi_bad test to dynamically create the embed tags it uses as it runs.

BUG=none
TEST=trybots


Review URL: http://codereview.chromium.org/7583017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95726 0039d316-1c4b-4281-b951-d872f2087c98

Put common code in hr.shadow class.

BUG=chromium-os:18807
TEST=Top and bottom lines should not be present in gaia signin screen.

Review URL: http://codereview.chromium.org/7569021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95725 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements the proxy necessary for out-of-process video decoding and
introduces a shared base class between the PPB_VideoDecoder_Impl and the proxy.

BUG=NONE
TEST=gles2 plugin runs with or without --ppapi-out-of-process flag, no crashes


Review URL: http://codereview.chromium.org/7545014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95724 0039d316-1c4b-4281-b951-d872f2087c98

When suggest has been disabled, omnibox text is not sent to the default search
engine. Instant's field trial should also be disabled in such a case, to avoid
sending the omnibox text due to Instant.

Note that if the Instant experiment has already been enabled, and *then* the
user disables suggest, this won't disable the experiment immediately (since we
don't listen for changes to prefs::kSuggestEnabled). Instead, it will be
disabled at the next opportunity (some Instant pref changing, browser restart,
etc). I think this is acceptable since, if the user is fiddling with
preferences after Instant has been enabled, they can already click the Instant
checkbox to turn it off.

BUG=91730
TEST=Disable suggest. Verify that the Instant field trial doesn't get enabled.

Review URL: http://codereview.chromium.org/7578014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95723 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91862
TEST=NONE


Review URL: http://codereview.chromium.org/7585012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95722 0039d316-1c4b-4281-b951-d872f2087c98

PrerenderManager::GetAsValue().

NetInternalsTest.NetInternalsPrerenderView expects to always
see the prerender as active or in the history, once started.

BUG=91799
TEST=NetInternalsTest.NetInternalsPrerenderView (Currently flaky)

Review URL: http://codereview.chromium.org/7550031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95721 0039d316-1c4b-4281-b951-d872f2087c98

passwords.PasswordTest.testInfoBarDisappearByNavigatingPage

BUG=91887
Test=Run above

Review URL: http://codereview.chromium.org/7583020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95720 0039d316-1c4b-4281-b951-d872f2087c98

The API is very simple at this point but works end-to-end.

BUG=None
TEST=VideoCapture sample (in a later CL)


Review URL: http://codereview.chromium.org/7553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95719 0039d316-1c4b-4281-b951-d872f2087c98

- Modified enterprise_helper_linux script to handle changing file permissions for multiple json files.

BUG=NONE

Review URL: http://codereview.chromium.org/7453062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95718 0039d316-1c4b-4281-b951-d872f2087c98

Change crash_service.exe so that the named pipe it listens on
(normally global) and the directory it writes to (normally per-user)
can both be overridden via command line options.

Similarly, add an environment variable to Chromium for connecting to
crash_service.exe via a non-default named pipe.

This will allow automated tests of Chromium's Breakpad crash reporting
to be more robust.  A test runner can use a temp dir for crashes and a
temporary named pipe, so that it does not have to worry about
pre-existing instances of crash_service.exe or pre-existing dump
files.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2006
TEST=inbrowser_crash_test in the NaCl tree, with the change http://codereview.chromium.org/7569002

Review URL: http://codereview.chromium.org/7538036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95714 0039d316-1c4b-4281-b951-d872f2087c98

Adds suppressions for leaks related to HTMLMediaElement.  Seems to have been introduced in r95685.

BUG=91896
TEST=HeapCheck bot turns green.
TBR=scottfr@chromium.org

Review URL: http://codereview.chromium.org/7491075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95713 0039d316-1c4b-4281-b951-d872f2087c98

BUG=72317
TEST=None

R=tony@chromium.org

Review URL: http://codereview.chromium.org/7491072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95711 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7511005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95710 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7569003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95709 0039d316-1c4b-4281-b951-d872f2087c98

This matches the behavior of NSPopover.

This is done by overriding the SPI _sharesParentKeyState, which works on 10.7 but
not on 10.6. If we want to get this right on 10.6, we could use the SPI described
in http://code.google.com/p/chromium/issues/detail?id=44087#c42 , but since we
didn't feel we need this until now, we can probably live with this being 10.7-only.

I do need this functionality for the history-swipe-overlay.

BUG=none
TEST=Click e.g. bookmark star. Bookmark bubble should appear, browser window close
button should still look active.


Review URL: http://codereview.chromium.org/7585013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95708 0039d316-1c4b-4281-b951-d872f2087c98

extensions.ExtensionsTest.testSetExtensionStates

BUG=91764
TEST=Run above Tests

Review URL: http://codereview.chromium.org/7572045

TBR=pucchakayala@chromium.org
Review URL: http://codereview.chromium.org/7550054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95707 0039d316-1c4b-4281-b951-d872f2087c98

Suppresses leak reports on Mac Valgrind.

BUG=91892
TEST=Valgrind Mac bot turns green.
TBR=rsesek@chromium.org

Review URL: http://codereview.chromium.org/7569026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95706 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7570001

TBR=varunjain@chromium.org
Review URL: http://codereview.chromium.org/7584021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95705 0039d316-1c4b-4281-b951-d872f2087c98

BUG=48119,84507
TEST=*Extension*


Review URL: http://codereview.chromium.org/7508029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95704 0039d316-1c4b-4281-b951-d872f2087c98

extensions.ExtensionsTest.testSetExtensionStates

BUG=91764
TEST=Run above Tests

Review URL: http://codereview.chromium.org/7572045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95703 0039d316-1c4b-4281-b951-d872f2087c98

I want to change a function prototype and I'm scared of getting
it wrong in a subclass.

Review URL: http://codereview.chromium.org/7569022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95702 0039d316-1c4b-4281-b951-d872f2087c98

TEST=build with touchui=1, drag selection handles.
Review URL: http://codereview.chromium.org/7569024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95701 0039d316-1c4b-4281-b951-d872f2087c98

Suppresses memory access violations on GPU Valgrind Mac.

BUG=91889
TEST=Valgrind bots turn green on Mac.
TBR=thakis@chromium.org

Review URL: http://codereview.chromium.org/7582023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95699 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7570001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95698 0039d316-1c4b-4281-b951-d872f2087c98

P2PSocketClient may DCHECK in Close() if Close() is called immediately after Init() because delegate_message_loop_ is initialized on the IPC thread. Initialize it in the constructor instead.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/7584011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95697 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91835
TEST=Close the window at various points and check that you are prompted (or not) according to whether or not there is a connection pending or in progress.

Review URL: http://codereview.chromium.org/7583018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95696 0039d316-1c4b-4281-b951-d872f2087c98

BUG=77730
TEST=browse to chrome://settings/languages, click on a language and verify no outline on whole list
R=estade@chromium.org


Review URL: http://codereview.chromium.org/7460013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95695 0039d316-1c4b-4281-b951-d872f2087c98

- RequestFocus in LoadURL so that WebUILoginView is focused after window creation;
- Override TabContentsDelegate::TakeFocus and forward the focus back to web contents; This gets rid of the mysterious tab stop;

BUG=chromium-os:18466
TEST=Verify fix for chromium-os:18466.

Review URL: http://codereview.chromium.org/7506004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95694 0039d316-1c4b-4281-b951-d872f2087c98

We now ensure cached passphrases are always used. In addition, encryption now
happens after configuration, allowing us to make use of the
pending_encrypted_types to know if we're waiting for encryption (which
affects how we prompt for passphrase). This is dependent on sync_setup_flow.cc
always calling EncryptDataTypes before configuring the new datatypes and setting
pending_encrypted_types_ appropriately, which then gets consumed on
SYNC_CONFIGURE_DONE.

BUG=91314
TEST=see bug

Review URL: http://codereview.chromium.org/7551024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95693 0039d316-1c4b-4281-b951-d872f2087c98

TBR=apatrick@chromium.org
BUG=84419
TEST=None

Review URL: http://codereview.chromium.org/7583019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95692 0039d316-1c4b-4281-b951-d872f2087c98

* Check available quota before storing anything
* Inform quota manager of storage updates
* Evict an origin when quota manager requests

BUG=83652
TEST=llvm/Debug/unit_tests --gtest_filter=IndexedDBQuotaClientTest.* && llvm/Debug/browser_tests --gtest_filter=IndexedDBBrowser*

Review URL: http://codereview.chromium.org/7470008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95691 0039d316-1c4b-4281-b951-d872f2087c98

Self-assignment was broken and would lose the reference. I uncovered this when
running a test. It outputted a warning to the console, but we never looked at
it. I made a more explicit test.

This also fixes output exceptions. The OutException helper class detected
whether the existing object had an exception or not incorrectly. This was
exposed when var assignment was fixed.

TEST=included
BUG=none
Review URL: http://codereview.chromium.org/7511026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95690 0039d316-1c4b-4281-b951-d872f2087c98

OptionsPage.showTab could be called with wrong 'this' so remember activeNavTab in parent tab bar instead.

BUG=chromium-os:18662
TEST=Verify fix for chromium-os:18662.

Review URL: http://codereview.chromium.org/7572047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95689 0039d316-1c4b-4281-b951-d872f2087c98

If the current context was ever nil, sending a "restore" message would be a no-op and would likely leave an out-of-scope context as current.

BUG=90140
TEST=repeatedly select items in an open file dialog in column mode; no crash

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95611

Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=95631

Review URL: http://codereview.chromium.org/7572031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95686 0039d316-1c4b-4281-b951-d872f2087c98

Relanding 95542. Reverted due to issue caused by 95496.

BUG=none
TEST=manually

Review URL: http://codereview.chromium.org/7480032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95685 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95684 0039d316-1c4b-4281-b951-d872f2087c98