- 08 Jun, 2020 40 commits
-
-
Jared Saul authored
Bug: 1088600, 1088622, 1088623, 1088631 Change-Id: Ib490c244168de493bd9e50851a6a75f713b3bc7d Fixed: 1088600, 1088622, 1088623, 1088631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229367 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#776209}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iaed491c7994b741e1ca88b938d003d0b5d80988d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236219Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776208}
-
Alexis Savery authored
Add UMA histogram "Platform.StatefulWritesDaily" to track the KiB written to the stateful partition each day. Implementation CL: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2227044 Bug: chromium:1063105 Test: ran validate_format.py Change-Id: Ib7f4f4eb70f6e0cbe6701930220712a45d04a6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225288Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Alexis Savery <asavery@chromium.org> Cr-Commit-Position: refs/heads/master@{#776207}
-
Peter Wen authored
Follow-up to: https://crrev.com/c/2235463 Now that WebRTC is migrated to using invoker.lint_suppressions_file, we no longer have a need for this global build override variable. Also clarify that lint_suppressions_dep is specifically for generating this custom file. Bug: 1082743 Change-Id: Id6fd199aed8ad0007b192f022ccc9c152a058dea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235943 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#776206}
-
Lukasz Anforowicz authored
Fixed: 1092614 Change-Id: I5deb29ce23ec0625e85eac185dbacbeb96b85cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236460 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#776205}
-
Yulun Wu authored
Bug: 1091050 Change-Id: I830c2c3d024a3d3c8030a3083d69d791c90c2d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236225Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Yulun Wu <yulunwu@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#776204}
-
Denis Kuznetsov authored
TBR=rsorokin@chromium.org Bug: 1082670 Change-Id: I52aa684837c8328156505af273e536427c8dba62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236472Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#776203}
-
Tom Anderson authored
This is a reland of d1bd3ffb Original change's description: > Enable Snap package for official builds > > BUG=1055026,1090915 > R=dpranke > CC=goanuj > > Change-Id: I7009f67268fa5d35e9d41fca593248c36f6ef631 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232837 > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776165} TBR=dpranke Bug: 1055026, 1090915 Change-Id: I80fd77b927b9a832b779bdb09b843016a9c3a93f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236069Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#776202}
-
Nektarios Paisios authored
In AXObject, there are a lot of methods that traverse the accessibility tree. However, there is a lot of confusion as to which methods work on unignored nodes, which on ignored nodes that are included in tree, and which on nodes that are totally excluded from the tree. This confusion is the cause behind a bug in AXPosition, whereby the wrong method was called, unignored AXObject::NextInPreOrder(), instead of the ignored version AXObject::NextInTreeObject. This bug was fixed in https://crrev.com/c/2220035/ This patch renames all the tree traversal methods to give them more explicit names. In the process one more bug, having the same cause, was discovered in AXPosition (see ax_Position_test:PreviousPositionAfterARIAHiddenShouldNotSkipARIAHidden). This patch also harmonizes somewhat the method names between Blink and those used on the browser. For example, took the opportunity to introduce UnignoredChildCount() and UnignoredChildAt(index) methods which are especially useful in tests. AX-Relnotes: n/a. Bug: 1082814 R=dmazzoni@chromium.org Change-Id: I6c092dda12406ea7fb0ce9c2ade0410470f28125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205399 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#776201}
-
Xing Liu authored
The prompt status pref for download later dialog is similar to the prompt status used in the download location dialog. The checkbox and the setting UX spec is the same as well. Bug: 1078454 Change-Id: Ibaea0c63782b8fb4e33fc1336c862a015c9d219a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236213Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776200}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1557a1c16778..60bf7bf3310f 2020-06-08 patrick.brosset@microsoft.com DevTools: E2E test covering going from perf to sources 2020-06-08 kahinds@microsoft.com Fix Network request initiator tooltip If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1069404,chromium:1079076 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2a8ebbc4341d761e90145bd8cdf0725304397198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236375Reviewed-by:
-
Siye Liu authored
Some IMEs and Windows OS dictation will either insert zero-length text or delete existing composition text to commit active composition. Therefore, we should allow IMEs to cancel composition by committing zero length text. Bug: 1091069 Change-Id: I99cb213dc2ba1965abfa88ccf6858b89bd7e82df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233234 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#776198}
-
Charlie Hu authored
Previously, unoptimized-images is migrated from feature policy to document policy in https://chromium-review.googlesource.com/c/chromium/src/+/2058702, but there are still expectation files to feature-policy-unoptimized-*. This CL cleans up those obsolete files. Change-Id: I8dd65679f5aacc4a19497903c03beb2834a0d942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229014Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#776197}
-
Toni Barzic authored
BUG=1070236 Change-Id: I9cb48488c536b344c89333e26f89ab5ef54f1de3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220340Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#776196}
-
Tom Anderson authored
Braces are needed around LOGO otherwise bash will look for variables called LOGO_beta and LOGO_dev, which is not the intention. BUG=1055026,1090915 R=dpranke Change-Id: I3462151be1f632f3c2be145d8c1123c9c3886175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236228 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#776195}
-
Eric Orth authored
Bug: 1052919 Change-Id: Ibf34c5dcede327bbbb0ea08ea407014981fb0e4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236274Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#776194}
-
Owen Min authored
All policies on the platform with future_on flag will be ignored by default unless they are whitelisted by EnableExperimentalPolicies. However, this restriction doesn't have to apply to the Dev, Canary and Chromium build because they are used for development and testing anyway. Also whitelist in browser test in case they need to be ran with branded browser. Bug: 1067190 Change-Id: I139208115657f698e9c94921827db686f3ac346c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225289Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#776193}
-
evliu authored
This CL adds a speech recognition client that will be used by the Live Caption feature. This is a temporary implementation using the Open Speech API that will allow testing and experimentation of the Live Caption feature while the Speech On-Device API (SODA) is under development. Once SODA development is completed, the Cloud client will be replaced by the SodaClient. Bug: 1076667 Change-Id: Ia4fd07ab3ec8a6c454a125addca7d55e600a57a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194923 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#776192}
-
Thomas Anderson authored
This reverts commit d1bd3ffb. Reason for revert: beta/unstable snaps are failing to build: https://ci.chromium.org/p/chrome/builders/ci/linux-chrome/10134 Original change's description: > Enable Snap package for official builds > > BUG=1055026,1090915 > R=dpranke > CC=goanuj > > Change-Id: I7009f67268fa5d35e9d41fca593248c36f6ef631 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232837 > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776165} TBR=dpranke@chromium.org,thomasanderson@chromium.org Change-Id: Ibac9621b0bdf085a9a90458c25496cea1813be12 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1055026, 1090915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236227Reviewed-by:
-
Brian Sheedy authored
Suppresses a failure in info_collection_tests on HD 630 machines with the experimental driver caused by NV12 overlay support being reported as SOFTWARE instead of SCALING. TBR=ynovikov@chromium.org Bug: 1079393 Change-Id: I0fbedb7923ade85f98004f8810f90a57ecdacc00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236278Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#776190}
-
Scott Violet authored
This changes the compatibility checks around so that the more recent product gets to decide compat. Both sides are still involved. This means that if we needed to increase the skew we have a more flexible way to do that. For example, currently if we wanted to allow 80 implementation to work with 85 client we have no way to do that (because we aren't shippping updates to 80 anymore). This patch would allow us to change that. BUG=1067704 TEST=none Change-Id: I6dc232d742890839f450b34cfa5cd90d53d98aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235837Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#776189}
-
Kyle Milka authored
Pass in a Callback<Tab> that handles creating all the objects needed to print the provided Tab. Bug: 1022172 Change-Id: I9941ca0d168110bccde7b393007e05f5593dfabb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228109 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#776188}
-
Robbie Gibson authored
Cookies need to be stripped from requests when Cookie Blocking is enabled. This can be done using Apple's Content Blocker framework. Bug: 1087872 Change-Id: Ie65dd27aaeb4edaec601223600280e492798ad04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218043 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#776187}
-
Chris Blume authored
The Renderer4.LockExistingCachedImage* histograms will be expiring soon. These track the cache hit rate for the software decode cache when associated with various tile bins. The Renderer4.SoftwareImageDecodeState* histogram tracks the cache hit rate without the tile bin information. It continues to be useful. The tile bin distinction is no longer useful. This CL marks the Renderer4.LockExistingCachedImage* histograms as obsolete. It also adds me as an owner of the histograms since I plan to be doing a lot of image decoder work. Bug: 1089349 Change-Id: I3d03f703d909cf108cc3f6321fcebdecd5e480e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234550Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#776186}
-
Sean Kau authored
Modify test to use mock time. Add a destructor test. Change from RunUntilIdle to FastForward so that we clear the delayed callbacks. Bug: chromium:1090458 Change-Id: Ifeea919b2249f1c3a0a240c0c1c668798e38421d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225855Reviewed-by:
Piotr Pawliczek <pawliczek@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#776185}
-
Maggie Chen authored
Bug: 1092512 Change-Id: Ie6afbe0d8e9e264ab7e42089b853121126ff17d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236059Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#776184}
-
Min Qin authored
see cl/314848673 Change-Id: I883f7ebb436bae3b5d3020b0e79dbac4abc63b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232999Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/47e79f83dec0..6370cd416c74 2020-06-08 lalitm@google.com Merge "test: run functional benchmarks under sanitizer." 2020-06-08 ilkos@google.com Merge "Add ion_buffer_create/destroy events" 2020-06-08 fmayer@google.com Merge "Drive-by^2: fix potential unaligned read." 2020-06-08 fmayer@google.com Merge "Only show "Download profile" for native." 2020-06-08 fmayer@google.com Merge "drive-by: Make RemoveWhitespace call-by-value." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6df08125a206bb435834fbdba9ae5e17d823a72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236312Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3e1a57b83a52..e9a0cb87f7a3 2020-06-08 yang.gu@intel.com Fix assertion when running tests without suffix on Windows If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Ic610ad012276d47ed99353ccead5440bc10fe050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235920Reviewed-by:
-
Hongbo Song authored
This UKM is for the duration of event handlers processing the input event UKM Privacy Review:https://docs.google.com/document/d/1FV_oiGauBxxLiGqpAfNFYaDCg-0z8Tc2oaYMqqMBdEU/edit?usp=sharing Change-Id: I1396809c982cc49dd9b74d669dc71859b3a7eb9f Bug: 1086233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225879Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Hongbo Song <hbsong@google.com> Cr-Commit-Position: refs/heads/master@{#776180}
-
Xing Liu authored
This CL exposes the download later feature flag to Java. TBR=dtrainor@chromium.org Bug: 1078454 Change-Id: Ib500e472c78383ce663a43f77792b6da6c248f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236215Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776179}
-
Charlie Hu authored
|DocumentPolicy::IsFeatureEnabled| is a dead function that should be removed when |mojom::DocumentPolicyFeature| is used in document policy to replace usage of |mojom::FeaturePolicyFeature|. Change-Id: I9a844b771607adec03ede78b03fcb78cbee979ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235984Reviewed-by:
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Ia88aabece93431cb8fb08dd958a0434d81084e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236056Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
-
Bettina authored
Many untested lines of client side detection related code are log statements. Removing them as they make the code messier. Also removed unneeded methods that only does DCHECKs and made them inline instead. Removed unneeded methods in tests. There will be follow up CLs to address untested methods. Bug: 1069793 Change-Id: I910e01dd89db27351474a9d5bc589f3f67437d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233712 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#776176}
-
Matt Menke authored
They were previously aborted instead, which both confused users and required an extra round trip to figure out that bug reports in this case are actually related to H2. Bug: 941651 Change-Id: I5a84f5fa117c5fe50e0b399e3ad9f24b4f2ea1e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232758Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#776175}
-
Frank Liberato authored
At least, set it correctly for some value of "correct". Bug: 1091466 Change-Id: Ib5f242fcc923333d647e5209233b718acf902197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232777Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#776174}
-
Eric Orth authored
Bug: 1088715 Change-Id: I8e55f1350126632b83ae6e57148d97881f66c455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231661 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#776173}
-
Doug Arnett authored
Bug: 1089210 Change-Id: I883e8fae43262a428a2f8488d962358dc03728a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236238Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#776172}
-
Joel Hockey authored
When all fonts have been exhausted and we must render tofu / notdef, we use the first candidate font rather than the system or last resort font. This helps in the case where a user has specified a monospace font such as for the terminal system app. We want to use the uniform width tofu, rather than the system or last resort font. Renamed is_last_resort to is_last_font in HarfBuzzShaper to reduce confusion since the final font used may not be the system last resort font. Some tests required updating since they are now rendering .notdef from the preferred font rather than the last resort font. I have added SansNotoTibetan-Regular.ttf font which is required in test external/wpt/css/css-text/word-break/word-break-break-all-005.html. Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.10-blink-rel;luci.chromium.try:mac10.11-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:mac10.14-blink-rel;luci.chromium.try:mac10.15-blink-rel;luci.chromium.try:win7-blink-rel;luci.chromium.try:win10-blink-rel Bug: 1090566 Change-Id: Ifca2800e6296adac3e40e3dae16008959b669337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227711Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#776171}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a85d58e50e33..355e6449e7fd 2020-06-08 brucedawson@chromium.org Python 3 support for get_toolchain_if_necessary.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I494a8a6c360d0bb443d3a81e62db694619555dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236239Reviewed-by:
-
