- 08 Nov, 2018 40 commits
-
-
David Jean authored
Will merge the cell_utils with card_cell after crrev/c/1303730 is merged. Bug: 845472 Change-Id: Iead98637aeaa8b7e3b0252057b8592ef4fff0529 Reviewed-on: https://chromium-review.googlesource.com/c/1317853 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#606423}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ie6a5db975ef6caa8b9f05643384687d249570e3a Reviewed-on: https://chromium-review.googlesource.com/c/1326322Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606422}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/34abcd63072e..2c774c363516 Created with: gclient setdep -r src-internal@2c774c363516 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I24c1d5ef4a28b2519e19856c5a694771c38f47ac Reviewed-on: https://chromium-review.googlesource.com/c/1326321Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606421}
-
Patrik Höglund authored
I missed 4 (!) cases when disabling this test for win, so let's fix that. Bug: 893494 Change-Id: I6ebfe7d2db4462b4da378aa6a39497b60025f060 Tbr: emircan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1326146Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#606420}
-
Alexandr Ilin authored
This CL fixes flaky LoadingPredictorBrowserTest.PrepareForPageLoadWithPrediction test. If a navigation finishes earlier than the PreconnectManager completes all its preresolve jobs, remaining jobs will be cancelled and the test will fail by timeout. This CL uses TestNavigationManager that pauses navigations to avoid this race. Bug: 902963 Change-Id: I6aea05b3518627f7bbef0af18bb89bb1b1463f81 Reviewed-on: https://chromium-review.googlesource.com/c/1325984Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#606419}
-
Rayan Kanso authored
The new version of the spec removes the clause about waiting for installing workers since that can easily cause deadlocks. Bug: 542437 Change-Id: I4192787248e3d147ec001516f86aa17ea361752f Reviewed-on: https://chromium-review.googlesource.com/c/1323717Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#606418}
-
Colin Blundell authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1302175, IdentityTestEnvironment now requires a properly set-up task environment. The error that ensues at runtime if this is lacking is currently quite cryptic. This CL adds documentation of the requirement and a transparent runtime error for the case where the task environment is missing. Bug: 798699 Change-Id: I7187b9d30f3072c2a0e697e7e325b01d238665bc Reviewed-on: https://chromium-review.googlesource.com/c/1323073 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#606417}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/905ee08219fa..743899de3f2d git log 905ee08219fa..743899de3f2d --date=short --no-merges --format='%ad %ae %s' 2018-11-08 jiajia.qin@intel.com ES31: Implement MAX_SHADER_STORAGE_BLOCK_SIZE Created with: gclient setdep -r src/third_party/angle@743899de3f2d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I5ffb4968b35f4cedde5d77bcc592dfdee4557bcc Reviewed-on: https://chromium-review.googlesource.com/c/1326101Reviewed-by:
-
Antonio Gomes authored
CL also converts ::GetMessagesForAvatarSyncError defined at c/b/sync/sync_ui_util.h|cc, (but not the whole file). BUG=890804,890796 Change-Id: I4d7dbbdb1c5ca6f86e44cf9b4b454143eac08d9d Reviewed-on: https://chromium-review.googlesource.com/c/1324589 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#606415}
-
Vaclav Brozek authored
The test expectations for form_parser_unittest.cc contain the expected roles for form fields (username, new-password, etc.). There can be at most one of each, so if there are multiple same roles, all but one are ignored. This CL adds a DCHECK to guard that there are no multiple same roles specified, so that the expecations are not described in a confusing way. It is a DCHECK instead of an ASSERT/EXPECT, because this is something not depending on the tested code, just the way the test is written. Hence if it passes when submitting the CL, it will pass until the next change to the test file. Bug: 902700 Change-Id: I022daf5a1701f13e7d52c881b60acfc412cd2e96 Reviewed-on: https://chromium-review.googlesource.com/c/1325985Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#606414}
-
Fredrik Söderquist authored
Does not appear to be flaky anymore. TBR=schenney@chromium.org Bug: 306222 Change-Id: I4e381ca9d89e5495cb98286e0fd387b94d67c125 Reviewed-on: https://chromium-review.googlesource.com/c/1326008Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#606413}
-
Vasilii Sukhanov authored
Unnecessary update skews the metrics. Typical flow before the CL is - The profile chooser shown. - User clicks something. - The profile chooser is being hidden. - Some state changes and updates still existing bubble. Bug: 901449 Change-Id: Iee9b5c7757aad2f0d9c7149a1e26b33e6e954716 Reviewed-on: https://chromium-review.googlesource.com/c/1320172Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#606412}
-
Jordan Demeulenaere authored
The details image is now downloaded using the CachedImageFetcher introduced in http://crrev/c/1297639. This allows to safely download the image and avoid downloading the same one multiple times. Change-Id: I5ad8e433307b75fafc522fcd379e62c4b3938a9f Reviewed-on: https://chromium-review.googlesource.com/c/1326005Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#606411}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6b82a698270f..34abcd63072e Created with: gclient setdep -r src-internal@34abcd63072e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5077536e0976082d868dc178292ae3c276c2f513 Reviewed-on: https://chromium-review.googlesource.com/c/1326061Reviewed-by:
-
Daniel Bratell authored
A change included an internal blink header in the public api layer which then leaked parts of blink's internal out into the wild dangerous world outside. This is a quick fix to close that leak. Might need some tuning. Bug: 902022 Change-Id: I076f4c5d0a27cd4c3070d8fe8a5be97f2f65e1e0 Reviewed-on: https://chromium-review.googlesource.com/c/1323715 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#606409}
-
Javier Ernesto Flores Robles authored
Creates and logs user actions for the following actions. ManualFallback_Close ManualFallback_ClosePopover ManualFallback_OpenPassword ManualFallback_OpenCreditCard ManualFallback_OpenProfile ManualFallback_Password_SelectUsername ManualFallback_Password_SelectPassword ManualFallback_Password_OpenOtherPassword ManualFallback_Password_OpenManagePassword Bug: 845472, 881734 Change-Id: If251294575be60b9c27296e79e06a394a277762e Reviewed-on: https://chromium-review.googlesource.com/c/1317914Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#606408}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 12dbcc93. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams hbos@chromium.org, hta@chromium.org: external/wpt/webrtc meade@chromium.org: external/wpt/web-animations NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic9532b352ac67df15f3784e65b5c289a19cd402a Reviewed-on: https://chromium-review.googlesource.com/c/1325563 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606407}
-
Yi Su authored
Current implementation of search_engine.js finds Open Search <link> when the Js file is injected without a check on page's loading status. This CL adds a check for document.readyState, so that the finding process will only be executed when the page is fully loaded. Bug: 433824 Change-Id: I3384081dd3079f15dba6a727cf1373edc4b593ba Reviewed-on: https://chromium-review.googlesource.com/c/1323716 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#606406}
-
Tomas Popela authored
Currently when the stubs code is used outside of the Chromium (i.e. in WebRTC) the build will fail because of the missing implementation of VLOG() - it's defined in the //base/logging.h, but WebRTC can't use that as it uses its own //base_rtc/logging.h with RTC_LOG() functions. To make it buildable there add a two new options to the generate_stubs.py. The first one '--logging-function' or '-l' is used for passing the function call for logging. Its default value is set to 'VLOG(1)' so the current code doesn't need to be updated. The second one is '--logging-include' or '-n' that is used for passing the header file where the function from the '--logging-function' is defined. Change-Id: Iafc898deb818c0a140d177d0190f4db52294df0d Reviewed-on: https://chromium-review.googlesource.com/c/1317918Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> Cr-Commit-Position: refs/heads/master@{#606405}
-
Boris Sazonov authored
1. Revised how Preferences activity gets argument bundle to pass to a subpage fragment. PreferencesLauncher methods got Bundle argument, so EXTRA_SHOW_FRAGMENT and EXTRA_SHOW_FRAGMENT_ARGUMENTS are package-private now. 2. The type of PreferencesLauncher.launchSettingsPage fragment parameter is changed to Class<? extends Fragment> to get compile-time checks. 3. A bunch of callers are changed to use launchSettingsPage instead of createIntentForSettingsPage followed by startActivity. 4. DataReductionPreferences and PasswordEntryEditor now get their parameters using fragment arguments instead of intent extras. Bug: None Change-Id: Ic0ae700149d721ab9194ed36c311c8f8b47bea1e Reviewed-on: https://chromium-review.googlesource.com/c/1323071Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#606404}
-
philipel authored
Cleanup related to https://webrtc-review.googlesource.com/c/src/+/108861 Bug: webrtc:9946 Change-Id: Iae472e30fa5e574c7e23b53c5dc7af767838b98f Reviewed-on: https://chromium-review.googlesource.com/c/1323091Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Philip Eliasson <philipel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606403}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/acacecec..5c68fccf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id9448a19f02186e23422d76db01009b1add0fe59 Reviewed-on: https://chromium-review.googlesource.com/c/1325941Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606402}
-
Mathias Carlen authored
Before this change we only had a fork of the payment request logic, not the UI underneath. This makes customizing the UI tricky without exposing larger parts of the Payment Request UI to Autofill Assisatnt. This patch tries to fork the PaymentRequestUI in a non invasive way. This includes the java classes and the corresponding xml. We accept the potential of being broken by changes in payments/ to non-forked parts and will fix that on the Autofill Assistant side as needed and merge back later if that makes sense. As an example of how to customize the UI on the Autofill Assistant side, this patch includes a customized PaymentRequestBottomBar (java and xml). The buttons need more styling, which will be done in an upcoming change. R=gogerald@chromium.org, twellington@chromium.org another use case. It should go away once we refactor the existing API and share more code. Binary-Size: Increase is temporary due to a payment request UI reuse for Bug: 806868 Change-Id: Iec801cc7d667e39c58e3604c0f62ea8289e90a1e Reviewed-on: https://chromium-review.googlesource.com/c/1316730 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:Theresa <twellington@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#606401}
-
Khushal authored
Currently text blobs are cached in the GPU process in the ServiceTransferCache during OOP raster. This approach has 2 shortcomings: 1) While it gives us cache hits in skia's internal caching keyed on these blobs, we still reserialize the blobs each time. This is because the client side tracking of an entry in ClientTransferCache can get more expensive than serializing the entry itself for these small entries. 2) The ServiceTransferCache budget is based on the assumption that it will be used for images, which is much larger than needed for this use-case. And because the eviction is also only done when we hit the cache limit, even if the renderer creating the entries is now invisible, the cache gets filled with stale data that may have already been purged on the client and will never be reused. This change adds a new client driven cache for these paint data type (text blobs and paths), with a much smaller budget and something that is cleared during our normal context idle cleanup or on visibility change. Lookup and additions to the cache are also slightly cheaper than transfer cache since it avoids allocating discardable handles for cross process ref-counting and the need to track entries which need to be unref-ed after every raster. TBR=tsepez@chromium.org R=enne@chromium.org, piman@chromium.org Change-Id: Ibc4039ec5ab20e45c1ae67aec20367c20371458f Bug: 898910,894200 Reviewed-on: https://chromium-review.googlesource.com/c/1321190 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606400}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/f56830ed406f..fb0d66d04c4d $ git log f56830ed4..fb0d66d04 --date=short --no-merges --format='%ad %ae %s' 2018-11-07 bungeman [truetype] Fix VF check from 2018-09-12 (#54973). 2018-11-06 wl [pshinter] Fix numeric overflow. 2018-11-06 wl [psaux] Fix timeout in old CFF engine. 2018-11-04 apodtele Minor. 2018-11-04 apodtele * src/truetype/ttgxvar.c: Use enum definitions. 2018-11-03 apodtele * src/truetype/ttgxvar.c (ft_var_apply_tuple): Adjust condition. 2018-11-03 apodtele * src/truetype/ttgxvar.c (ft_var_apply_tuple): Tracing tweaks. 2018-11-03 apodtele Revert due to specs: [truetype] Speed up variation IUP. 2018-11-03 apodtele Revert "[truetype] Speed up variation IUP." 2018-11-02 apodtele * src/truetype/ttgxvar.c (ft_var_get_item_delta): Fixed logic. 2018-11-02 shailesh.mistry [autofit] Prevent SEGV. 2018-10-31 apodtele [truetype] Speed up variation IUP. 2018-10-31 apodtele * src/type1/t1load.c (t1_set_mm_blend): Optimized. 2018-10-31 apodtele * src/truetype/ttgxvar.c (ft_var_get_item_delta): Optimized. 2018-10-29 wl [base] Fix numeric overflow. 2018-10-29 wl [cff] Fix numeric overflow. 2018-10-28 apodtele Comment on timestamp storage. 2018-10-26 apodtele [sfnt] Make `head' timestamps unsigned. 2018-10-26 apodtele Revert "Align FreeType with standard C memory management." 2018-10-27 wl [psaux] Fix numeric overflow. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng PDFium-Issue: pdfium:1191 Bug: chromium:902759 Change-Id: I9cecc7b01263a068b81e7692962cd92ec60fccc6 Reviewed-on: https://chromium-review.googlesource.com/c/1323793 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#606399}
-
Marc Treib authored
One less custom subclass of FakeSyncService :) Bug: 859874 Change-Id: Idfafda6dcb3ab705a6c6410d27dd4087b0d91699 Reviewed-on: https://chromium-review.googlesource.com/c/1318979 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#606398}
-
Marc Treib authored
One less subclass of FakeSyncService to maintain :) Bug: 859874 Change-Id: I29d0f367227f59c2ab3b08eefefbd1b21bb35019 Reviewed-on: https://chromium-review.googlesource.com/c/1318922Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#606397}
-
Mark Cogan authored
-tabLoadComplete just tells the tab model to save asynchronously; this CL just has call sites do that directly. Change-Id: Ic7306d20505de61ca412f08794719fdd8c0057e6 Reviewed-on: https://chromium-review.googlesource.com/c/1323052 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#606396}
-
Alexey Baskakov authored
We parse them from manifest during installability check. Bug: 891172 Change-Id: I891dd48f29e6f43386c028a14f92c08db630da5e Reviewed-on: https://chromium-review.googlesource.com/c/1325580 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#606395}
-
Nico Weber authored
This reverts commit 58730f7f. Reason for revert: There's no tot bot for this config (https://crbug.com/903078) Original change's description: > Promote win-libfuzzer-asan-rel CQ bot out of experimental. > > Cycle time and failure rate looks good. > > Bug: 893614 > Change-Id: I43fcdf7f8e1b920ec784c0c67025e72aa7169873 > Reviewed-on: https://chromium-review.googlesource.com/c/1299973 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603113} TBR=dpranke@chromium.org,bpastene@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 893614 Change-Id: I10200022b338edf0cc0ee7100f7ff417b7c19eb8 Reviewed-on: https://chromium-review.googlesource.com/c/1325982Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#606394}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bd8b72d215eb..6b82a698270f Created with: gclient setdep -r src-internal@6b82a698270f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I05e3cf9fdf741a3b2a2dce3050eba8475438ea58 Reviewed-on: https://chromium-review.googlesource.com/c/1325376Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2f8889b876d3..23d1f94faac1 git log 2f8889b876d3..23d1f94faac1 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@23d1f94faac1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I07b09336847b1d21e54c779a02af902c55bca8ce Reviewed-on: https://chromium-review.googlesource.com/c/1325861Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/026f83d49289..f04a3a61ad90 git log 026f83d49289..f04a3a61ad90 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 dpranke@chromium.org Update the expectation parser in TYP to match the new format. Created with: gclient setdep -r src/third_party/catapult@f04a3a61ad90 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:835690 TBR=sullivan@chromium.org Change-Id: I342f7d89d9cd55f70eaad8659ac9d56450d4ddf5 Reviewed-on: https://chromium-review.googlesource.com/c/1325653Reviewed-by:
-
Alexandre Courbot authored
This document used to be maintained as a Google Docs, but having it available in the Chromium repository makes it much easier to access for partners. BUG=None TEST=Generated and checked HTML using Markdown. Change-Id: I790504be2720150cebee151a585a2435ac35a494 Reviewed-on: https://chromium-review.googlesource.com/c/1322174 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#606390}
-
Yuzu Saijo authored
This CL allows detection-only mode for oom intervention in order to gather data from finch, while not actually triggering intervention (or the infobar). Change-Id: I511bf3ccd51218521a526ea001de2a823e1c16bc Reviewed-on: https://chromium-review.googlesource.com/c/1325583Reviewed-by:
-
Yoichi Osato authored
We used to invalidate always LayoutSVGText even local selection rect was empty before inserting early return of L342. That caused regression that selection in svg text is not invalidated. This patch fixes the regression by invalidating LayoutSVGText always as before. Bug: 897752 Change-Id: I534959ccb461d55d38e85e053c9b9c478b3878b3 Reviewed-on: https://chromium-review.googlesource.com/c/1314019 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606388}
-
Gauthier Ambard authored
This CL removes the -closeAllIncognitoTabs command as it is not used. Bug: 902781 Change-Id: I583e53095fcddf03c899d6b44779b38daced32a3 Reviewed-on: https://chromium-review.googlesource.com/c/1323670Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#606387}
-
Arthur Sonzogni authored
After sending: URLLoaderClient::OnReceiveResponse(response_head), not all URLLoader are sending: URLLoaderClient::OnStartLoadingResponseBody(response_body). It even happens to send URLLoaderClient::OnComplete(net::OK) after that, which may confuse the URLLoaderClient. Most URLLoader not sending a response's body datapipe are the one with an empty response. For consistency, always send a response's body datapipe, even if it doesn't contains data. This CL updates every tests not aligned with this. Once every URLLoader and tests are consistent. DCHECK enforcing this will be added. This CL is a prerequisite for: https://chromium-review.googlesource.com/c/chromium/src/+/1172290 Bug: 826868, 831155 Change-Id: Id3434ea442c93b47bd200d15322cc21cd0c0b89f Reviewed-on: https://chromium-review.googlesource.com/c/1323092Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#606386}
-
Hayato Ito authored
This bug number is not related to the content of TODO comment. TBR=rakina@chromium.org Change-Id: Ifd8563c8104a00134d91c176d8418b93592098da Reviewed-on: https://chromium-review.googlesource.com/c/1325284Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#606385}
-
yoshiki iguchi authored
This CL is almost reverts of the following CL: crrev.com/c/1315207 This test has been disabled on Chrome OS because of flakiness: crbug.com/901235. The flakiness is fixed by the recent change (crrev.com/c/1316986) so that this CL re-enable it. TBR=mlamouri@chromium.org, vitaliii@chromium.org Bug: 901235 Test: trybots pass Change-Id: I1cec695988728ae40bd1f6031135efaf07c760b3 Reviewed-on: https://chromium-review.googlesource.com/c/1325597Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#606384}
-
