- 08 Nov, 2018 40 commits
-
-
Etienne Pierre-doray authored
base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more explicit counterpart. It should have been replaced by : * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. * base::ScopedAllowSyncPrimitives in non-test files * base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads that don't allow blocking The last one is strongly frowned upon but this CL aims to document existing behavior rather than address it. Owners are encouraged to follow-up by fixing unnecessary waits and more particularly unnecessary waits outside-blocking-scope. Note: The non-for-testing versions require friend'ing in thread_restrictions.h but care was taken to add these friends ahead of git cl split (since it wasn't possible to do a line-by-line associated CL split). Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1288533 Please CQ if LGTY! This CL was uploaded by git cl split. R=wittman@chromium.org Bug: 766678 Change-Id: I2c45612b77a49ca5720da95093b0cdd8845b6f03 Reviewed-on: https://chromium-review.googlesource.com/c/1325191Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606478}
-
Tim Volodine authored
Add a constructor to AwWebResourceRequest to make it possible to create AwWebResourceRequests directly from network::ResourceRequest. Also use this constructor in the new code path related to Network Service. This reduces duplicate code and increases readability in current and future code. Also because of the recent introduction of is_renderer_initiated member which is not included in any existing constructor, this patch simplifies the actual creation of requests. BUG=897149,841556 Change-Id: I91c3337fe9d9c3cb2b12f36e53b888bbeebb0d30 Reviewed-on: https://chromium-review.googlesource.com/c/1312484 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#606477}
-
Friedrich Horschig authored
Before this CL, the accessory would only clear the accessory suggestions when the origin changes during a navigation or when new suggestions overwrite the existing ones. With this CL, the accessory also clears the suggestions when a reload was the reason for a page navigation. Bug: 902716 Change-Id: I897dd774a31676adb4aede8fc4016446f058ffa0 Reviewed-on: https://chromium-review.googlesource.com/c/1323712Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#606476}
-
Egor Pasko authored
Also rewrite matching to be more assertive on particular sub-parts of the string. Hopefully this would allow resolving particular cases before the perf/memory regressions creep in. The new parsing finds extra ~2000 symbols compared to the previous version. For testing I compared the extracted symbol infos with the output of 'arm-linux-androideabi-nm --print-size --size-sort --reverse-sort' on the instrumented binary. The differences are: * 'linker_script_end_of_text' is ignored by the symbol extractor (the 'linker_script_start_of_text' is output as a special case because we rely on it later) * the symbol extractor seems to rightfully ignore local labels and pointers deep into functions, like: 'PRE_LOOP_STAGES_7_OR_8' or 'jsimd_idct_islow_neon_consts' * v8 builtins like 'Builtins_RecordWrite' have the size 0 and unfortunately are not distinguishable from labels above Bug: 893981 Change-Id: Ie2ac9a76508832cb90fdedda1ceb46f6c2b24dba Reviewed-on: https://chromium-review.googlesource.com/c/1326486Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#606475}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/63ae28d13da9..7491c965b291 Created with: gclient setdep -r src-internal@7491c965b291 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8690844804eea6609d8f9fd1d72dc16a97c4e31a Reviewed-on: https://chromium-review.googlesource.com/c/1326327Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606474}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/de6267f6e213..0bbca7f95d2f git log de6267f6e213..0bbca7f95d2f --date=short --no-merges --format='%ad %ae %s' 2018-11-08 lalitm@google.com trace_processor: fix build Created with: gclient setdep -r src/third_party/perfetto@0bbca7f95d2f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I5dfc9b910287a0fa5089003608c84ed42232fefd Reviewed-on: https://chromium-review.googlesource.com/c/1326326Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606473}
-
Philip Rogers authored
The compositor has a concept of "damage" that is similar to the raster invalidation calculated in blink and represents the part of the screen that needs to be redrawn. Damage in the compositor is calculated using |Layer::subtree_property_changed()|. This patch uses SPV2's property node "changed" bits to mark cc::Layers as changed if any ancestor property tree node changes. Bug: 901051 Change-Id: I8899ce2ef8dd2b37855f38c71dea443d28520788 Reviewed-on: https://chromium-review.googlesource.com/c/1324093 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606472}
-
David Jean authored
This is a reland of 50ac3f62 The problem is fixed in https://crrev.com/c/1326155 Original change's description: > [ios] add manual fallback address cell > > Will merge the cell_utils with card_cell after crrev/c/1303730 is merged. > > Bug: 845472 > Change-Id: Iead98637aeaa8b7e3b0252057b8592ef4fff0529 > Reviewed-on: https://chromium-review.googlesource.com/c/1317853 > Commit-Queue: David Jean <djean@chromium.org> > Reviewed-by: Eric Noyau <noyau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606423} TBR=noyau@chromium.org,mahmadi@chromium.org Bug: 845472 Change-Id: I6524b3ed9d38233c0c5489a2b6ecd2753708d09a Reviewed-on: https://chromium-review.googlesource.com/c/1326484Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#606471}
-
Max Morin authored
The current code assumes that the time stamp given by CRAS is from the clock that base::TimeTicks uses. It is not, leading to incorrect time stamps. I verified that, in a VM, the new code in apprtc reports ~the same latency as running "cras_test_client --capture_file /dev/null --show_latency". Bug: 903213 Change-Id: Ib998414d4c4c8a3df7c7ef62f8386960f7439156 Reviewed-on: https://chromium-review.googlesource.com/c/1326142Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#606470}
-
Hans Wennborg authored
Disable flaky test org.chromium.chrome.browser.partnercustomizations.PartnerHomepageUnitTest#testHomepageFeatureFlag TBR=danielpark Bug: 901769 Change-Id: I3b6b67f3381f77cc3520139eea3c11d5a189ae8c Reviewed-on: https://chromium-review.googlesource.com/c/1326485Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#606469}
-
Vadym Doroshenko authored
This reverts commit 7b104ecc. Reason for revert: test AshKeyboardControllerTest.ShowAndHideKeyboard which was added on this CL fails on some bots. Here is the first failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/30008 Original change's description: > Add Show/HideKeyboard methods to keybaord_controller.mojom > > This CL: > * Introduces ShowKeyboard, HideKeyboard, and IsKeyboardVisible > to keyboard_controller.mojom. > * Includes HideReason for HideKeyboard (User or System). > * Introduces keyboard::mojom::KeyboardEnableFlag::kTemporarilyEnabled > for temporarily enabling the keyboard and showing it. > * Renames keyboard::mojom::ReloadKeyboard() -> RebuildKeyboardIfEnabled(). > * Introduces keyboard::mojom::ReloadKeyboardIfNeeded() which calls > KeyboardUI::ReloadKeyboardIfNeeded() which updates the keyboard URL if > it has changed and otherwise does nothing. > * Replaces direct calls to KeyboardController from most of src/chrome > Notable exception: ChromeVirtualKeyboardDelegate which will be > transitioned in a follow up CL. > > Bug: 843332 > Change-Id: I2faf000c8233ee0253b799a6e4780020ba3bbe1f > Reviewed-on: https://chromium-review.googlesource.com/c/1309215 > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Shu Chen <shuchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606311} TBR=jamescook@chromium.org,stevenjb@chromium.org,sky@chromium.org,shuchen@chromium.org,tsepez@chromium.org,shend@chromium.org Change-Id: Ib2634d6ebc0274049368ebf86488fc185d81f9c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843332 Reviewed-on: https://chromium-review.googlesource.com/c/1326490Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#606468}
-
François Doray authored
This reverts commit 4d971424. Reason for revert: Caused a binary size regression on Android. https://crbug.com/883902 TBR=alemate@chromium.org,chili@chromium.org,kouhei@chromium.org Bug: 883902 Original change's description: > Base: Mark TimeDelta::In...() methods as constexpr. > > This will allow use of these methods in constexpr expressions such as > https://chromium-review.googlesource.com/c/chromium/src/+/1195852/4/chrome/browser/resource_coordinator/tab_manager_features.h#118 > > Change-Id: I4407ac72846e7c826e5cf3d920cda5f4b5d5071c > Reviewed-on: https://chromium-review.googlesource.com/1220446 > Commit-Queue: François Doray <fdoray@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590667} TBR=fdoray@chromium.org,mark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ib3b8ead36933549c238622ea2b6641dc427f65ad Reviewed-on: https://chromium-review.googlesource.com/c/1226098 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#606467}
-
Hans Wennborg authored
This reverts commit e1a5c58c. Reason for revert: Multiple reports of flakiness, see bugs. Original change's description: > [Autofill] Add Autofill StrikeSystem to waterfall testing config > > Bug: 884817 > Change-Id: Iab61ac0b51d4541313f48263cadbfe2110fac543 > Reviewed-on: https://chromium-review.googlesource.com/c/1321255 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Jared Saul <jsaul@google.com> > Cr-Commit-Position: refs/heads/master@{#606087} TBR=rkaplow@chromium.org,jsaul@google.com Change-Id: I6b8f3f6961891fc876900a574d2e3683fc63d5c0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 884817, 903055, 903080, 903083, 903228 Reviewed-on: https://chromium-review.googlesource.com/c/1326503Reviewed-by:
-
Koji Ishii authored
This test is identical to: external/wpt/css/CSS2/text/white-space-normal-007.xht Found when the two tests start to fail in a local change. TBR=foolip@chromium.org Change-Id: I5c8c9767c2279867fc48379146f322703cc37103 Reviewed-on: https://chromium-review.googlesource.com/c/1325589Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#606465}
-
Mark Cogan authored
This CL makes BVC's tabModel property synthesized, and changes all uses of the previous backing ivar to uses of the property. Change-Id: If75a5b72e0fd222d08a0aa8b7c493d07e404b24f Reviewed-on: https://chromium-review.googlesource.com/c/1323556 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#606464}
-
David Bokan authored
Bug: 798719 Change-Id: Iee4735a21292c8de2d5f638358844a3b279f92d5 Reviewed-on: https://chromium-review.googlesource.com/c/1320193 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#606463}
-
Christopher Grant authored
This is a reland of 3e5be326 The source location of pak resources collected for tests has been updated to match the new location. TBR=agrieve@chromium.org Original change's description: > Android: Unify pak resource generation for Chrome and Monochrome > > Previously, Monochrome used its own set of GN targets to package > resources, analogous to the ones used for Chrome (some of which are the > same used for non-Android platforms). This change moves both variants > to use matching sets of template-generated targets. > > Later, when bundle-specific native libraries are added, this common > template can be reused again. > > BUG=874584 > > Change-Id: Ia9c34cb0dfa8754207bdee146dbde47f9aca78d3 > Reviewed-on: https://chromium-review.googlesource.com/c/1318418 > Commit-Queue: Christopher Grant <cjgrant@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606060} Bug: 874584 Change-Id: Ifa3b02a3f87d757435d125eb0c5a15f01d5ca6e1 Reviewed-on: https://chromium-review.googlesource.com/c/1324412Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#606462}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e1f79644..82a57102 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieda34914bd96bee6f7f217a8a016b2ce705e2efe Reviewed-on: https://chromium-review.googlesource.com/c/1326421Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606461}
-
Anders Hartvoll Ruud authored
This makes it possible to use CSSPropertyRef to get instances which represent aliases. R=futhark@chromium.org Change-Id: I6098c02678bb36bb08ecb28764893245e747a350 Reviewed-on: https://chromium-review.googlesource.com/c/1323111 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#606460}
-
Mikel Astiz authored
The pseudo-USS codepath now implements the same UMA metric as the legacy codepath (SharedChangeProcessor), representing the time required to run association per datatype (SyncableService::MergeDataAndStartSyncing()). We are not only interested in the exact timings, but also the *number* of them, which should be similar. Bug: 870624 Change-Id: If734966e37cda71b9f2edde3ea4ef8fc4779073b Reviewed-on: https://chromium-review.googlesource.com/c/1326143 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#606459}
-
Patrik Höglund authored
Bug: 893494 Change-Id: Ia1d28a678058ce949726e71f511f536482c2eee9 Tbr: emircan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1326461Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#606458}
-
Javier Ernesto Flores Robles authored
TBR: mahmadi@chromium.org Change-Id: I0958a168f04de6c4a0564fa6b942c7780d37cde5 Reviewed-on: https://chromium-review.googlesource.com/c/1326155 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
Vincent Boisselle authored
It will now default to USE_UPLOAD_RATES. We are planning to get rid of that field in the new API. Change-Id: Idd7d7821d016ec13c0c7e5e03a26f94a52628d42 Reviewed-on: https://chromium-review.googlesource.com/c/1323706 Commit-Queue: Vincent Boisselle <vincb@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#606456}
-
Mythri Alle authored
This add layout tests to ensure javascript code caching is working as expected. This also adds virtual tests with ( --enable-features=IsolatedCodeCache --site-per-process) to test that the isolated code cache is behaving as expected. These tests test that: 1. code cache is created on the second visit to the script 2. code cache is consumed on the third visit to the script 3. code cache for the same script resource is not reused if requested from a different origin (for the virtual tests). This also adds a timeout expectation for the failing tests. Bug: chromium:879494 Change-Id: I4504da0fb0222f73bbf12e93d85e12a0717f8749 Reviewed-on: https://chromium-review.googlesource.com/c/1310173 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#606455}
-
Matthew Cary authored
The instrumentation code outputs offsets relative to the start of text as defined by a special symbol (linker_script_start_of_text). This currently corresponds to the first symbol appearing in text, which also happens to be the first SymbolInfo produced by symbol_extractor. To protect against changes to the symbol_extractor this change uses the special symbol for the dump offset base rather than the lowest SymbolInfo offset seen. Bug: 893981 Change-Id: Ia3d265ae56e6a3b7362abf177c9cbe8d2eda36fb Reviewed-on: https://chromium-review.googlesource.com/c/1325989Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#606454}
-
Shik Chen authored
BUG=b:118418068,b:118408452,b:64996728,b:77833131 TEST=Check the external camera is shown in settings. Change-Id: I83604f5114d4dcd317c281cf63e9fd50ef619d9f Reviewed-on: https://chromium-review.googlesource.com/c/1326342Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#606453}
-
Mikel Astiz authored
syncer::WriteNode::Drop() guarantees that if the entity hasn't been committed to the server, the call gets ignored (i.e. the entity isn't actually dropped). Let's mimic the same behavior in the pseudo-USS codepath. Unfortunately, in order to do so, interface ModelTypeChangeProcessor needs to be extended. A TODO is introduced to improve this implementation in the future, when pseudo-USS is fully launched. This logic could be simplified a lot as well as the overall complexity of the SyncableService (logic implemented in DeleteDirectiveHandler) if everything was moved to history's backend thread. Bug: 870624 Change-Id: Ic064d809371c49f4281d986b4b30bdb3fa37844a Reviewed-on: https://chromium-review.googlesource.com/c/1326001 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#606452}
-
Eric Willigers authored
Blink should be running, and contributing to, the filter-effects tests https://github.com/web-platform-tests/wpt/tree/master/css/filter-effects The tests currently in css-filter can then easily be moved to filter-effects. Change-Id: Ibf50ee79c5456573e76ec42deebdb7bc727612e4 Reviewed-on: https://chromium-review.googlesource.com/c/1325274 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fa8898747551..6d1df6d9c128 git log fa8898747551..6d1df6d9c128 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 mtklein@google.com limit visibility of opts and optional targets Created with: gclient setdep -r src/third_party/skia@6d1df6d9c128 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I75179454e50dec07e5c4ad694a65f4831040b389 Reviewed-on: https://chromium-review.googlesource.com/c/1326325Reviewed-by:
-
Keishi Hattori authored
This reverts commit 2cc1550c. Reason for revert: Caused crashes crbug.com/902832 crbug.com/902848 Original change's description: > [Reland] Oilpan: Enable HeapCompaction for incremental marking > > Enables HeapCompaction for kIncrementalIdleGC and kIncrementalV8FollowupGC. > > Bug: 864425 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#603477} > Change-Id: I506868b5ea224714491fb4dfd9403e5311550255 > Reviewed-on: https://chromium-review.googlesource.com/c/1316954 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605608} TBR=haraken@chromium.org,keishi@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 864425 Change-Id: I864a985719c1c12bf4b56f05d228c6ff8450ef5f Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1326341Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#606449}
-
Leszek Swirski authored
This is a reland of 31bcf8aa which was a reland of 5528336d, which was a reland of dd9df78c, which was a reland of 7bd91635. Relanding with no changes, seems that this wasn't the cause of https://crbug.com/902832 after all. Original change's description: > Reland^3 "[blink] Control ScriptStreamer with ScriptResource" > > This is a reland of 5528336d, which > was a reland of dd9df78c, which was > a reland of 7bd91635. > > VR tests have been properly deflaked in https://crrev.com/c/1319715, this > is otherwise unchanged. > > Original change's description: > > Reland "Reland "[blink] Control ScriptStreamer with ScriptResource"" > > > > This reverts commit c564235f. > > > > No changes from the original, VR flakes are caused by issues with > > loadUrl and have been deflaked (see 894796 for details) > > > > Original change's description: > > > Revert "Reland "[blink] Control ScriptStreamer with ScriptResource"" > > > > > > This reverts commit dd9df78c. > > > > > > Reason for revert: Makes VR tests flaky (https://crbug.com/894796) > > > > > > Original change's description: > > > > Reland "[blink] Control ScriptStreamer with ScriptResource" > > > > > > > > This is a reland of 7bd91635 > > > > > > > > No changes from the original, revert reason is fixed with > > > > https://chromium-review.googlesource.com/c/1283037 > > > > > > > > Original change's description: > > > > > [blink] Control ScriptStreamer with ScriptResource > > > > > > > > > > Move the ScriptStreamer control logic from ClassicPendingScript to > > > > > ScriptResource. In the future, this will allow us to start streaming > > > > > a ScriptResource before the ClassicPendingScript is available, e.g on > > > > > preload. > > > > > > > > > > The ClassicPendingScript now only sends one "finished" callback, from > > > > > ScriptResource. This callback is either when the streaming completes, > > > > > or when there is no streaming and the ClassicPendingScript has told > > > > > the ScriptResource that it doesn't intend to start streaming. In the > > > > > long run, we want all scripts to go through the streaming interface, > > > > > and we want ScriptResource to control when streaming starts, so the > > > > > "no more streaming" call will disappear -- however it is necessary to > > > > > maintain the current behaviour, and be able to control it with a > > > > > runtime flag. > > > > > > > > > > Bug: chromium:865098 > > > > > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1181430 > > > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > > > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > > > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > > > > > Cr-Commit-Position: refs/heads/master@{#599148} > > > > > > > > TBR=kouhei@chromium.org,kinuko@chromium.org > > > > > > > > Bug: chromium:865098 > > > > Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1286450 > > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#601143} > > > > > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > Bug: chromium:865098 > > > Change-Id: Ibdbd7e80d0fcfacc84a73e83d165581c7f1d02d2 > > > Reviewed-on: https://chromium-review.googlesource.com/c/1297138 > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#602310} > > > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: chromium:865098 > > Change-Id: I9794fe5366aa8cfc9291d53271ed680465b29a76 > > Reviewed-on: https://chromium-review.googlesource.com/c/1317566 > > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#605295} > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org > > Bug: chromium:865098 > Change-Id: I8d6101f51eb33b19ec332a06a310172b371b7fa4 > Reviewed-on: https://chromium-review.googlesource.com/c/1318923 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605815} TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org Bug: chromium:865098 Change-Id: I73854c4d524ab0cc8e08ef512c10334f0ab5ead4 Reviewed-on: https://chromium-review.googlesource.com/c/1325921Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#606448}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ff46b65fdb14..de6267f6e213 git log ff46b65fdb14..de6267f6e213 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 lalitm@google.com trace_processor: fix slice view for Android traces Created with: gclient setdep -r src/third_party/perfetto@de6267f6e213 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:119002659 TBR=perfetto-bugs@google.com Change-Id: Ic3f59ed19e1d011ac642e9521861445d4bd94bae Reviewed-on: https://chromium-review.googlesource.com/c/1326324Reviewed-by:
-
Michael Lippautz authored
This flag overrides the default Blink value for content layer. Sheriffs: This is a dry-run of the feature and will be reverted after cycling through the waterfall and performance bots. Tbr: jochen@chromium.org, lfg@chromium.org Bug: 843903 Change-Id: Ie362301e4874198eb775346d051bf8267837aaf8 Reviewed-on: https://chromium-review.googlesource.com/c/1320970 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#606446}
-
Marc Treib authored
This replaces a custom subclass of FakeSyncService with the standard syncer::TestSyncService. It also removed another custom subclass that's just not used at all. Bug: 859874 Change-Id: I0ef20ca70a1fdc81649c856c287ed6f1432956f8 Reviewed-on: https://chromium-review.googlesource.com/c/1326149Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#606445}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2c774c363516..63ae28d13da9 Created with: gclient setdep -r src-internal@63ae28d13da9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7bcd30ddf6a80e058baf94d98035ae95668384d3 Reviewed-on: https://chromium-review.googlesource.com/c/1326323Reviewed-by:
-
Rune Lillesveen authored
If we are changing :empty to match when there are whitespace children, we need to know to what extent this affects existing content. Bug: 447880 Change-Id: I53906fe6295f42cdc72d5ca6d6e58e1aa60786c3 Reviewed-on: https://chromium-review.googlesource.com/c/1326003 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#606443}
-
Marc Treib authored
This removes a bunch of methods/members that aren't used (anymore). Bug: 859874 Change-Id: Ia3d0c3be3b1bfdaa9230a26e0ad44c9ea359bf43 Reviewed-on: https://chromium-review.googlesource.com/c/1326004Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7a397415. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org, mstensho@chromium.org: external/wpt/css/CSS2 NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib28cea91f2861ffedc9562f3e9a5eeda6c0f7893 Reviewed-on: https://chromium-review.googlesource.com/c/1326223 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606441}
-
Antonio Gomes authored
This CL is a continuation of [1], where AdvancedProtectionStatusManager (production code) was migrated from SigninManager and OAuth2TokenService to IdentityManager. At this time the respective unittests are migrated. The CL adds the adds/changes the following testing APIs: - IdentityTestEnvironment::WaitForAccessTokenRequestIfNecessaryAndRespondWithToken receives an extra (optional) parameter |id_token|, and forward it to FakeProfileOAuth2TokenService::IssueAllTokensForAccount. This allows the body of AdvancedProtectionStatusManagerTest::MakeOAuthTokenFetchSucceed to be migrated flawlessly. - IdentityTestEnvironment::UpdateAccountInfoForAccount. This method updates the account information for a given known account, by calling AccountTrackerService::SeedAccountInfo. [1] https://crrev.com/c/1250968 BUG=887266 Change-Id: Ica84fd299794552f2ae6957dfc6c7dde6bba7afa Reviewed-on: https://chromium-review.googlesource.com/c/1308993 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#606440}
-
Antonio Gomes authored
This CL only migrates DiceResponseHandler production code away from SigninManager, leaves migration away from ProfileOAuth2TokenService and unittests for a follow up step. Note that the unittest c/b/signin/dice_response_handler_unittest.cc was minimally updated to keep passing. BUG=890790,902296 Change-Id: Iecdf43b80afe6514b7f19075c2bb62aadfbdbe4c Reviewed-on: https://chromium-review.googlesource.com/c/1318550 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
