Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 20 Aug, 2018 6 commits
  3. 19 Aug, 2018 23 commits
  5. 18 Aug, 2018 11 commits
    • James Cook's avatar
      chromeos: Speculative fix for M69 shutdown crash in system tray · 43097139
      James Cook authored 
      When the user clicks on the shutdown button in the system tray we start
a process that tears down ash::Shell and closes the tray bubble. This
dispatches mouse exit events to windows as the system is being torn
down. In production this sometimes crashes. I cannot repro on device,
on linux-chromeos, or under ASAN, using the M69 code.

The crash started after we turned off the new unified system tray
in M69, so it's likely related to the old system tray. It should
go away when we switch to the new tray.

As a workaround, skip dispatch of mouse exits during shutdown and
don't process any new events.

Bug: 874156
Test: manually exercise sign out and shutdown
Change-Id: Ic898d15270661b3275a4f396d154ad2c02ba0644
Reviewed-on: https://chromium-review.googlesource.com/1180070
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584324}
      43097139
    • Christopher Cameron's avatar
      RemoteMacViews: Re-separate test code · 740a6c4c
      Christopher Cameron authored 
      This removes parts of crrev.com/583350, preserving the following
- explicitly require that NSWindows be NativeWidgetMacNSWindow
- return a scoped_nsobject from CreateNSWindow, and remove requirement
  of autoreleasing the result, to clarify lifetimes

This removes the ability to create an NSWindow in the AppShim process
for now. That will be re-added later.

Bug: 859152
Change-Id: Ife70a91ac9557f2ec7a488a8714f907eaecea0e3
Reviewed-on: https://chromium-review.googlesource.com/1177276
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: default avatarTrent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584323}
      740a6c4c
    • Ben L. Titzer's avatar
      [wasm] Update owners for UMA histograms. · 042a0b01
      Ben L. Titzer authored 
      Keep these owners up to date: remove bradnelson@ and eholk@ from WASM
metrics (sadly).

R=adamk@chromium.org

Change-Id: Iaec80eb69da6159b2547e57d1ad618057c6cdc13
Reviewed-on: https://chromium-review.googlesource.com/1156597Reviewed-by: default avatarAdam Klein <adamk@chromium.org>
Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Commit-Queue: Ben Titzer <titzer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584322}
      042a0b01
    • Rouslan Solomakhin's avatar
      [Payment Request] Enable Jumbo build · 0823526b
      Rouslan Solomakhin authored 
      Speed up builds in /components/payments with "use_jumbo_build = true"
setting in GN args.

Bug: NONE
Change-Id: I18890875b46450dde461e126573e44958e6ac7d9
Reviewed-on: https://chromium-review.googlesource.com/1180555
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: default avatarGanggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584321}
      0823526b
    • Nico Weber's avatar
      win/asan: Fix GetSandboxSidPrefix test and run install_static_unittests on bot. · e57c623d
      Nico Weber authored 
      The test was comparing two wchar_ts for pointer equality. In non-asan builds,
equal constant strings in different TUs got merged, but in asan builds this
seems ot not happen. Do a string comparison instead.

Bug: 875225
Change-Id: I6a4031d1d6bca5697fb0a2dd6224323667711a81
Reviewed-on: https://chromium-review.googlesource.com/1180552Reviewed-by: default avatarReid Kleckner <rnk@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584320}
      e57c623d
    • Wei Li's avatar
      Use printing layout correctly for subframes · e342abf1
      Wei Li authored 
      When an oopif is printed along with its parent, this frame should not
use printing layout. Instead, its size is confined by its parent. Before
this change, ShouldUsePrintingLayout() works correctly in
LocalFrame::SetPrinting() since it also checks |use_printing_layout|
variable. But ShouldUsePrintingLayout() doesn't work correctly during
layout code where it is also called to decide whether printing layout
should be applied for style etc.

This CL fixes ShouldUsePrintingLayout() to return the correct value for
all cases.

BUG=853942

Change-Id: I6cad75fd6db59d00d4c07ea8b23dbaf6a4a47afc
Reviewed-on: https://chromium-review.googlesource.com/1175404
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: default avatarKen Buchanan <kenrb@chromium.org>
Reviewed-by: default avatarXianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584319}
      e342abf1
    • Philip Rogers's avatar
      [BlinkGenPropertyTrees] Mark more tests as passing · d4f1fbf3
      Philip Rogers authored 
      This patch marks 33 tests as passing. Many of the android/fullscreen
tests were fixed by chaopeng's recent patch https://crrev.com/584169.

Bug: 836886

Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I978cf46b333f81f0688dea6ca5023f5d59d0b01d
Reviewed-on: https://chromium-review.googlesource.com/1180620
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: default avatarXianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584318}
      d4f1fbf3
    • Joshua Peraza's avatar
      Roll src/third_party/breakpad/breakpad/ 79ba6a494..1459e5df7 (16 commits) · 961cb03d
      Joshua Peraza authored 
      https://chromium.googlesource.com/breakpad/breakpad.git/+log/79ba6a494fb2..1459e5df74dd

$ git log 79ba6a494..1459e5df7 --date=short --no-merges --format='%ad %ae %s'
2018-08-17 jperaza Fix debug build after 16e0852
2018-08-17 jperaza Make a parameter a const reference
2018-08-16 jperaza Treat high_pc as an address for DW_FORM_GNU_addr_index
2018-08-15 mark Fix Windows client_tests GYP build after 88d8114fda3e
2018-08-14 gsvelto Fixed a typo introduced in revision 16e08520e6027df4bf1934abbfd5e1a088ffb69c
2018-08-04 gsvelto Add support for parsing the DW_AT_ranges attributes
2018-08-06 jperaza Set new ARM64 context flags
2018-08-01 jperaza processor: Fix memory leak after 88d8114f
2018-08-01 jperaza Define and use a a new MDRawContextARM64
2018-07-31 jperaza Rename MDRawContextARM64 and its context flags
2018-07-31 jperaza mac: Fix broken xcode projects
2018-07-19 ivanpe Add path_helper.cc and path_helper.h to dump_syms.xcodeproj.
2018-07-10 jperaza Update lss to a89bf7903f3169e6bc7b8efc10a73a7571de21cf
2018-07-09 jperaza ios: Fix build of exception_handler_no_mach
2018-07-09 jperaza Use hash_map and hash_set from __gnu_cxx
2018-07-06 jperaza iOS: disable using CFI in stackwalking

Created with:
  roll-dep src/third_party/breakpad/breakpad

Bug: 870908
Change-Id: Ib24fd9b8cb35783745191a3442bf8634e9444e7f
Reviewed-on: https://chromium-review.googlesource.com/1180598Reviewed-by: default avatarMark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584317}
      961cb03d
    • Christian Biesinger's avatar
      [layoutng] Handle overflow: auto more correctly · 3de2c595
      Christian Biesinger authored 
      We need to relayout whenever scrollbars change. The change in
https://chromium-review.googlesource.com/1162657 was not quite correct.

The change to CopyFragmentDataToLayoutBox is necessary to not break
virtual/layout_ng_experimental/fragmentation/auto-overflow.html

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I589d6a1bd1b3f06224e6c4aeae3e7cdf163206cc
Reviewed-on: https://chromium-review.googlesource.com/1178804Reviewed-by: default avatarEmil A Eklund <eae@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584316}
      3de2c595
    • Chromium WPT Sync's avatar
      Import wpt@203c34855f6871d6e55eaf7b55b50dad563f781f · ed4591ba
      Chromium WPT Sync authored 
      Using wpt-import in Chromium c8635904.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22867

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
bjonesbe@adobe.com:
  external/wpt/css/css-shapes
bugsnash@chromium.org, ericwilligers@chromium.org, meade@chromium.org, nainar@chromium.org, rjwright@chromium.org, shend@chromium.org:
  external/wpt/css/css-cascade
ericwilligers@chromium.org:
  external/wpt/css/motion
kojii@chromium.org:
  external/wpt/css/css-writing-modes
rego@igalia.com:
  external/wpt/css/css-ui

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I499748d80324c6854cf2862f5e410ea9a8fabd8d
Reviewed-on: https://chromium-review.googlesource.com/1180617
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: default avatarBlink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584315}
      ed4591ba
    • Alex Clarke's avatar
      Revert "Second try at using LazilyDeallocatedDeque instead of circular_deque in TaskQueue" · c8c4a655
      Alex Clarke authored 
      This reverts commit 6410ee3d.

Reason for revert: This is causing some crashes.

Original change's description:
> Second try at using LazilyDeallocatedDeque instead of circular_deque in TaskQueue
> 
> Previous patch: https://chromium-review.googlesource.com/c/chromium/src/+/1080792
> 
> Our usage pattern is unfortunate for existing queues such as
> base::circular_deque.  We tend to fill up an empty queue and then drain all
> those tasks until it's empty.  This means the queue yo-yos in size which
> confuses the memory reclamation schemes of most queues.
> 
> As an optimisation we introduce a deque specialised for TaskQueueManager's
> usage patterns. For performance (memory allocation isn't free) we don't
> automatically reclaim memory when the queue becomes empty.  Instead we rely
> on the surrounding code periodically calling MaybeShrinkQueue, ideally when
> the queue is empty.
> 
> We keep track of the maximum recent queue size and rate limit
> how often MaybeShrinkQueue actually shrinks the buffer to avoid unnecessary
> churn.
> 
> This yields a nice win on our microbenchmark:
> 
> Patch: us/run for 10000 delayed tasks with N queues
> 1 queue            4 queues           8 queues           32 queues
> 33448.166666666664 33215.75496688742   33484.34           34018.37414965987
> 33972.18243243243  33846.91891891892   34489.737931034484 34727.90277777778
> 33367.90666666667  33167.54304635762   33392.96           33906.89864864865
> 33392.13333333333  33107.17763157895   33340.18           33718.73825503356
> 37921.01515151515  39379.06299212598   38851.27906976744  39366.03125
> 38171.564885496184 37401.72388059701   37640.32330827068  37800.51127819549
> 34691.2275862069   34359.61643835616   34993.468531468534 35366.795774647886
> 35981.20863309353  35089.18881118881   38530.230769230766 39280.3515625
> 39262.8671875      36411.384057971016  33576.10067114094  33939.69594594595
> 37913.59848484849  38324.076335877864  38061.59848484849  39921.00793650794
> Average 35812.1871 35430.24471         35636.02188        36204.63076
> 
> ToT: us/run for 10000 delayed tasks with N queues
> 1 queue            4 queues           8 queues           32 queues
> 40459.540322580644 40536.04838709677  38994.573643410855 38696.2
> 39422.149606299216 39299.5            37888.18939393939  37874.74436090225
> 38419.70229007633  38025.742424242424 37844.41353383459  38020.469696969696
> 35052.72027972028  38147.80303030303  35504.89361702128  34138.02721088436
> 37096.77777777778  34942.541666666664 37003.529411764706 37579.60447761194
> 38818.67441860465  38233.068702290075 37978.628787878784 37867.57142857143
> 38455.49618320611  37903.05303030303  38106.143939393936 38129.5
> 40609.33064516129  37721.75187969925  34656.441379310345 34294.33561643836
> 35273.704225352114 34646.324137931035 34335.643835616436 34311.82876712329
> 35821.41428571429  35362.035211267605 37522.27611940299  35429.281690140844
> Average 37942.951  37481.78685        36983.47337        36634.15632
> 
> Percentage improvement
> 5.61570422	5.473437399	3.643388159	1.172472933
> 
> NB the reason the improvement goes down with the number of queues is because
> we're saving malloc overhead in the queue, but a constant number of tasks are
> posted across N queues.  This means the more queues we have in this test, the
> less loaded the queues are individually.
> 
> Change-Id: I975d7f864dc55715fb9f949ef65321da93e4cef4
> Reviewed-on: https://chromium-review.googlesource.com/1169043
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Commit-Queue: Alex Clarke <alexclarke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582586}

TBR=skyostil@chromium.org,alexclarke@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Id8290646dba1dcea9fcf92d490b9ce4ac63ae702
Reviewed-on: https://chromium-review.googlesource.com/1177561Reviewed-by: default avatarAlex Clarke <alexclarke@chromium.org>
Reviewed-by: default avatarSami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584314}
      c8c4a655