- 01 Sep, 2020 40 commits
-
-
Oleh Lamzin authored
Bug: b:158658869 Change-Id: I175ff7d28ae71d3f2d5d85e2f453fe74d692e92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387644Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#803632}
-
Sean Gilhuly authored
This is a reland of 7456a5e0 Use a custom lambda instead of implementing PrintTo(SkBlendMode). Original change's description: > Add names to tuple-parameterized tests > > Test names can only contain alphanumeric characters, plus underscores. > testing::PrintToStringParamName() stringifies tuples using characters > that aren't valid for test names. > > Add a similar function which joins each element using underscores. This > will generate valid names for test parameterization, provided each > element of the tuple can be written using valid characters. > > Bug: 1092945, 1117587 > Change-Id: I868b1d4040a93bdbf763dbb45b94ff15f181dd18 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376882 > Reviewed-by: kylechar <kylechar@chromium.org> > Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803182} Bug: 1092945, 1117587, 1123758 Change-Id: I4b3614bae62b557ac5da011f0dd5be1cb3256afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386388 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#803631}
-
Jan Wilken Dörrie authored
This change adds support for move-only types to base::test::RunOnceCallback. If a move-only type is passed to the constructor of RunOnceCallback, it will later be passed by move to the OnceCallback that should be run. This invalidates the action, and running it twice will result in a run-time crash. Bug: 752720 Change-Id: I43ca5e81e9323c7c374e67de14be2637fbfea589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379840 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#803630}
-
Oleh Lamzin authored
Bug: b:158658869 Change-Id: Ic920541850a6e29f9db04b84e333709cb74d5827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387642Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#803629}
-
Eric Orth authored
Android is moving to the UI launched on other platforms. Also add a disabled provider to better match the in-use configuration. Change-Id: Id7bae5694a3d34cdbdec9bae28f1488282cea7f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388147 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#803628}
-
Weilun Shi authored
Support a shorthand to use the variant's name to format the generated histogram's summary when the variant's summary attribute is omitted. Bug: 758782 Change-Id: I38d8659be97cdc26d3f0e0eb692bf423aded82b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387205 Commit-Queue: Weilun Shi <sweilun@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#803627}
-
Wei Li authored
Browser in kiosk mode enters full screen mode, which might be flaky on Mac. So we use faked platform fullscreen for this test. Bug: 920582 Change-Id: I04216a517c3a06957389fb21cabe4d8f4003a53a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382428Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#803626}
-
Maksim Ivanov authored
Fix typo found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I3d8d3235f5b25e42c0e9bba6c0c698fb92bcad5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386741Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803625}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a041d2d8848c..feb4151c5a11 2020-09-01 michael.liao@microsoft.com [Acessibility - Service Workers]: Making status an alert element If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1120099 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8bf5901c20f7de421a7369e1c91d119ab72365b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388420Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803624}
-
Daniel Nicoara authored
If the GPU process gets killed, display configuration changes. Ozone signals when the previous display configuration is invalidated. Use the signal to invalidate the cached state otherwise any display related call in between invalidation and the new state would cause a crash. Bug: b/167033029 Test: CQ Change-Id: Ib65dbb8141f70c24d9619400f3c8ebd236143c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385757Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#803623}
-
Peter Kasting authored
No functional changes, other than replacing a "320" with a Harmony constant of the same value. Bug: none Change-Id: Ia948c2fd608be294d5e0feadec7790f26941075a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385238 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#803622}
-
Matt Wolenetz authored
Upcoming worker-context-hosted MSE code paths will need to be distanced from relying directly upon the main-thread-hosted HTMLMediaElement. This change breaks one such strong dependency in MSE implementation by using the already-known execution context in MediaSource and SourceBuffer directly to record deprecation and usecounters, instead of consulting to use the UseCounter context of the attached media element. Also includes a necessary set of braces to fix a pre-existing style error flagged this time by presubmit. BUG=878133 Change-Id: I74b3ba0e9e11f866ffc1ec08376e045cee31efbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382678 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#803621}
-
Guillaume Jenkins authored
Adds a comment explaining the decision to use Apple's device identifier rather than the user-entered device name for cloud reporting. The goal is to prevent accidentally switching to the user device name in the future. Bug: 1123949 Change-Id: If03a6531662297a2598d970822ef04ecb4666787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388600Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#803620}
-
Scott Violet authored
ModalDialogManager had a couple of code paths that would calling onLastDialogDismissed(), even if the state hasn't changed. BUG=1121388 TEST=covered by test Change-Id: I33a5b3d3f43d9ec83760e24eec85d7b11f2b03ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386320Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#803619}
-
Aleks Totic authored
This fixes a very subtle bug: If table size is auto: - table assignable size is computed as sum of its column max widths - then, the size gets redistributed to columns - in the old code, even though the sum of columns matched table width exactly, each column would still recompute its value. - due to floating-point rounding error, a column might shrink or grow slightly. - shrunk column would cause text to wrap, when it should not I am having a hard time creating a reproducible test for this one. I've only seen it once in my temporary test file, and fixed it. Then I blew away my test, and decided to create a real test. I could never make my fp math fail in the new test. I am submitting a test, that might fail on some fp implementation, but not on my linux box. Bug: 958381 Change-Id: I3c5dbb5577b9c7b7f6f922974eb67fa743d947b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386285 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#803618}
-
Rouslan Solomakhin authored
This patch adds a test for JSON serialization of a very long string being passed into PaymentRequest API. Bug: 1110324, 1115091 Change-Id: Ia6690b2f41ff99190afed4431854515b167056b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348411 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#797165} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359155 Cr-Commit-Position: refs/heads/master@{#803617}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e2645e44ad6b..816506e1c600 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I833b8b1330a42a52e0ea5279ac04cc335d7000fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387206Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803616}
-
Yuwei Huang authored
Stream requests unlike unary requests don't set the request timeout, since that would simply destroy the stream if it hasn't been closed within the timeout. This CL adds a OneShotTimer to ProtobufHttpStreamRequest to run the StreamClosedCallback with DEADLINE_EXCEEDED if the stream does not receive its first data within the timeout. Bug: 1123199 Change-Id: Iaeb9c5c4f896d2a24378bb83c57d2d39ab49312c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386280 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#803615}
-
Vidhan authored
This CL creates and registers the Autofill States Data Component. Change-Id: Ie6ad98363764101859ec775f64781db4dce82afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332585Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#803614}
-
Rahul Singh authored
Problem: UnregisterShortcutsMenuWithOs() was being called twice as part of uninstalling an Extensions based PWA. Reason: A refactor introduced OsIntegrationManager::UninstallOsHooks as part of which we call UnregisterShortcutsMenuWithOs(). https://chromium-review.googlesource.com/c/chromium/src/+/2294332 When an extensions based PWA is uninstalled, existing code in ExtensionService::UninstallExtension triggers observer code in BookmarkAppRegistrar::OnExtensionUninstalled which in turn calls out to OsIntegrationManager::UninstallOsHooks(). So, we end up with 2 calls to UnregisterShortcutsMenuWithOs(). One from OsIntegrationManager and the other from ExtensionService. Fix: Removed the second call to UnregisterShortcutsMenuWithOs() in ExtensionService::UninstallExtension. Bug: 1123777 Change-Id: I7e89c319aa8e346a3bdfe04cff62a008ce466741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386434Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Rahul Singh <rahsin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#803613}
-
Kalvin Lee authored
This change adds a new metric for recording the success rates in setting up Zeroconf printers in Chromium OS. Bug: chromium:1077326 Test: none Change-Id: Ie005fb686592177e430c65564663cb8be53eba2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382883Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Kalvin Lee <kdlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#803612}
-
Yulun Wu authored
Inkdrop color and opacity have been moved to ash_color_provider and are now adapted to system color scheme. Bug: 1110757 Change-Id: Id88812a12a11e510a3ea957c465e7754ebd95ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382222Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803611}
-
Donn Denman authored
Check the context for being null. Also make a few members final. BUG=1123514 Change-Id: Iade8ec0318464ef1e190aae46da1b8c6634be76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386199 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#803610}
-
Morten Stenshorne authored
The containing block of a spanner is always the multicol container itself. Bug: 1123710, 1123792 Change-Id: I3486e6ad2484396548f8682c842a6fb8a731e058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386799Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#803609}
-
Jared Saul authored
This bubble/button still exist because the Butter Status Chip is not yet fully rolled out. Once it is, these metrics can likely be removed. Fixed: 1109811 Change-Id: Ica83690035c2c880216a98663edcc926557e149a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386384Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#803608}
-
Erik Chen authored
This reverts commit da75e6c8. Reason for revert: No longer want this functionality. Original change's description: > Enable lacros on stable channel. > > Change-Id: I3a3efe60a3b53bbd6f431a257bbf8e6266f903e8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377067 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Auto-Submit: Erik Chen <erikchen@chromium.org> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801861} TBR=erikchen@chromium.org,hidehiko@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I8e5affae1020f948b3b18be3af858fd9ba052a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388345Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#803607}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1c4a7f780f10..be53792880bc 2020-09-01 rharrison@chromium.org Roll 9 dependencies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I3e4dc368bca8378d43c422414c78a212d37c45a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388429Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803606}
-
Matt Wolenetz authored
Moves the core MediaSource interface into the core MediaSourceAttachment interface, centralizing much of the core interaction with the MSE API into the attachment interface. Concrete implementations of MediaSourceAttachments will perform the necessary proxying of behavior between HTMLMediaElement and MSE, which in future changes will include cross-thread attachment support. Implements a concrete same-thread modules MediaSourceAttachmentImpl. This refactor to proxy the MSE API via the attachment and move attachment and tracer implementations into modules has essentially unchanged externally visible behavior (other than debug log messages, for example.) Updates the core HTMLMediaElement to use the attachment interface with the MediaSourceTracer to accomplish existing MSE API operation. The next change will update the internals of the modules MediaSource, MediaSourceAttachmentImpl and MediaSourceTracerImpl to similarly communicate with the media element via the attachment rather than directly to the media element. That part is kept out of this initial change to reduce review complexity here. BUG=878133 Change-Id: Id90f3b5babe87907f884268dffcca799356553f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380571 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#803605}
-
Carlos IL authored
This reverts commit c82e8fea. Reason for revert: Bugs remained after this CL, so both bidi handling CLs will be reverted until the bugs are fixed, we'll also merge a change that disables elision for bidi URLs to 86. Original change's description: > Reset simplified_domain_bounds_ on each animation start > > simplified_domain_bounds_ is calculated on animation start via union, > but was never being reset, this was causing bugs when an animation is > reused (e.g. when switching tabs, or with URLs that redirect). This > adds a reset. > > Bug: 1117631 > Change-Id: I99d1eba536f39ad3c16fc09eca0aa79788b4bb62 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382893 > Commit-Queue: Carlos IL <carlosil@chromium.org> > Commit-Queue: Tommy Li <tommycli@chromium.org> > Auto-Submit: Carlos IL <carlosil@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802826} TBR=tommycli@chromium.org,carlosil@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1117631 Change-Id: I4af20299fbf5e4351c51f468e48d50f53554a2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387482Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#803604}
-
Weilun Shi authored
Update README and one-pager for the latest pattern histogram instructions. Reuse/Remove some of the legacy histogram-suffixes docs. Change-Id: I0bc63ea8d419c5ab861d5d64f39ecc150c6ad8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380344 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#803603}
-
Joshua Pawlicki authored
This requires opening global_prefs a bit earlier. The code will release global_prefs early if it determines qualification is necessary, and will also release it before attempting to self-uninstall (this was an oversight from earlier). As a side-effect of this CL, a candidate will not be able to start qualification while the active updater is running, since it cannot open global_prefs in that case. I also introduced a specific server exit code for when the server shuts down post-qualification. Bug: 1122739 Change-Id: Iad33f88ca438aee3fa2f5f0daf1105e2712baf0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385795 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#803602}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4202dc47a417..928a02b1527d 2020-09-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from b89144a4 to 09ccc6e0 (370 revisions) 2020-09-01 mtklein@google.com debug LSAN failures If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: Ib6ff5a0bfac910c23b52e2217e368ba62bee4008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388428Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803601}
-
Deepanjan Roy authored
We're running system health benchmarks on FYI bots to support development of experimental TBMv3 metrics. We realized the abridged version didn't include any accessiblity story, so we could not test the accessibility metric. In general, since we're interested in making sure TBMv3 metrics work well across a wide range of scenarios, it's best to turn on the non-abridged version so we can detect any strange errors early on. If the load on the bots proves to be too much we can rollback and manually pick a better subset of stories. Change-Id: I7c2538b36b41b414a33ade5749a2953603602914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388262Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Deep Roy <dproy@google.com> Cr-Commit-Position: refs/heads/master@{#803600}
-
Thomas Lukaszewicz authored
This CL updates the Tab Search keyboard shortcut to use the same code path as the TabSearchButton. This is necessary to ensure that the button is triggered correctly when the UI is invoked and prevents multiple instances of the UI from being created per browser window. Bug: 1099917 Change-Id: I3f31b0c6ba1620ca77a2197bd71a1241b904bb36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387199Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#803599}
-
Kyle Horimoto authored
Removes oppressive language from //chromeos/components/tether. Bug: 1123072 Change-Id: I570c8e252828e6688cbb854ffedf28a7434521e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387340 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#803598}
-
Kyle Horimoto authored
Renames |master_symmetric_key| to |session_symmetric_key|. Bug: 1123072 Change-Id: I1a13116206214e95d6bd43e3d9fc01b5b7ac4811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386462 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#803597}
-
Mila Green authored
Bug: 1112522 Change-Id: Idcae3a8103e817fd1c70394a21680df4e6621163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387431 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#803596}
-
Fabio Rocha authored
Change-Id: Iec9da11c762c8090a8ef77110c802d766eb9704d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387486Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#803595}
-
Evan Stade authored
When an intent attempts to start MediaSessionService but WebLayer has not been loaded, the service will no-op instead of throwing an exception. Bug: b/167388918 Change-Id: I0f191d0f620016c8ee072e0953d10ad1c257fa15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388404Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#803594}
-
Becca Hughes authored
This is a reland of 3bd3ee29 TBR=dcheng@chromium.org,msramek@chromium.org,steimel@chromium.org Original change's description: > Add public side implementation of "frameless" module > > Using the frame on the NTP to load the data is too > slow for what we want to do so this removes the frame > and does the fetching in C++ instead. The deserialization > and business logic is still handled by the JS but on > the NTP instead of in a child frame. > > BUG=1121360 > > Change-Id: Idad8c9403fd51cccaf4a8edff31d244ac2642432 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373384 > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803181} Bug: 1121360 Change-Id: Id38f58f88d624002ee06a2e41fcc38316db92ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387197Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#803593}
-