Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 20 Jun, 2018 35 commits
  3. 19 Jun, 2018 5 commits
    • Steven Holte's avatar
      Disable CrossOriginFrameEnterLeaveCloseWindow test. · 5ded30e4
      Steven Holte authored 
      TBR=mlamouri
NOTRY=true

Bug: 854349
Change-Id: I97e80d2798a902bcdece04cf74deb7138a20f2af
Reviewed-on: https://chromium-review.googlesource.com/1107173Reviewed-by: default avatarSteven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568651}
      5ded30e4
    • Devlin Cronin's avatar
      [Extensions] Don't automatically skip extension subtests · 26746893
      Devlin Cronin authored 
      As a workaround for flakiness in https://crbug.com/177163,
crrev.com/9b393cf4 made all
extension api subtests exit immediately for windows debug builds.
However, this can lead to a number of issues:
- Unnecessarily disabling tests that use RunExtensionSubtest that
  *aren't* flaky
- Requiring tests that rely on RunExtensionSubtest() as only a portion
  of their validation to also be disabled.
- Masking flakiness by having the test return true (instead of show up
  as disabled for a platform).

Instead of doing this, we should find and disable specific flaky tests
on specific platforms.

This CL removes the logic to suppress extension api subtests.

Sheriffs note: Since this has passed the CQ, this CL does not directly
disable any tests. Any tests found to be flaky on Windows Dbg as a
result of this CL should be disabled on Windows Dbg directly, rather
than reverting this CL. (They were flaky before, and simply not run.)

Bug: 177163

Change-Id: Id44a3b9ffd1882e15c1251a9665ffdf99a259373
Reviewed-on: https://chromium-review.googlesource.com/1106284Reviewed-by: default avatarIstiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568650}
      26746893
    • Ned Nguyen's avatar
      Rename pixel shards map to match with commandline flag · 90a2d3e7
      Ned Nguyen authored 
      
NOTRY=true  # no tests on CQ cover this
TBR=eyaich@chromium.org

Bug: 713357
Change-Id: I252064713b2c8e5584f9db2fec35e58c0bf8a5f3
Reviewed-on: https://chromium-review.googlesource.com/1107213Reviewed-by: default avatarNed Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#568649}
      90a2d3e7
    • Chromite Chromium Autoroll's avatar
      Roll src/third_party/chromite efd58885b78d..9cccc5ce4fb9 (7 commits) · 84e07da8
      Chromite Chromium Autoroll authored 
      https://chromium.googlesource.com/chromiumos/chromite.git/+log/efd58885b78d..9cccc5ce4fb9


git log efd58885b78d..9cccc5ce4fb9 --date=short --no-merges --format='%ad %ae %s'
2018-06-19 ayatane@chromium.org sysmon: Ignore chromeos3-* devservers
2018-06-19 dgarrett@google.com gclient: Stop using implicit git_cache_dir.
2018-06-19 lhchavez@google.com Add 'signed' image type examples / docs to cros flash
2018-06-19 dgarrett@google.com chromeos_config: Move toolchain builders to swarming.
2018-06-19 dgarrett@google.com build_status: Remove config_lib.UseBuildbucketScheduler.
2018-06-19 yunlian@google.com cros_gdb: set debug-file-directory for simple chrome.
2018-06-19 vapier@chromium.org pylintrc: convert warnings list into readable ids


Created with:
  gclient setdep -r src/third_party/chromite@9cccc5ce4fb9

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:853866,chromium:853391,chromium:852017,chromium:853969,chromium:853025,chromium:843275,chromium:None
TBR=chrome-os-gardeners@chromium.org

Change-Id: I38b6b86c7271b9ca0ec2148faa144816e012ac81
Reviewed-on: https://chromium-review.googlesource.com/1107006Reviewed-by: default avatarChromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568648}
      84e07da8
    • Sylvain Defresne's avatar
      Unregister SyncObserver on shutdown · ddd2927c
      Sylvain Defresne authored 
      ProfileSyncService DCHECK in Shutdown that all observer have
been unregistered, so refactor DesktopPromotionSyncService
to unregister its observer in Shutdown.

The refactor consist in removal of the helper observer class
DesktopPromotionSyncObserver that is folded in the service
as it makes it easier to track whether the observer is still
registered (the alternative is to introduce a delegate class
that is implemented by the service and invoked by the observer
when it needs to unregister). As the class had no behaviour
at this point, merging it with the observer is simpler.

Also fix the fact that desktop_metrics_logger_initiated_ was
not initialized in DesktopPromotionSyncObserver constructor,
so the check in OnStateChange was undefined behaviour (most
likely the result would have been that the variable was read
to be non-false).

Mark some local variable as const and avoid reading prefs that
are not used.

Bug: 854118
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8d5d2bcb09da0430d3a08d79058bdecd047f3f28
Reviewed-on: https://chromium-review.googlesource.com/1105978
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: default avatarJustin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568647}
      ddd2927c