GitLab

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a7b1f947eb0a..b780372797ea


Created with:
  gclient setdep -r src-internal@b780372797ea

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ifb8873988fc58c90d9b7fa57bfca011ccc60d2e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083331Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746008}

Using wpt-import in Chromium 34b020bf.
With Chromium commits locally applied on WPT:
d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/resources

NOAUTOREVERT=true
TBR=smcgruer

No-Export: true
Change-Id: I263d6707a99cf8502c17f45dfd35356f0556c825
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083053Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746007}

This cleans up Mixed Content Site Setting (aka shield removal) from

launched. This still leaves the feature behind a flag in case it needs
to be used as a killswitch (that can be cleaned up after M82 branches).

chrome: //flags since the flag has already expired and the change
Change-Id: I413163573ee73953d354f6c0ed5c7be50d2644e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080896
Auto-Submit: Carlos IL <carlosil@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746006}

The identity service project was started circa 2017 as part of
Chromium's servification efforts. The initial refactoring of
identity code into the C++ signin::IdentityManager consolidated
chrome's identity logic into a single location, improving
the understandability and maintainability of the code. However,
in late 2019 shifting priorities led to further work on the
mojo service part of the project being deprioritized.

By early 2020 there were only 2 clients of the mojo service,
Assistant and DriveFS. Both ran only on Chrome OS and only in
the browser process. These were migrated to use the in-process
C++ IdentityManager.

Since the mojo identity service now has no clients, and no new
clients are planned in the immediate future, delete it.

Bug: 654990

Change-Id: I9d86fe3f5d4a6435bd2440e859af89af031483c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079795Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746005}

|Profile#getLastUsedProfile| is deprecated and replaced with
|Profile#getLastUsedRegularProfile|. This CL updates LocationBarModel
class.

Note: This change is only code clean-up, does not change any behavior.

Bug: 1041781
Change-Id: Id9a6647395aac65bafd543529215fa827e5b1869
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067070Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746004}

Note that some were actually removed earlier, but not marked as obsolete.

Bug: 1025210, 1037097
Change-Id: Ia6b85fff5a409655c6e73fe52ec00880806bc788
Fixed: 1025210, 1037097
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074922Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746003}

In anticipation of moving the compositor ownership inside blink adjust
the BeginFrame method so it doesn't take an argument to determine if
recording of UMA/UKM should take place. It can easily be queried inside
blink itself.

Change-Id: I48a749fad7f6b051e7bdd0a556611871b563d4f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080434Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746002}

If the browser is using an RTL language, the zoom toolbar should be
displayed on the bottom left of the PDF viewer. As an extension, the
PDF viewer gets its UI directions after loading translated strings from
the backend with a latency. Due to this latency, the zoom toolbar will
first show up on the right side of the PDF viewer by default and then
switch to the left side after it gets all UI directions from the
backend.

To fix this issue, this CL will hide the zoom toolbar until all
translated strings are loaded from the backend.

Bug: 1038022
Change-Id: I6f49b888466fe9f4717c89c7b996feeda2777380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078747Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Hui Yingst <nigi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746001}

This change adds thread_checker in GpuChannelManager to verify methods
are called on GPU thread.

This change also fixes a potential problem when gpu channel isn't
created successfully.

Bug: 978804
Change-Id: I7661f08d49a5af2ff3fb0a067357ad7fcb8e28ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083392
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746000}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fee07500..ff1896a1

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I259e5905c1ad8056b059eeafcf0f2ea3b57b88b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083045Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745999}

This should likely have been window.speechSynthesis

Bug: None
Test: Screen reader on chromecast display assistant
Change-Id: I879bc288d1592dcc2e92e2700d0f751ae0790335
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075046Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745998}

Bug: 1046181
Change-Id: I01effb7bd759b20932768a57ed1c80c74c26ad94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067415
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Auto-Submit: bttk <bttk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745997}

The Mac implementation uses the out of process service.
Win still doesn't have that, so the implementation is unchanged.

Bug: 1048653
Change-Id: I70227020f79fc164b361cfcb998a041528a89dd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078907
Commit-Queue: Mila Green <milagreen@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745996}

This test leaks memory.

Bug: 1057340
Change-Id: Ic2ef4b97e181a940f640ddd618c00fde2fee0149
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082894
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745995}

https://skia.googlesource.com/skia.git/+log/b7a3291dd131..777e146564b4

git log b7a3291dd131..777e146564b4 --date=short --first-parent --format='%ad %ae %s'
2020-03-02 bsalomon@google.com Remove domain-uses-decal code from GrTextureProducer
2020-03-02 reed@google.com Do we still need bones on vertices for canvas
2020-03-02 borenet@google.com [recipes] Revert DM changes due to broken result files
2020-03-02 borenet@google.com [recipes] Speculative fix for empty properties

Created with:
  gclient setdep -r src/third_party/skia@777e146564b4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC herb@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: herb@google.com
Change-Id: If645ca461f7acd30c36b07787ab2faa69df8b3c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083333Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745994}

This will help debug why exactly WebLayer is not getting package id
0x02.

Bug: 1045262
Change-Id: Ib05d3eb81bf25120bf34d4997440c73cbbbdedb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080779Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745993}

Fix TSAN data race found in Edge TSAN environment

Bug: 1055898
Change-Id: Ic8ef76e28bce4c2190dc5be66e21605f744a9a07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072920Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Callum May <camay@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#745992}

Bug: 1007815
Change-Id: Iafc5e48f25325e51b3733a3e7b5a5fe436e0954c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080246Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Anna Malova <amalova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745991}

This patch clears a frame name when a BrowsingInstance swap
happened because of COOP. This happens as follows:
1. All COOP navigations force a browsing instance swap.
2. When swapping browsing instances, a new provisional frame needs to
be created.
3. When creating a new provisional frame in response to a COOP-forced swap, the
   frame is created with a FrameReplicationState with an empty name/unique_name.
4. When the provisional frame is committed, this is detected in CommitPending(),
   which then clears the name/unique_name on the FrameTreeNode and replicates
   the name updates.

- Fixes an issue in blink where the provisional frame would use the
previous name instead of the replicated_state one passed as an argument.
- Remembers when we had a switch that was COOP related and stores this
state in the NavigationRequest.
- When we create a RenderFrame and NavigationRequest has this state, we
pass an empty name to the RenderFrame creation in the renderer.
- When we get a DidCommit from the renderer and NavigationRequest has
this state we update the name on the browser side in the FrameTreeNode.




Together this should ensure that the new RenderFrame, as well as all the
proxy references to it have the correct empty name at the end of the
navigation.

Bug: 1018655
Change-Id: I9262ba49d3c883e55a29aba1ca0d4e2011a1289c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027456
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745990}

Decimals are similar to floats, except that they have a maximum of
12 integer digits, and three fractional digits. They are represented as
doubles for storage.

This brings that portion of the implementation in line with the latest
spec drafts (including serialization, which has been fixed since draft
15.) Tests are updated with the latest canonical tests from
https://github.com/httpwg/structured-header-tests, as well as additional
non-serializable-float tests from
https://github.com/httpwg/structured-header-tests/pull/35.

Bug: 1048754
Change-Id: I0205b37e25c3f1f0bcb0425f8a8588ec9c9e4b15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055411
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745989}

This eliminates questionable practice of switching timeDomain while
performance metrics collection is enabled by allowing us to remove
Performance.setTimeDomain() method.

timeDomain argument is optional and has default value of 'timeTicks'

Bug: 1056306
Change-Id: I085bb5939d04eba65f3f6cf07f6a4d8f94fa32a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076427
Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745988}

We continue to need those to monitor DirectWrite stability in the field
(for font local matching, font fallback, browser side DWrite IPC host).

Change owner for sandbox startup UMA.

Fixed: 1053104, 1052966, 1052965, 1052964, 1052963, 1052962, 1052961, 1052960, 1052959, 1052958, 1052928, 1052927
Change-Id: I6f5782619a2236bf8f0f20c50280325fd820c19a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082375Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745987}

- Added toast to be displayed when the QRCode doesn't correspond
to a URL.

- Fixed issue where camera would read QRCode even when the screen was
on share tab.

Change-Id: Icc90903310bf4fb12c36e336cfe7d174bc7b4246

Fixed a few bugs

Change-Id: Id75a9e785f33b15e596663b1f9e0de1a17a6cdec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079093
Commit-Queue: Tanya Gupta <tgupta@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745986}

This allows the embedder to run the beforeunload handler, if any,
before closing a tab.

Bug: 1055540,1025256
Change-Id: I894256d0a05f11d58fa4234265beb03b34a019b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072922
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745985}

Original: r745386 http://crrev.com/c/2041759
Revert: r745843 http://crrev.com/c/2082658

Fix "no-op build wasn't a no-op" error on bots using ninja's restat tool

Make sure to "touch" the new file so that access, modify and change
times are always newer than the source file's, otherwise Modify time
will be kept as per the call to shutil.copystat(), causing unnecessary
generations of the output file in in subsequent incremental due to
ninja considering it dirty.

Original change's description:

New script to downgrade .mojom files from the new to the old mojo types

Following the discussion in chromium-mojo and platform-architecture-dev,
we're proposing to add this script to the chromium repository so that
external repositories that still depend on the old mojo types (e.g.
Android's and ChromeOS's libchrome repos) have a simple and maintained
way to downgrade Chromium's .mojom files to the old syntax, while they
can't support the new one.

This CL includes a new mojom_types_downgrader.py script that can be
integrates with those external builds requiring it, plus the necessary
unit tests to guarantee that the downgraded files can still be parsed
correctly by the bindings generator (i.e. mojom_bindings_generator.py).

For extra context, see the relevant discussion in the chromium-mojo ML:
https://groups.google.com/a/chromium.org/d/msg/chromium-mojo/BRK0Xeu7bgQ/z00hkpaGEQAJ

Bug: 1035484, 1057525
Change-Id: Ib7dd91405e1b26a6ba6e8b0c40b97f9afca27df5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082513Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#745984}

Done through 2 refactors:
- FileContents is now declared in the header to be used by tests.
- GetSha256Blocking is now in the header as a static function.

Bug: 1041890
Change-Id: I15e6ecf6938324271e2bf018db57d0071d7d0072
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078973Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745983}

This CL update the profile passing to TrackerFactory from
ToolbarManager. Currently, it is always regular profile, however it is
not safe because of possible data leakage from incognito to regular
profile.

Therefore, this CL uses |isIncognito| boolean created from current
tab model to get correct profile object(i.e., regular or
off-the-record profile).

Bug: 1041781
Change-Id: Ie9942d02a345cd6a755da1d8fd0b34089b22425b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075417Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745982}

Following r741744 <crrev.com/c/2048707>, this patch fixes
the block offset of a positioned object whose containing box
is an inline box in split inlines.

Bug: 982194
Change-Id: I3bcb9d8c6618b315abfddc0fe25284dd5a059a91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081718
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745981}

Most of the include are obsolete. The remaining one can be removed
as all the code is compiled with ARC thus there is no need to have
a C++ smart pointer to call retain/release when the compiler can
do it automatically.

Also add missing guard checking that the file are correctly build
with ARC (automatic reference counting) enabled.

Bug: 1051997
Change-Id: Ia19d1e41aa16106ffebd87a0a3dd2815c741d8c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074297
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745980}

This CL is a logical no-op.

It manually covers the use cases the script
(https://crbug.com/1026641#c22) didn't cover in
https://chromium-review.googlesource.com/c/chromium/src/+/2026350.

A few of the affected files were also migrated to
content::GetUIThreadTaskRunner() whenever surrounding code consistency
was at stake (but the bulk of that migration is staged to happen after
this one so this wasn't a priority in this batch).

Most files intentionally kept base/task/post_task.h as an include. It is
still required because of a cyclical dependency during the migration
preventing base/task/thread_pool.h from implicitly providing
base/task/task_traits.h to its users (callers that explicitly store
TaskTraits and include task_traits.h don't have this problem). The
post_task.h include will be cleaned up in a later phase.
This CL was uploaded by git cl split.

TBR=bradnelson@chromium.org

Bug: 1026641
Change-Id: I0278c69144f7aee55a3abba0e405d141add05261
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076358
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745979}

This patch means replace selectable_list_layout_row_padding with
default_list_row_padding. It is used for more generic value.
This has been discussed in other patches[1].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2049424

Bug: none
Change-Id: I4705c0e1208d094b4ce8704ed81dcffb6f32b7e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074998Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com>
Cr-Commit-Position: refs/heads/master@{#745978}

Change-Id: I6f8fa5a4670f25ce7ca77fe8819671f989645f64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080433Reviewed-by: Rohit Agarwal <roagarwal@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745977}

When limit was introduced it was set to 3 seconds, but that's still a
long wait, especially for repeated user actions that may result in long
scroll distance, such as stepping between find-in-page matches.

R=bokan@chromium.org

Bug: 852549
Change-Id: If866c528c0358a6ae27f6c90f16e3a5e4bbb9302
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044270
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745976}

This diff was generated by running:

  find . -type f -print0 | xargs -0 perl -pi -e "BEGIN { \$/ = undef; } s/assert_throws\(([ \n]*'[A-Za-z_]*') *(, *.)/assert_throws_dom(\1\2/gs"

Then manually correcting some expectation files and fixing up whitespace.

Bug: 1051932
Change-Id: I9105cb0363f3f39b7543d360ea3e3c7e06655527
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079143
Auto-Submit: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745975}

This diff was generated by running:

  find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*)([A-Za-z]*Error) *\(\) *(, *.)/assert_throws_js(\1\2\3/gs'

Then manually fixing up whitespace.

Bug: 1051932
Change-Id: I65c91797b66c467ded3eb8c5ba4e8fdb3207921b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079831
Auto-Submit: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745974}

It's simpler to just pass an initializer list.

Change-Id: Ifed1b626f694f4987ebb6f30a2df24c147e8a48e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078910
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745973}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b60935270c47..5f96597ad93d

git log b60935270c47..5f96597ad93d --date=short --first-parent --format='%ad %ae %s'
2020-03-02 szuend@chromium.org [utilities] Use Map instead of Array for DOMNode attributes

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@5f96597ad93d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1050549
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I4cdd1b1d428ac108a6933fdb061d260ce045f920
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083220Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745972}

arc_vm_client_adapter_unittest.cc will soon start calling StartJob()
twice in its ARC startup sequence, and this change will allow the
test code to have more control over which job(s) fail to start.

BUG=None
TEST=components_unittests

Change-Id: I34ca62a617e5450b98eeb7aea65d5d4b472b3602
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078977
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745971}

CL 1715764 introduced a performance regression, where a replaced
animation would not be composited for the initial frame.  This was
caused by a bug in calculation of the pending state, which in turn
caused a replaced animation to be flagged as incompatible.  The bug was
fixed in CL 1728074. This patch introduced a test to ensure that the fix
does not regress.

Bug: 992408
Change-Id: Iab210ca9b525773ebb2c0a6f28d63f25c0b574e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080445Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745970}

This CL adds a histogram to record the displayed sWAA value in
|chrome://settings/syncSetup| for sync users.  We neglect the short
period of time while sWAA is not fetched or is being fetched. In case of
failure to fetch sWAA, we display nothing.  In case of success, we
either show on or off with an explanation of the reason for which sWAA
is off. The histogram is recorded every time sWAA is
calculated/refreshed.

Bug: 1050070
Change-Id: I6ad75626edc590707c2594d86db4cb61a2069196
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062421
Commit-Queue: Monica Basta <msalama@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745969}