- 21 Dec, 2020 21 commits
-
-
Tal Pressman authored
This reverts commit 1af362f4. Reason for revert: The rollback did not fix bots, so I am relanding the CL. Original change's description: > Revert "Wait until safe time to create web document" > > This reverts commit 593304b4. > > Reason for revert: Suspect it caused failures in content_browsertests > Accessibility tests. > > Original change's description: > > Wait until safe time to create web document > > > > TBR=kinuko@chromium.org > > > > Bug: 1156939 > > Change-Id: I23443fc4461dc61223fef249bac109a8b7e8183e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586233 > > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#838244} > > TBR=dmazzoni@chromium.org,aleventhal@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1156939 > Change-Id: Iac0282f6e1a24119a67dacf81c5e1c33ed303d33 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596292 > Reviewed-by: Tal Pressman <talp@google.com> > Commit-Queue: Tal Pressman <talp@google.com> > Cr-Commit-Position: refs/heads/master@{#838585} TBR=dmazzoni@chromium.org,aleventhal@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,talp@google.com # Not skipping CQ checks because this is a reland. Bug: 1156939 Change-Id: Ib7571aa00acc5c1202abdbebfb40e2180aba36e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598303Reviewed-by:
Tal Pressman <talp@google.com> Commit-Queue: Tal Pressman <talp@google.com> Cr-Commit-Position: refs/heads/master@{#838596}
-
John Palmer authored
BUG=b/175820571 BUG=b/175820584 Change-Id: Ia143818e70d325c03c9e0b8b8c04de5de41d4de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595561Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Commit-Queue: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#838595}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e9f7d2179637..2622d88609d1 2020-12-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8622b47e8bf9f35c98c19ab9cfaa4ee55f84b43f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599456Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838594}
-
Bao-Duy Tran authored
Bug: 1159297 Change-Id: I7f940cc3403c52e1cb2fe3eaf1f5f99d4284bd74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592851 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#838593}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I57ae09e0f083b7b6dd3617a2a6f971f1e04677ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597649Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838592}
-
Kinuko Yasuda authored
The change https://crrev.com/c/2577150 missed to set this value. This also adds a unittest to check this (which fails without the fix). R=rbpotter@chromium.org, thakis@chromium.org Bug: 862175 Change-Id: I6548804749de242d6ccf1ec4b4c20547dfba2d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597249Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#838591}
-
Tal Pressman authored
This reverts commit ef97c140. Reason for revert: Suspect this is causing various AssistantBrowserTest tests to fail. Sample failure: ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/10788/overview Manually adding the failing bot (linux-chromeos-chrome) shows that the tests pass. Original change's description: > Simplify Libassistant startup (and fix crashes) > > Currently starting Libassistant happens in 2 steps: > 1. (On background thread) ServiceController::Start() creates the > |AssistantManager|. > 2. (On main thread) ServiceControllerProxy::FinishAssistantStart() > sets some extra fields on |AssistantManager| and calls > AssistantManager::Start(). > > This causes a race condition if Libassistant is immediately stopped, > as that happens on the background thread and can collide with step 2 > above. > > To prevent this from happening, this CL collapses both starting steps in > a single step that runs on the background thread. We do this by > registering a callback which is called by the background thread in step > 1 above. > > This callback is temporary but necessary as some parts of the > initialization code still use objects that have not been migrated to the > Libassistant mojom service yet. > > Bug: 1157177, b/171748795, 1128032 > Test: chromeos_unittests "Assistant*:ServiceController*" > Change-Id: Ifab9705839ad5d3e5c9f2b7f7fba4c336b9f7c9d > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594090 > Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838277} TBR=xiaohuic@chromium.org,wutao@chromium.org,meilinw@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,jeroendh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1157177 Bug: b/171748795 Bug: 1128032 Change-Id: I252bd0f14d662eadfd9fb61b8972e34a460fb040 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Tbr: jeroendh@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597250 Commit-Queue: Tal Pressman <talp@google.com> Reviewed-by:
-
Bao-Duy Tran authored
This field is never used anywhere, other than asserting that it must always carry value "ime" (!). All parsing and validation is unnecessary. The field's existence is unnecessary and may hinder the flexibility for future work. It'd better be gone in the spirit of YAGNI "you aren't gonna need it". Note that the specs for these manifests have never been formally specified or published anywhere. Also, this cleanup is fully backward compat even for 3P, because the field is never really used. Bug: 1134465 Change-Id: Ied6e1ad30a9ab6f08091a7d31a9c3f3124989a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592072 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#838589}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608480487-c8d6a020311436cdd2559a40dfb31e24c333522a.profdata to chrome-mac-master-1608508387-4c99c0c6e0807bf68be573ad8b3c8353e1fc0e76.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iaee829f920eea9f0d55b7e3d8edc3395c58b3528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596553Reviewed-by:
-
Joel Hockey authored
If a path is already shared, we can avoid the extra seneschal dbus call. This code was originally written before GuestOsSharePath::IsPathShared() was available. Change-Id: Ia92dcad3e3202f40606a0e8b7620e0ea76847c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596472 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#838587}
-
Tal Pressman authored
Change-Id: I10cd12f9b6356254acaa66639dfaec8b8a0465b2 Bug: 1160594 Tbr: dom-dev@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596946Reviewed-by:
-
Tal Pressman authored
This reverts commit 593304b4. Reason for revert: Suspect it caused failures in content_browsertests Accessibility tests. Original change's description: > Wait until safe time to create web document > > TBR=kinuko@chromium.org > > Bug: 1156939 > Change-Id: I23443fc4461dc61223fef249bac109a8b7e8183e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586233 > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838244} TBR=dmazzoni@chromium.org,aleventhal@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1156939 Change-Id: Iac0282f6e1a24119a67dacf81c5e1c33ed303d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596292Reviewed-by:
-
Yuichiro Hanada authored
WindowEventDispatcher can defer the processing of mouse/touch events until a non-mouse/touch events comes or it's explicitly released. If a target window of the deferred window destroys another window in their event handler, the destruction is also deferred. It can cause use-after-free if the following non-mouse/touch event's target is the window being destroyed because searching of the target window happens before the release of the deferred mouse events. Bug: 1099985 Test: aura_unittests Change-Id: Ia386bb99edd1374d1d39038ff44b3bfc73c26fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576983Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#838584}
-
Thanh Nguyen authored
Since LSS has been sandboxed and clients are using new sandboxed LSS, we need to clean up the code. This CL cleans the unused sync code. Design doc: go/lss-sandboxing Implementation plan: go/lss-sandboxing-impl Bug: 1137560 Change-Id: If8347e621b0169ff15062deb7a8953c1c76bf6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594747Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#838583}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/02a278d97bec..d63a6aaf6fb4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC talp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: talp@google.com Change-Id: Id8a3ff01d823e825bd5131e9f64909dbd39202d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599004Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Gyuyoung Kim authored
This CL replaces all uses of the native ContextMenuDataMediaType enum class with a new Mojo ContextMenuDataMediayType enum in order to make blink public layer slim. The new Mojo enum is added to public/mojom/context_menu/context_menu_data.mojom file. Bug: 919392 Change-Id: I1be31ed41cfe8808b953a14b7732a7addbb5d5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596289Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#838581}
-
David Munro authored
We track time with a GUI window in foreground and time with Crostini running in the background. We do not yet track time with a terminal browser window in foreground. Note that the actual metric-emitting code is at https://osscs.corp.google.com/chromium/chromium/src/+/master:components/guest_os/guest_os_engagement_metrics.cc;l=177;drc=4cc56e90bebaf1df23e738c19b88463cb4e2f366 Bug: chromium:1007139 Test: Deploy, use Crostini, check chrome://histograms Change-Id: Ib7b0d6d88d7c0a4d94fcb3c399c41a243ccccbe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586649 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#838580}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I66136ef28b4d4fd1af3bfc96a37dfc76f59167e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599227Reviewed-by:
-
Bao-Duy Tran authored
These are read from manifest.json but never used afterwards. They'd better go away in the spirit of YAGNI "you aren't gonna need it". There's no backward compat issues, even for 3P, because corresponding configs are never used. Not to mention the "schema" of these manifests has never been documented or specified formally anywhere. Existence of bloated but unused specs hinders flexibility for future work. Certain fields, such as "description", are almost always specified with not-so-helpful config data like empty strings, simply because they are unnecessarily compulsory. Bug: 1134465 Change-Id: I7911c8967a7ee1ad0f6130b8f3cd99c765b0c2fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593792Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608473617-410812d4946901026196d594d22f14fdd0f02e7e.profdata to chrome-win64-master-1608480487-d09244758c3f22256fe9146780e06c2aad82d633.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I75bd0c40f607e0c70611d85954de19ec2ded2f6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599226Reviewed-by:
-
dpapad authored
Bug: None Change-Id: I891a2b905c2e75c70b5d9c55e47d947aa80a57f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596122Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#838576}
-
- 20 Dec, 2020 19 commits
-
-
Ben Sylvester Millar authored
Bug: b:175745669 Change-Id: I75f32ee59c1a845c762a8063a1be78cd6bdcfc00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592216Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Benjamin Sylvester Millar <bsylvmillar@google.com> Cr-Commit-Position: refs/heads/master@{#838575}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c1079b0cc5d..02a278d97bec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Iff368d989af87440d58682f51ff5f056aeccab29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599228Reviewed-by:
-
Mike Reed authored
See skia change: https://skia-review.googlesource.com/c/skia/+/345170 TBR=fmalita Bug: skia:7650 Change-Id: I0540e55a0ce00b36d1c7fe13b996a3a57d0175a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597643Reviewed-by:
Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#838573}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/65f5626b3ef8..4c1079b0cc5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I98eef4a53c5f8c6fd2b5be495127b8340ae38837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597154Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608421160-d53e8465ce5cab6f1122da4f69c4414fe923dca1.profdata to chrome-win64-master-1608473617-410812d4946901026196d594d22f14fdd0f02e7e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icd8a9c4123560b0513470ea047b5a11c74dcf493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597227 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I02efbeae67d55b5525b54a56a15eacdc226a278a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597644Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838570}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608464837-2de0ca6faffdef520ee9bc7d90f1cc05cbda82a4.profdata to chrome-mac-master-1608480487-c8d6a020311436cdd2559a40dfb31e24c333522a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I57b2b896b6c56bbd762e0efc0d749a11bdad458f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596545Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/89b61664da79..65f5626b3ef8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Idc7a2a35917b72e3771cd01fac2f901ecb20ed6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597228Reviewed-by:
-
Nektarios Paisios authored
This is done for three reasons: 1. The two methods don't really check if the next / previous anchor is a text node. They simply move to the next / previous leaf text position assuming that every leaf node is a text node. 2. There is already a set of corresponding CreateNext/PreviousLeafTreePosition methods. 3. There is a similar method `CreateNextLeafTextPosition(bool*)`, used for paragraph boundaries. Making that method to be an overload of CreateNextLeafTextPosition is clearer, since they both move in the same way through the AX tree. Split out from a larger patch that makes AXPosition work with a forest of accessibility trees at: https://chromium-review.googlesource.com/c/chromium/src/+/2595454 AX-Relnotes: n/a. TBR=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1049261 Change-Id: Idc56c19f908fde8b145a55fe542ee637ae4cbd44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598625Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#838567}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6d254a58c626..89b61664da79 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I676267429a56862e75184c2a916b1806756fc7db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598655Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ica952ebc325bad7c2580748c5f0ccca9aeabdc99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596891Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012200600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/97cSjc_Tjv810DAVmAh-xqhwbphGqNsTmBJluRhxfZ8C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: I632c3217b087a4c87af5a53b4a474576640c144a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598654Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608438831-f283c69afaa33c48df7358f7f2813237ef785868.profdata to chrome-mac-master-1608464837-2de0ca6faffdef520ee9bc7d90f1cc05cbda82a4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia3b8e663b54282f0ad63749a3cc4ef2908db6c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599119Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7fcb4018e5cd..e9f7d2179637 2020-12-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I45442bcaba76dc5b2f60d569c7d483d886b679f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599262Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c07be8700d7d..6d254a58c626 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I62b045036ae2729e38254010673ae2566fb347db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599237Reviewed-by:
-
Robert Ma authored
Metadata have been migrated from the comment in OWNERS to DIR_METADATA. Change-Id: I6c035d8ce37df2289cdb12e800c286cd3b8642ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598898 Auto-Submit: Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#838560}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ad3ed525ed8..c07be8700d7d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I70f4a39a5891d757de5fd0ff08bf08a63f312acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597226Reviewed-by:
-
Mike West authored
This reverts commit 70d0600a. Reason for revert: This is apparently causing null dereferences out there in the wild. I'm not going to have time to look into it until pretty close to the branch point, so let's revert it and take another stab at landing it after the holidays. Original change's description: > Measure `unsafe-url` usage. > > We never landed metrics to measure the impact of the proposal in > https://github.com/w3c/webappsec-referrer-policy/pull/124. This > patch remedies that oversight. > > Bug: 1158426 > Change-Id: Iccde2a755d7003a401a80e6c085a5ad97ac87389 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589875 > Reviewed-by: Eric Lawrence [MSFT] <ericlaw@microsoft.com> > Commit-Queue: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837484} TBR=dom@chromium.org,mkwst@chromium.org,ericlaw@microsoft.com,kaustubhag@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1158426,1160462 Change-Id: Ibae67bbd02cb64bd840402a10c74d530e96c4903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595737Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#838558}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/785930457a23..0ad3ed525ed8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I83a408cdc5a1b48ded5296ae1c447364af8ca709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597225Reviewed-by:
-
