- 27 Feb, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3ee6a6225e33..b400da62cf14 git log 3ee6a6225e33..b400da62cf14 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 saklein@chromium.org Build API: Make autotest more generic. 2019-02-27 bpastene@chromium.org cros_chrome_sdk: Fetch the chromeos-base/tast-* packages when entering the SDK. 2019-02-27 vapier@chromium.org image_test: allow /usr/share/misc/magic.mgc in base images 2019-02-27 lamontjones@chromium.org buildstore: Redirect GetSlaveStatuses. 2019-02-27 nednguyen@google.com board_build_dependency: fix breakage of query dependencies for "whirlwind" board 2019-02-27 gmeinke@chromium.org scheduler stage: propagate cbb_snapshot_revision 2019-02-27 gmeinke@chromium.org cbuildbot: set properties for Findit integration 2019-02-27 derat@chromium.org chromite: Run bvt-tast-informational suite. Created with: gclient setdep -r src/third_party/chromite@b400da62cf14 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ifa73ca8c1edc568bd98ce7586d2dc340dd73d9f9 Reviewed-on: https://chromium-review.googlesource.com/c/1490525Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635882}
-
Rakina Zata Amni authored
Previously, locked subtrees are skipped when doing find-in-page. With this change, we force updates to activatable locked subtrees that affect the block we're currently doing find-in-page in so that we can do find-in-page on activatable-locked nodes with guaranteed updated style & layout values. This change makes the total match count include matches that are in activatable-locked subtrees, but this change doesn't make the locked matches navigable (e.g. highlighted and can be scrolled to with find next/prev arrow buttons). That functionality will be added in a different CL. Bug: 882663 Change-Id: Icf7cec63959f7b429bbdbcaa671bf9ef5caa661e Reviewed-on: https://chromium-review.googlesource.com/c/1477466 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635881}
-
Justin Cohen authored
When correcting the NavigationItem URL, such as a restore targetURL, don't reset the visible URL. Doing so breaks navigating back to an NTP by overwriting the NTP's visible URL. Change-Id: If220cf65ff5bebae72e7a7e42c5ba94beab3e170 Reviewed-on: https://chromium-review.googlesource.com/c/1490056 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#635880}
-
Antonio Gomes authored
R=haraken@chromium.org CC=blink-reviews-vendor@chromium.org BUG=891908 Change-Id: I0156c1ba2fad75f50678d6446b53b1bf1b6b9ae9 Reviewed-on: https://chromium-review.googlesource.com/c/1489953 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#635879}
-
Rakina Zata Amni authored
Revert "Remove mojo-blob-urls virtual test suites now that network service has launched on desktop and trunk is running with it enabled." This reverts commit 868af228. Reason for revert: 3 external/wpt/FileAPI tests failure causes failed builds on non_network_service_webkit_layout_tests (see crbug.com/936237) Original change's description: > Remove mojo-blob-urls virtual test suites now that network service has launched on desktop and trunk is running with it enabled. > > Bug: 933880 > Change-Id: I3fbc8b037126ddefe75fa1400e89486cc22d214c > Reviewed-on: https://chromium-review.googlesource.com/c/1488834 > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Auto-Submit: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635708} TBR=jam@chromium.org,mek@chromium.org Change-Id: Iab8bcf874a288ffec625b9b51094d8bdcfa372a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 933880 Reviewed-on: https://chromium-review.googlesource.com/c/1491061Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#635878}
-
Yuwei Huang authored
This CL makes FtlClient async such that it makes the RPC call asynchronously and runs the callback after the response is received. Bug: 927962 Change-Id: Id1399f3edc381f0acca7780aca2959a4aa1a3737 Reviewed-on: https://chromium-review.googlesource.com/c/1487960 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#635877}
-
John Chen authored
This is a reland of 4fe92e6c Original change's description: > [ChromeDriver] Remove unused shadow DOM object cache > > ChromeDriver uses object caches for use while calling JavaScript > functions. The data structure was designed to allow a separate cache for > each shadow DOM, but that feature was never used, and objects in shadow > DOMs have always been stored in the main page cache. This CL removes > unused code, and resolves differences between test expectancies and > actual code behavior. It prepares for future changes to make the object > cache standard compliant. > > Bug: chromedriver:1461 > Change-Id: I10fcd94a7fd2359cc43fe6bc7241d36647e9d744 > Reviewed-on: https://chromium-review.googlesource.com/c/1485011 > Commit-Queue: John Chen <johnchen@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635754} Bug: chromedriver:1461 chromedriver:2794 Change-Id: Iedd6b7e43eb256d65bf71fec7e66454ceb0f776c Reviewed-on: https://chromium-review.googlesource.com/c/1490855Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#635876}
-
iOS Autoroller authored
TBR=smut Change-Id: I0794b5eceb8cf1a481b5a060ca9881bec97c4993 Reviewed-on: https://chromium-review.googlesource.com/c/1490635Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#635875}
-
Erik Luo authored
Dragging the cursor in Elements results in a new blank property, whenever there is no text selection. This is not ideal when users select text, then unselect text within the same mousedown-up phase. Screenshot: https://imgur.com/a/xZoos2r Bug: 929536 Change-Id: Ic9800dbb5c37d93943154bc4af71dd88965c633a Reviewed-on: https://chromium-review.googlesource.com/c/1413400 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#635874}
-
Khushal authored
BufferQueue maintains tracking for damage in previous frames, and copies it to the buffer for the current frame for partial swap. But because the copy happens after generating the ready fence for the OutputSurface's overlay, this creates a synchronization bug where the display controller could try to read from this overlay while the GPU is still writing to it. Avoid this by notifying the OutputSurface of the damage for the current frame before the ready fence is generated. R=piman@chromium.org Bug: 889530 Change-Id: Ic9e099c0bea7b8c990d1485d581590ee3ce81b77 Reviewed-on: https://chromium-review.googlesource.com/c/1487884 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#635873}
-
Martin Kreichgauer authored
WebAuthn requests originating from cryptotoken are executed in the RenderFrame of the cryptotoken background page. Hence, navigation events in the U2F request's sender tab have no influence over the lifetime of the request. This means the corresponding WebAuthn request lives on until it eventually times out; new requests are immediately resolved with a PENDING_REQUEST error in the meantime. As a workaround, have AuthenticatorImpl cancel any pending request, when a new request from the cryptotoken extension arrives. This will make the post-reload u2f request cancel the zombie pre-reload request. However, it will also make subsequent requests (across tabs) cancel any pending requests, whereas before cryptotoken proxying requests would have been queued. Bug: 935480 Change-Id: I6c8986ab010d687efae14927328d3a3eb900ea4a Reviewed-on: https://chromium-review.googlesource.com/c/1490892 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#635872}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4dbb96dfaa04..71865048224b git log 4dbb96dfaa04..71865048224b --date=short --no-merges --format='%ad %ae %s' 2019-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 54c4772e855c..7f6f891204d0 (1 commits) 2019-02-26 csmartdalton@google.com Reland "Stack-allocate pipelines for GrMeshDrawOp" 2019-02-26 mtklein@google.com remove mention of SkPaintDefaults_Flags 2019-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 8adf1fcd08d0..54c4772e855c (1 commits) Created with: gclient setdep -r src/third_party/skia@71865048224b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I6027cf020b20d2afb2ca6ce6ff12492a9194b867 Reviewed-on: https://chromium-review.googlesource.com/c/1490380Reviewed-by:
-
Maggie Chen authored
The z order of an underlay should be a decreasing number for each underlay layer at the bottom. It doesn't have to be a contiguous number though. Bug: 868561 Change-Id: I3ba9afbd9f02404ca23f416a464f18c30771b962 Reviewed-on: https://chromium-review.googlesource.com/c/1488151 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#635870}
-
Yuzu Saijo authored
When OomIntervention is performed on an iframe, its lifecycle becomes kV8MemoryIsForciblyPurged. And then it is possible that the iframe gets detached, and lifecycle moves to kFrameIsDetachedAndV8MemoryIsPurged. This CL allows this transition to happen. Also it changes the name of lifecycle from kForciblyPurgedV8Memory to kV8MemoryIsForciblyPurged. Change-Id: Id1459ec99fdac840bcb3dc4b3355002af77c57ac Reviewed-on: https://chromium-review.googlesource.com/c/1445341Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Wenzhao Zang authored
The mock is at https://docs.google.com/document/d/1Ai-U_4n5Clfc7ni6XVwhTev9XnPaEa1WyNLlnHGsKqs/edit#heading=h.e2ilewob1a3d Bug: 888733 Change-Id: I7568aa3600c639068d0c9d393381281fd4d649db Reviewed-on: https://chromium-review.googlesource.com/c/1471463 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#635868}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f6100576bcc4..0d1d8c12e826 git log f6100576bcc4..0d1d8c12e826 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 benjhayden@chromium.org Serialize a new HistogramSet JSON format. 2019-02-26 benjhayden@chromium.org Add cursor lines to chart-base. Created with: gclient setdep -r src/third_party/catapult@0d1d8c12e826 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918208,chromium:918193 TBR=sullivan@chromium.org Change-Id: If58b5d2b2bdc4da318e72e694128b369e9f4c25d Reviewed-on: https://chromium-review.googlesource.com/c/1490386Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9240dad68dd..f90ad85cf0cc Created with: gclient setdep -r src-internal@f90ad85cf0cc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I823cbb177337ce96820b7a6ac5c9cabc30d6e733 Reviewed-on: https://chromium-review.googlesource.com/c/1490384Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635866}
-
Yuli Huang authored
BUG=b:117816926 TEST=Tested by taking pictures and checking GA traffic. Change-Id: I984a0cd69d9977f2b3faf2b3054c1156340e268c Reviewed-on: https://chromium-review.googlesource.com/c/1484876Reviewed-by:
Sheng-hao Tsao <shenghao@google.com> Commit-Queue: yuli <yuli@chromium.org> Cr-Commit-Position: refs/heads/master@{#635865}
-
Nigel Tao authored
BUG=826982 Change-Id: I5bee3696fe24dd611ab51a6bf82e974373d55165 Reviewed-on: https://chromium-review.googlesource.com/c/1484960Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#635864}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: Id89db5937272e38fe969e01ea7fbfc61a2c9e59f Reviewed-on: https://chromium-review.googlesource.com/c/1490955Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#635863}
-
Tien Mai authored
This better reflects the use of this class as something used to validate access for users associated with GCPW. Bug: 924520 Change-Id: I78e8b5a72b1a9f4030b016ad9c920d53b2f789e6 Reviewed-on: https://chromium-review.googlesource.com/c/1489103 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#635862}
-
Martin Kreichgauer authored
Some U2F devices enter an unresponsive state after receiving a CTAP2 GetInfo command. This change checks for these devices by their VID/PID during initialization and forces them into U2F mode. Bug: 935131 Change-Id: I11c18808c272aa06d839ae7bc5ceba351634fe09 Reviewed-on: https://chromium-review.googlesource.com/c/1488718 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d28f8754..9e723d07 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I37d9c422e9f5dfbb100394210ca9fe1f90f91424 Reviewed-on: https://chromium-review.googlesource.com/c/1490741Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635860}
-
rbpotter authored
This feature has been enabled by default since M71. Bug: 775999 Change-Id: Ia2a6af706f799fdd770515c04f6df0566335d370 Reviewed-on: https://chromium-review.googlesource.com/c/1487527Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#635859}
-
Dan Beam authored
Screenshot: https://imgur.com/a/k0Y3J7N R=hcarmona@chromium.org BUG=923597 Change-Id: Ib2d782d084cf02eacf68f5296a884a09d0b2be70 Reviewed-on: https://chromium-review.googlesource.com/c/1487882 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#635858}
-
Dan Beam authored
Screenshots: https://imgur.com/a/hQji9EA Bug: 926658 Change-Id: I7ee67f123e67ea43f4681d14dce89ac55c657a1e Reviewed-on: https://chromium-review.googlesource.com/c/1487190Reviewed-by:
-
Dan Beam authored
Screenshot: https://imgur.com/a/wLZIEi0 R=hcarmona@chromium.org BUG=935238 Change-Id: I080af135e2754b2cc723d276eebbe465f6e2a958 Reviewed-on: https://chromium-review.googlesource.com/c/1488033 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
Dan Beam authored
R=hcarmona@chromium.org BUG=923224 Change-Id: I1fe33c412952be065cb8c5794030b1bdef8fd526 Reviewed-on: https://chromium-review.googlesource.com/c/1487842Reviewed-by:
-
Joonghun Park authored
Before this CL, the number specified as font-style's value is just passed not considering its unit type. R=ericwilligers@chromium.org Bug: 889277 Change-Id: Ifb5be52be5342390c27c4d4905f7d5e424bc2023 Reviewed-on: https://chromium-review.googlesource.com/c/1484958 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#635854}
-
Morten Stenshorne authored
Also get rid of local NGBoxStrut variables for border/padding. This saves 128 bytes [*] of stack space per in-flow layout recursion. [*] Linux 64bit release. Bug: 930637 Change-Id: I2a52f164634d22347282bd0eb08a6a7c2a64b5c0 Reviewed-on: https://chromium-review.googlesource.com/c/1489426 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#635853}
-
Tsuyoshi Horo authored
Bug: 910516 Change-Id: I0768c0f7379778cb78c783a2d3e31ab02163085b Reviewed-on: https://chromium-review.googlesource.com/c/1490359Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#635852}
-
Sam McNally authored
Bug: 934549 Change-Id: Idd9d1f6c5733e4d993a0bd5d1bc4d33311622e4a Reviewed-on: https://chromium-review.googlesource.com/c/1488394Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#635851}
-
Brandon Wylie authored
This allows fetching gifs from java using new api methods. Involved some additions/changes to the customization of CachedImageFetcher: * Allow skipping transcoding option when only fetching image_data. * Pipe up FetchImageData to Java. * Wrap FetchImageData into FetchGif. * Write code to potentially fetch/decode gif from disk in Java. Bug: 919915 Change-Id: I8d825272f67b136e5c0d79bdff236d37e3f70f73 Reviewed-on: https://chromium-review.googlesource.com/c/1474799 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#635850}
-
Abhishek Bhardwaj authored
This is a rework of https://crrev.com/c/1302866 monitoring all wake locks rather than just ARC++ wake locks. This change adds functionality to support lock screen notifications for ARC++, Assistant on Chrome OS and other future clients. It adds a new module that listens to dark resume events from the power manager. It - 1. Starts a timer to check for any current app suspension wake locks. 2. After the timer in 1 expires, if no app suspension wake lock is acquired the power manager is requested to re-suspend the system. If an app suspension wake lock is acquired then another hard timeout timer is set and also an observer to the wake lock being released is set. 3. If the wake lock is released, the system is re-suspended immediately. 4. If the hard timeout in 2 expires and a wake lock is still acquired then the system is re-suspended immediately. 5. If the system transitions to a full resume all dark resume related state and timers are cleared. On top of this change - 1. Changes were added to fix linker errors by declaring static constants in the source file as well. 2. Refactored some functions in the test code. BUG=chromium:898297 TEST=Unit tests and end to end test with Android applications and Assistant. Change-Id: I695a7dc666b26fce00f6b0f5d0d2017f6556f83a Reviewed-on: https://chromium-review.googlesource.com/c/1372477 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#635849}
-
Charlie Reis authored
BUG=935175 Change-Id: Id4a9198d5dff823bc3d324b9de9bff2ee86dc499 Reviewed-on: https://chromium-review.googlesource.com/c/1488152 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#635848}
-
Kristi Park authored
Do not use dark mode chips (i.e. Most Visited icons, Vasco, fakebox, etc.) if a background image is applied to the NTP. This includes custom backgrounds and images from themes. In order to keep compatibility with M73 versions and Vasco, we use the negation ":not(.light-chip)" instead of a positive selector such as ".dark-chip". Bug: 928548 Change-Id: I0284e08485810ce3aad29a288ce4ad21042e7567 Reviewed-on: https://chromium-review.googlesource.com/c/1475207Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#635847}
-
Sam McNally authored
https://crrev.com/510729 updated renames outside the directory tree; update renames in the directory tree to match. Also fix a "Redundant double negation" eslint spotted 40 lines away and demanded be fixed. Bug: 934683 Change-Id: I1a915fa4359e87f807ccd0cdc346f3f7b7fba664 Reviewed-on: https://chromium-review.googlesource.com/c/1488478 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
-
Tien Mai authored
- Now when a user needs to reauth their local login privilege is denied and the user is removed from the user list for winlogon through a registry setting. - Sign in of the user through GCPW will unlock the user and allow them to sign in. - These permissions are only revoked during Winlogin to ensure a user's state is not completely broken by accident. - Added a new credential provider filter used mainly to ensure that the privileges for a user that needs a reauth is correctly revoked before any credential providers try to create a credential. - Correctly support "Other User" credential. when it appears. - When a user needs a reauth and an entry is not found in the user array in SetUserArray then an anonymous credential associated to this user is added so that they can sign in with gaia to reauth themselves. Bug: 924520 Change-Id: Iaed674025606dc0319a0c1a6f5cf5d4ff662f824 Reviewed-on: https://chromium-review.googlesource.com/c/1481858 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
-
Meng-Huan Yu authored
In CL:1423978, we add UMA to measure the async dbus call at server side. BUG=920850, b:124719803 Change-Id: Ia767981f0cfee72e056f2088c66b0c88f19a2053 Reviewed-on: https://chromium-review.googlesource.com/c/1477131Reviewed-by:
-
Joshua Peraza authored
The custom browser ptype exists to differentiate single process webview crashes from multi-process webview crashes, but was mistakenly set for child process crashes instead of browser crashes. Bug: 936243 Change-Id: I9e37f42323ae39a7a3fa8b81e71331c08aff35bb Reviewed-on: https://chromium-review.googlesource.com/c/1490891Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#635843}
-
