- 20 Nov, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6a331d7926b7..6743d1edbf35 2020-11-20 ntfschr@chromium.org Devil: change test runner to use vpython If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nuskos@google.com Test: Test: ./devil/bin/generate_md_docsTest: Test: ./devil/bin/run_py_devicetestsTest: Test: ./devil/bin/run_py_tests Change-Id: I7cb72f5ce62c1dbaf290f23a99dec83ebfe4ed48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551581Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829558}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ed289e777cfa..4f660f22d9eb 2020-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 060020166679 to de9e649438ed (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Change-Id: I0921b3647f5fca9335f1b6856a2d9deb598b736a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551332Reviewed-by:
-
Hiroshige Hayashizaki authored
Before this CL, for ModuleScript::RunScript(), we entered: - v8::HandleScope in ModuleScript::RunScript(), - v8::Context in ModuleScript::RunScript(), - v8::EscapableHandleScope in V8ScriptRunner::EvaluateModule(), and - v8::Context in V8ScriptRunner::EvaluateModule(). After this CL, we enter: - v8::HandleScope in ModuleScript::RunScript(), and - v8::Context in V8ScriptRunner::EvaluateModule(). This is to remove duplicated scopes and thus simplify the semantics: callers of V8ScriptRunner::EvaluateModule() should enter v8::HandleScope while EvaluateModule() enters v8::Context. Bug: 1111134, 1151165 Change-Id: I84be5b89038fa5fb9f20a36ac9e4996c0e3c7510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476693 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#829556}
-
Noel Gordon authored
chrome_file_manager_private_test_impl.js is also being used to provide file manager private fakes to the file manager SWA app. The SWA has no MockVolumeManager, so move MockVolumeManager.resolveLocalFileSystemURL code into the normal (non-swa) if block at the top. Bug: 1113981 Change-Id: I2f7ba86fd8b28860e9319f6f3561b28d9d6fa8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551860Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#829555}
-
Amr Aboelkher authored
The PSM helper function GetPrivateSetMembershipCachedDecision is returning the actual base::Value*, not its boolean content. When it's being assigned to a boolean variable directly, that indicates whether that base::Value* exists or not. This CL is getting the actual PSM cached boolean decision to be compared against Hash dance decision. It also makes the signature of GetPrivateSetMembershipCachedDecision function to be Optional<bool>. BUG=chromium:1150373 Change-Id: Id9340183f1c1e72d951a2476c591d25b45b9c088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545308 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Cr-Commit-Position: refs/heads/master@{#829554}
-
Zain Afzal authored
getFile can throw a NotFoundError when called on a handle which has been moved or deleted, this cl adds explicit handling for the cases when this happens. BUG: b/172628918, b/172628918 Change-Id: Ie4dea3e667c821a0ac2d2b2c7e90a958eb4f0271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522802 Commit-Queue: Zain Afzal <zafzal@google.com> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#829553}
-
Alan Cutter authored
This CL updates the Google Drive bundled manifest start_url to match what's served by the site: https://drive.google.com/_/AppsNotifyUi/manifest.json (Note that "/?lfhs\u003d2" is the same as "/?lfhs=2".) This maintains the "usp=installed_webapp" query param via launch_query_params. This needed to be fixed up to work properly for bundled manifests. Bug: 1058265 Change-Id: I39a2a5442d56153948c4c2ea1f6a75d1b58e7f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531085 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/master@{#829552}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b472168267a0..eeca9c6ee7e1 2020-11-20 ehmaldonado@google.com [owners][git-cl] Use owners client to show all owners for a file. 2020-11-19 ehmaldonado@google.com [owners] Implement GetFilesApprovalStatus for OwnersClient. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I5ff5e3fdb080e392504dcd1d61230881b9329dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551722Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/46107d3ece07..8930f18245df 2020-11-20 cclao@google.com Vulkan: Add feature flag to fallback rotation to use driver uniform 2020-11-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 4fe17f3425ee to 3f73b676d6e8 (9 revisions) 2020-11-19 geofflang@google.com roll_aosp: Pass more forceful args to gclient sync If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I1878c98fd78e90c31c59b00ad71c1652894cfc9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551835Reviewed-by:
-
Mason Freed authored
The allow_shadow_root parameters were recently added [1] to the declarative Shadow DOM fragment parser APIs to provide an opt-in to avoid an XSS sanitizer bypass. However, to make these new changes more parallel to the existing getInnerHTML() API, which uses the plural "include_shadow_roots", the opt-in parameters will be renamed here. This CL also deletes some dead code from document_fragment.h. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2530222 Bug: 1042130 Change-Id: Ic553316b799f1b1bfe64c8aa457b2d77b97951a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548181Reviewed-by:
-
Alan Cutter authored
This CL moves the app ID constants in default_web_app_ids.h out of the chromeos directory as chrome/browser/web_applications/components/web_app_id_constants.h. This is in preparation for Chrome Windows/Mac/Linux depending on these app IDs as they migrate their preinstalled Chrome apps over to web apps. See: https://chromium-review.googlesource.com/c/chromium/src/+/2531085 Bug: 809304 Change-Id: Iafcab362380a6cc5853dcfb1a57272f51b18a88c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546674 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#829548}
-
Yao Xiao authored
This change propagates signals for sticky ad and overlay-popup ad detection from the renderer to the ads intervention manager through the subresource filter component. As the ads intervention manager is running in dry run mode and does not block ads, this allows us to record intervention behavior when triggered by one of these two interventions. Understanding the intervention behavior is a precursor to the ads intervention manager intervening to actively intervening on sites with better ads standard violations. Add base::Feature flags to allow disabling the frequency capping from either web_tests and browsertests. Move relevant tests into a virtual test suite that has the flag disabled. Bug: 1099741 Change-Id: Id0c922adfbb7cd71f641c6e9586eed9c311feb18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525769 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#829547}
-
Robbie McElrath authored
This is a reland of d3f64670 Reason for reland: fixed junit test failures Original change's description: > [WebLayer] Update Fragment.getActivity() implementation. > > This CL updates the bytecode modifications we perform on > Fragment.getActivity() to have it call ContextUtils.activityFromContext( > getContext()), and modifies compile_java.py to detect compilation errors > related to this change and print a message pointing you to documentation > about the bytecode modifications. > > A compilation error will now print: > ../...../PasswordEntryEditor.java:144: error: cannot find symbol > getActivity().getSupportFragmentManager(), > ^ > symbol: method getSupportFragmentManager() > location: class Activity > Expecting a FragmentActivity? See docs/.......md > > Bug: 1123216 > Change-Id: I04016e30fba46c7d5c592e9ab2c5e5fa4c4cfde1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508352 > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Natalie Chouinard <chouinard@chromium.org> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828643} Bug: 1123216 Change-Id: Id03753fce7da29b914aa02217186b2bb8da5c83e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547626 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#829546}
-
Xianzhu Wang authored
This fixes performance regression caused by crrev.com/c/2547435 by avoiding z-order list refresh when there will be no overlay scroll controls. The invalidation is not necessary because we'll invalidate z-order list when the ScrollableArea actually creates an overlay scroll control. TEST=Existing tests Bug: 1149793, 1150795 Change-Id: Ifc380b891b9c9155b706c0d5c24c02685bf18a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550586Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829545}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ic709538aa5638abf3b1f37dd0a0b619eed54b726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549243 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#829544}
-
David Van Cleve authored
We've rolled out the new default referrer policy of strict-origin-when-cross-origin to 100% and, in the parent CL, removed the enterprise policy that emulates the prior default policy. This CL removes the remaining piping that was used to propagate the enterprise policy's effect to Blink. Bug: 1150018 Change-Id: Ie2ef9a2137201a065f54325e5ad518efe5645ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545063 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#829543}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2ed6fc040fdc..6a331d7926b7 2020-11-19 ntfschr@chromium.org Devil: relax WebView fallback logic requirement If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1150898 Tbr: nuskos@google.com Test: Test: ./devil/bin/run_py_testsTest: Test: out/Default/bin/system_webview_apk set-webview-provider Change-Id: I2a6c33533fa9e35816b3e191e50ffec081845cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550607Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d0b25f6e314a..a241aa984fd6 2020-11-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I41e83fd2f4988688a7dd36109a9ef7108d3d09bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551996Reviewed-by:
-
Trent Begin authored
Enough routines have been added that the list of routines needs to be scrollable to fit inside of the app window. Bug: chromium:1142857 Change-Id: Ia38e61b707fc093bc131a4cb2c7f56d9411bc8d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550178 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#829540}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7d9c32d374ba..82b7546133db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shimazu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1102812 Tbr: shimazu@google.com Change-Id: I81e950ad04a07ebf4a53e7f9b02c297106edcf5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551612Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829539}
-
Jinsuk Kim authored
Factors out the self-contained tab-obscuring logic in LBFS. This is injected as a new callback via ctor. Bug: 1127732 Change-Id: Icd7369391ee6b8463fd86eb68d5781d697ff3b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503534 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#829538}
-
Will Harris authored
No behavior change in this CL. BUG=584575 Change-Id: Id2cb83087966964f3817efe5037c070a6dbbca1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551796Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#829537}
-
Bao-Duy Tran authored
Prior to this patch, these tests relied on global input method configs meant for prod. This made the tests unnecessarily non-hermetic. Not to mention such configs come from legacy input_methods.txt [1], remnant from before the migration to extension-based input methods circa 2011 (via the use of GetSupportedInputMethods() [2] which uses kInputMethods autogen'd from input_methods.txt by gen_input_methods.py [3]). Nowadays the canonical source-of-truth configs for 1P input methods on Chrome OS is google_xkb_manifest.json [4]. This refactoring helps further reduce usage of input_methods.txt, towards its full deprecation and removal. Related tests now use test-only config data that's hermetic and minimal for their needs. [1] https://source.chromium.org/chromium/chromium/src/+/master:chromeos/ime/input_methods.txt;drc=5ab33d25bc676b63e4afbcfade6f9265a5f5a3ea [2] https://source.chromium.org/chromium/chromium/src/+/master:ui/base/ime/chromeos/input_method_allowlist.cc;l=24;drc=0c6b25ab44b47df2e954ad588f5b518a53ac4c20 [3] https://source.chromium.org/chromium/chromium/src/+/master:chromeos/ime/gen_input_methods.py;drc=0303b222088853ce1c0af2bbc7f47937746eda97 [4] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json;drc=03ae97c2c311ac00d3e9a59203f4921c9e87e707 Bug: 1134526 Change-Id: I524f1146a2d1ea09548c2b8f62446db601dc1158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546667 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#829536}
-
Shubham Aggarwal authored
Should have no behavioural effect. Change-Id: Ibf58e36fc56307af001b66e9a874485f5c3a022f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548689 Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#829535}
-
Rebekah Potter authored
This reverts commit 0c1232a0. Reason for revert: More complaints with this new behavior than the previous one. Seems to make more sense to revert back. Original change's description: > Print Preview: Restore media size setting if height and width match > > In an attempt to not match the setting too easily and restore a size > the printer didn't support (see https://crbug.com/924488), Print Preview > required two media sizes from different printers to match exactly, or > the size would be reset to the printer default when the destination was > changed. > > This CL allows any media sizes reporting the exact same dimensions to > match, which will allow the user's selected paper size to be persisted > across different destinations more often. > > Note that in certain cases, different destinations have similarly > named paper sizes that may correspond to the same standardized size, but > report slightly different dimensions for these sizes to Print Preview. > This CL does not change the behavior for those cases, as it may be > infeasible to distinguish such cases from printers with very similar > reported sizes that correspond to different physical paper sizes, > particularly given that custom user paper sizes are supported by a > large number of printers. > > Bug: 1108661 > Change-Id: I42794fd1b80f34bcd277c111a66aeeb49239e71d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321965 > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Daniel Hosseinian <dhoss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792536} TBR=rbpotter@chromium.org,dhoss@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1108661 Change-Id: If21084d8f2034ab4695882ead7a74da92d8090b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551817Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#829534}
-
Eric Orth authored
When timeout was implemented, it was assumed that Classic DNS transactions would always use fast timeouts, and thus the timeout determination for classic DNS was left unimplemented. Turns out there are some obscure cornercases that I had forgotten about where classic DNS transactions don't allow fallback to the system resolver and thus don't request fast timeouts because it actually would be ideal to ensure the transaction waits on a full timeout period. Fixed: 1149408,1109792 Change-Id: I20c9b1f427b98f47a189d9ac614702c9fb944307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545057Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#829533}
-
Jinsuk Kim authored
When first requested, preview tab now opens to 3 different ways (peek, half, full) via chrome://flags. This will also be controlled via field trial configuration for experiments. 1) 'Open peek' variation: opens the sheet to the peek state. Users manually swipe up to open fully. Swiping down goes to peek or closes the sheet. 2) 'Open half' variation: opens the sheet to the half state. Users manually swipe up to open fully. Swiping down close the sheet. 3) 'Open full' variation: opens the sheet fully immediately. Swiping down closes the sheet. Bug: 1146295 Change-Id: I4936c23f3ffa17117a7ef33c7730d18bac705f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545341 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#829532}
-
Kuo Jen Wei authored
Bug: b:173672812 Test: Rebuild chrome and verify SWA CCA can be opened successfully. Test: cca deploy-swa <BOARD> <DEVICE> Change-Id: I8a82840fa35e2cb3245a6eb568b8bd363b6e5d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548594 Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#829531}
-
Yutaka Hirano authored
As ScriptResource is the only Resource subclass that uses Resource::cache_handler_, this CL moves the member to ScriptResource. Resource::CodeCacheSize is made a virtual function, and Resource::ResponseReceived now has an implementation in ScriptResource. This CL moves some tests in resource_test.cc to the newly created script_resource_test.cc. resource_test.cc contained tests testing CachedMetadataSender::Create behavior, so they are moved to the newly created cached_metadata_handler_test.cc. Bug: None Change-Id: Ia1020a28d922e3a2745fcf8336c279f8cea8c0fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537288 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#829530}
-
Alexandre Courbot authored
The client counter is decreased upon destruction if a VDA has been created. But it is only increased during `OnInitializeDone()`, i.e. way after the VDA has been created. If something goes wrong and the GAVDA instance is destructed in the meantime, we will underflow client which will then take the maximal integer value, and will prevent any additional decoders from being created, forever. Fix this by increasing the client count as soon as the VDA is created, and making sure the counter cannot underflow in the destructor. BUG=b:173700103 BUG=b:165035340 TEST=com.google.android.exoplayer.gts.DashTest GTS does not underflow the client counter. Change-Id: I0dc080e2a0ca7665a2f937cdfea0878842b05b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551857Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#829529}
-
Christopher Cameron authored
The specification allows the user to specify the format for data to be retrieved using getImageData. Add support for this functionality. Add the function to the IDL. Make both versions of BaseRenderingContext2D::getImageData call into a common BaseRenderingContext2D::getImageDataInternal function. Move the function ImageData::GetCanvasColorSpace to the function CanvasColorSpaceFromName and make all callers (including the new one added here) use that function. Add a test that verifies that getImageData works for all canvas color spaces, formats, and ImageData color spaces and formats. R=yiyix TBR=fserb Bug: 1115317 Change-Id: I3a5178d1497f0b20ef33af30bf73f276d329f135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542740 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#829528}
-
Kenneth Russell authored
WebGL conformance test for this is incoming in https://github.com/KhronosGroup/WebGL/pull/3183 . Bug: 1149176 Change-Id: I805ae3dfc63af6afa926599ccc606d11e2e3e20e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542770Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#829527}
-
Xida Chen authored
This was experimental before: https://chromium-review.googlesource.com/c/chromium/src/+/1699381 But somehow the status was changed. This CL makes it experimental to make sure that all tests are good. With this CL being landed: https://chromium-review.googlesource.com/c/chromium/src/+/2375886 Changing the status to "experimental" should make all web_tests running with this flag. Bug: 414283 Change-Id: I66bca528d4ef9ca9fcc86b983b519c409927c4d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533803 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#829526}
-
Jonah Chin authored
In a recent patch [1], an early return was replaced by a DCHECK. This DCHECK failed to catch lost contexts in production code. This CL reintroduces the conditional early return. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2419653 Bug: 1149174 Change-Id: I1db867c2a9fe3154fad0824bb37ac5d6b9eee3d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551616 Commit-Queue: Jonah Chin <jochin@microsoft.com> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#829525}
-
Hiroki Nakagawa authored
Static functions on CrossOriginResourcePolicy take mojom::CrossOriginEmbedderPolicyReporter* that can be nullptr as a default argument, but almost all callers of the functions explicitly pass an argument. Bug: n/a Change-Id: I9fbb9d6e451b5669bc793b21a8144c685e3318e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550963Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#829524}
-
Mike Wasserman authored
The desktop chooser and scanning prompt hold controller raw pointers. The controllers might be destroyed immediately, leaving bad pointers. Use WeakPtrs instead of raw pointers and refactor init patterns. Bug: 1149692 Change-Id: Ic1efee18ec2e98921206bea14c3c1500ea085877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551936Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#829523}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: I4ce3bc7ccd026a9ec2063f3d983d2b08dbf50b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551838Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829522}
-
Renjie Tang authored
Change-Id: I3097a6925a59f2cced10c43f389f6d1108fcde6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531055 Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#829521}
-
Dave Tapuska authored
A subtle change that occurs is that WebFrameWidgetBase always returns its own size, previously it stored a size but delegated Size() to the View method. Remove the Resize methods on the public WebView API for removal in the future. BUG=1097816 Change-Id: Ic165921efd8bc8f3afafd8b2f821a602300d0b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547965 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#829520}
-
Ioana Pandele authored
Change-Id: I508cab7aab3f1a6fb6fd03daf535d0a0934c3e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549965Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#829519}
-
